From: Petr Tesarik <ptesarik@suse.cz> To: Dave Young <dyoung@redhat.com> Cc: dzickus@redhat.com, Neil Horman <nhorman@redhat.com>, Tony Luck <tony.luck@intel.com>, bhe@redhat.com, Michael Ellerman <mpe@ellerman.id.au>, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, Martin Schwidefsky <schwidefsky@de.ibm.com>, "Eric W. Biederman" <ebiederm@xmission.com>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, Hari Bathini <hbathini@linux.vnet.ibm.com>, Cong Wang <xiyou.wangcong@gmail.com>, Andrew Morton <akpm@linux-foundation.org>, Ingo Molnar <mingo@kernel.org>, Vivek Goyal <vgoyal@redhat.com> Subject: Re: [PATCH] kdump: add default crashkernel reserve kernel config options Date: Thu, 24 May 2018 08:57:08 +0200 [thread overview] Message-ID: <20180524085708.31aa311d@ezekiel.suse.cz> (raw) In-Reply-To: <20180524014905.GB2031@dhcp-128-65.nay.redhat.com> On Thu, 24 May 2018 09:49:05 +0800 Dave Young <dyoung@redhat.com> wrote: > Hi Petr, > > On 05/23/18 at 10:22pm, Petr Tesarik wrote: >[...] > > In short, if one size fits none, what good is it to hardcode that "one > > size" into the kernel image? > > I agreed with all the things that we can not know the exact memory > requirement for 100% use cases. But that does not means this is useless > it is still useful for common use cases of no special and memory hog > requirements as I mentioned in another reply it can simplify the kdump > deployment for those people who do not need the special setup. I still tend to disagree. This "common-case" reservation depends on things that are defined by user space. It surely does not make it easier to build a distribution kernel. Today, I get bug reports that the number calculated and added to the boot loader configuration by the installer is inaccurate. If I put a fixed number into a kernel config option, I will start getting bugs that this number is incorrect (for some systems). > For example, if this is a workstation I just want to break into a shell > to collect some panic info, then I just need a very minimal initrd, then > the Kconfig will work just fine. What is "a very minimal initrd"? Last time I had to make a significant adjustment to the estimation for openSUSE, this was caused by growing user-space requirements (systemd in this case, but I don't want to start flamewars on that topic, please). Anyway, if you want to improve the "common case", then look how IBM tries to solve it for firmware-assisted dump (fadump) on powerpc: https://patchwork.ozlabs.org/patch/905026/ The main idea is: > Instead of setting aside a significant chunk of memory nobody can use, > [...] reserve a significant chunk of memory that the kernel is prevented > from using [...], but applications are free to use it. That works great, because user space pages are filtered out in the common case, so they can be used freely by the panic kernel. Just my two cents, Petr T
WARNING: multiple messages have this Message-ID (diff)
From: Petr Tesarik <ptesarik@suse.cz> To: Dave Young <dyoung@redhat.com> Cc: dzickus@redhat.com, Neil Horman <nhorman@redhat.com>, Tony Luck <tony.luck@intel.com>, bhe@redhat.com, Michael Ellerman <mpe@ellerman.id.au>, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, Hari Bathini <hbathini@linux.vnet.ibm.com>, "Eric W. Biederman" <ebiederm@xmission.com>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, Martin Schwidefsky <schwidefsky@de.ibm.com>, Cong Wang <xiyou.wangcong@gmail.com>, Andrew Morton <akpm@linux-foundation.org>, Ingo Molnar <mingo@kernel.org>, Vivek Goyal <vgoyal@redhat.com> Subject: Re: [PATCH] kdump: add default crashkernel reserve kernel config options Date: Thu, 24 May 2018 08:57:08 +0200 [thread overview] Message-ID: <20180524085708.31aa311d@ezekiel.suse.cz> (raw) In-Reply-To: <20180524014905.GB2031@dhcp-128-65.nay.redhat.com> On Thu, 24 May 2018 09:49:05 +0800 Dave Young <dyoung@redhat.com> wrote: > Hi Petr, > > On 05/23/18 at 10:22pm, Petr Tesarik wrote: >[...] > > In short, if one size fits none, what good is it to hardcode that "one > > size" into the kernel image? > > I agreed with all the things that we can not know the exact memory > requirement for 100% use cases. But that does not means this is useless > it is still useful for common use cases of no special and memory hog > requirements as I mentioned in another reply it can simplify the kdump > deployment for those people who do not need the special setup. I still tend to disagree. This "common-case" reservation depends on things that are defined by user space. It surely does not make it easier to build a distribution kernel. Today, I get bug reports that the number calculated and added to the boot loader configuration by the installer is inaccurate. If I put a fixed number into a kernel config option, I will start getting bugs that this number is incorrect (for some systems). > For example, if this is a workstation I just want to break into a shell > to collect some panic info, then I just need a very minimal initrd, then > the Kconfig will work just fine. What is "a very minimal initrd"? Last time I had to make a significant adjustment to the estimation for openSUSE, this was caused by growing user-space requirements (systemd in this case, but I don't want to start flamewars on that topic, please). Anyway, if you want to improve the "common case", then look how IBM tries to solve it for firmware-assisted dump (fadump) on powerpc: https://patchwork.ozlabs.org/patch/905026/ The main idea is: > Instead of setting aside a significant chunk of memory nobody can use, > [...] reserve a significant chunk of memory that the kernel is prevented > from using [...], but applications are free to use it. That works great, because user space pages are filtered out in the common case, so they can be used freely by the panic kernel. Just my two cents, Petr T _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2018-05-24 6:57 UTC|newest] Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-21 2:53 [PATCH] kdump: add default crashkernel reserve kernel config options Dave Young 2018-05-21 2:53 ` Dave Young 2018-05-21 19:02 ` Andrew Morton 2018-05-21 19:02 ` Andrew Morton 2018-05-22 1:43 ` Dave Young 2018-05-22 1:43 ` Dave Young 2018-05-22 1:48 ` Dave Young 2018-05-22 1:48 ` Dave Young 2018-05-23 7:06 ` Dave Young 2018-05-23 7:06 ` Dave Young 2018-05-23 15:53 ` Eric W. Biederman 2018-05-23 15:53 ` Eric W. Biederman 2018-05-23 20:22 ` Petr Tesarik 2018-05-23 20:22 ` Petr Tesarik 2018-05-24 1:49 ` Dave Young 2018-05-24 1:49 ` Dave Young 2018-05-24 6:57 ` Petr Tesarik [this message] 2018-05-24 6:57 ` Petr Tesarik 2018-05-24 7:26 ` Dave Young 2018-05-24 7:26 ` Dave Young 2018-05-24 7:39 ` Dave Young 2018-05-24 7:39 ` Dave Young 2018-05-24 7:56 ` Dave Young 2018-05-24 7:56 ` Dave Young 2018-05-24 8:29 ` Baoquan He 2018-05-24 8:29 ` Baoquan He 2018-05-24 9:02 ` Petr Tesarik 2018-05-24 9:02 ` Petr Tesarik 2018-05-24 7:31 ` Baoquan He 2018-05-24 7:31 ` Baoquan He 2018-05-24 16:34 ` Eric W. Biederman 2018-05-24 16:34 ` Eric W. Biederman 2018-05-25 4:59 ` Petr Tesarik 2018-05-25 4:59 ` Petr Tesarik 2018-05-25 20:00 ` Eric W. Biederman 2018-05-25 20:00 ` Eric W. Biederman 2018-05-28 12:34 ` Petr Tesarik 2018-05-28 12:34 ` Petr Tesarik 2018-05-29 12:19 ` Eric W. Biederman 2018-05-29 12:19 ` Eric W. Biederman 2018-05-24 1:42 ` Dave Young 2018-05-24 1:42 ` Dave Young 2018-05-24 16:41 ` Eric W. Biederman 2018-05-24 16:41 ` Eric W. Biederman 2018-05-25 2:43 ` Dave Young 2018-05-25 2:43 ` Dave Young
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180524085708.31aa311d@ezekiel.suse.cz \ --to=ptesarik@suse.cz \ --cc=akpm@linux-foundation.org \ --cc=benh@kernel.crashing.org \ --cc=bhe@redhat.com \ --cc=dyoung@redhat.com \ --cc=dzickus@redhat.com \ --cc=ebiederm@xmission.com \ --cc=hbathini@linux.vnet.ibm.com \ --cc=kexec@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mingo@kernel.org \ --cc=mpe@ellerman.id.au \ --cc=nhorman@redhat.com \ --cc=schwidefsky@de.ibm.com \ --cc=tony.luck@intel.com \ --cc=vgoyal@redhat.com \ --cc=xiyou.wangcong@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.