All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Wunderlich <sw@simonwunderlich.de>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org,
	Sven Eckelmann <sven@narfation.org>,
	Simon Wunderlich <sw@simonwunderlich.de>
Subject: [PATCH 2/8] batman-adv: Disable CONFIG_BATMAN_ADV_DEBUGFS by default
Date: Thu, 24 May 2018 14:02:54 +0200	[thread overview]
Message-ID: <20180524120300.15829-3-sw@simonwunderlich.de> (raw)
In-Reply-To: <20180524120300.15829-1-sw@simonwunderlich.de>

From: Sven Eckelmann <sven@narfation.org>

All tools which were known to the batman-adv development team are
supporting the batman-adv netlink interface since a while. Also debugfs is
not supported for batman-adv interfaces in any non-default netns. Thus
disabling CONFIG_BATMAN_ADV_DEBUGFS by default should not cause problems on
most systems. It is still possible to enable it in case it is still
required in a specific setup.

Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
---
 net/batman-adv/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/batman-adv/Kconfig b/net/batman-adv/Kconfig
index e4e2e02b7380..bee034a95208 100644
--- a/net/batman-adv/Kconfig
+++ b/net/batman-adv/Kconfig
@@ -94,13 +94,13 @@ config BATMAN_ADV_DEBUGFS
 	bool "batman-adv debugfs entries"
 	depends on BATMAN_ADV
 	depends on DEBUG_FS
-	default y
+	default n
 	help
 	  Enable this to export routing related debug tables via debugfs.
 	  The information for each soft-interface and used hard-interface can be
 	  found under batman_adv/
 
-	  If unsure, say Y.
+	  If unsure, say N.
 
 config BATMAN_ADV_DEBUG
 	bool "B.A.T.M.A.N. debugging"
-- 
2.11.0

WARNING: multiple messages have this Message-ID (diff)
From: Simon Wunderlich <sw@simonwunderlich.de>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org,
	Sven Eckelmann <sven@narfation.org>,
	Simon Wunderlich <sw@simonwunderlich.de>
Subject: [B.A.T.M.A.N.] [PATCH 2/8] batman-adv: Disable CONFIG_BATMAN_ADV_DEBUGFS by default
Date: Thu, 24 May 2018 14:02:54 +0200	[thread overview]
Message-ID: <20180524120300.15829-3-sw@simonwunderlich.de> (raw)
In-Reply-To: <20180524120300.15829-1-sw@simonwunderlich.de>

From: Sven Eckelmann <sven@narfation.org>

All tools which were known to the batman-adv development team are
supporting the batman-adv netlink interface since a while. Also debugfs is
not supported for batman-adv interfaces in any non-default netns. Thus
disabling CONFIG_BATMAN_ADV_DEBUGFS by default should not cause problems on
most systems. It is still possible to enable it in case it is still
required in a specific setup.

Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
---
 net/batman-adv/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/batman-adv/Kconfig b/net/batman-adv/Kconfig
index e4e2e02b7380..bee034a95208 100644
--- a/net/batman-adv/Kconfig
+++ b/net/batman-adv/Kconfig
@@ -94,13 +94,13 @@ config BATMAN_ADV_DEBUGFS
 	bool "batman-adv debugfs entries"
 	depends on BATMAN_ADV
 	depends on DEBUG_FS
-	default y
+	default n
 	help
 	  Enable this to export routing related debug tables via debugfs.
 	  The information for each soft-interface and used hard-interface can be
 	  found under batman_adv/
 
-	  If unsure, say Y.
+	  If unsure, say N.
 
 config BATMAN_ADV_DEBUG
 	bool "B.A.T.M.A.N. debugging"
-- 
2.11.0


  parent reply	other threads:[~2018-05-24 12:03 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-24 12:02 [PATCH 0/8] pull request for net-next: batman-adv 2017-05-24 Simon Wunderlich
2018-05-24 12:02 ` [B.A.T.M.A.N.] " Simon Wunderlich
2018-05-24 12:02 ` [PATCH 1/8] batman-adv: Start new development cycle Simon Wunderlich
2018-05-24 12:02   ` [B.A.T.M.A.N.] " Simon Wunderlich
2018-05-24 12:02 ` Simon Wunderlich [this message]
2018-05-24 12:02   ` [B.A.T.M.A.N.] [PATCH 2/8] batman-adv: Disable CONFIG_BATMAN_ADV_DEBUGFS by default Simon Wunderlich
2018-05-25 10:33   ` Sergei Shtylyov
2018-05-25 10:33     ` [B.A.T.M.A.N.] " Sergei Shtylyov
2018-05-25 10:50     ` Sven Eckelmann
2018-05-25 10:50       ` [B.A.T.M.A.N.] " Sven Eckelmann
2018-05-25 11:13       ` Sergei Shtylyov
2018-05-25 11:13         ` [B.A.T.M.A.N.] " Sergei Shtylyov
     [not found]         ` <6fd70d33-11f7-33dd-3b11-e5031fe46466-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2018-05-25 11:15           ` Sven Eckelmann
2018-05-25 11:15             ` [B.A.T.M.A.N.] " Sven Eckelmann
2018-05-25 15:56             ` Sergei Shtylyov
2018-05-25 15:56               ` [B.A.T.M.A.N.] " Sergei Shtylyov
2018-05-25 18:39               ` David Miller
2018-05-25 18:39                 ` [B.A.T.M.A.N.] " David Miller
2018-05-25 18:20         ` Joe Perches
2018-05-25 18:20           ` [B.A.T.M.A.N.] " Joe Perches
2018-05-24 12:02 ` [PATCH 3/8] batman-adv: Avoid old nodes disabling multicast optimizations completely Simon Wunderlich
2018-05-24 12:02   ` [B.A.T.M.A.N.] " Simon Wunderlich
2018-05-24 12:02 ` [PATCH 4/8] batman-adv: Avoid bool in structures Simon Wunderlich
2018-05-24 12:02   ` [B.A.T.M.A.N.] " Simon Wunderlich
2018-05-24 12:02 ` [PATCH 5/8] batman-adv: Remove unused dentry without DEBUGFS Simon Wunderlich
2018-05-24 12:02   ` [B.A.T.M.A.N.] " Simon Wunderlich
2018-05-24 12:02 ` [PATCH 6/8] batman-adv: fix batadv_interface_tx()'s return type Simon Wunderlich
2018-05-24 12:02   ` [B.A.T.M.A.N.] " Simon Wunderlich
2018-05-24 12:02 ` [PATCH 7/8] batman-adv: disable ethtool link speed detection when auto negotiation off Simon Wunderlich
2018-05-24 12:02   ` [B.A.T.M.A.N.] " Simon Wunderlich
2018-05-24 12:03 ` [PATCH 8/8] batman-adv: enable B.A.T.M.A.N. V compilation by default Simon Wunderlich
2018-05-24 12:03   ` [B.A.T.M.A.N.] " Simon Wunderlich
2018-05-24 12:09   ` Joe Perches
2018-05-24 12:09     ` [B.A.T.M.A.N.] " Joe Perches
2018-05-24 15:03 ` [PATCH 0/8] pull request for net-next: batman-adv 2017-05-24 David Miller
2018-05-24 15:03   ` [B.A.T.M.A.N.] " David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180524120300.15829-3-sw@simonwunderlich.de \
    --to=sw@simonwunderlich.de \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=sven@narfation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.