* [PATCH] wlcore: sdio: check for valid platform device data before suspend
@ 2018-05-24 11:35 Eyal Reizer
2018-05-24 14:24 ` Tony Lindgren
0 siblings, 1 reply; 3+ messages in thread
From: Eyal Reizer @ 2018-05-24 11:35 UTC (permalink / raw)
To: kvalo, tony, nsekhar, linux-wireless; +Cc: Eyal Reizer
the wl pointer can be null In case only wlcore_sdio is probed while
no WiLink module is successfully probed, as in the case of mounting a
wl12xx module while using a device tree file configured with wl18xx
related settings.
In this case the system was crashing in wl1271_suspend() as platform
device data is not set.
Make sure wl the pointer is valid before using it.
Signed-off-by: Eyal Reizer <eyalr@ti.com>mamai
---
drivers/net/wireless/ti/wlcore/sdio.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/wireless/ti/wlcore/sdio.c b/drivers/net/wireless/ti/wlcore/sdio.c
index da701cd..aec6225 100644
--- a/drivers/net/wireless/ti/wlcore/sdio.c
+++ b/drivers/net/wireless/ti/wlcore/sdio.c
@@ -406,6 +406,11 @@ static int wl1271_suspend(struct device *dev)
mmc_pm_flag_t sdio_flags;
int ret = 0;
+ if (!wl) {
+ dev_err(dev, "no wilink module was probed\n");
+ goto out;
+ }
+
dev_dbg(dev, "wl1271 suspend. wow_enabled: %d\n",
wl->wow_enabled);
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] wlcore: sdio: check for valid platform device data before suspend
2018-05-24 11:35 [PATCH] wlcore: sdio: check for valid platform device data before suspend Eyal Reizer
@ 2018-05-24 14:24 ` Tony Lindgren
2018-05-28 8:20 ` [EXTERNAL] " Reizer, Eyal
0 siblings, 1 reply; 3+ messages in thread
From: Tony Lindgren @ 2018-05-24 14:24 UTC (permalink / raw)
To: Eyal Reizer; +Cc: kvalo, nsekhar, linux-wireless, Eyal Reizer
* Eyal Reizer <eyalreizer@gmail.com> [180524 11:38]:
> the wl pointer can be null In case only wlcore_sdio is probed while
> no WiLink module is successfully probed, as in the case of mounting a
> wl12xx module while using a device tree file configured with wl18xx
> related settings.
> In this case the system was crashing in wl1271_suspend() as platform
> device data is not set.
> Make sure wl the pointer is valid before using it.
Just checking.. It seems like this fix is separate from the PM
runtime conversion, right?
> Signed-off-by: Eyal Reizer <eyalr@ti.com>mamai
Looks like you have some extra characters ^^^^^ here.
Regards,
Tony
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [EXTERNAL] Re: [PATCH] wlcore: sdio: check for valid platform device data before suspend
2018-05-24 14:24 ` Tony Lindgren
@ 2018-05-28 8:20 ` Reizer, Eyal
0 siblings, 0 replies; 3+ messages in thread
From: Reizer, Eyal @ 2018-05-28 8:20 UTC (permalink / raw)
To: Tony Lindgren, Eyal Reizer; +Cc: kvalo, Nori, Sekhar, linux-wireless
> > the wl pointer can be null In case only wlcore_sdio is probed while
> > no WiLink module is successfully probed, as in the case of mounting a
> > wl12xx module while using a device tree file configured with wl18xx
> > related settings.
> > In this case the system was crashing in wl1271_suspend() as platform
> > device data is not set.
> > Make sure wl the pointer is valid before using it.
>=20
> Just checking.. It seems like this fix is separate from the PM
> runtime conversion, right?
Correct. This is a separate patch/
>=20
> > Signed-off-by: Eyal Reizer <eyalr@ti.com>mamai
>=20
> Looks like you have some extra characters ^^^^^ here.
>=20
Thanks!. Will fix and submit v2
Best Regards,
Eyal
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-28 8:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-24 11:35 [PATCH] wlcore: sdio: check for valid platform device data before suspend Eyal Reizer
2018-05-24 14:24 ` Tony Lindgren
2018-05-28 8:20 ` [EXTERNAL] " Reizer, Eyal
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.