From: Rob Herring <robh@kernel.org> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Linus Walleij <linus.walleij@linaro.org>, Alexander Graf <agraf@suse.de>, Bjorn Andersson <bjorn.andersson@linaro.org>, "Rafael J. Wysocki" <rjw@rjwysocki.net>, Kevin Hilman <khilman@kernel.org>, Ulf Hansson <ulf.hansson@linaro.org>, Joerg Roedel <joro@8bytes.org>, Robin Murphy <robin.murphy@arm.com>, Mark Brown <broonie@kernel.org>, Frank Rowand <frowand.list@gmail.com> Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, boot-architecture@lists.linaro.org, linux-arm-kernel@lists.infradead.org, Pavel Machek <pavel@ucw.cz>, Len Brown <len.brown@intel.com>, linux-pm@vger.kernel.org Subject: [PATCH v2 8/8] PM / Domains: Stop deferring probe at the end of initcall Date: Thu, 24 May 2018 12:50:24 -0500 [thread overview] Message-ID: <20180524175024.19874-9-robh@kernel.org> (raw) In-Reply-To: <20180524175024.19874-1-robh@kernel.org> All PM domain drivers must be built-in (at least those using DT), so there is no point deferring probe after initcalls are done. Continuing to defer probe may prevent booting successfully even if managing PM domains is not required. This can happen if the user failed to enable the driver or if power-domains are added to a platform's DT, but there is not yet a driver (e.g. a new DTB with an old kernel). Call the driver core function driver_deferred_probe_check_init_done() instead of just returning -EPROBE_DEFER to stop deferring probe when initcalls are done. Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> Cc: Kevin Hilman <khilman@kernel.org> Cc: Ulf Hansson <ulf.hansson@linaro.org> Cc: Pavel Machek <pavel@ucw.cz> Cc: Len Brown <len.brown@intel.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: linux-pm@vger.kernel.org Signed-off-by: Rob Herring <robh@kernel.org> --- drivers/base/power/domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c index 1ea0e2502e8e..6398cf786e6a 100644 --- a/drivers/base/power/domain.c +++ b/drivers/base/power/domain.c @@ -2218,7 +2218,7 @@ int genpd_dev_pm_attach(struct device *dev) mutex_unlock(&gpd_list_lock); dev_dbg(dev, "%s() failed to find PM domain: %ld\n", __func__, PTR_ERR(pd)); - return -EPROBE_DEFER; + return driver_deferred_probe_check_init_done(dev, true); } dev_dbg(dev, "adding to PM domain %s\n", pd->name); -- 2.17.0
WARNING: multiple messages have this Message-ID (diff)
From: robh@kernel.org (Rob Herring) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 8/8] PM / Domains: Stop deferring probe at the end of initcall Date: Thu, 24 May 2018 12:50:24 -0500 [thread overview] Message-ID: <20180524175024.19874-9-robh@kernel.org> (raw) In-Reply-To: <20180524175024.19874-1-robh@kernel.org> All PM domain drivers must be built-in (at least those using DT), so there is no point deferring probe after initcalls are done. Continuing to defer probe may prevent booting successfully even if managing PM domains is not required. This can happen if the user failed to enable the driver or if power-domains are added to a platform's DT, but there is not yet a driver (e.g. a new DTB with an old kernel). Call the driver core function driver_deferred_probe_check_init_done() instead of just returning -EPROBE_DEFER to stop deferring probe when initcalls are done. Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> Cc: Kevin Hilman <khilman@kernel.org> Cc: Ulf Hansson <ulf.hansson@linaro.org> Cc: Pavel Machek <pavel@ucw.cz> Cc: Len Brown <len.brown@intel.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: linux-pm at vger.kernel.org Signed-off-by: Rob Herring <robh@kernel.org> --- drivers/base/power/domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c index 1ea0e2502e8e..6398cf786e6a 100644 --- a/drivers/base/power/domain.c +++ b/drivers/base/power/domain.c @@ -2218,7 +2218,7 @@ int genpd_dev_pm_attach(struct device *dev) mutex_unlock(&gpd_list_lock); dev_dbg(dev, "%s() failed to find PM domain: %ld\n", __func__, PTR_ERR(pd)); - return -EPROBE_DEFER; + return driver_deferred_probe_check_init_done(dev, true); } dev_dbg(dev, "adding to PM domain %s\n", pd->name); -- 2.17.0
next prev parent reply other threads:[~2018-05-24 17:51 UTC|newest] Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-24 17:50 [PATCH v2 0/8] Make deferring probe forever optional Rob Herring 2018-05-24 17:50 ` Rob Herring 2018-05-24 17:50 ` [PATCH v2 1/8] driver core: make deferring probe after init optional Rob Herring 2018-05-24 17:50 ` Rob Herring 2018-05-24 17:50 ` Rob Herring 2018-05-24 18:18 ` Mark Brown 2018-05-24 18:18 ` Mark Brown 2018-05-24 20:25 ` Rob Herring 2018-05-24 20:25 ` Rob Herring 2018-05-25 11:47 ` Robin Murphy 2018-05-25 11:47 ` Robin Murphy 2018-05-29 5:12 ` Frank Rowand 2018-05-29 5:12 ` Frank Rowand 2018-05-29 14:46 ` Rob Herring 2018-05-29 14:46 ` Rob Herring 2018-05-29 14:46 ` Rob Herring 2018-05-24 18:56 ` Greg Kroah-Hartman 2018-05-24 18:56 ` Greg Kroah-Hartman 2018-05-24 19:42 ` Rob Herring 2018-05-24 19:42 ` Rob Herring 2018-05-24 19:00 ` Greg Kroah-Hartman 2018-05-24 19:00 ` Greg Kroah-Hartman 2018-05-24 20:57 ` Rob Herring 2018-05-24 20:57 ` Rob Herring 2018-05-25 12:20 ` Robin Murphy 2018-05-25 12:20 ` Robin Murphy 2018-05-25 17:35 ` Rob Herring 2018-05-25 17:35 ` Rob Herring 2018-05-24 22:28 ` Bjorn Andersson 2018-05-24 22:28 ` Bjorn Andersson 2018-05-24 23:47 ` Rob Herring 2018-05-24 23:47 ` Rob Herring 2018-05-24 17:50 ` [PATCH v2 2/8] driver core: add a deferred probe timeout Rob Herring 2018-05-24 17:50 ` Rob Herring 2018-05-24 19:01 ` Greg Kroah-Hartman 2018-05-24 19:01 ` Greg Kroah-Hartman 2018-05-24 19:45 ` Rob Herring 2018-05-24 19:45 ` Rob Herring 2018-05-24 19:51 ` Greg Kroah-Hartman 2018-05-24 19:51 ` Greg Kroah-Hartman 2018-05-24 17:50 ` [PATCH v2 3/8] dt-bindings: pinctrl: add a 'pinctrl-use-default' property Rob Herring 2018-05-24 17:50 ` Rob Herring 2018-05-24 17:50 ` [PATCH v2 4/8] arm: dts: bcm283x: mark the UART pin muxing nodes with pinctrl-use-default Rob Herring 2018-05-24 17:50 ` Rob Herring 2018-05-24 17:50 ` [PATCH v2 5/8] pinctrl: optionally stop deferring probe at end of initcalls Rob Herring 2018-05-24 17:50 ` Rob Herring 2018-05-24 17:50 ` Rob Herring 2018-05-30 7:00 ` Linus Walleij 2018-05-30 7:00 ` Linus Walleij 2018-05-30 7:00 ` Linus Walleij 2018-05-24 17:50 ` [PATCH v2 6/8] iommu: Stop " Rob Herring 2018-05-24 17:50 ` Rob Herring 2018-05-24 17:50 ` Rob Herring [not found] ` <20180524175024.19874-1-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> 2018-05-24 17:50 ` [PATCH v2 7/8] iommu: Remove IOMMU_OF_DECLARE Rob Herring 2018-05-24 17:50 ` Rob Herring 2018-05-24 17:50 ` Rob Herring [not found] ` <20180524175024.19874-8-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> 2018-05-25 11:31 ` Will Deacon 2018-05-25 11:31 ` Will Deacon 2018-05-25 11:31 ` Will Deacon 2018-05-28 6:53 ` Marek Szyprowski 2018-05-28 6:53 ` Marek Szyprowski 2018-05-28 6:53 ` Marek Szyprowski 2018-05-24 17:50 ` Rob Herring [this message] 2018-05-24 17:50 ` [PATCH v2 8/8] PM / Domains: Stop deferring probe at the end of initcall Rob Herring 2018-05-29 11:48 ` [PATCH v2 0/8] Make deferring probe forever optional Joerg Roedel 2018-05-29 11:48 ` Joerg Roedel
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180524175024.19874-9-robh@kernel.org \ --to=robh@kernel.org \ --cc=agraf@suse.de \ --cc=bjorn.andersson@linaro.org \ --cc=boot-architecture@lists.linaro.org \ --cc=broonie@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=frowand.list@gmail.com \ --cc=gregkh@linuxfoundation.org \ --cc=joro@8bytes.org \ --cc=khilman@kernel.org \ --cc=len.brown@intel.com \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=pavel@ucw.cz \ --cc=rjw@rjwysocki.net \ --cc=robin.murphy@arm.com \ --cc=ulf.hansson@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.