* [PATCH net-next] ath10k: Remove useless test before clk_disable_unprepare
@ 2018-05-16 10:54 YueHaibing
2018-05-16 11:42 ` Kalle Valo
2018-05-25 10:04 ` Kalle Valo
0 siblings, 2 replies; 5+ messages in thread
From: YueHaibing @ 2018-05-16 10:54 UTC (permalink / raw)
To: kvalo, davem; +Cc: netdev, linux-wireless, YueHaibing
clk_disable_unprepare() already checks that the clock pointer is valid.
No need to test it before calling it.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/net/wireless/ath/ath10k/ahb.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/ahb.c b/drivers/net/wireless/ath/ath10k/ahb.c
index 35d1049..fa39fff 100644
--- a/drivers/net/wireless/ath/ath10k/ahb.c
+++ b/drivers/net/wireless/ath/ath10k/ahb.c
@@ -180,14 +180,11 @@ static void ath10k_ahb_clock_disable(struct ath10k *ar)
{
struct ath10k_ahb *ar_ahb = ath10k_ahb_priv(ar);
- if (!IS_ERR_OR_NULL(ar_ahb->cmd_clk))
- clk_disable_unprepare(ar_ahb->cmd_clk);
+ clk_disable_unprepare(ar_ahb->cmd_clk);
- if (!IS_ERR_OR_NULL(ar_ahb->ref_clk))
- clk_disable_unprepare(ar_ahb->ref_clk);
+ clk_disable_unprepare(ar_ahb->ref_clk);
- if (!IS_ERR_OR_NULL(ar_ahb->rtc_clk))
- clk_disable_unprepare(ar_ahb->rtc_clk);
+ clk_disable_unprepare(ar_ahb->rtc_clk);
}
static int ath10k_ahb_rst_ctrl_init(struct ath10k *ar)
--
2.7.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH net-next] ath10k: Remove useless test before clk_disable_unprepare
2018-05-16 10:54 [PATCH net-next] ath10k: Remove useless test before clk_disable_unprepare YueHaibing
@ 2018-05-16 11:42 ` Kalle Valo
2018-05-16 12:10 ` YueHaibing
2018-05-25 10:04 ` Kalle Valo
1 sibling, 1 reply; 5+ messages in thread
From: Kalle Valo @ 2018-05-16 11:42 UTC (permalink / raw)
To: YueHaibing; +Cc: davem, netdev, linux-wireless
YueHaibing <yuehaibing@huawei.com> writes:
> clk_disable_unprepare() already checks that the clock pointer is valid.
> No need to test it before calling it.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Just a note that ath10k patches are applied to my ath.git tree, not to
net-next. So adding net-next to the subject is wrong, but no need to
resend just because of that.
--
Kalle Valo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] ath10k: Remove useless test before clk_disable_unprepare
2018-05-16 11:42 ` Kalle Valo
@ 2018-05-16 12:10 ` YueHaibing
0 siblings, 0 replies; 5+ messages in thread
From: YueHaibing @ 2018-05-16 12:10 UTC (permalink / raw)
To: Kalle Valo; +Cc: davem, netdev, linux-wireless
On 2018/5/16 19:42, Kalle Valo wrote:
> YueHaibing <yuehaibing@huawei.com> writes:
>
>> clk_disable_unprepare() already checks that the clock pointer is valid.
>> No need to test it before calling it.
>>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>
> Just a note that ath10k patches are applied to my ath.git tree, not to
> net-next. So adding net-next to the subject is wrong, but no need to
> resend just because of that.
>
OK, got it, thank you
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [net-next] ath10k: Remove useless test before clk_disable_unprepare
@ 2018-05-25 10:04 ` Kalle Valo
0 siblings, 0 replies; 5+ messages in thread
From: Kalle Valo @ 2018-05-25 10:04 UTC (permalink / raw)
To: YueHaibing; +Cc: kvalo, davem, netdev, linux-wireless, YueHaibing
YueHaibing <yuehaibing@huawei.com> wrote:
> clk_disable_unprepare() already checks that the clock pointer is valid.
> No need to test it before calling it.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
cf3c0ae6a32b ath10k: remove useless test before clk_disable_unprepare
--
https://patchwork.kernel.org/patch/10403597/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-05-25 10:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-16 10:54 [PATCH net-next] ath10k: Remove useless test before clk_disable_unprepare YueHaibing
2018-05-16 11:42 ` Kalle Valo
2018-05-16 12:10 ` YueHaibing
2018-05-25 10:04 ` [net-next] " Kalle Valo
2018-05-25 10:04 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.