All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/2] arm64: dts: renesas: add missing strobe pin to SDHI
@ 2018-05-25 15:05 Wolfram Sang
  2018-05-25 15:05 ` [PATCH 1/2] arm64: dts: salvator-common: Add sdhi2_ds pin group to SDHI2 pinctrl groups Wolfram Sang
  2018-05-25 15:05 ` [PATCH 2/2] arm64: dts: ulcb: " Wolfram Sang
  0 siblings, 2 replies; 4+ messages in thread
From: Wolfram Sang @ 2018-05-25 15:05 UTC (permalink / raw)
  To: linux-renesas-soc; +Cc: Simon Horman, Niklas Söderlund, Wolfram Sang

The strobe pin (SD2_DS) was forgotten to be configured when switching to 1.8V
on H3/M3-W/M3-N boards. Fix it with this series.

While this is a bug, I am not sure if it needs to be backported. This pin is
only needed for HS400 operation which we don't support yet but soon.

So, we surely want to have it in 4.17 before we hopefully merge HS400 support
for 4.18. But it could also be argued that this is a bug in the HW description,
so it needs to be backported. I am open for both options here.

But we really want this patch whenever we test HS400.

Thanks,

   Wolfram


Masaharu Hayakawa (1):
  arm64: dts: salvator-common: Add sdhi2_ds pin group to SDHI2 pinctrl
    groups

Wolfram Sang (1):
  arm64: dts: ulcb: Add sdhi2_ds pin group to SDHI2 pinctrl groups

 arch/arm64/boot/dts/renesas/salvator-common.dtsi | 4 ++--
 arch/arm64/boot/dts/renesas/ulcb.dtsi            | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

-- 
2.11.0

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/2] arm64: dts: salvator-common: Add sdhi2_ds pin group to SDHI2 pinctrl groups
  2018-05-25 15:05 [PATCH 0/2] arm64: dts: renesas: add missing strobe pin to SDHI Wolfram Sang
@ 2018-05-25 15:05 ` Wolfram Sang
  2018-05-25 15:05 ` [PATCH 2/2] arm64: dts: ulcb: " Wolfram Sang
  1 sibling, 0 replies; 4+ messages in thread
From: Wolfram Sang @ 2018-05-25 15:05 UTC (permalink / raw)
  To: linux-renesas-soc
  Cc: Simon Horman, Niklas Söderlund, Masaharu Hayakawa,
	Takeshi Kihara, Wolfram Sang

From: Masaharu Hayakawa <masaharu.hayakawa.ry@renesas.com>

This patch adds definitions for configuration of the power-source,
drive-strength, etc... for the SD2_DS pin.

Signed-off-by: Masaharu Hayakawa <masaharu.hayakawa.ry@renesas.com>
Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 arch/arm64/boot/dts/renesas/salvator-common.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
index 9256fbaaab7f..b3c0b6912af4 100644
--- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
+++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
@@ -589,13 +589,13 @@
 	};
 
 	sdhi2_pins: sd2 {
-		groups = "sdhi2_data8", "sdhi2_ctrl";
+		groups = "sdhi2_data8", "sdhi2_ctrl", "sdhi2_ds";
 		function = "sdhi2";
 		power-source = <3300>;
 	};
 
 	sdhi2_pins_uhs: sd2_uhs {
-		groups = "sdhi2_data8", "sdhi2_ctrl";
+		groups = "sdhi2_data8", "sdhi2_ctrl", "sdhi2_ds";
 		function = "sdhi2";
 		power-source = <1800>;
 	};
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/2] arm64: dts: ulcb: Add sdhi2_ds pin group to SDHI2 pinctrl groups
  2018-05-25 15:05 [PATCH 0/2] arm64: dts: renesas: add missing strobe pin to SDHI Wolfram Sang
  2018-05-25 15:05 ` [PATCH 1/2] arm64: dts: salvator-common: Add sdhi2_ds pin group to SDHI2 pinctrl groups Wolfram Sang
@ 2018-05-25 15:05 ` Wolfram Sang
  2018-05-28  9:31   ` Simon Horman
  1 sibling, 1 reply; 4+ messages in thread
From: Wolfram Sang @ 2018-05-25 15:05 UTC (permalink / raw)
  To: linux-renesas-soc; +Cc: Simon Horman, Niklas Söderlund, Wolfram Sang

This patch adds definitions for configuration of the power-source,
drive-strength, etc... for the SD2_DS pin. Based on a similar patch for
Salvator boards by Masaharu Hayakawa and Takeshi Kihara.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 arch/arm64/boot/dts/renesas/ulcb.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/renesas/ulcb.dtsi b/arch/arm64/boot/dts/renesas/ulcb.dtsi
index 0edb16e6b372..702df9cbed52 100644
--- a/arch/arm64/boot/dts/renesas/ulcb.dtsi
+++ b/arch/arm64/boot/dts/renesas/ulcb.dtsi
@@ -330,13 +330,13 @@
 	};
 
 	sdhi2_pins: sd2 {
-		groups = "sdhi2_data8", "sdhi2_ctrl";
+		groups = "sdhi2_data8", "sdhi2_ctrl", "sdhi2_ds";
 		function = "sdhi2";
 		power-source = <3300>;
 	};
 
 	sdhi2_pins_uhs: sd2_uhs {
-		groups = "sdhi2_data8", "sdhi2_ctrl";
+		groups = "sdhi2_data8", "sdhi2_ctrl", "sdhi2_ds";
 		function = "sdhi2";
 		power-source = <1800>;
 	};
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 2/2] arm64: dts: ulcb: Add sdhi2_ds pin group to SDHI2 pinctrl groups
  2018-05-25 15:05 ` [PATCH 2/2] arm64: dts: ulcb: " Wolfram Sang
@ 2018-05-28  9:31   ` Simon Horman
  0 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2018-05-28  9:31 UTC (permalink / raw)
  To: Wolfram Sang; +Cc: linux-renesas-soc, Niklas Söderlund

On Fri, May 25, 2018 at 05:05:18PM +0200, Wolfram Sang wrote:
> This patch adds definitions for configuration of the power-source,
> drive-strength, etc... for the SD2_DS pin. Based on a similar patch for
> Salvator boards by Masaharu Hayakawa and Takeshi Kihara.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Hi Wolfram,

Given Olof Johansson's recent comments in ("Re: [GIT PULL] Renesas ARM64
Based SoC DT Updates for v4.18") please consider squashing this
series into a single patch and reposting.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-05-28  9:31 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-25 15:05 [PATCH 0/2] arm64: dts: renesas: add missing strobe pin to SDHI Wolfram Sang
2018-05-25 15:05 ` [PATCH 1/2] arm64: dts: salvator-common: Add sdhi2_ds pin group to SDHI2 pinctrl groups Wolfram Sang
2018-05-25 15:05 ` [PATCH 2/2] arm64: dts: ulcb: " Wolfram Sang
2018-05-28  9:31   ` Simon Horman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.