All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: Sinan Kaya <okaya@codeaurora.org>
Cc: linux-pci@vger.kernel.org, timur@codeaurora.org, ryan@finnie.org,
	linux-arm-msm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org,
	Bjorn Helgaas <bhelgaas@google.com>,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Kate Stewart <kstewart@linuxfoundation.org>,
	Frederick Lawler <fred@fredlawl.com>,
	Dongdong Liu <liudongdong3@huawei.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	open list <linux-kernel@vger.kernel.org>,
	Don Brace <don.brace@microsemi.com>,
	esc.storagedev@microsemi.com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH V2] PCI/portdrv: do not disable device on reboot/shutdown
Date: Fri, 25 May 2018 17:10:24 -0500	[thread overview]
Message-ID: <20180525221024.GC92995@bhelgaas-glaptop.roam.corp.google.com> (raw)
In-Reply-To: <984b9734-244d-04e9-946f-7524f148ff7c@codeaurora.org>

On Fri, May 25, 2018 at 09:30:59AM -0400, Sinan Kaya wrote:
> On 5/24/2018 2:35 PM, Bjorn Helgaas wrote:
> > That sounds like a reasonable idea, and it is definitely another can
> > of worms.  I looked briefly at some of the .shutdown() cases:
> 
> should we throw it into 4.18 and see what happens?

It wouldn't solve this particular problem because hpsa *does* have a
.shutdown() method.  The problem is that it doesn't work -- it's
supposed to stop DMA and interrupts but it apparently doesn't.

I think we need to fix hpsa first.

WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Helgaas <helgaas@kernel.org>
To: Sinan Kaya <okaya@codeaurora.org>
Cc: ryan@finnie.org, Kate Stewart <kstewart@linuxfoundation.org>,
	linux-scsi@vger.kernel.org, Frederick Lawler <fred@fredlawl.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-pci@vger.kernel.org, timur@codeaurora.org,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	esc.storagedev@microsemi.com,
	open list <linux-kernel@vger.kernel.org>,
	stable@vger.kernel.org, Dongdong Liu <liudongdong3@huawei.com>,
	linux-arm-msm@vger.kernel.org,
	Bjorn Helgaas <bhelgaas@google.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Don Brace <don.brace@microsemi.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V2] PCI/portdrv: do not disable device on reboot/shutdown
Date: Fri, 25 May 2018 17:10:24 -0500	[thread overview]
Message-ID: <20180525221024.GC92995@bhelgaas-glaptop.roam.corp.google.com> (raw)
In-Reply-To: <984b9734-244d-04e9-946f-7524f148ff7c@codeaurora.org>

On Fri, May 25, 2018 at 09:30:59AM -0400, Sinan Kaya wrote:
> On 5/24/2018 2:35 PM, Bjorn Helgaas wrote:
> > That sounds like a reasonable idea, and it is definitely another can
> > of worms.  I looked briefly at some of the .shutdown() cases:
> 
> should we throw it into 4.18 and see what happens?

It wouldn't solve this particular problem because hpsa *does* have a
.shutdown() method.  The problem is that it doesn't work -- it's
supposed to stop DMA and interrupts but it apparently doesn't.

I think we need to fix hpsa first.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: helgaas@kernel.org (Bjorn Helgaas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2] PCI/portdrv: do not disable device on reboot/shutdown
Date: Fri, 25 May 2018 17:10:24 -0500	[thread overview]
Message-ID: <20180525221024.GC92995@bhelgaas-glaptop.roam.corp.google.com> (raw)
In-Reply-To: <984b9734-244d-04e9-946f-7524f148ff7c@codeaurora.org>

On Fri, May 25, 2018 at 09:30:59AM -0400, Sinan Kaya wrote:
> On 5/24/2018 2:35 PM, Bjorn Helgaas wrote:
> > That sounds like a reasonable idea, and it is definitely another can
> > of worms.  I looked briefly at some of the .shutdown() cases:
> 
> should we throw it into 4.18 and see what happens?

It wouldn't solve this particular problem because hpsa *does* have a
.shutdown() method.  The problem is that it doesn't work -- it's
supposed to stop DMA and interrupts but it apparently doesn't.

I think we need to fix hpsa first.

  reply	other threads:[~2018-05-25 22:10 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-23  2:44 [PATCH V2] PCI/portdrv: do not disable device on reboot/shutdown Sinan Kaya
2018-05-23  2:44 ` Sinan Kaya
2018-05-23  2:44 ` Sinan Kaya
2018-05-23 21:32 ` Bjorn Helgaas
2018-05-23 21:32   ` Bjorn Helgaas
2018-05-23 21:32   ` Bjorn Helgaas
2018-05-23 22:57   ` Sinan Kaya
2018-05-23 22:57     ` Sinan Kaya
2018-05-24 11:43     ` Sinan Kaya
2018-05-24 11:43       ` Sinan Kaya
2018-05-24 13:07       ` Bjorn Helgaas
2018-05-24 13:07         ` Bjorn Helgaas
2018-05-24 13:07         ` Bjorn Helgaas
2018-05-24 13:35         ` okaya
2018-05-24 13:35           ` okaya at codeaurora.org
2018-05-24 13:37         ` Don Brace
2018-05-24 13:37           ` Don Brace
2018-05-24 13:37           ` Don Brace
2018-05-28 21:25           ` Sinan Kaya
2018-05-28 21:25             ` Sinan Kaya
2018-05-28 21:25             ` Sinan Kaya
2018-05-24 18:35     ` Bjorn Helgaas
2018-05-24 18:35       ` Bjorn Helgaas
2018-05-24 18:35       ` Bjorn Helgaas
2018-05-25 13:30       ` Sinan Kaya
2018-05-25 13:30         ` Sinan Kaya
2018-05-25 22:10         ` Bjorn Helgaas [this message]
2018-05-25 22:10           ` Bjorn Helgaas
2018-05-25 22:10           ` Bjorn Helgaas
2018-05-25 22:34           ` okaya
2018-05-25 22:34             ` okaya at codeaurora.org
2018-05-30  2:41           ` Sinan Kaya
2018-05-30  2:41             ` Sinan Kaya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180525221024.GC92995@bhelgaas-glaptop.roam.corp.google.com \
    --to=helgaas@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=don.brace@microsemi.com \
    --cc=esc.storagedev@microsemi.com \
    --cc=fred@fredlawl.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kstewart@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=liudongdong3@huawei.com \
    --cc=mika.westerberg@linux.intel.com \
    --cc=okaya@codeaurora.org \
    --cc=rafael.j.wysocki@intel.com \
    --cc=ryan@finnie.org \
    --cc=stable@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=timur@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.