* [U-Boot] [PATCH v2 3/6] common: iotrace: add timestamp to iotrace records
@ 2018-05-26 13:56 Ramon Fried
2018-05-26 22:18 ` Simon Glass
0 siblings, 1 reply; 2+ messages in thread
From: Ramon Fried @ 2018-05-26 13:56 UTC (permalink / raw)
To: u-boot
Add timestamp to each iotrace record to aid in debugging
of IO timing access bugs.
Signed-off-by: Ramon Fried <ramon.fried@gmail.com>
---
v2: replace get_ticks() with timer_get_us()
common/iotrace.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/common/iotrace.c b/common/iotrace.c
index f39885663a..2f03a6082e 100644
--- a/common/iotrace.c
+++ b/common/iotrace.c
@@ -27,11 +27,13 @@ enum iotrace_flags {
* struct iotrace_record - Holds a single I/O trace record
*
* @flags: I/O access type
+ * @timestamp: Timestamp of access
* @addr: Address of access
* @value: Value written or read
*/
struct iotrace_record {
enum iotrace_flags flags;
+ u64 timestamp;
phys_addr_t addr;
iovalue_t value;
};
@@ -81,7 +83,7 @@ static void add_record(int flags, const void *ptr, ulong value)
iotrace.start + iotrace.offset,
sizeof(value));
}
-
+ rec->timestamp = timer_get_us();
rec->flags = flags;
rec->addr = map_to_sysmem(ptr);
rec->value = value;
--
2.17.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [U-Boot] [PATCH v2 3/6] common: iotrace: add timestamp to iotrace records
2018-05-26 13:56 [U-Boot] [PATCH v2 3/6] common: iotrace: add timestamp to iotrace records Ramon Fried
@ 2018-05-26 22:18 ` Simon Glass
0 siblings, 0 replies; 2+ messages in thread
From: Simon Glass @ 2018-05-26 22:18 UTC (permalink / raw)
To: u-boot
On 26 May 2018 at 07:56, Ramon Fried <ramon.fried@gmail.com> wrote:
> Add timestamp to each iotrace record to aid in debugging
> of IO timing access bugs.
>
> Signed-off-by: Ramon Fried <ramon.fried@gmail.com>
> ---
> v2: replace get_ticks() with timer_get_us()
>
> common/iotrace.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-05-26 22:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-26 13:56 [U-Boot] [PATCH v2 3/6] common: iotrace: add timestamp to iotrace records Ramon Fried
2018-05-26 22:18 ` Simon Glass
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.