From: kbuild test robot <lkp@intel.com>
To: David Lechner <david@lechnology.com>
Cc: kbuild-all@01.org, dri-devel@lists.freedesktop.org,
devicetree@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>,
limor@ladyada.net, David Lechner <david@lechnology.com>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Nitin Patil <nitin@mindsensors.com>
Subject: Re: [PATCH v2 4/4] drm/tinydrm: new driver for ILI9341 display panels
Date: Sun, 27 May 2018 22:04:33 +0800 [thread overview]
Message-ID: <201805271947.urSNdO7A%fengguang.wu@intel.com> (raw)
In-Reply-To: <20180525193623.15533-5-david@lechnology.com>
[-- Attachment #1: Type: text/plain, Size: 5568 bytes --]
Hi David,
I love your patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v4.17-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/David-Lechner/drm-tinydrm-new-dirver-for-ILI9341-displays/20180527-182036
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 8.1.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=ia64
All errors (new ones prefixed by >>):
drivers/gpu//drm/tinydrm/ili9341.c: In function 'yx240qv29_enable':
drivers/gpu//drm/tinydrm/ili9341.c:128:2: error: too many arguments to function 'mipi_dbi_enable_flush'
mipi_dbi_enable_flush(mipi, crtc_state, plane_state);
^~~~~~~~~~~~~~~~~~~~~
In file included from drivers/gpu//drm/tinydrm/ili9341.c:21:
include/drm/tinydrm/mipi-dbi.h:70:6: note: declared here
void mipi_dbi_enable_flush(struct mipi_dbi *mipi);
^~~~~~~~~~~~~~~~~~~~~
drivers/gpu//drm/tinydrm/ili9341.c: At top level:
>> drivers/gpu//drm/tinydrm/ili9341.c:132:12: error: initialization of 'void (*)(struct drm_simple_display_pipe *, struct drm_crtc_state *)' from incompatible pointer type 'void (*)(struct drm_simple_display_pipe *, struct drm_crtc_state *, struct drm_plane_state *)' [-Werror=incompatible-pointer-types]
.enable = yx240qv29_enable,
^~~~~~~~~~~~~~~~
drivers/gpu//drm/tinydrm/ili9341.c:132:12: note: (near initialization for 'ili9341_pipe_funcs.enable')
drivers/gpu//drm/tinydrm/ili9341.c:135:16: error: 'drm_gem_fb_simple_display_pipe_prepare_fb' undeclared here (not in a function); did you mean 'tinydrm_display_pipe_prepare_fb'?
.prepare_fb = drm_gem_fb_simple_display_pipe_prepare_fb,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
tinydrm_display_pipe_prepare_fb
cc1: some warnings being treated as errors
vim +132 drivers/gpu//drm/tinydrm/ili9341.c
49
50 static void yx240qv29_enable(struct drm_simple_display_pipe *pipe,
51 struct drm_crtc_state *crtc_state,
52 struct drm_plane_state *plane_state)
53 {
54 struct tinydrm_device *tdev = pipe_to_tinydrm(pipe);
55 struct mipi_dbi *mipi = mipi_dbi_from_tinydrm(tdev);
56 u8 addr_mode;
57 int ret;
58
59 DRM_DEBUG_KMS("\n");
60
61 ret = mipi_dbi_poweron_conditional_reset(mipi);
62 if (ret < 0)
63 return;
64 if (ret == 1)
65 goto out_enable;
66
67 mipi_dbi_command(mipi, MIPI_DCS_SET_DISPLAY_OFF);
68
69 mipi_dbi_command(mipi, ILI9341_PWCTRLB, 0x00, 0xc1, 0x30);
70 mipi_dbi_command(mipi, ILI9341_PWRSEQ, 0x64, 0x03, 0x12, 0x81);
71 mipi_dbi_command(mipi, ILI9341_DTCTRLA, 0x85, 0x00, 0x78);
72 mipi_dbi_command(mipi, ILI9341_PWCTRLA, 0x39, 0x2c, 0x00, 0x34, 0x02);
73 mipi_dbi_command(mipi, ILI9341_PUMPCTRL, 0x20);
74 mipi_dbi_command(mipi, ILI9341_DTCTRLB, 0x00, 0x00);
75
76 /* Power Control */
77 mipi_dbi_command(mipi, ILI9341_PWCTRL1, 0x23);
78 mipi_dbi_command(mipi, ILI9341_PWCTRL2, 0x10);
79 /* VCOM */
80 mipi_dbi_command(mipi, ILI9341_VMCTRL1, 0x3e, 0x28);
81 mipi_dbi_command(mipi, ILI9341_VMCTRL2, 0x86);
82
83 /* Memory Access Control */
84 mipi_dbi_command(mipi, MIPI_DCS_SET_PIXEL_FORMAT, MIPI_DCS_PIXEL_FMT_16BIT);
85
86 /* Frame Rate */
87 mipi_dbi_command(mipi, ILI9341_FRMCTR1, 0x00, 0x1b);
88
89 /* Gamma */
90 mipi_dbi_command(mipi, ILI9341_EN3GAM, 0x00);
91 mipi_dbi_command(mipi, MIPI_DCS_SET_GAMMA_CURVE, 0x01);
92 mipi_dbi_command(mipi, ILI9341_PGAMCTRL,
93 0x0f, 0x31, 0x2b, 0x0c, 0x0e, 0x08, 0x4e, 0xf1,
94 0x37, 0x07, 0x10, 0x03, 0x0e, 0x09, 0x00);
95 mipi_dbi_command(mipi, ILI9341_NGAMCTRL,
96 0x00, 0x0e, 0x14, 0x03, 0x11, 0x07, 0x31, 0xc1,
97 0x48, 0x08, 0x0f, 0x0c, 0x31, 0x36, 0x0f);
98
99 /* DDRAM */
100 mipi_dbi_command(mipi, ILI9341_ETMOD, 0x07);
101
102 /* Display */
103 mipi_dbi_command(mipi, ILI9341_DISCTRL, 0x08, 0x82, 0x27, 0x00);
104 mipi_dbi_command(mipi, MIPI_DCS_EXIT_SLEEP_MODE);
105 msleep(100);
106
107 mipi_dbi_command(mipi, MIPI_DCS_SET_DISPLAY_ON);
108 msleep(100);
109
110 out_enable:
111 switch (mipi->rotation) {
112 default:
113 addr_mode = ILI9341_MADCTL_MX;
114 break;
115 case 90:
116 addr_mode = ILI9341_MADCTL_MV;
117 break;
118 case 180:
119 addr_mode = ILI9341_MADCTL_MY;
120 break;
121 case 270:
122 addr_mode = ILI9341_MADCTL_MV | ILI9341_MADCTL_MY |
123 ILI9341_MADCTL_MX;
124 break;
125 }
126 addr_mode |= ILI9341_MADCTL_BGR;
127 mipi_dbi_command(mipi, MIPI_DCS_SET_ADDRESS_MODE, addr_mode);
> 128 mipi_dbi_enable_flush(mipi, crtc_state, plane_state);
129 }
130
131 static const struct drm_simple_display_pipe_funcs ili9341_pipe_funcs = {
> 132 .enable = yx240qv29_enable,
133 .disable = mipi_dbi_pipe_disable,
134 .update = tinydrm_display_pipe_update,
135 .prepare_fb = drm_gem_fb_simple_display_pipe_prepare_fb,
136 };
137
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 49884 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kbuild test robot <lkp@intel.com>
Cc: kbuild-all@01.org, dri-devel@lists.freedesktop.org,
devicetree@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>,
limor@ladyada.net, David Lechner <david@lechnology.com>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Nitin Patil <nitin@mindsensors.com>
Subject: Re: [PATCH v2 4/4] drm/tinydrm: new driver for ILI9341 display panels
Date: Sun, 27 May 2018 22:04:33 +0800 [thread overview]
Message-ID: <201805271947.urSNdO7A%fengguang.wu@intel.com> (raw)
In-Reply-To: <20180525193623.15533-5-david@lechnology.com>
[-- Attachment #1: Type: text/plain, Size: 5568 bytes --]
Hi David,
I love your patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v4.17-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/David-Lechner/drm-tinydrm-new-dirver-for-ILI9341-displays/20180527-182036
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 8.1.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=ia64
All errors (new ones prefixed by >>):
drivers/gpu//drm/tinydrm/ili9341.c: In function 'yx240qv29_enable':
drivers/gpu//drm/tinydrm/ili9341.c:128:2: error: too many arguments to function 'mipi_dbi_enable_flush'
mipi_dbi_enable_flush(mipi, crtc_state, plane_state);
^~~~~~~~~~~~~~~~~~~~~
In file included from drivers/gpu//drm/tinydrm/ili9341.c:21:
include/drm/tinydrm/mipi-dbi.h:70:6: note: declared here
void mipi_dbi_enable_flush(struct mipi_dbi *mipi);
^~~~~~~~~~~~~~~~~~~~~
drivers/gpu//drm/tinydrm/ili9341.c: At top level:
>> drivers/gpu//drm/tinydrm/ili9341.c:132:12: error: initialization of 'void (*)(struct drm_simple_display_pipe *, struct drm_crtc_state *)' from incompatible pointer type 'void (*)(struct drm_simple_display_pipe *, struct drm_crtc_state *, struct drm_plane_state *)' [-Werror=incompatible-pointer-types]
.enable = yx240qv29_enable,
^~~~~~~~~~~~~~~~
drivers/gpu//drm/tinydrm/ili9341.c:132:12: note: (near initialization for 'ili9341_pipe_funcs.enable')
drivers/gpu//drm/tinydrm/ili9341.c:135:16: error: 'drm_gem_fb_simple_display_pipe_prepare_fb' undeclared here (not in a function); did you mean 'tinydrm_display_pipe_prepare_fb'?
.prepare_fb = drm_gem_fb_simple_display_pipe_prepare_fb,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
tinydrm_display_pipe_prepare_fb
cc1: some warnings being treated as errors
vim +132 drivers/gpu//drm/tinydrm/ili9341.c
49
50 static void yx240qv29_enable(struct drm_simple_display_pipe *pipe,
51 struct drm_crtc_state *crtc_state,
52 struct drm_plane_state *plane_state)
53 {
54 struct tinydrm_device *tdev = pipe_to_tinydrm(pipe);
55 struct mipi_dbi *mipi = mipi_dbi_from_tinydrm(tdev);
56 u8 addr_mode;
57 int ret;
58
59 DRM_DEBUG_KMS("\n");
60
61 ret = mipi_dbi_poweron_conditional_reset(mipi);
62 if (ret < 0)
63 return;
64 if (ret == 1)
65 goto out_enable;
66
67 mipi_dbi_command(mipi, MIPI_DCS_SET_DISPLAY_OFF);
68
69 mipi_dbi_command(mipi, ILI9341_PWCTRLB, 0x00, 0xc1, 0x30);
70 mipi_dbi_command(mipi, ILI9341_PWRSEQ, 0x64, 0x03, 0x12, 0x81);
71 mipi_dbi_command(mipi, ILI9341_DTCTRLA, 0x85, 0x00, 0x78);
72 mipi_dbi_command(mipi, ILI9341_PWCTRLA, 0x39, 0x2c, 0x00, 0x34, 0x02);
73 mipi_dbi_command(mipi, ILI9341_PUMPCTRL, 0x20);
74 mipi_dbi_command(mipi, ILI9341_DTCTRLB, 0x00, 0x00);
75
76 /* Power Control */
77 mipi_dbi_command(mipi, ILI9341_PWCTRL1, 0x23);
78 mipi_dbi_command(mipi, ILI9341_PWCTRL2, 0x10);
79 /* VCOM */
80 mipi_dbi_command(mipi, ILI9341_VMCTRL1, 0x3e, 0x28);
81 mipi_dbi_command(mipi, ILI9341_VMCTRL2, 0x86);
82
83 /* Memory Access Control */
84 mipi_dbi_command(mipi, MIPI_DCS_SET_PIXEL_FORMAT, MIPI_DCS_PIXEL_FMT_16BIT);
85
86 /* Frame Rate */
87 mipi_dbi_command(mipi, ILI9341_FRMCTR1, 0x00, 0x1b);
88
89 /* Gamma */
90 mipi_dbi_command(mipi, ILI9341_EN3GAM, 0x00);
91 mipi_dbi_command(mipi, MIPI_DCS_SET_GAMMA_CURVE, 0x01);
92 mipi_dbi_command(mipi, ILI9341_PGAMCTRL,
93 0x0f, 0x31, 0x2b, 0x0c, 0x0e, 0x08, 0x4e, 0xf1,
94 0x37, 0x07, 0x10, 0x03, 0x0e, 0x09, 0x00);
95 mipi_dbi_command(mipi, ILI9341_NGAMCTRL,
96 0x00, 0x0e, 0x14, 0x03, 0x11, 0x07, 0x31, 0xc1,
97 0x48, 0x08, 0x0f, 0x0c, 0x31, 0x36, 0x0f);
98
99 /* DDRAM */
100 mipi_dbi_command(mipi, ILI9341_ETMOD, 0x07);
101
102 /* Display */
103 mipi_dbi_command(mipi, ILI9341_DISCTRL, 0x08, 0x82, 0x27, 0x00);
104 mipi_dbi_command(mipi, MIPI_DCS_EXIT_SLEEP_MODE);
105 msleep(100);
106
107 mipi_dbi_command(mipi, MIPI_DCS_SET_DISPLAY_ON);
108 msleep(100);
109
110 out_enable:
111 switch (mipi->rotation) {
112 default:
113 addr_mode = ILI9341_MADCTL_MX;
114 break;
115 case 90:
116 addr_mode = ILI9341_MADCTL_MV;
117 break;
118 case 180:
119 addr_mode = ILI9341_MADCTL_MY;
120 break;
121 case 270:
122 addr_mode = ILI9341_MADCTL_MV | ILI9341_MADCTL_MY |
123 ILI9341_MADCTL_MX;
124 break;
125 }
126 addr_mode |= ILI9341_MADCTL_BGR;
127 mipi_dbi_command(mipi, MIPI_DCS_SET_ADDRESS_MODE, addr_mode);
> 128 mipi_dbi_enable_flush(mipi, crtc_state, plane_state);
129 }
130
131 static const struct drm_simple_display_pipe_funcs ili9341_pipe_funcs = {
> 132 .enable = yx240qv29_enable,
133 .disable = mipi_dbi_pipe_disable,
134 .update = tinydrm_display_pipe_update,
135 .prepare_fb = drm_gem_fb_simple_display_pipe_prepare_fb,
136 };
137
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 49884 bytes --]
next prev parent reply other threads:[~2018-05-27 14:04 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-25 19:36 [PATCH v2 0/4] drm/tinydrm: new dirver for ILI9341 displays David Lechner
2018-05-25 19:36 ` David Lechner
2018-05-25 19:36 ` [PATCH v2 1/4] MAINTAINERS: fix path to ilitek,ili9225 device tree bindings David Lechner
2018-05-25 19:36 ` [PATCH v2 1/4] MAINTAINERS: fix path to ilitek, ili9225 " David Lechner
2018-05-25 19:36 ` [PATCH v2 2/4] dt-bindings: Add vendor prefix for Adafruit David Lechner
2018-05-25 19:36 ` David Lechner
2018-05-31 3:38 ` Rob Herring
2018-05-31 3:38 ` Rob Herring
2018-05-25 19:36 ` [PATCH v2 3/4] dt-bindings: new binding for Ilitek ILI9341 display panels David Lechner
2018-05-25 19:36 ` David Lechner
2018-05-25 20:14 ` David Lechner
2018-05-25 20:14 ` David Lechner
2018-05-31 3:39 ` Rob Herring
2018-05-31 3:39 ` Rob Herring
2018-05-25 19:36 ` [PATCH v2 4/4] drm/tinydrm: new driver for " David Lechner
2018-05-27 14:04 ` kbuild test robot
2018-05-27 14:04 ` kbuild test robot
2018-05-27 14:04 ` kbuild test robot [this message]
2018-05-27 14:04 ` kbuild test robot
2018-05-27 14:50 ` kbuild test robot
2018-05-27 14:50 ` kbuild test robot
2018-05-25 19:36 ` [PATCH v2 0/4] drm/tinydrm: new dirver for ILI9341 displays Robert P. J. Day
2018-05-25 19:36 ` Robert P. J. Day
2018-06-03 22:00 ` Noralf Trønnes
2018-06-04 1:21 ` David Lechner
2018-06-05 15:49 ` Noralf Trønnes
2018-06-05 15:49 ` Noralf Trønnes
2018-06-19 15:36 ` Noralf Trønnes
2018-06-19 15:36 ` Noralf Trønnes
2018-06-20 9:07 ` Daniel Vetter
2018-06-20 9:07 ` Daniel Vetter
2018-06-26 18:16 ` David Lechner
2018-06-26 18:16 ` David Lechner
2018-06-27 6:58 ` Daniel Vetter
2018-06-27 6:58 ` Daniel Vetter
2018-06-27 18:08 ` David Lechner
2018-06-27 18:08 ` David Lechner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201805271947.urSNdO7A%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=david@lechnology.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=kbuild-all@01.org \
--cc=limor@ladyada.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nitin@mindsensors.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.