All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Ross Zwisler <ross.zwisler@linux.intel.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>,
	"Michael S . Tsirkin" <mst@redhat.com>,
	linux-nvdimm <linux-nvdimm@lists.01.org>,
	qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
	Igor Mammedov <imammedo@redhat.com>
Subject: Re: [qemu PATCH v4 0/4] support NFIT platform capabilities
Date: Tue, 29 May 2018 13:54:33 -0600	[thread overview]
Message-ID: <20180529195433.GA16151@linux.intel.com> (raw)
In-Reply-To: <20180521163203.26590-1-ross.zwisler@linux.intel.com>

Ping on this series.  Rob, I think I've addressed all your feedback.  Can you
please verify?

Thanks,
- Ross

On Mon, May 21, 2018 at 10:31:59AM -0600, Ross Zwisler wrote:
> Changes since v3:
>  * Updated the text in docs/nvdimm.txt to make it clear that the value
>    being passed in on the command line in an integer made up of various
>    bit fields. (Rob Elliott)
>  
>  * Updated the "Highest Valid Capability" byte to be dynamic based on
>    the highest valid bit in the user's input. (Rob Elliott)
> 
> ---
> 
> The first 2 patches in this series clean up some things I noticed while
> coding.
> 
> Patch 3 adds support for the new Platform Capabilities Structure, which
> was added to the NFIT in ACPI 6.2 Errata A.  We add a machine command
> line option "nvdimm-cap":
> 
>     -machine pc,accel=kvm,nvdimm,nvdimm-cap=2
> 
> which allows the user to pass in a value for this structure.  When such
> a value is passed in we will generate the new NFIT subtable.
> 
> Patch 4 adds code to the "make check" self test infrastructure so that
> we generate the new Platform Capabilities Structure, and adds it to the
> expected NFIT output so that we test for it.
> 
> Ross Zwisler (4):
>   nvdimm: fix typo in label-size definition
>   tests/.gitignore: add entry for generated file
>   nvdimm, acpi: support NFIT platform capabilities
>   ACPI testing: test NFIT platform capabilities
> 
>  docs/nvdimm.txt                       |  27 ++++++++++++++++++++
>  hw/acpi/nvdimm.c                      |  45 +++++++++++++++++++++++++++++++---
>  hw/i386/pc.c                          |  31 +++++++++++++++++++++++
>  hw/mem/nvdimm.c                       |   2 +-
>  include/hw/i386/pc.h                  |   1 +
>  include/hw/mem/nvdimm.h               |   7 +++++-
>  tests/.gitignore                      |   1 +
>  tests/acpi-test-data/pc/NFIT.dimmpxm  | Bin 224 -> 240 bytes
>  tests/acpi-test-data/q35/NFIT.dimmpxm | Bin 224 -> 240 bytes
>  tests/bios-tables-test.c              |   2 +-
>  10 files changed, 109 insertions(+), 7 deletions(-)
> 
> -- 
> 2.14.3
> 
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

WARNING: multiple messages have this Message-ID (diff)
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Ross Zwisler <ross.zwisler@linux.intel.com>
Cc: Igor Mammedov <imammedo@redhat.com>,
	qemu-devel@nongnu.org, Haozhong Zhang <haozhong.zhang@intel.com>,
	"Michael S . Tsirkin" <mst@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Eduardo Habkost <ehabkost@redhat.com>,
	linux-nvdimm <linux-nvdimm@lists.01.org>,
	"Elliott, Robert (Persistent Memory)" <elliott@hpe.com>
Subject: Re: [Qemu-devel] [qemu PATCH v4 0/4] support NFIT platform capabilities
Date: Tue, 29 May 2018 13:54:33 -0600	[thread overview]
Message-ID: <20180529195433.GA16151@linux.intel.com> (raw)
In-Reply-To: <20180521163203.26590-1-ross.zwisler@linux.intel.com>

Ping on this series.  Rob, I think I've addressed all your feedback.  Can you
please verify?

Thanks,
- Ross

On Mon, May 21, 2018 at 10:31:59AM -0600, Ross Zwisler wrote:
> Changes since v3:
>  * Updated the text in docs/nvdimm.txt to make it clear that the value
>    being passed in on the command line in an integer made up of various
>    bit fields. (Rob Elliott)
>  
>  * Updated the "Highest Valid Capability" byte to be dynamic based on
>    the highest valid bit in the user's input. (Rob Elliott)
> 
> ---
> 
> The first 2 patches in this series clean up some things I noticed while
> coding.
> 
> Patch 3 adds support for the new Platform Capabilities Structure, which
> was added to the NFIT in ACPI 6.2 Errata A.  We add a machine command
> line option "nvdimm-cap":
> 
>     -machine pc,accel=kvm,nvdimm,nvdimm-cap=2
> 
> which allows the user to pass in a value for this structure.  When such
> a value is passed in we will generate the new NFIT subtable.
> 
> Patch 4 adds code to the "make check" self test infrastructure so that
> we generate the new Platform Capabilities Structure, and adds it to the
> expected NFIT output so that we test for it.
> 
> Ross Zwisler (4):
>   nvdimm: fix typo in label-size definition
>   tests/.gitignore: add entry for generated file
>   nvdimm, acpi: support NFIT platform capabilities
>   ACPI testing: test NFIT platform capabilities
> 
>  docs/nvdimm.txt                       |  27 ++++++++++++++++++++
>  hw/acpi/nvdimm.c                      |  45 +++++++++++++++++++++++++++++++---
>  hw/i386/pc.c                          |  31 +++++++++++++++++++++++
>  hw/mem/nvdimm.c                       |   2 +-
>  include/hw/i386/pc.h                  |   1 +
>  include/hw/mem/nvdimm.h               |   7 +++++-
>  tests/.gitignore                      |   1 +
>  tests/acpi-test-data/pc/NFIT.dimmpxm  | Bin 224 -> 240 bytes
>  tests/acpi-test-data/q35/NFIT.dimmpxm | Bin 224 -> 240 bytes
>  tests/bios-tables-test.c              |   2 +-
>  10 files changed, 109 insertions(+), 7 deletions(-)
> 
> -- 
> 2.14.3
> 

  parent reply	other threads:[~2018-05-29 19:54 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-21 16:31 [qemu PATCH v4 0/4] support NFIT platform capabilities Ross Zwisler
2018-05-21 16:31 ` [Qemu-devel] " Ross Zwisler
2018-05-21 16:32 ` [qemu PATCH v4 1/4] nvdimm: fix typo in label-size definition Ross Zwisler
2018-05-21 16:32   ` [Qemu-devel] " Ross Zwisler
2018-05-21 16:32 ` [qemu PATCH v4 2/4] tests/.gitignore: add entry for generated file Ross Zwisler
2018-05-21 16:32   ` [Qemu-devel] " Ross Zwisler
2018-05-21 16:41   ` Eric Blake
2018-05-21 16:41     ` Eric Blake
2018-05-21 17:32     ` Philippe Mathieu-Daudé
2018-05-21 17:32       ` Philippe Mathieu-Daudé
2018-05-21 18:29       ` Eric Blake
2018-05-21 18:29         ` Eric Blake
2018-05-21 16:32 ` [qemu PATCH v4 3/4] nvdimm, acpi: support NFIT platform capabilities Ross Zwisler
2018-05-21 16:32   ` [Qemu-devel] " Ross Zwisler
2018-06-05 15:25   ` Michael S. Tsirkin
2018-06-05 15:25     ` [Qemu-devel] " Michael S. Tsirkin
2018-06-05 16:42     ` Ross Zwisler
2018-06-05 16:42       ` [Qemu-devel] " Ross Zwisler
2018-06-05 18:15       ` Dan Williams
2018-06-05 18:15         ` [Qemu-devel] " Dan Williams
2018-06-05 18:37         ` Michael S. Tsirkin
2018-06-05 18:37           ` [Qemu-devel] " Michael S. Tsirkin
2018-06-05 22:07           ` Ross Zwisler
2018-06-05 22:07             ` [Qemu-devel] " Ross Zwisler
2018-06-05 22:21             ` Dan Williams
2018-06-05 22:21               ` [Qemu-devel] " Dan Williams
2018-06-06 16:50               ` Ross Zwisler
2018-06-06 16:50                 ` [Qemu-devel] " Ross Zwisler
2018-06-06 17:00                 ` Ross Zwisler
2018-06-06 17:00                   ` [Qemu-devel] " Ross Zwisler
2018-06-06 17:08                   ` Ross Zwisler
2018-06-06 17:08                     ` [Qemu-devel] " Ross Zwisler
2018-06-06 19:06                     ` Michael S. Tsirkin
2018-06-06 19:06                       ` [Qemu-devel] " Michael S. Tsirkin
2018-06-12 11:55                       ` Igor Mammedov
2018-06-12 11:55                         ` Igor Mammedov
2018-06-06 19:04                   ` Michael S. Tsirkin
2018-06-06 19:04                     ` [Qemu-devel] " Michael S. Tsirkin
2018-06-06 19:07                 ` Michael S. Tsirkin
2018-06-06 19:07                   ` [Qemu-devel] " Michael S. Tsirkin
2018-06-06 23:20               ` Elliott, Robert (Persistent Memory)
2018-06-06 23:20                 ` [Qemu-devel] " Elliott, Robert (Persistent Memory)
2018-06-06 23:40                 ` Dan Williams
2018-06-06 23:40                   ` [Qemu-devel] " Dan Williams
2018-06-07 15:29                   ` Michael S. Tsirkin
2018-06-07 15:29                     ` [Qemu-devel] " Michael S. Tsirkin
2018-06-07 15:30                 ` Michael S. Tsirkin
2018-06-07 15:30                   ` [Qemu-devel] " Michael S. Tsirkin
2018-05-21 16:32 ` [qemu PATCH v4 4/4] ACPI testing: test " Ross Zwisler
2018-05-21 16:32   ` [Qemu-devel] " Ross Zwisler
2018-05-25 17:51 ` [qemu PATCH v4 0/4] support " Michael S. Tsirkin
2018-05-25 17:51   ` [Qemu-devel] " Michael S. Tsirkin
2018-05-31 22:03   ` Ross Zwisler
2018-05-31 22:03     ` [Qemu-devel] " Ross Zwisler
2018-05-29 19:54 ` Ross Zwisler [this message]
2018-05-29 19:54   ` Ross Zwisler
2018-06-01  5:11   ` Elliott, Robert (Persistent Memory)
2018-06-01  5:11     ` [Qemu-devel] " Elliott, Robert (Persistent Memory)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180529195433.GA16151@linux.intel.com \
    --to=ross.zwisler@linux.intel.com \
    --cc=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=linux-nvdimm@lists.01.org \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.