From: Andreas Gruenbacher <agruenba@redhat.com> To: cluster-devel@redhat.com, Christoph Hellwig <hch@lst.de> Cc: linux-fsdevel@vger.kernel.org, Andreas Gruenbacher <agruenba@redhat.com> Subject: [PATCH v5 00/14] gfs2 iomap write support Date: Wed, 30 May 2018 11:48:28 +0200 [thread overview] Message-ID: <20180530094842.13559-1-agruenba@redhat.com> (raw) Here's an update of my gfs2 iomap write patch queue, with support for buffered writes as well as direct I/O reads and writes through iomap. This update fixes a few bugs in the gfs2 specific parts. The patches are still meant for the upcoming merge window. The first five patches are minor gfs2 specific cleanups and improvements. The actual fun starts with patch "iomap: Add write_{begin,end} iomap operations" which adds callbacks into the filesystem for any per-page processing. Christoph has suggested that at least the stuffed inode (aka. inline data) handline should be moved to the iomap_{begin,end} operations. As the last patch tries to demonstrate, this is a bit tricky, so even though Christoph's approach is slightly cleaner conceptually, it doesn't look like an improvement overall. Patches "iomap: Mark newly allocated buffer heads as new" and "iomap: Complete partial direct I/O writes synchronously" have been added as discussed. A 4.17-rc7 based version of the patches can be found here: https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git/log/?h=iomap-write Thanks, Andreas Andreas Gruenbacher (13): gfs2: Update find_metapath comment gfs2: hole_size improvement gfs2: gfs2_stuffed_write_end cleanup gfs2: Remove ordered write mode handling from gfs2_trans_add_data gfs2: Iomap cleanups and improvements iomap: Add write_{begin,end} iomap operations iomap: Mark newly allocated buffer heads as new gfs2: iomap buffered write support gfs2: gfs2_extent_length cleanup iomap: Complete partial direct I/O writes synchronously gfs2: iomap direct I/O support gfs2: Remove gfs2_write_{begin,end} gfs2: Handle stuffed files in iomap_{begin,end} Christoph Hellwig (1): iomap: inline data should be an iomap type, not a flag fs/buffer.c | 8 +- fs/ext2/inode.c | 2 + fs/ext4/inline.c | 4 +- fs/ext4/inode.c | 2 + fs/gfs2/aops.c | 344 +------------------ fs/gfs2/aops.h | 22 ++ fs/gfs2/bmap.c | 772 ++++++++++++++++++++++++++++++++---------- fs/gfs2/bmap.h | 6 +- fs/gfs2/file.c | 174 +++++++++- fs/gfs2/inode.c | 4 - fs/gfs2/log.h | 7 +- fs/gfs2/quota.c | 5 +- fs/gfs2/trans.c | 27 +- fs/iomap.c | 109 +++--- fs/xfs/xfs_iomap.c | 2 + include/linux/iomap.h | 25 +- 16 files changed, 920 insertions(+), 593 deletions(-) create mode 100644 fs/gfs2/aops.h -- 2.17.0
WARNING: multiple messages have this Message-ID (diff)
From: Andreas Gruenbacher <agruenba@redhat.com> To: cluster-devel.redhat.com Subject: [Cluster-devel] [PATCH v5 00/14] gfs2 iomap write support Date: Wed, 30 May 2018 11:48:28 +0200 [thread overview] Message-ID: <20180530094842.13559-1-agruenba@redhat.com> (raw) Here's an update of my gfs2 iomap write patch queue, with support for buffered writes as well as direct I/O reads and writes through iomap. This update fixes a few bugs in the gfs2 specific parts. The patches are still meant for the upcoming merge window. The first five patches are minor gfs2 specific cleanups and improvements. The actual fun starts with patch "iomap: Add write_{begin,end} iomap operations" which adds callbacks into the filesystem for any per-page processing. Christoph has suggested that at least the stuffed inode (aka. inline data) handline should be moved to the iomap_{begin,end} operations. As the last patch tries to demonstrate, this is a bit tricky, so even though Christoph's approach is slightly cleaner conceptually, it doesn't look like an improvement overall. Patches "iomap: Mark newly allocated buffer heads as new" and "iomap: Complete partial direct I/O writes synchronously" have been added as discussed. A 4.17-rc7 based version of the patches can be found here: https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git/log/?h=iomap-write Thanks, Andreas Andreas Gruenbacher (13): gfs2: Update find_metapath comment gfs2: hole_size improvement gfs2: gfs2_stuffed_write_end cleanup gfs2: Remove ordered write mode handling from gfs2_trans_add_data gfs2: Iomap cleanups and improvements iomap: Add write_{begin,end} iomap operations iomap: Mark newly allocated buffer heads as new gfs2: iomap buffered write support gfs2: gfs2_extent_length cleanup iomap: Complete partial direct I/O writes synchronously gfs2: iomap direct I/O support gfs2: Remove gfs2_write_{begin,end} gfs2: Handle stuffed files in iomap_{begin,end} Christoph Hellwig (1): iomap: inline data should be an iomap type, not a flag fs/buffer.c | 8 +- fs/ext2/inode.c | 2 + fs/ext4/inline.c | 4 +- fs/ext4/inode.c | 2 + fs/gfs2/aops.c | 344 +------------------ fs/gfs2/aops.h | 22 ++ fs/gfs2/bmap.c | 772 ++++++++++++++++++++++++++++++++---------- fs/gfs2/bmap.h | 6 +- fs/gfs2/file.c | 174 +++++++++- fs/gfs2/inode.c | 4 - fs/gfs2/log.h | 7 +- fs/gfs2/quota.c | 5 +- fs/gfs2/trans.c | 27 +- fs/iomap.c | 109 +++--- fs/xfs/xfs_iomap.c | 2 + include/linux/iomap.h | 25 +- 16 files changed, 920 insertions(+), 593 deletions(-) create mode 100644 fs/gfs2/aops.h -- 2.17.0
next reply other threads:[~2018-05-30 9:48 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-30 9:48 Andreas Gruenbacher [this message] 2018-05-30 9:48 ` [Cluster-devel] [PATCH v5 00/14] gfs2 iomap write support Andreas Gruenbacher 2018-05-30 9:48 ` [PATCH v5 01/14] gfs2: Update find_metapath comment Andreas Gruenbacher 2018-05-30 9:48 ` [Cluster-devel] " Andreas Gruenbacher 2018-05-30 9:48 ` [PATCH v5 02/14] gfs2: hole_size improvement Andreas Gruenbacher 2018-05-30 9:48 ` [Cluster-devel] " Andreas Gruenbacher 2018-05-30 9:48 ` [PATCH v5 03/14] gfs2: gfs2_stuffed_write_end cleanup Andreas Gruenbacher 2018-05-30 9:48 ` [Cluster-devel] " Andreas Gruenbacher 2018-05-30 9:48 ` [PATCH v5 04/14] gfs2: Remove ordered write mode handling from gfs2_trans_add_data Andreas Gruenbacher 2018-05-30 9:48 ` [Cluster-devel] " Andreas Gruenbacher 2018-05-30 9:48 ` [PATCH v5 05/14] gfs2: Iomap cleanups and improvements Andreas Gruenbacher 2018-05-30 9:48 ` [Cluster-devel] " Andreas Gruenbacher 2018-05-30 9:48 ` [PATCH v5 06/14] iomap: Add write_{begin,end} iomap operations Andreas Gruenbacher 2018-05-30 9:48 ` [Cluster-devel] [PATCH v5 06/14] iomap: Add write_{begin, end} " Andreas Gruenbacher 2018-05-30 9:48 ` [PATCH v5 07/14] iomap: Mark newly allocated buffer heads as new Andreas Gruenbacher 2018-05-30 9:48 ` [Cluster-devel] " Andreas Gruenbacher 2018-05-30 9:48 ` [PATCH v5 08/14] gfs2: iomap buffered write support Andreas Gruenbacher 2018-05-30 9:48 ` [Cluster-devel] " Andreas Gruenbacher 2018-05-30 9:48 ` [PATCH v5 09/14] gfs2: gfs2_extent_length cleanup Andreas Gruenbacher 2018-05-30 9:48 ` [Cluster-devel] " Andreas Gruenbacher 2018-05-30 9:48 ` [PATCH v5 10/14] iomap: Complete partial direct I/O writes synchronously Andreas Gruenbacher 2018-05-30 9:48 ` [Cluster-devel] " Andreas Gruenbacher 2018-05-30 9:48 ` [PATCH v5 11/14] gfs2: iomap direct I/O support Andreas Gruenbacher 2018-05-30 9:48 ` [Cluster-devel] " Andreas Gruenbacher 2018-05-30 9:48 ` [PATCH v5 12/14] gfs2: Remove gfs2_write_{begin,end} Andreas Gruenbacher 2018-05-30 9:48 ` [Cluster-devel] [PATCH v5 12/14] gfs2: Remove gfs2_write_{begin, end} Andreas Gruenbacher 2018-05-30 9:48 ` [PATCH v5 13/14] iomap: inline data should be an iomap type, not a flag Andreas Gruenbacher 2018-05-30 9:48 ` [Cluster-devel] " Andreas Gruenbacher 2018-05-30 9:48 ` [PATCH v5 14/14] gfs2: Handle stuffed files in iomap_{begin,end} Andreas Gruenbacher 2018-05-30 9:48 ` [Cluster-devel] [PATCH v5 14/14] gfs2: Handle stuffed files in iomap_{begin, end} Andreas Gruenbacher 2018-05-30 9:57 ` [PATCH v5 14/14] gfs2: Handle stuffed files in iomap_{begin,end} Christoph Hellwig 2018-05-30 9:57 ` [Cluster-devel] [PATCH v5 14/14] gfs2: Handle stuffed files in iomap_{begin, end} Christoph Hellwig 2018-05-30 15:48 ` [Cluster-devel] [PATCH v5 00/14] gfs2 iomap write support Bob Peterson 2018-05-30 15:48 ` Bob Peterson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180530094842.13559-1-agruenba@redhat.com \ --to=agruenba@redhat.com \ --cc=cluster-devel@redhat.com \ --cc=hch@lst.de \ --cc=linux-fsdevel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.