[Qemu-devel] [PATCH v1 0/8] Travis stability and a few docker patches

[Qemu-devel] [PATCH v1 0/8] Travis stability and a few docker patches

[Alex Bennée]

Hi,

Again the final patch won't make it into a pull-request but I'm just
keeping it around to keep track of failures. So far my numerous
re-builds have been mainly plain timeouts.

The alternate co-routine builds are sailing the closest to timeout
purgatory which makes me think we should limit the scope of the
testing - I'm not sure how much of the unit tests or qapi tests are
likely to exercise the co-routine code. Is it likely only the
(currently not run) block tests really exercise this area of code?

I've also updated the Travis image to be more recent. I noticed while
doing so that the Travis clang was newer than our hand crafted tools
so I took the opportunity to drop them and just concentrate on
exercising the python stuff. It might be worth just limiting the
target list for those tests to x86_64 only though?

There are also a couple of Philippe's patches which I should have
queued ages ago. If we get some quick reviews I can turn around a pull
request by the end of the week.

Alex Bennée (6):
  .travis.yml: disable linux-user build for gcov
  docker: update Travis docker image
  .travis.yml: rationalise clang testing
  .travis.yml: make current setup explicit
  .travis.yml: update GCC sanitizer build to GCC 7
  tests/Makefile: mark flakey tests (!UPSTREAM)

Philippe Mathieu-Daudé (2):
  docker: sort images list displayed by 'make docker'
  docker: do not display deprecated images in 'make docker' help

 .travis.yml                            | 82 +++++---------------------
 tests/Makefile.include                 |  4 ++
 tests/docker/Makefile.include          |  5 +-
 tests/docker/dockerfiles/travis.docker |  7 ++-
 4 files changed, 28 insertions(+), 70 deletions(-)

-- 
2.17.0

[Qemu-devel] [PATCH v1 1/8] .travis.yml: disable linux-user build for gcov

[Alex Bennée]

Currently the default testing doesn't exercise the linux-user builds
so there is no point spending time building them. We may want to
enable a separate gcov build once linux-user testing is re-enabled
although it's likely to report very low coverage.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 .travis.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.travis.yml b/.travis.yml
index c1e99237b2..aa83e9aed7 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -74,7 +74,7 @@ matrix:
     - env: CONFIG=""
       compiler: clang
     # gprof/gcov are GCC features
-    - env: CONFIG="--enable-gprof --enable-gcov --disable-pie"
+    - env: CONFIG="--enable-gprof --enable-gcov --disable-pie --disable-linux-user"
       compiler: gcc
     # We manually include builds which we disable "make check" for
     - env: CONFIG="--enable-debug --enable-tcg-interpreter"
-- 
2.17.0

[Qemu-devel] [PATCH v1 2/8] docker: sort images list displayed by 'make docker'

[Alex Bennée]

From: Philippe Mathieu-Daudé <f4bug@amsat.org>

we can now directly see different version sort consecutively.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 tests/docker/Makefile.include | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
index ef1a3e62eb..50cd51a54e 100644
--- a/tests/docker/Makefile.include
+++ b/tests/docker/Makefile.include
@@ -4,7 +4,7 @@
 
 DOCKER_SUFFIX := .docker
 DOCKER_FILES_DIR := $(SRC_PATH)/tests/docker/dockerfiles
-DOCKER_IMAGES := $(notdir $(basename $(wildcard $(DOCKER_FILES_DIR)/*.docker)))
+DOCKER_IMAGES := $(sort $(notdir $(basename $(wildcard $(DOCKER_FILES_DIR)/*.docker))))
 DOCKER_TARGETS := $(patsubst %,docker-image-%,$(DOCKER_IMAGES))
 # Use a global constant ccache directory to speed up repetitive builds
 DOCKER_CCACHE_DIR := $$HOME/.cache/qemu-docker-ccache
-- 
2.17.0

[Qemu-devel] [PATCH v1 3/8] docker: do not display deprecated images in 'make docker' help

[Alex Bennée]

From: Philippe Mathieu-Daudé <f4bug@amsat.org>

the 'debian' base image is deprecated since 3e11974988d8

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 tests/docker/Makefile.include | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
index 50cd51a54e..31f21a43f5 100644
--- a/tests/docker/Makefile.include
+++ b/tests/docker/Makefile.include
@@ -4,7 +4,8 @@
 
 DOCKER_SUFFIX := .docker
 DOCKER_FILES_DIR := $(SRC_PATH)/tests/docker/dockerfiles
-DOCKER_IMAGES := $(sort $(notdir $(basename $(wildcard $(DOCKER_FILES_DIR)/*.docker))))
+DOCKER_DEPRECATED_IMAGES := debian
+DOCKER_IMAGES := $(filter-out $(DOCKER_DEPRECATED_IMAGES),$(sort $(notdir $(basename $(wildcard $(DOCKER_FILES_DIR)/*.docker)))))
 DOCKER_TARGETS := $(patsubst %,docker-image-%,$(DOCKER_IMAGES))
 # Use a global constant ccache directory to speed up repetitive builds
 DOCKER_CCACHE_DIR := $$HOME/.cache/qemu-docker-ccache
@@ -63,7 +64,7 @@ docker-image-debian-win64-cross: docker-image-debian8-mxe
 docker-image-travis: NOUSER=1
 
 # Expand all the pre-requistes for each docker image and test combination
-$(foreach i,$(DOCKER_IMAGES), \
+$(foreach i,$(DOCKER_IMAGES) $(DOCKER_DEPRECATED_IMAGES), \
 	$(foreach t,$(DOCKER_TESTS) $(DOCKER_TOOLS), \
 		$(eval .PHONY: docker-$t@$i) \
 		$(eval docker-$t@$i: docker-image-$i docker-run-$t@$i) \
-- 
2.17.0

[Qemu-devel] [PATCH v1 4/8] docker: update Travis docker image

[Alex Bennée]

This is still poorly documented by Travis but according to:

  https://docs.travis-ci.com/user/common-build-problems/#Running-a-Container-Based-Docker-Image-Locally

their reference images are now hosted on Docker Hub. So we update the
FROM line to refer to the new default image. We also need a few
additional tweaks:

  - re-enable deb-src lines for our build-dep install
  - add explicit PATH definition for tools
  - force the build USER to be Travis
  - add clang to FEATURES for our test-clang machinery

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 tests/docker/dockerfiles/travis.docker | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/tests/docker/dockerfiles/travis.docker b/tests/docker/dockerfiles/travis.docker
index 605b6e429b..6e90f033d5 100644
--- a/tests/docker/dockerfiles/travis.docker
+++ b/tests/docker/dockerfiles/travis.docker
@@ -1,8 +1,11 @@
-FROM quay.io/travisci/travis-ruby
+FROM travisci/ci-garnet:packer-1512502276-986baf0
 ENV DEBIAN_FRONTEND noninteractive
 ENV LANG en_US.UTF-8
 ENV LC_ALL en_US.UTF-8
+RUN cat /etc/apt/sources.list | sed "s/# deb-src/deb-src/" >> /etc/apt/sources.list
 RUN apt-get update
 RUN apt-get -y build-dep qemu
 RUN apt-get -y install device-tree-compiler python2.7 python-yaml dh-autoreconf gdb strace lsof net-tools
-ENV FEATURES pyyaml
+ENV PATH /usr/local/phantomjs/bin:/usr/local/phantomjs:/usr/local/neo4j-3.2.7/bin:/usr/local/maven-3.5.2/bin:/usr/local/cmake-3.9.2/bin:/usr/local/clang-5.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
+ENV FEATURES clang pyyaml
+USER travis
-- 
2.17.0

[Qemu-devel] [PATCH v1 5/8] .travis.yml: rationalise clang testing

[Alex Bennée]

As Travis includes Clang 5.0 in its own build environment there is no
point manually building with older Clangs. We still need to test with
the two pythons though so we leave them as system only builds. We also
split the clang build into two as it often exceeds the 40 minute build
time limit.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 .travis.yml | 67 +++++------------------------------------------------
 1 file changed, 6 insertions(+), 61 deletions(-)

diff --git a/.travis.yml b/.travis.yml
index aa83e9aed7..85ee2a1edb 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -70,8 +70,10 @@ script:
   - make ${MAKEFLAGS} && ${TEST_CMD}
 matrix:
   include:
-    # Test with CLang for compile portability
-    - env: CONFIG=""
+    # Test with Clang for compile portability (Travis uses clang-5.0)
+    - env: CONFIG="--disable-system"
+      compiler: clang
+    - env: CONFIG="--disable-user"
       compiler: clang
     # gprof/gcov are GCC features
     - env: CONFIG="--enable-gprof --enable-gcov --disable-pie --disable-linux-user"
@@ -95,70 +97,13 @@ matrix:
     - env: CONFIG=""
       os: osx
       compiler: clang
-    # Plain Trusty System Build
+    # Python builds
     - env: CONFIG="--disable-linux-user"
-      sudo: required
-      addons:
-      dist: trusty
-      compiler: gcc
-      before_install:
-        - sudo apt-get update -qq
-        - sudo apt-get build-dep -qq qemu
-        - wget -O - http://people.linaro.org/~alex.bennee/qemu-submodule-git-seed.tar.xz | tar -xvJ
-        - git submodule update --init --recursive
-    # Plain Trusty Linux User Build
-    - env: CONFIG="--disable-system"
-      sudo: required
-      addons:
-      dist: trusty
-      compiler: gcc
-      before_install:
-        - sudo apt-get update -qq
-        - sudo apt-get build-dep -qq qemu
-        - wget -O - http://people.linaro.org/~alex.bennee/qemu-submodule-git-seed.tar.xz | tar -xvJ
-        - git submodule update --init --recursive
-    # Trusty System build with latest stable clang & python 3.0
-    - sudo: required
-      addons:
-      dist: trusty
-      language: generic
-      compiler: none
       python:
         - "3.0"
-      env:
-        - COMPILER_NAME=clang CXX=clang++-3.9 CC=clang-3.9
-        - CONFIG="--disable-linux-user --cc=clang-3.9 --cxx=clang++-3.9 --python=/usr/bin/python3"
-      before_install:
-        - wget -nv -O - http://llvm.org/apt/llvm-snapshot.gpg.key | sudo apt-key add -
-        - sudo apt-add-repository -y 'deb http://llvm.org/apt/trusty llvm-toolchain-trusty-3.9 main'
-        - sudo apt-get update -qq
-        - sudo apt-get install -qq -y clang-3.9
-        - sudo apt-get build-dep -qq qemu
-        - wget -O - http://people.linaro.org/~alex.bennee/qemu-submodule-git-seed.tar.xz | tar -xvJ
-        - git submodule update --init --recursive
-      before_script:
-        - ./configure ${CONFIG} || cat config.log
-    # Trusty Linux User build with latest stable clang & python 3.6
-    - sudo: required
-      addons:
-      dist: trusty
-      language: generic
-      compiler: none
+    - env: CONFIG="--disable-linux-user"
       python:
         - "3.6"
-      env:
-        - COMPILER_NAME=clang CXX=clang++-3.9 CC=clang-3.9
-        - CONFIG="--disable-system --cc=clang-3.9 --cxx=clang++-3.9 --python=/usr/bin/python3"
-      before_install:
-        - wget -nv -O - http://llvm.org/apt/llvm-snapshot.gpg.key | sudo apt-key add -
-        - sudo apt-add-repository -y 'deb http://llvm.org/apt/trusty llvm-toolchain-trusty-3.9 main'
-        - sudo apt-get update -qq
-        - sudo apt-get install -qq -y clang-3.9
-        - sudo apt-get build-dep -qq qemu
-        - wget -O - http://people.linaro.org/~alex.bennee/qemu-submodule-git-seed.tar.xz | tar -xvJ
-        - git submodule update --init --recursive
-      before_script:
-        - ./configure ${CONFIG} || cat config.log
     # Using newer GCC with sanitizers
     - addons:
         apt:
-- 
2.17.0

[Qemu-devel] [PATCH v1 6/8] .travis.yml: make current setup explicit

[Alex Bennée]

Add some commentary and make the selection of Container based Trusty
build explicit. We will need to add VM builds later when using docker.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 .travis.yml | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/.travis.yml b/.travis.yml
index 85ee2a1edb..e99af6f357 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,4 +1,8 @@
+# The current Travis default is a container based 14.04 Trust on EC2
+# Additional builds with specific requirements for a full VM need to
+# be added as additional matrix: entries later on
 sudo: false
+dist: trusty
 language: c
 python:
   - "2.6"
-- 
2.17.0

[Qemu-devel] [PATCH v1 7/8] .travis.yml: update GCC sanitizer build to GCC 7

[Alex Bennée]

GCC has moved on and so should we. We also enable apt update to ensure
we get the latest build from the toolchain PPA.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 .travis.yml | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/.travis.yml b/.travis.yml
index e99af6f357..ecc4367036 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -111,13 +111,14 @@ matrix:
     # Using newer GCC with sanitizers
     - addons:
         apt:
+          update: true
           sources:
             # PPAs for newer toolchains
             - ubuntu-toolchain-r-test
           packages:
             # Extra toolchains
-            - gcc-5
-            - g++-5
+            - gcc-7
+            - g++-7
             # Build dependencies
             - libaio-dev
             - libattr1-dev
@@ -146,8 +147,8 @@ matrix:
       language: generic
       compiler: none
       env:
-        - COMPILER_NAME=gcc CXX=g++-5 CC=gcc-5
-        - CONFIG="--cc=gcc-5 --cxx=g++-5 --disable-pie --disable-linux-user"
+        - COMPILER_NAME=gcc CXX=g++-7 CC=gcc-7
+        - CONFIG="--cc=gcc-7 --cxx=g++-7 --disable-pie --disable-linux-user"
         - TEST_CMD=""
       before_script:
         - ./configure ${CONFIG} --extra-cflags="-g3 -O0 -fsanitize=thread -fuse-ld=gold" || cat config.log
-- 
2.17.0

[Qemu-devel] [PATCH v1 8/8] tests/Makefile: mark flakey tests (!UPSTREAM)

[Alex Bennée]

This is a bookmarking commit to keep track of the failures I'm
currently seeing in Travis. They are currently:

1. test-aio

GTESTER tests/test-thread-pool
**
ERROR:tests/test-aio.c:501:test_timer_schedule: assertion failed: (aio_poll(ctx, true))
GTester: last random seed: R02S66126aca97f9606b33e5d7be7fc9b625
make: *** [check-tests/test-aio] Error 1
make: *** Waiting for unfinished jobs....

Last discussion @ 20180525091724.GC14757@stefanha-x1.localdomain

  - rcutorture

[AWAITING EXAMPLE]

I suspect it is load that causes the problems but they really need to
be fixed properly.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 tests/Makefile.include | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tests/Makefile.include b/tests/Makefile.include
index b499ba1813..8ff4ab9e27 100644
--- a/tests/Makefile.include
+++ b/tests/Makefile.include
@@ -76,7 +76,9 @@ gcov-files-test-coroutine-y = coroutine-$(CONFIG_COROUTINE_BACKEND).c
 check-unit-y += tests/test-visitor-serialization$(EXESUF)
 check-unit-y += tests/test-iov$(EXESUF)
 gcov-files-test-iov-y = util/iov.c
+# start: flakey
 check-unit-y += tests/test-aio$(EXESUF)
+# end: flakey
 gcov-files-test-aio-y = util/async.c util/qemu-timer.o
 gcov-files-test-aio-$(CONFIG_WIN32) += util/aio-win32.c
 gcov-files-test-aio-$(CONFIG_POSIX) += util/aio-posix.c
@@ -110,7 +112,9 @@ gcov-files-test-mul64-y = util/host-utils.c
 check-unit-y += tests/test-int128$(EXESUF)
 # all code tested by test-int128 is inside int128.h
 gcov-files-test-int128-y =
+# start: flakey
 check-unit-y += tests/rcutorture$(EXESUF)
+# end: flakey
 gcov-files-rcutorture-y = util/rcu.c
 check-unit-y += tests/test-rcu-list$(EXESUF)
 gcov-files-test-rcu-list-y = util/rcu.c
-- 
2.17.0

Re: [Qemu-devel] [PATCH v1 5/8] .travis.yml: rationalise clang testing

[Philippe Mathieu-Daudé]

On 05/30/2018 08:06 AM, Alex Bennée wrote:
> As Travis includes Clang 5.0 in its own build environment there is no
> point manually building with older Clangs. We still need to test with
> the two pythons though so we leave them as system only builds. We also
> split the clang build into two as it often exceeds the 40 minute build
> time limit.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

Nice cut.

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> ---
>  .travis.yml | 67 +++++------------------------------------------------
>  1 file changed, 6 insertions(+), 61 deletions(-)
> 
> diff --git a/.travis.yml b/.travis.yml
> index aa83e9aed7..85ee2a1edb 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -70,8 +70,10 @@ script:
>    - make ${MAKEFLAGS} && ${TEST_CMD}
>  matrix:
>    include:
> -    # Test with CLang for compile portability
> -    - env: CONFIG=""
> +    # Test with Clang for compile portability (Travis uses clang-5.0)
> +    - env: CONFIG="--disable-system"
> +      compiler: clang
> +    - env: CONFIG="--disable-user"
>        compiler: clang
>      # gprof/gcov are GCC features
>      - env: CONFIG="--enable-gprof --enable-gcov --disable-pie --disable-linux-user"
> @@ -95,70 +97,13 @@ matrix:
>      - env: CONFIG=""
>        os: osx
>        compiler: clang
> -    # Plain Trusty System Build
> +    # Python builds
>      - env: CONFIG="--disable-linux-user"
> -      sudo: required
> -      addons:
> -      dist: trusty
> -      compiler: gcc
> -      before_install:
> -        - sudo apt-get update -qq
> -        - sudo apt-get build-dep -qq qemu
> -        - wget -O - http://people.linaro.org/~alex.bennee/qemu-submodule-git-seed.tar.xz | tar -xvJ
> -        - git submodule update --init --recursive
> -    # Plain Trusty Linux User Build
> -    - env: CONFIG="--disable-system"
> -      sudo: required
> -      addons:
> -      dist: trusty
> -      compiler: gcc
> -      before_install:
> -        - sudo apt-get update -qq
> -        - sudo apt-get build-dep -qq qemu
> -        - wget -O - http://people.linaro.org/~alex.bennee/qemu-submodule-git-seed.tar.xz | tar -xvJ
> -        - git submodule update --init --recursive
> -    # Trusty System build with latest stable clang & python 3.0
> -    - sudo: required
> -      addons:
> -      dist: trusty
> -      language: generic
> -      compiler: none
>        python:
>          - "3.0"
> -      env:
> -        - COMPILER_NAME=clang CXX=clang++-3.9 CC=clang-3.9
> -        - CONFIG="--disable-linux-user --cc=clang-3.9 --cxx=clang++-3.9 --python=/usr/bin/python3"
> -      before_install:
> -        - wget -nv -O - http://llvm.org/apt/llvm-snapshot.gpg.key | sudo apt-key add -
> -        - sudo apt-add-repository -y 'deb http://llvm.org/apt/trusty llvm-toolchain-trusty-3.9 main'
> -        - sudo apt-get update -qq
> -        - sudo apt-get install -qq -y clang-3.9
> -        - sudo apt-get build-dep -qq qemu
> -        - wget -O - http://people.linaro.org/~alex.bennee/qemu-submodule-git-seed.tar.xz | tar -xvJ
> -        - git submodule update --init --recursive
> -      before_script:
> -        - ./configure ${CONFIG} || cat config.log
> -    # Trusty Linux User build with latest stable clang & python 3.6
> -    - sudo: required
> -      addons:
> -      dist: trusty
> -      language: generic
> -      compiler: none
> +    - env: CONFIG="--disable-linux-user"
>        python:
>          - "3.6"
> -      env:
> -        - COMPILER_NAME=clang CXX=clang++-3.9 CC=clang-3.9
> -        - CONFIG="--disable-system --cc=clang-3.9 --cxx=clang++-3.9 --python=/usr/bin/python3"
> -      before_install:
> -        - wget -nv -O - http://llvm.org/apt/llvm-snapshot.gpg.key | sudo apt-key add -
> -        - sudo apt-add-repository -y 'deb http://llvm.org/apt/trusty llvm-toolchain-trusty-3.9 main'
> -        - sudo apt-get update -qq
> -        - sudo apt-get install -qq -y clang-3.9
> -        - sudo apt-get build-dep -qq qemu
> -        - wget -O - http://people.linaro.org/~alex.bennee/qemu-submodule-git-seed.tar.xz | tar -xvJ
> -        - git submodule update --init --recursive
> -      before_script:
> -        - ./configure ${CONFIG} || cat config.log
>      # Using newer GCC with sanitizers
>      - addons:
>          apt:
> 

Re: [Qemu-devel] [PATCH v1 7/8] .travis.yml: update GCC sanitizer build to GCC 7

[Philippe Mathieu-Daudé]

On 05/30/2018 08:06 AM, Alex Bennée wrote:
> GCC has moved on and so should we. We also enable apt update to ensure
> we get the latest build from the toolchain PPA.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> ---
>  .travis.yml | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/.travis.yml b/.travis.yml
> index e99af6f357..ecc4367036 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -111,13 +111,14 @@ matrix:
>      # Using newer GCC with sanitizers
>      - addons:
>          apt:
> +          update: true
>            sources:
>              # PPAs for newer toolchains
>              - ubuntu-toolchain-r-test
>            packages:
>              # Extra toolchains
> -            - gcc-5
> -            - g++-5
> +            - gcc-7
> +            - g++-7
>              # Build dependencies
>              - libaio-dev
>              - libattr1-dev
> @@ -146,8 +147,8 @@ matrix:
>        language: generic
>        compiler: none
>        env:
> -        - COMPILER_NAME=gcc CXX=g++-5 CC=gcc-5
> -        - CONFIG="--cc=gcc-5 --cxx=g++-5 --disable-pie --disable-linux-user"
> +        - COMPILER_NAME=gcc CXX=g++-7 CC=gcc-7
> +        - CONFIG="--cc=gcc-7 --cxx=g++-7 --disable-pie --disable-linux-user"
>          - TEST_CMD=""
>        before_script:
>          - ./configure ${CONFIG} --extra-cflags="-g3 -O0 -fsanitize=thread -fuse-ld=gold" || cat config.log
> 

Re: [Qemu-devel] [PATCH v1 6/8] .travis.yml: make current setup explicit

[Philippe Mathieu-Daudé]

On 05/30/2018 08:06 AM, Alex Bennée wrote:
> Add some commentary and make the selection of Container based Trusty
> build explicit. We will need to add VM builds later when using docker.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> ---
>  .travis.yml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/.travis.yml b/.travis.yml
> index 85ee2a1edb..e99af6f357 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -1,4 +1,8 @@
> +# The current Travis default is a container based 14.04 Trust on EC2
> +# Additional builds with specific requirements for a full VM need to
> +# be added as additional matrix: entries later on
>  sudo: false
> +dist: trusty
>  language: c
>  python:
>    - "2.6"
> 

Re: [Qemu-devel] [PATCH v1 1/8] .travis.yml: disable linux-user build for gcov

[Philippe Mathieu-Daudé]

On 05/30/2018 08:06 AM, Alex Bennée wrote:
> Currently the default testing doesn't exercise the linux-user builds
> so there is no point spending time building them. We may want to
> enable a separate gcov build once linux-user testing is re-enabled
> although it's likely to report very low coverage.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

Finally.

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> ---
>  .travis.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/.travis.yml b/.travis.yml
> index c1e99237b2..aa83e9aed7 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -74,7 +74,7 @@ matrix:
>      - env: CONFIG=""
>        compiler: clang
>      # gprof/gcov are GCC features
> -    - env: CONFIG="--enable-gprof --enable-gcov --disable-pie"
> +    - env: CONFIG="--enable-gprof --enable-gcov --disable-pie --disable-linux-user"
>        compiler: gcc
>      # We manually include builds which we disable "make check" for
>      - env: CONFIG="--enable-debug --enable-tcg-interpreter"
> 

Re: [Qemu-devel] [PATCH v1 4/8] docker: update Travis docker image

[Philippe Mathieu-Daudé]

Hi Alex,

On 05/30/2018 08:06 AM, Alex Bennée wrote:
> This is still poorly documented by Travis but according to:
> 
>   https://docs.travis-ci.com/user/common-build-problems/#Running-a-Container-Based-Docker-Image-Locally
> 
> their reference images are now hosted on Docker Hub. So we update the
> FROM line to refer to the new default image. We also need a few
> additional tweaks:
> 
>   - re-enable deb-src lines for our build-dep install
>   - add explicit PATH definition for tools

I don't understand how this is related to QEMU testing, isn't it rather
some Travis-ci bug? We don't need to use PhantomJS / Neo4j / Maven.

>   - force the build USER to be Travis
>   - add clang to FEATURES for our test-clang machinery
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>  tests/docker/dockerfiles/travis.docker | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/docker/dockerfiles/travis.docker b/tests/docker/dockerfiles/travis.docker
> index 605b6e429b..6e90f033d5 100644
> --- a/tests/docker/dockerfiles/travis.docker
> +++ b/tests/docker/dockerfiles/travis.docker
> @@ -1,8 +1,11 @@
> -FROM quay.io/travisci/travis-ruby
> +FROM travisci/ci-garnet:packer-1512502276-986baf0
>  ENV DEBIAN_FRONTEND noninteractive
>  ENV LANG en_US.UTF-8
>  ENV LC_ALL en_US.UTF-8
> +RUN cat /etc/apt/sources.list | sed "s/# deb-src/deb-src/" >> /etc/apt/sources.list
>  RUN apt-get update
>  RUN apt-get -y build-dep qemu
>  RUN apt-get -y install device-tree-compiler python2.7 python-yaml dh-autoreconf gdb strace lsof net-tools
> -ENV FEATURES pyyaml
> +ENV PATH /usr/local/phantomjs/bin:/usr/local/phantomjs:/usr/local/neo4j-3.2.7/bin:/usr/local/maven-3.5.2/bin:/usr/local/cmake-3.9.2/bin:/usr/local/clang-5.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
> +ENV FEATURES clang pyyaml
> +USER travis
> 

Re: [Qemu-devel] [PATCH v1 4/8] docker: update Travis docker image

[Alex Bennée]

Philippe Mathieu-Daudé <f4bug@amsat.org> writes:

> Hi Alex,
>
> On 05/30/2018 08:06 AM, Alex Bennée wrote:
>> This is still poorly documented by Travis but according to:
>>
>>   https://docs.travis-ci.com/user/common-build-problems/#Running-a-Container-Based-Docker-Image-Locally
>>
>> their reference images are now hosted on Docker Hub. So we update the
>> FROM line to refer to the new default image. We also need a few
>> additional tweaks:
>>
>>   - re-enable deb-src lines for our build-dep install
>>   - add explicit PATH definition for tools
>
> I don't understand how this is related to QEMU testing, isn't it rather
> some Travis-ci bug? We don't need to use PhantomJS / Neo4j / Maven.

It's oddly constructed I'll grant you but I just set the path to what a
running image has. The normal image is started up with a full systemd
init whereas we drop directly into the shell.

>
>>   - force the build USER to be Travis
>>   - add clang to FEATURES for our test-clang machinery
>>
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> ---
>>  tests/docker/dockerfiles/travis.docker | 7 +++++--
>>  1 file changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/tests/docker/dockerfiles/travis.docker b/tests/docker/dockerfiles/travis.docker
>> index 605b6e429b..6e90f033d5 100644
>> --- a/tests/docker/dockerfiles/travis.docker
>> +++ b/tests/docker/dockerfiles/travis.docker
>> @@ -1,8 +1,11 @@
>> -FROM quay.io/travisci/travis-ruby
>> +FROM travisci/ci-garnet:packer-1512502276-986baf0
>>  ENV DEBIAN_FRONTEND noninteractive
>>  ENV LANG en_US.UTF-8
>>  ENV LC_ALL en_US.UTF-8
>> +RUN cat /etc/apt/sources.list | sed "s/# deb-src/deb-src/" >> /etc/apt/sources.list
>>  RUN apt-get update
>>  RUN apt-get -y build-dep qemu
>>  RUN apt-get -y install device-tree-compiler python2.7 python-yaml dh-autoreconf gdb strace lsof net-tools
>> -ENV FEATURES pyyaml
>> +ENV PATH /usr/local/phantomjs/bin:/usr/local/phantomjs:/usr/local/neo4j-3.2.7/bin:/usr/local/maven-3.5.2/bin:/usr/local/cmake-3.9.2/bin:/usr/local/clang-5.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
>> +ENV FEATURES clang pyyaml
>> +USER travis
>>


--
Alex Bennée

Re: [Qemu-devel] [PATCH v1 4/8] docker: update Travis docker image

[Philippe Mathieu-Daudé]

On 05/31/2018 05:14 PM, Alex Bennée wrote:
> 
> Philippe Mathieu-Daudé <f4bug@amsat.org> writes:
> 
>> Hi Alex,
>>
>> On 05/30/2018 08:06 AM, Alex Bennée wrote:
>>> This is still poorly documented by Travis but according to:
>>>
>>>   https://docs.travis-ci.com/user/common-build-problems/#Running-a-Container-Based-Docker-Image-Locally
>>>
>>> their reference images are now hosted on Docker Hub. So we update the
>>> FROM line to refer to the new default image. We also need a few
>>> additional tweaks:
>>>
>>>   - re-enable deb-src lines for our build-dep install
>>>   - add explicit PATH definition for tools
>>
>> I don't understand how this is related to QEMU testing, isn't it rather
>> some Travis-ci bug? We don't need to use PhantomJS / Neo4j / Maven.
> 
> It's oddly constructed I'll grant you but I just set the path to what a
> running image has. The normal image is started up with a full systemd
> init whereas we drop directly into the shell.

OK, can you add a comment about it? (so we don't remove what seems
unrelated).

> 
>>
>>>   - force the build USER to be Travis
>>>   - add clang to FEATURES for our test-clang machinery
>>>
>>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>>> ---
>>>  tests/docker/dockerfiles/travis.docker | 7 +++++--
>>>  1 file changed, 5 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/tests/docker/dockerfiles/travis.docker b/tests/docker/dockerfiles/travis.docker
>>> index 605b6e429b..6e90f033d5 100644
>>> --- a/tests/docker/dockerfiles/travis.docker
>>> +++ b/tests/docker/dockerfiles/travis.docker
>>> @@ -1,8 +1,11 @@
>>> -FROM quay.io/travisci/travis-ruby
>>> +FROM travisci/ci-garnet:packer-1512502276-986baf0
>>>  ENV DEBIAN_FRONTEND noninteractive
>>>  ENV LANG en_US.UTF-8
>>>  ENV LC_ALL en_US.UTF-8
>>> +RUN cat /etc/apt/sources.list | sed "s/# deb-src/deb-src/" >> /etc/apt/sources.list
>>>  RUN apt-get update
>>>  RUN apt-get -y build-dep qemu
>>>  RUN apt-get -y install device-tree-compiler python2.7 python-yaml dh-autoreconf gdb strace lsof net-tools
>>> -ENV FEATURES pyyaml

# Travis tools require PhantomJS / Neo4j / Maven accessible
# in their PATH (QEMU build won't access them).

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

>>> +ENV PATH /usr/local/phantomjs/bin:/usr/local/phantomjs:/usr/local/neo4j-3.2.7/bin:/usr/local/maven-3.5.2/bin:/usr/local/cmake-3.9.2/bin:/usr/local/clang-5.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
>>> +ENV FEATURES clang pyyaml
>>> +USER travis
>>>
> 
> 
> --
> Alex Bennée
>