From: "Michael S. Tsirkin" <mst@redhat.com> To: "Rustad, Mark D" <mark.d.rustad@intel.com> Cc: "Bie, Tiwei" <tiwei.bie@intel.com>, Bjorn Helgaas <bhelgaas@google.com>, "virtualization@lists.linux-foundation.org" <virtualization@lists.linux-foundation.org>, LKML <linux-kernel@vger.kernel.org>, "virtio-dev@lists.oasis-open.org" <virtio-dev@lists.oasis-open.org>, "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>, "Daly, Dan" <dan.daly@intel.com>, "Duyck, Alexander H" <alexander.h.duyck@intel.com>, "Liang, Cunming" <cunming.liang@intel.com>, "Wang, Zhihong" <zhihong.wang@intel.com> Subject: Re: [virtio-dev] [PATCH] virtio_pci: support enabling VFs Date: Wed, 30 May 2018 19:09:37 +0300 [thread overview] Message-ID: <20180530190819-mutt-send-email-mst@kernel.org> (raw) In-Reply-To: <D7004E41-C23D-48B7-94A4-ACBBA06B021D@intel.com> On Wed, May 30, 2018 at 04:03:37PM +0000, Rustad, Mark D wrote: > On May 30, 2018, at 1:55 AM, Tiwei Bie <tiwei.bie@intel.com> wrote: > > > There is a new feature bit allocated in virtio spec to > > support SR-IOV (Single Root I/O Virtualization): > > > > https://github.com/oasis-tcs/virtio-spec/issues/11 > > > > This patch enables the support for this feature bit in > > virtio driver. > > > > Signed-off-by: Tiwei Bie <tiwei.bie@intel.com> > > --- > > This patch depends on below proposal: > > https://lists.oasis-open.org/archives/virtio-dev/201805/msg00154.html > > > > This patch depends on below patch: > > https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git/commit/?h=pci/virtualization&id=8effc395c2097e258fcedfc02ed4a66d45fb4238 > > > > drivers/virtio/virtio_pci_common.c | 20 ++++++++++++++++++++ > > drivers/virtio/virtio_pci_modern.c | 14 ++++++++++++++ > > include/uapi/linux/virtio_config.h | 7 ++++++- > > 3 files changed, 40 insertions(+), 1 deletion(-) > > > > <snip> > > > diff --git a/include/uapi/linux/virtio_config.h > > b/include/uapi/linux/virtio_config.h > > index 308e2096291f..b7c1f4e7d59e 100644 > > --- a/include/uapi/linux/virtio_config.h > > +++ b/include/uapi/linux/virtio_config.h > > @@ -49,7 +49,7 @@ > > There is a value in the comment directly before this that should > be updated as well to be consistent with the new value for > VIRTIO_TRANSPORT_F_END below. It hasn't been updated to 34 yet. I suggest a separate patch to replace the numbers with VIRTIO_TRANSPORT_F_START and VIRTIO_TRANSPORT_F_END in the comment. Maybe replace "e.g. virtio_ring" with "e.g. virtio_ring, virtio_pci etc." as well. > > * transport being used (eg. virtio_ring), the rest are per-device feature > > * bits. */ > > #define VIRTIO_TRANSPORT_F_START 28 > > -#define VIRTIO_TRANSPORT_F_END 34 > > +#define VIRTIO_TRANSPORT_F_END 38 > > > > #ifndef VIRTIO_CONFIG_NO_LEGACY > > /* Do we get callbacks when the ring is completely used, even if we've > > <snip> > > -- > Mark Rustad, Networking Division, Intel Corporation
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com> To: "Rustad, Mark D" <mark.d.rustad@intel.com> Cc: "Bie, Tiwei" <tiwei.bie@intel.com>, Bjorn Helgaas <bhelgaas@google.com>, "virtualization@lists.linux-foundation.org" <virtualization@lists.linux-foundation.org>, LKML <linux-kernel@vger.kernel.org>, "virtio-dev@lists.oasis-open.org" <virtio-dev@lists.oasis-open.org>, "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>, "Daly, Dan" <dan.daly@intel.com>, "Duyck, Alexander H" <alexander.h.duyck@intel.com>, "Liang, Cunming" <cunming.liang@intel.com>, "Wang, Zhihong" <zhihong.wang@intel.com> Subject: Re: [virtio-dev] [PATCH] virtio_pci: support enabling VFs Date: Wed, 30 May 2018 19:09:37 +0300 [thread overview] Message-ID: <20180530190819-mutt-send-email-mst@kernel.org> (raw) In-Reply-To: <D7004E41-C23D-48B7-94A4-ACBBA06B021D@intel.com> On Wed, May 30, 2018 at 04:03:37PM +0000, Rustad, Mark D wrote: > On May 30, 2018, at 1:55 AM, Tiwei Bie <tiwei.bie@intel.com> wrote: > > > There is a new feature bit allocated in virtio spec to > > support SR-IOV (Single Root I/O Virtualization): > > > > https://github.com/oasis-tcs/virtio-spec/issues/11 > > > > This patch enables the support for this feature bit in > > virtio driver. > > > > Signed-off-by: Tiwei Bie <tiwei.bie@intel.com> > > --- > > This patch depends on below proposal: > > https://lists.oasis-open.org/archives/virtio-dev/201805/msg00154.html > > > > This patch depends on below patch: > > https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git/commit/?h=pci/virtualization&id=8effc395c2097e258fcedfc02ed4a66d45fb4238 > > > > drivers/virtio/virtio_pci_common.c | 20 ++++++++++++++++++++ > > drivers/virtio/virtio_pci_modern.c | 14 ++++++++++++++ > > include/uapi/linux/virtio_config.h | 7 ++++++- > > 3 files changed, 40 insertions(+), 1 deletion(-) > > > > <snip> > > > diff --git a/include/uapi/linux/virtio_config.h > > b/include/uapi/linux/virtio_config.h > > index 308e2096291f..b7c1f4e7d59e 100644 > > --- a/include/uapi/linux/virtio_config.h > > +++ b/include/uapi/linux/virtio_config.h > > @@ -49,7 +49,7 @@ > > There is a value in the comment directly before this that should > be updated as well to be consistent with the new value for > VIRTIO_TRANSPORT_F_END below. It hasn't been updated to 34 yet. I suggest a separate patch to replace the numbers with VIRTIO_TRANSPORT_F_START and VIRTIO_TRANSPORT_F_END in the comment. Maybe replace "e.g. virtio_ring" with "e.g. virtio_ring, virtio_pci etc." as well. > > * transport being used (eg. virtio_ring), the rest are per-device feature > > * bits. */ > > #define VIRTIO_TRANSPORT_F_START 28 > > -#define VIRTIO_TRANSPORT_F_END 34 > > +#define VIRTIO_TRANSPORT_F_END 38 > > > > #ifndef VIRTIO_CONFIG_NO_LEGACY > > /* Do we get callbacks when the ring is completely used, even if we've > > <snip> > > -- > Mark Rustad, Networking Division, Intel Corporation --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2018-05-30 16:09 UTC|newest] Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-30 8:55 [PATCH] virtio_pci: support enabling VFs Tiwei Bie 2018-05-30 8:55 ` [virtio-dev] " Tiwei Bie 2018-05-30 12:29 ` Stefan Hajnoczi 2018-05-30 12:29 ` Stefan Hajnoczi 2018-05-30 12:41 ` Michael S. Tsirkin 2018-05-30 12:41 ` [virtio-dev] " Michael S. Tsirkin 2018-05-30 12:41 ` Michael S. Tsirkin 2018-05-30 16:03 ` [virtio-dev] " Rustad, Mark D 2018-05-30 16:09 ` Michael S. Tsirkin [this message] 2018-05-30 16:09 ` Michael S. Tsirkin 2018-05-31 2:55 ` Tiwei Bie 2018-05-31 2:55 ` Tiwei Bie 2018-06-01 1:21 ` Michael S. Tsirkin 2018-06-01 1:21 ` Michael S. Tsirkin 2018-06-01 1:21 ` Michael S. Tsirkin 2018-06-01 1:36 ` Tiwei Bie 2018-06-01 1:36 ` Tiwei Bie 2018-06-01 1:36 ` Tiwei Bie 2018-05-31 2:55 ` Tiwei Bie 2018-05-30 16:09 ` Michael S. Tsirkin 2018-05-30 16:03 ` Rustad, Mark D 2018-05-30 16:10 ` Alexander Duyck 2018-05-30 16:10 ` Alexander Duyck 2018-05-30 16:22 ` Michael S. Tsirkin 2018-05-30 16:22 ` Michael S. Tsirkin 2018-05-30 16:22 ` Michael S. Tsirkin 2018-05-30 16:26 ` Duyck, Alexander H 2018-05-30 16:26 ` Duyck, Alexander H 2018-05-30 16:26 ` Duyck, Alexander H 2018-05-30 17:15 ` Michael S. Tsirkin 2018-05-30 17:15 ` Michael S. Tsirkin 2018-05-30 17:15 ` Michael S. Tsirkin 2018-05-30 16:10 ` Alexander Duyck 2018-05-30 16:22 ` Michael S. Tsirkin 2018-05-30 16:22 ` [virtio-dev] " Michael S. Tsirkin 2018-05-30 16:44 ` Rustad, Mark D 2018-05-30 16:44 ` [virtio-dev] " Rustad, Mark D 2018-05-30 16:44 ` Rustad, Mark D 2018-05-30 16:54 ` Duyck, Alexander H 2018-05-30 16:54 ` Duyck, Alexander H 2018-05-30 17:11 ` Rustad, Mark D 2018-05-30 17:11 ` [virtio-dev] " Rustad, Mark D 2018-05-30 17:11 ` Rustad, Mark D 2018-05-31 3:20 ` Tiwei Bie 2018-05-31 3:20 ` [virtio-dev] " Tiwei Bie 2018-05-31 14:27 ` Alexander Duyck 2018-05-31 14:27 ` Alexander Duyck 2018-05-31 14:27 ` [virtio-dev] " Alexander Duyck 2018-06-01 2:30 ` Tiwei Bie 2018-06-01 2:30 ` Tiwei Bie 2018-06-01 2:30 ` [virtio-dev] " Tiwei Bie 2018-05-31 3:20 ` Tiwei Bie 2018-05-30 16:54 ` Duyck, Alexander H 2018-05-30 16:22 ` Michael S. Tsirkin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180530190819-mutt-send-email-mst@kernel.org \ --to=mst@redhat.com \ --cc=alexander.h.duyck@intel.com \ --cc=bhelgaas@google.com \ --cc=cunming.liang@intel.com \ --cc=dan.daly@intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=mark.d.rustad@intel.com \ --cc=tiwei.bie@intel.com \ --cc=virtio-dev@lists.oasis-open.org \ --cc=virtualization@lists.linux-foundation.org \ --cc=zhihong.wang@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.