All of lore.kernel.org
 help / color / mirror / Atom feed
* [LTP] [PATCH v2 ltp] network/stress/ssh/ssh-stress01-rmt: fix shellcheck error
@ 2018-05-31  2:37 Yixin Zhang
  2018-06-06 10:59 ` Alexey Kodanev
  0 siblings, 1 reply; 2+ messages in thread
From: Yixin Zhang @ 2018-05-31  2:37 UTC (permalink / raw)
  To: ltp

testcases/network/stress/ssh/ssh-stress01-rmt:57:16: error: Since you
double quoted this, it will not word split, and the loop will only run
once. [SC2066]

Signed-off-by: Yixin Zhang <yixin.zhang@intel.com>
---
 testcases/network/stress/ssh/ssh-stress01-rmt | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/testcases/network/stress/ssh/ssh-stress01-rmt b/testcases/network/stress/ssh/ssh-stress01-rmt
index 2a84957ca..b2f65793e 100644
--- a/testcases/network/stress/ssh/ssh-stress01-rmt
+++ b/testcases/network/stress/ssh/ssh-stress01-rmt
@@ -53,10 +53,7 @@ done
 # Disconnect all ssh connection
 all_conn=$(ps auxw | grep -Fv grep | \
 	grep "ssh[[:blank:]].*${ssh_config}" | awk '{print $2}')
-
-for ssh_pid in "$all_conn"; do
-	kill $ssh_pid
-done
+kill $all_conn
 
 # Check the connectivity again
 ssh -$ip_ver -F $ssh_config $server_ipaddr \
-- 
2.14.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [LTP] [PATCH v2 ltp] network/stress/ssh/ssh-stress01-rmt: fix shellcheck error
  2018-05-31  2:37 [LTP] [PATCH v2 ltp] network/stress/ssh/ssh-stress01-rmt: fix shellcheck error Yixin Zhang
@ 2018-06-06 10:59 ` Alexey Kodanev
  0 siblings, 0 replies; 2+ messages in thread
From: Alexey Kodanev @ 2018-06-06 10:59 UTC (permalink / raw)
  To: ltp

On 31.05.2018 05:37, Yixin Zhang wrote:
> testcases/network/stress/ssh/ssh-stress01-rmt:57:16: error: Since you
> double quoted this, it will not word split, and the loop will only run
> once. [SC2066]
> 
> Signed-off-by: Yixin Zhang <yixin.zhang@intel.com>
> ---

Applied, thanks!

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-06-06 10:59 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-31  2:37 [LTP] [PATCH v2 ltp] network/stress/ssh/ssh-stress01-rmt: fix shellcheck error Yixin Zhang
2018-06-06 10:59 ` Alexey Kodanev

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.