* [PATCH net-next] net: netcp: ethss: remove unnecessary pointer set to NULL
@ 2018-05-31 3:48 YueHaibing
2018-06-03 14:40 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2018-05-31 3:48 UTC (permalink / raw)
To: davem, w-kwok2, m-karicheri2; +Cc: netdev, linux-kernel, YueHaibing
If statement has make sure the 'slave->phy' is NULL
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/net/ethernet/ti/netcp_ethss.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/ti/netcp_ethss.c b/drivers/net/ethernet/ti/netcp_ethss.c
index 6a728d3..6e455a2 100644
--- a/drivers/net/ethernet/ti/netcp_ethss.c
+++ b/drivers/net/ethernet/ti/netcp_ethss.c
@@ -3206,7 +3206,6 @@ static void init_secondary_ports(struct gbe_priv *gbe_dev,
if (!slave->phy) {
dev_err(dev, "phy not found for slave %d\n",
slave->slave_num);
- slave->phy = NULL;
} else {
dev_dbg(dev, "phy found: id is: 0x%s\n",
phydev_name(slave->phy));
--
2.7.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net: netcp: ethss: remove unnecessary pointer set to NULL
2018-05-31 3:48 [PATCH net-next] net: netcp: ethss: remove unnecessary pointer set to NULL YueHaibing
@ 2018-06-03 14:40 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-06-03 14:40 UTC (permalink / raw)
To: yuehaibing; +Cc: w-kwok2, m-karicheri2, netdev, linux-kernel
From: YueHaibing <yuehaibing@huawei.com>
Date: Thu, 31 May 2018 11:48:48 +0800
> If statement has make sure the 'slave->phy' is NULL
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Looks good, applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-06-03 14:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-31 3:48 [PATCH net-next] net: netcp: ethss: remove unnecessary pointer set to NULL YueHaibing
2018-06-03 14:40 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.