All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ALSA: xen-front: signdness bug in alsa_prepare()
@ 2018-05-31  6:25 ` Dan Carpenter
  0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2018-05-31  6:25 UTC (permalink / raw)
  To: Oleksandr Andrushchenko
  Cc: xen-devel, alsa-devel, kernel-janitors, Takashi Iwai

"sndif_format" needs to be signed for the error handling to work.

Fixes: 1cee559351a7 ("ALSA: xen-front: Implement ALSA virtual sound driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/sound/xen/xen_snd_front_alsa.c b/sound/xen/xen_snd_front_alsa.c
index 5041f83e98d2..43478f66954a 100644
--- a/sound/xen/xen_snd_front_alsa.c
+++ b/sound/xen/xen_snd_front_alsa.c
@@ -463,7 +463,7 @@ static int alsa_prepare(struct snd_pcm_substream *substream)
 
 	if (!stream->is_open) {
 		struct snd_pcm_runtime *runtime = substream->runtime;
-		u8 sndif_format;
+		int sndif_format;
 		int ret;
 
 		sndif_format = to_sndif_format(runtime->format);

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] ALSA: xen-front: signdness bug in alsa_prepare()
@ 2018-05-31  6:25 ` Dan Carpenter
  0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2018-05-31  6:25 UTC (permalink / raw)
  To: Oleksandr Andrushchenko
  Cc: xen-devel, alsa-devel, kernel-janitors, Takashi Iwai

"sndif_format" needs to be signed for the error handling to work.

Fixes: 1cee559351a7 ("ALSA: xen-front: Implement ALSA virtual sound driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/sound/xen/xen_snd_front_alsa.c b/sound/xen/xen_snd_front_alsa.c
index 5041f83e98d2..43478f66954a 100644
--- a/sound/xen/xen_snd_front_alsa.c
+++ b/sound/xen/xen_snd_front_alsa.c
@@ -463,7 +463,7 @@ static int alsa_prepare(struct snd_pcm_substream *substream)
 
 	if (!stream->is_open) {
 		struct snd_pcm_runtime *runtime = substream->runtime;
-		u8 sndif_format;
+		int sndif_format;
 		int ret;
 
 		sndif_format = to_sndif_format(runtime->format);

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] ALSA: xen-front: signdness bug in alsa_prepare()
  2018-05-31  6:25 ` Dan Carpenter
@ 2018-05-31  6:47   ` Oleksandr Andrushchenko
  -1 siblings, 0 replies; 6+ messages in thread
From: Oleksandr Andrushchenko @ 2018-05-31  6:47 UTC (permalink / raw)
  To: Dan Carpenter; +Cc: xen-devel, alsa-devel, kernel-janitors, Takashi Iwai

On 05/31/2018 09:25 AM, Dan Carpenter wrote:
> "sndif_format" needs to be signed for the error handling to work.
>
> Fixes: 1cee559351a7 ("ALSA: xen-front: Implement ALSA virtual sound driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/sound/xen/xen_snd_front_alsa.c b/sound/xen/xen_snd_front_alsa.c
> index 5041f83e98d2..43478f66954a 100644
> --- a/sound/xen/xen_snd_front_alsa.c
> +++ b/sound/xen/xen_snd_front_alsa.c
> @@ -463,7 +463,7 @@ static int alsa_prepare(struct snd_pcm_substream *substream)
>   
>   	if (!stream->is_open) {
>   		struct snd_pcm_runtime *runtime = substream->runtime;
> -		u8 sndif_format;
> +		int sndif_format;
>   		int ret;
>   
>   		sndif_format = to_sndif_format(runtime->format);
Thank you for your patch,
please see 
https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git/commit/sound/xen?h=for-next&id\x014cea591afac9b3dae61793446f83d5be634203


^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] ALSA: xen-front: signdness bug in alsa_prepare()
@ 2018-05-31  6:47   ` Oleksandr Andrushchenko
  0 siblings, 0 replies; 6+ messages in thread
From: Oleksandr Andrushchenko @ 2018-05-31  6:47 UTC (permalink / raw)
  To: Dan Carpenter; +Cc: xen-devel, alsa-devel, kernel-janitors, Takashi Iwai

On 05/31/2018 09:25 AM, Dan Carpenter wrote:
> "sndif_format" needs to be signed for the error handling to work.
>
> Fixes: 1cee559351a7 ("ALSA: xen-front: Implement ALSA virtual sound driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/sound/xen/xen_snd_front_alsa.c b/sound/xen/xen_snd_front_alsa.c
> index 5041f83e98d2..43478f66954a 100644
> --- a/sound/xen/xen_snd_front_alsa.c
> +++ b/sound/xen/xen_snd_front_alsa.c
> @@ -463,7 +463,7 @@ static int alsa_prepare(struct snd_pcm_substream *substream)
>   
>   	if (!stream->is_open) {
>   		struct snd_pcm_runtime *runtime = substream->runtime;
> -		u8 sndif_format;
> +		int sndif_format;
>   		int ret;
>   
>   		sndif_format = to_sndif_format(runtime->format);
Thank you for your patch,
please see 
https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git/commit/sound/xen?h=for-next&id=014cea591afac9b3dae61793446f83d5be634203

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] ALSA: xen-front: signdness bug in alsa_prepare()
  2018-05-31  6:25 ` Dan Carpenter
  (?)
  (?)
@ 2018-05-31  6:47 ` Oleksandr Andrushchenko
  -1 siblings, 0 replies; 6+ messages in thread
From: Oleksandr Andrushchenko @ 2018-05-31  6:47 UTC (permalink / raw)
  To: Dan Carpenter
  Cc: xen-devel, alsa-devel, kernel-janitors, Takashi Iwai, Jaroslav Kysela

On 05/31/2018 09:25 AM, Dan Carpenter wrote:
> "sndif_format" needs to be signed for the error handling to work.
>
> Fixes: 1cee559351a7 ("ALSA: xen-front: Implement ALSA virtual sound driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/sound/xen/xen_snd_front_alsa.c b/sound/xen/xen_snd_front_alsa.c
> index 5041f83e98d2..43478f66954a 100644
> --- a/sound/xen/xen_snd_front_alsa.c
> +++ b/sound/xen/xen_snd_front_alsa.c
> @@ -463,7 +463,7 @@ static int alsa_prepare(struct snd_pcm_substream *substream)
>   
>   	if (!stream->is_open) {
>   		struct snd_pcm_runtime *runtime = substream->runtime;
> -		u8 sndif_format;
> +		int sndif_format;
>   		int ret;
>   
>   		sndif_format = to_sndif_format(runtime->format);
Thank you for your patch,
please see 
https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git/commit/sound/xen?h=for-next&id=014cea591afac9b3dae61793446f83d5be634203


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH] ALSA: xen-front: signdness bug in alsa_prepare()
@ 2018-05-31  6:25 Dan Carpenter
  0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2018-05-31  6:25 UTC (permalink / raw)
  To: Oleksandr Andrushchenko
  Cc: xen-devel, alsa-devel, kernel-janitors, Takashi Iwai, Jaroslav Kysela

"sndif_format" needs to be signed for the error handling to work.

Fixes: 1cee559351a7 ("ALSA: xen-front: Implement ALSA virtual sound driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/sound/xen/xen_snd_front_alsa.c b/sound/xen/xen_snd_front_alsa.c
index 5041f83e98d2..43478f66954a 100644
--- a/sound/xen/xen_snd_front_alsa.c
+++ b/sound/xen/xen_snd_front_alsa.c
@@ -463,7 +463,7 @@ static int alsa_prepare(struct snd_pcm_substream *substream)
 
 	if (!stream->is_open) {
 		struct snd_pcm_runtime *runtime = substream->runtime;
-		u8 sndif_format;
+		int sndif_format;
 		int ret;
 
 		sndif_format = to_sndif_format(runtime->format);

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply related	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-05-31  7:19 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-31  6:25 [PATCH] ALSA: xen-front: signdness bug in alsa_prepare() Dan Carpenter
2018-05-31  6:25 ` Dan Carpenter
2018-05-31  6:47 ` Oleksandr Andrushchenko
2018-05-31  6:47   ` Oleksandr Andrushchenko
2018-05-31  6:47 ` Oleksandr Andrushchenko
2018-05-31  6:25 Dan Carpenter

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.