Re: [PATCH v7 2/5] mtd: nand: Add core infrastructure to support SPI NANDs

[Boris Brezillon <boris.brezillon@bootlin.com>]

Hi Miquel,

On Thu, 31 May 2018 09:30:05 +0200
Miquel Raynal <miquel.raynal@bootlin.com> wrote:

> Hi Boris,
> 
> On Tue, 15 May 2018 17:08:22 +0200, Boris Brezillon
> <boris.brezillon@bootlin.com> wrote:
> 
> > +static bool spinand_isbad(struct nand_device *nand, const struct nand_pos *pos)
> > +{
> > +	struct spinand_device *spinand = nand_to_spinand(nand);
> > +	struct nand_page_io_req req = {
> > +		.pos = *pos,
> > +		.ooblen = 2,
> > +		.ooboffs = 0,
> > +		.oobbuf.in = spinand->oobbuf,
> > +		.mode = MTD_OPS_RAW,
> > +	};
> > +	int ret;
> > +
> > +	memset(spinand->oobbuf, 0, 2);
> > +	spinand_select_target(spinand, pos->target);
> > +	ret = spinand_read_page(spinand, &req, false);  
> 
> I got a warning here because ret is not checked, maybe a:
> 
>         if (ret) {
>                 dev_err(dev, "...");
>                 return false;
>         }

Or we could just ignore spinand_read_page() ret code since the first 2
bytes of spinand->oobbuf are initialized to 0, which means the block
will be considered bad if the read fails.

> 
> ?
> 
> > +	if (spinand->oobbuf[0] != 0xff || spinand->oobbuf[1] != 0xff)
> > +		return true;
> > +
> > +	return false;
> > +}  
> 
> Thanks,
> Miquèl