All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: jani.nikula@intel.com
Subject: [PATCH 3/4] drm/i915: be more strict about HAS_PCH_NOP() usage
Date: Thu, 31 May 2018 14:56:23 +0300	[thread overview]
Message-ID: <20180531115624.30269-4-jani.nikula@intel.com> (raw)
In-Reply-To: <20180531115624.30269-1-jani.nikula@intel.com>

HAS_PCH_NOP() implies a PCH platform without south display, not generic
disabled display. Prefer num_pipes == 0 for PCH independent checks.

Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/intel_bios.c | 2 +-
 drivers/gpu/drm/i915/intel_i2c.c  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c
index 1cf073b6ac8a..94428633a9d3 100644
--- a/drivers/gpu/drm/i915/intel_bios.c
+++ b/drivers/gpu/drm/i915/intel_bios.c
@@ -1700,7 +1700,7 @@ void intel_bios_init(struct drm_i915_private *dev_priv)
 	const struct bdb_header *bdb;
 	u8 __iomem *bios = NULL;
 
-	if (HAS_PCH_NOP(dev_priv)) {
+	if (INTEL_INFO(dev_priv)->num_pipes == 0) {
 		DRM_DEBUG_KMS("Skipping VBT init due to disabled display.\n");
 		return;
 	}
diff --git a/drivers/gpu/drm/i915/intel_i2c.c b/drivers/gpu/drm/i915/intel_i2c.c
index e6875509bcd9..61729bf84e08 100644
--- a/drivers/gpu/drm/i915/intel_i2c.c
+++ b/drivers/gpu/drm/i915/intel_i2c.c
@@ -771,7 +771,7 @@ int intel_setup_gmbus(struct drm_i915_private *dev_priv)
 	unsigned int pin;
 	int ret;
 
-	if (HAS_PCH_NOP(dev_priv))
+	if (INTEL_INFO(dev_priv)->num_pipes == 0)
 		return 0;
 
 	if (IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv))
-- 
2.11.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2018-05-31 11:56 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-31 11:56 drm/i915: virtual PCH and PCH_NOP fixes Jani Nikula
2018-05-31 11:56 ` [PATCH 1/4] drm/i915: fix guest virtual PCH detection on non-PCH systems Jani Nikula
2018-05-31 16:26   ` Lucas De Marchi
2018-06-08 12:33     ` Jani Nikula
2018-06-12 23:32       ` Lucas De Marchi
2018-06-13  6:49         ` Jani Nikula
2018-06-13  8:11           ` Arkadiusz Hiler
2018-06-13 17:09             ` Lucas De Marchi
2018-06-13 17:16               ` Lucas De Marchi
2018-06-14  6:57                 ` Arkadiusz Hiler
2018-06-19  7:02                   ` Lucas De Marchi
2018-06-01  0:43   ` Colin Xu
2018-05-31 11:56 ` [PATCH 2/4] drm/i915: clean up virtual PCH special case handling Jani Nikula
2018-06-01  0:45   ` Colin Xu
2018-05-31 11:56 ` Jani Nikula [this message]
2018-05-31 11:56 ` [PATCH 4/4] drm/i915: fix PCH_NOP setting for non-PCH platforms Jani Nikula
2018-05-31 16:41   ` Lucas De Marchi
2018-05-31 13:14 ` ✗ Fi.CI.BAT: failure for series starting with [1/4] drm/i915: fix guest virtual PCH detection on non-PCH systems Patchwork
2018-05-31 15:11 ` ✓ Fi.CI.BAT: success " Patchwork
2018-05-31 16:31 ` ✗ Fi.CI.BAT: failure for series starting with [1/4] drm/i915: fix guest virtual PCH detection on non-PCH systems (rev2) Patchwork
2018-05-31 18:07 ` ✓ Fi.CI.IGT: success for series starting with [1/4] drm/i915: fix guest virtual PCH detection on non-PCH systems Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180531115624.30269-4-jani.nikula@intel.com \
    --to=jani.nikula@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.