Re: [PATCH 1/4] drm/i915: fix guest virtual PCH detection on non-PCH systems

[Lucas De Marchi <lucas.de.marchi@gmail.com>]

On Fri, Jun 8, 2018 at 5:34 AM Jani Nikula <jani.nikula@intel.com> wrote:
>
> On Thu, 31 May 2018, Lucas De Marchi <lucas.de.marchi@gmail.com> wrote:
> > On Thu, May 31, 2018 at 02:56:21PM +0300, Jani Nikula wrote:
> >> Virtualized non-PCH systems such as Broxton or Geminilake should use
> >> PCH_NONE to indicate no PCH rather than PCH_NOP. The latter is a
> >> specific case to indicate a PCH system without south display.
> >
> > Then let's go ahead and document it?
>
> Please avoid sending suggestion patches in-reply-to existing
> series. This confused patchwork and screwed up CI for the series, which
> was already a resend just to get CI. :(

ugh, sorry.  Sometimes just adding a oneline diff is much better than
a hundred words explaining :( ... IMO pw is trying to be smarter than
it should here or not being smart enough. Nonetheless I won't do that
anymore.

Lucas De Marchi

>
> I'm resending the series, with your documentation patch added, but I'm
> keeping the extra explanatory text in the last patch. I think it's
> warranted.
>
> BR,
> Jani.
>
>
> >
> > -------------
> > Subject: [PATCH] drm/i915: document PCH_NOP
> >
> > There's a difference between PCH_NONE and PCH_NOP: the former means we
> > don't have a PCH while in the latter we do, but it doesn't have the
> > south display.
> >
> > Cc: Jani Nikula <jani.nikula@intel.com>
> > Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> > ---
> >  drivers/gpu/drm/i915/i915_drv.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> > index 72150f89f200..aa395a898258 100644
> > --- a/drivers/gpu/drm/i915/i915_drv.h
> > +++ b/drivers/gpu/drm/i915/i915_drv.h
> > @@ -631,7 +631,7 @@ enum intel_pch {
> >       PCH_KBP,        /* Kaby Lake PCH */
> >       PCH_CNP,        /* Cannon Lake PCH */
> >       PCH_ICP,        /* Ice Lake PCH */
> > -     PCH_NOP,
> > +     PCH_NOP,        /* PCH without south display */
> >  };
> >
> >  enum intel_sbi_destination {
>
> --
> Jani Nikula, Intel Open Source Graphics Center



-- 
Lucas De Marchi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx