* [PATCH] xfstests/btrfs: adapt ppc64le node size at least 65536
@ 2018-06-01 8:37 Yong Sun
2018-06-04 3:09 ` Dave Chinner
0 siblings, 1 reply; 4+ messages in thread
From: Yong Sun @ 2018-06-01 8:37 UTC (permalink / raw)
To: fstests; +Cc: yosun
From: yosun <yosun@suse.com>
node size(leaf size) in ppc64le at least 65536, so mkfs with --nodesize smaller than that number will cause a fail on 057 and 122.
Signed-off-by: Yong Sun <yosun@suse.com>
---
tests/btrfs/057 | 6 ++++++
tests/btrfs/122 | 8 +++++++-
2 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/tests/btrfs/057 b/tests/btrfs/057
index a834b763..69d096fb 100755
--- a/tests/btrfs/057
+++ b/tests/btrfs/057
@@ -48,6 +48,12 @@ _require_scratch
rm -f $seqres.full
+# the nodesize in ppc64le is at least 65536, it will mismatch output
+HARDWARE_PLATFORM=`uname -i`
+if [ "$HARDWARE_PLATFORM" = "ppc64le" ]; then
+ _notrun "Not supported on ppc64le with nodesize > 4096"
+fi
+
# use small leaf size to get higher btree height.
run_check _scratch_mkfs "-b 1g --nodesize 4096"
diff --git a/tests/btrfs/122 b/tests/btrfs/122
index 213a27f8..50003ad0 100755
--- a/tests/btrfs/122
+++ b/tests/btrfs/122
@@ -55,7 +55,13 @@ rm -f $seqres.full
# Force a small leaf size to make it easier to blow out our root
# subvolume tree
-_scratch_mkfs "--nodesize 16384" >/dev/null
+# Exception: leaf size at least 65536 in ppc64le
+HARDWARE_PLATFORM=`uname -i`
+if [ "$HARDWARE_PLATFORM" = "ppc64le" ]; then
+ _scratch_mkfs "--nodesize 65536" >/dev/null
+else
+ _scratch_mkfs "--nodesize 16384" >/dev/null
+fi
_scratch_mount
_run_btrfs_util_prog quota enable $SCRATCH_MNT
--
2.13.6
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] xfstests/btrfs: adapt ppc64le node size at least 65536
2018-06-01 8:37 [PATCH] xfstests/btrfs: adapt ppc64le node size at least 65536 Yong Sun
@ 2018-06-04 3:09 ` Dave Chinner
0 siblings, 0 replies; 4+ messages in thread
From: Dave Chinner @ 2018-06-04 3:09 UTC (permalink / raw)
To: Yong Sun; +Cc: fstests
On Fri, Jun 01, 2018 at 04:37:27PM +0800, Yong Sun wrote:
> From: yosun <yosun@suse.com>
>
> node size(leaf size) in ppc64le at least 65536, so mkfs with --nodesize smaller than that number will cause a fail on 057 and 122.
>
> Signed-off-by: Yong Sun <yosun@suse.com>
> ---
> tests/btrfs/057 | 6 ++++++
> tests/btrfs/122 | 8 +++++++-
> 2 files changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/tests/btrfs/057 b/tests/btrfs/057
> index a834b763..69d096fb 100755
> --- a/tests/btrfs/057
> +++ b/tests/btrfs/057
> @@ -48,6 +48,12 @@ _require_scratch
>
> rm -f $seqres.full
>
> +# the nodesize in ppc64le is at least 65536, it will mismatch output
> +HARDWARE_PLATFORM=`uname -i`
> +if [ "$HARDWARE_PLATFORM" = "ppc64le" ]; then
> + _notrun "Not supported on ppc64le with nodesize > 4096"
> +fi
Why doesn't ppc64le support node sizes smaller than 64K? What makes
it different to any other hardware? i.e. we should be checking for
the thing that prevents node sizes <64k, not the hardware platform.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xfstests/btrfs: adapt ppc64le node size at least 65536
2018-06-01 7:57 Yong Sun
@ 2018-06-01 8:06 ` Amir Goldstein
0 siblings, 0 replies; 4+ messages in thread
From: Amir Goldstein @ 2018-06-01 8:06 UTC (permalink / raw)
To: Yong Sun; +Cc: fstests, linux-xfs
Wrong list. You were looking for <fstests@vger.kernel.org>
Thanks,
Amir.
On Fri, Jun 1, 2018 at 10:57 AM, Yong Sun <yosun@suse.com> wrote:
> From: yosun <yosun@suse.com>
>
> node size(leaf size) in ppc64le at least 65536, so mkfs with --nodesize smaller than that number will cause a fail on 057 and 122.
>
> Signed-off-by: Yong Sun <yosun@suse.com>
> ---
> tests/btrfs/057 | 6 ++++++
> tests/btrfs/122 | 8 +++++++-
> 2 files changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/tests/btrfs/057 b/tests/btrfs/057
> index a834b763..69d096fb 100755
> --- a/tests/btrfs/057
> +++ b/tests/btrfs/057
> @@ -48,6 +48,12 @@ _require_scratch
>
> rm -f $seqres.full
>
> +# the nodesize in ppc64le is at least 65536, it will mismatch output
> +HARDWARE_PLATFORM=`uname -i`
> +if [ "$HARDWARE_PLATFORM" = "ppc64le" ]; then
> + _notrun "Not supported on ppc64le with nodesize > 4096"
> +fi
> +
> # use small leaf size to get higher btree height.
> run_check _scratch_mkfs "-b 1g --nodesize 4096"
>
> diff --git a/tests/btrfs/122 b/tests/btrfs/122
> index 213a27f8..50003ad0 100755
> --- a/tests/btrfs/122
> +++ b/tests/btrfs/122
> @@ -55,7 +55,13 @@ rm -f $seqres.full
>
> # Force a small leaf size to make it easier to blow out our root
> # subvolume tree
> -_scratch_mkfs "--nodesize 16384" >/dev/null
> +# Exception: leaf size at least 65536 in ppc64le
> +HARDWARE_PLATFORM=`uname -i`
> +if [ "$HARDWARE_PLATFORM" = "ppc64le" ]; then
> + _scratch_mkfs "--nodesize 65536" >/dev/null
> +else
> + _scratch_mkfs "--nodesize 16384" >/dev/null
> +fi
> _scratch_mount
> _run_btrfs_util_prog quota enable $SCRATCH_MNT
>
> --
> 2.13.6
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] xfstests/btrfs: adapt ppc64le node size at least 65536
@ 2018-06-01 7:57 Yong Sun
2018-06-01 8:06 ` Amir Goldstein
0 siblings, 1 reply; 4+ messages in thread
From: Yong Sun @ 2018-06-01 7:57 UTC (permalink / raw)
To: linux-xfs; +Cc: yosun
From: yosun <yosun@suse.com>
node size(leaf size) in ppc64le at least 65536, so mkfs with --nodesize smaller than that number will cause a fail on 057 and 122.
Signed-off-by: Yong Sun <yosun@suse.com>
---
tests/btrfs/057 | 6 ++++++
tests/btrfs/122 | 8 +++++++-
2 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/tests/btrfs/057 b/tests/btrfs/057
index a834b763..69d096fb 100755
--- a/tests/btrfs/057
+++ b/tests/btrfs/057
@@ -48,6 +48,12 @@ _require_scratch
rm -f $seqres.full
+# the nodesize in ppc64le is at least 65536, it will mismatch output
+HARDWARE_PLATFORM=`uname -i`
+if [ "$HARDWARE_PLATFORM" = "ppc64le" ]; then
+ _notrun "Not supported on ppc64le with nodesize > 4096"
+fi
+
# use small leaf size to get higher btree height.
run_check _scratch_mkfs "-b 1g --nodesize 4096"
diff --git a/tests/btrfs/122 b/tests/btrfs/122
index 213a27f8..50003ad0 100755
--- a/tests/btrfs/122
+++ b/tests/btrfs/122
@@ -55,7 +55,13 @@ rm -f $seqres.full
# Force a small leaf size to make it easier to blow out our root
# subvolume tree
-_scratch_mkfs "--nodesize 16384" >/dev/null
+# Exception: leaf size at least 65536 in ppc64le
+HARDWARE_PLATFORM=`uname -i`
+if [ "$HARDWARE_PLATFORM" = "ppc64le" ]; then
+ _scratch_mkfs "--nodesize 65536" >/dev/null
+else
+ _scratch_mkfs "--nodesize 16384" >/dev/null
+fi
_scratch_mount
_run_btrfs_util_prog quota enable $SCRATCH_MNT
--
2.13.6
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-06-04 3:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-01 8:37 [PATCH] xfstests/btrfs: adapt ppc64le node size at least 65536 Yong Sun
2018-06-04 3:09 ` Dave Chinner
-- strict thread matches above, loose matches on Subject: below --
2018-06-01 7:57 Yong Sun
2018-06-01 8:06 ` Amir Goldstein
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.