* [PATCH v2] virtio: update the comments for transport features
@ 2018-06-01 10:59 Tiwei Bie
0 siblings, 0 replies; 6+ messages in thread
From: Tiwei Bie @ 2018-06-01 10:59 UTC (permalink / raw)
To: mst, jasowang, stefanha, cohuck, virtualization, linux-kernel,
virtio-dev
The existing comments for transport features are out dated.
So update them to address the latest changes in the spec.
Suggested-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
---
This patch is generated on top of below patch:
https://lists.oasis-open.org/archives/virtio-dev/201805/msg00212.html
v2:
- Improve the comments (Cornelia);
- Improve the commit message;
include/uapi/linux/virtio_config.h | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/include/uapi/linux/virtio_config.h b/include/uapi/linux/virtio_config.h
index b7c1f4e7d59e..449132c76b1c 100644
--- a/include/uapi/linux/virtio_config.h
+++ b/include/uapi/linux/virtio_config.h
@@ -45,9 +45,12 @@
/* We've given up on this device. */
#define VIRTIO_CONFIG_S_FAILED 0x80
-/* Some virtio feature bits (currently bits 28 through 32) are reserved for the
- * transport being used (eg. virtio_ring), the rest are per-device feature
- * bits. */
+/*
+ * Virtio feature bits VIRTIO_TRANSPORT_F_START through
+ * VIRTIO_TRANSPORT_F_END are reserved for the transport
+ * being used (e.g. virtio_ring, virtio_pci etc.), the
+ * rest are per-device feature bits.
+ */
#define VIRTIO_TRANSPORT_F_START 28
#define VIRTIO_TRANSPORT_F_END 38
--
2.17.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] virtio: update the comments for transport features
2018-06-01 11:16 ` Cornelia Huck
2018-06-01 11:22 ` Tiwei Bie
@ 2018-06-01 11:22 ` Tiwei Bie
1 sibling, 0 replies; 6+ messages in thread
From: Tiwei Bie @ 2018-06-01 11:22 UTC (permalink / raw)
To: Cornelia Huck
Cc: mst, jasowang, stefanha, virtualization, linux-kernel, virtio-dev
On Fri, Jun 01, 2018 at 01:16:47PM +0200, Cornelia Huck wrote:
> On Fri, 1 Jun 2018 18:59:50 +0800
> Tiwei Bie <tiwei.bie@intel.com> wrote:
>
> > The existing comments for transport features are out dated.
>
> s/out dated/outdated/
Thanks for catching this typo!
>
[...]
> > +/*
> > + * Virtio feature bits VIRTIO_TRANSPORT_F_START through
> > + * VIRTIO_TRANSPORT_F_END are reserved for the transport
> > + * being used (e.g. virtio_ring, virtio_pci etc.), the
> > + * rest are per-device feature bits.
> > + */
> > #define VIRTIO_TRANSPORT_F_START 28
> > #define VIRTIO_TRANSPORT_F_END 38
> >
>
> Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Thanks for your review!
Best regards,
Tiwei Bie
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] virtio: update the comments for transport features
2018-06-01 11:16 ` Cornelia Huck
@ 2018-06-01 11:22 ` Tiwei Bie
2018-06-01 11:22 ` Tiwei Bie
1 sibling, 0 replies; 6+ messages in thread
From: Tiwei Bie @ 2018-06-01 11:22 UTC (permalink / raw)
To: Cornelia Huck; +Cc: virtio-dev, mst, linux-kernel, virtualization, stefanha
On Fri, Jun 01, 2018 at 01:16:47PM +0200, Cornelia Huck wrote:
> On Fri, 1 Jun 2018 18:59:50 +0800
> Tiwei Bie <tiwei.bie@intel.com> wrote:
>
> > The existing comments for transport features are out dated.
>
> s/out dated/outdated/
Thanks for catching this typo!
>
[...]
> > +/*
> > + * Virtio feature bits VIRTIO_TRANSPORT_F_START through
> > + * VIRTIO_TRANSPORT_F_END are reserved for the transport
> > + * being used (e.g. virtio_ring, virtio_pci etc.), the
> > + * rest are per-device feature bits.
> > + */
> > #define VIRTIO_TRANSPORT_F_START 28
> > #define VIRTIO_TRANSPORT_F_END 38
> >
>
> Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Thanks for your review!
Best regards,
Tiwei Bie
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] virtio: update the comments for transport features
2018-06-01 10:59 Tiwei Bie
2018-06-01 11:16 ` Cornelia Huck
@ 2018-06-01 11:16 ` Cornelia Huck
2018-06-01 11:22 ` Tiwei Bie
2018-06-01 11:22 ` Tiwei Bie
1 sibling, 2 replies; 6+ messages in thread
From: Cornelia Huck @ 2018-06-01 11:16 UTC (permalink / raw)
To: Tiwei Bie
Cc: mst, jasowang, stefanha, virtualization, linux-kernel, virtio-dev
On Fri, 1 Jun 2018 18:59:50 +0800
Tiwei Bie <tiwei.bie@intel.com> wrote:
> The existing comments for transport features are out dated.
s/out dated/outdated/
> So update them to address the latest changes in the spec.
>
> Suggested-by: Michael S. Tsirkin <mst@redhat.com>
> Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
> ---
> This patch is generated on top of below patch:
> https://lists.oasis-open.org/archives/virtio-dev/201805/msg00212.html
>
> v2:
> - Improve the comments (Cornelia);
> - Improve the commit message;
>
> include/uapi/linux/virtio_config.h | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/include/uapi/linux/virtio_config.h b/include/uapi/linux/virtio_config.h
> index b7c1f4e7d59e..449132c76b1c 100644
> --- a/include/uapi/linux/virtio_config.h
> +++ b/include/uapi/linux/virtio_config.h
> @@ -45,9 +45,12 @@
> /* We've given up on this device. */
> #define VIRTIO_CONFIG_S_FAILED 0x80
>
> -/* Some virtio feature bits (currently bits 28 through 32) are reserved for the
> - * transport being used (eg. virtio_ring), the rest are per-device feature
> - * bits. */
> +/*
> + * Virtio feature bits VIRTIO_TRANSPORT_F_START through
> + * VIRTIO_TRANSPORT_F_END are reserved for the transport
> + * being used (e.g. virtio_ring, virtio_pci etc.), the
> + * rest are per-device feature bits.
> + */
> #define VIRTIO_TRANSPORT_F_START 28
> #define VIRTIO_TRANSPORT_F_END 38
>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] virtio: update the comments for transport features
2018-06-01 10:59 Tiwei Bie
@ 2018-06-01 11:16 ` Cornelia Huck
2018-06-01 11:16 ` Cornelia Huck
1 sibling, 0 replies; 6+ messages in thread
From: Cornelia Huck @ 2018-06-01 11:16 UTC (permalink / raw)
To: Tiwei Bie; +Cc: virtio-dev, mst, linux-kernel, virtualization, stefanha
On Fri, 1 Jun 2018 18:59:50 +0800
Tiwei Bie <tiwei.bie@intel.com> wrote:
> The existing comments for transport features are out dated.
s/out dated/outdated/
> So update them to address the latest changes in the spec.
>
> Suggested-by: Michael S. Tsirkin <mst@redhat.com>
> Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
> ---
> This patch is generated on top of below patch:
> https://lists.oasis-open.org/archives/virtio-dev/201805/msg00212.html
>
> v2:
> - Improve the comments (Cornelia);
> - Improve the commit message;
>
> include/uapi/linux/virtio_config.h | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/include/uapi/linux/virtio_config.h b/include/uapi/linux/virtio_config.h
> index b7c1f4e7d59e..449132c76b1c 100644
> --- a/include/uapi/linux/virtio_config.h
> +++ b/include/uapi/linux/virtio_config.h
> @@ -45,9 +45,12 @@
> /* We've given up on this device. */
> #define VIRTIO_CONFIG_S_FAILED 0x80
>
> -/* Some virtio feature bits (currently bits 28 through 32) are reserved for the
> - * transport being used (eg. virtio_ring), the rest are per-device feature
> - * bits. */
> +/*
> + * Virtio feature bits VIRTIO_TRANSPORT_F_START through
> + * VIRTIO_TRANSPORT_F_END are reserved for the transport
> + * being used (e.g. virtio_ring, virtio_pci etc.), the
> + * rest are per-device feature bits.
> + */
> #define VIRTIO_TRANSPORT_F_START 28
> #define VIRTIO_TRANSPORT_F_END 38
>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] virtio: update the comments for transport features
@ 2018-06-01 10:59 Tiwei Bie
2018-06-01 11:16 ` Cornelia Huck
2018-06-01 11:16 ` Cornelia Huck
0 siblings, 2 replies; 6+ messages in thread
From: Tiwei Bie @ 2018-06-01 10:59 UTC (permalink / raw)
To: mst, jasowang, stefanha, cohuck, virtualization, linux-kernel,
virtio-dev
The existing comments for transport features are out dated.
So update them to address the latest changes in the spec.
Suggested-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
---
This patch is generated on top of below patch:
https://lists.oasis-open.org/archives/virtio-dev/201805/msg00212.html
v2:
- Improve the comments (Cornelia);
- Improve the commit message;
include/uapi/linux/virtio_config.h | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/include/uapi/linux/virtio_config.h b/include/uapi/linux/virtio_config.h
index b7c1f4e7d59e..449132c76b1c 100644
--- a/include/uapi/linux/virtio_config.h
+++ b/include/uapi/linux/virtio_config.h
@@ -45,9 +45,12 @@
/* We've given up on this device. */
#define VIRTIO_CONFIG_S_FAILED 0x80
-/* Some virtio feature bits (currently bits 28 through 32) are reserved for the
- * transport being used (eg. virtio_ring), the rest are per-device feature
- * bits. */
+/*
+ * Virtio feature bits VIRTIO_TRANSPORT_F_START through
+ * VIRTIO_TRANSPORT_F_END are reserved for the transport
+ * being used (e.g. virtio_ring, virtio_pci etc.), the
+ * rest are per-device feature bits.
+ */
#define VIRTIO_TRANSPORT_F_START 28
#define VIRTIO_TRANSPORT_F_END 38
--
2.17.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-06-01 11:22 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-01 10:59 [PATCH v2] virtio: update the comments for transport features Tiwei Bie
2018-06-01 10:59 Tiwei Bie
2018-06-01 11:16 ` Cornelia Huck
2018-06-01 11:16 ` Cornelia Huck
2018-06-01 11:22 ` Tiwei Bie
2018-06-01 11:22 ` Tiwei Bie
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.