[RFC PATCH 0/3] Small cleanup for hotplugmem

[RFC PATCH 0/3] Small cleanup for hotplugmem

[osalvador]

From: Oscar Salvador <osalvador@suse.de>

Hi guys,

I wanted to give it a chance a do a small cleanup in the hotplug memory code.
A lot more could be done, but I wanted to start somewhere.
I tried to unify/remove duplicated code.

Here I have just done three things

1) add_memory_resource() had code to allocate a node in case it was offline.
   Since try_online_node already does that, I just made add_memory_resource() to
   use that function.
   This is better explained in patch 1/3.

2) register_mem_sect_under_node() will be called only from link_mem_sections

3) Get rid of link_mem_sections() in favour of walk_memory_range with a callback to
   register_mem_sect_under_node()

I am posting this as a RFC because I could not see that these patches break anything,
but expert eyes might see something that I am missing here.

Oscar Salvador (3):
  mm/memory_hotplug: Make add_memory_resource use __try_online_node
  mm/memory_hotplug: Call register_mem_sect_under_node
  mm/memory_hotplug: Get rid of link_mem_sections

 drivers/base/memory.c |   2 -
 drivers/base/node.c   |  47 +++++------------------
 include/linux/node.h  |  21 +++++------
 mm/memory_hotplug.c   | 101 ++++++++++++++++++++++++++------------------------
 4 files changed, 71 insertions(+), 100 deletions(-)

Signed-off-by: Oscar Salvador <osalvador@suse.de>

-- 
2.13.6

Re: [RFC PATCH 0/3] Small cleanup for hotplugmem

[Oscar Salvador]

On Mon, May 28, 2018 at 10:13:52AM +0200, osalvador@techadventures.net wrote:
> From: Oscar Salvador <osalvador@suse.de>
> 
> Hi guys,
> 
> I wanted to give it a chance a do a small cleanup in the hotplug memory code.
> A lot more could be done, but I wanted to start somewhere.
> I tried to unify/remove duplicated code.
> 
> Here I have just done three things
> 
> 1) add_memory_resource() had code to allocate a node in case it was offline.
>    Since try_online_node already does that, I just made add_memory_resource() to
>    use that function.
>    This is better explained in patch 1/3.
> 
> 2) register_mem_sect_under_node() will be called only from link_mem_sections
> 
> 3) Get rid of link_mem_sections() in favour of walk_memory_range with a callback to
>    register_mem_sect_under_node()
> 
> I am posting this as a RFC because I could not see that these patches break anything,
> but expert eyes might see something that I am missing here.
> 
> Oscar Salvador (3):
>   mm/memory_hotplug: Make add_memory_resource use __try_online_node
>   mm/memory_hotplug: Call register_mem_sect_under_node
>   mm/memory_hotplug: Get rid of link_mem_sections
> 
>  drivers/base/memory.c |   2 -
>  drivers/base/node.c   |  47 +++++------------------
>  include/linux/node.h  |  21 +++++------
>  mm/memory_hotplug.c   | 101 ++++++++++++++++++++++++++------------------------
>  4 files changed, 71 insertions(+), 100 deletions(-)
> 
> Signed-off-by: Oscar Salvador <osalvador@suse.de>
> 
> -- 
> 2.13.6
> 

Since there have not been any concerns so far, I will send v1 of this patchset.

Thanks

Oscar Salvador

Re: [RFC PATCH 0/3] Small cleanup for hotplugmem

[Michal Hocko]

On Fri 01-06-18 13:25:30, Oscar Salvador wrote:
[...]
> Since there have not been any concerns so far, I will send v1 of this patchset.

I suspect nobody had time to look at those patches yet. It is getting
close to the merge window and I expect people are busy. I will try to
get to this after merge window.

-- 
Michal Hocko
SUSE Labs

Re: [RFC PATCH 0/3] Small cleanup for hotplugmem

[Oscar Salvador]

On Fri, Jun 01, 2018 at 03:08:42PM +0200, Michal Hocko wrote:
> On Fri 01-06-18 13:25:30, Oscar Salvador wrote:
> [...]
> > Since there have not been any concerns so far, I will send v1 of this patchset.
> 
> I suspect nobody had time to look at those patches yet. It is getting
> close to the merge window and I expect people are busy. I will try to
> get to this after merge window.

No problem at all, I know people are busy and merge window is coming so
I did not really expect a lot of movement here.

But since next week I am going to be quite busy and I will be tight in time, 
I just sent the patchset (<20180601125321.30652-1-osalvador@techadventures.net>), so you might want to comment
there in case you want.

Anyway, thanks for the time.

Oscar Salvador