[Buildroot] [PATCH 1/1] php-amqp: selects openssl

[Buildroot] [PATCH 1/1] php-amqp: selects openssl

[Fabrice Fontaine]

php-amqp needs a rabbitmq-c with openssl support:
https://github.com/pdezwart/php-amqp/issues/310

Fixes:
 - http://autobuild.buildroot.net/results/b7c89bbbd0ca1df08dd7cbfc90c7b45dcf1fad05

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/php-amqp/Config.in | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/package/php-amqp/Config.in b/package/php-amqp/Config.in
index 0aa2021f5a..cf32ec10b2 100644
--- a/package/php-amqp/Config.in
+++ b/package/php-amqp/Config.in
@@ -1,12 +1,14 @@
 config BR2_PACKAGE_PHP_AMQP
 	bool "php-amqp"
 	depends on BR2_PACKAGE_PHP
+	depends on !BR2_STATIC_LIBS # rabbitmq-c: amqp_ssl_socket.h
 	depends on BR2_TOOLCHAIN_HAS_THREADS # rabbitmq-c
+	select BR2_PACKAGE_OPENSSL # rabbitmq-c: amqp_ssl_socket.h
 	select BR2_PACKAGE_RABBITMQ_C
 	help
 	  Communicate with any AMQP compliant server.
 
 	  http://pecl.php.net/package/amqp
 
-comment "php-amqp needs a toolchain w/ threads"
-	depends on !BR2_TOOLCHAIN_HAS_THREADS
+comment "php-amqp needs a toolchain w/ dynamic library, threads"
+	depends on BR2_STATIC_LIBS || !BR2_TOOLCHAIN_HAS_THREADS
-- 
2.14.1

[Buildroot] [PATCH 1/1] php-amqp: selects openssl

[Baruch Siach]

Hi Fabrice,

On Sun, Jun 03, 2018 at 09:31:26PM +0200, Fabrice Fontaine wrote:
> php-amqp needs a rabbitmq-c with openssl support:
> https://github.com/pdezwart/php-amqp/issues/310
> 
> Fixes:
>  - http://autobuild.buildroot.net/results/b7c89bbbd0ca1df08dd7cbfc90c7b45dcf1fad05
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/php-amqp/Config.in | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/package/php-amqp/Config.in b/package/php-amqp/Config.in
> index 0aa2021f5a..cf32ec10b2 100644
> --- a/package/php-amqp/Config.in
> +++ b/package/php-amqp/Config.in
> @@ -1,12 +1,14 @@
>  config BR2_PACKAGE_PHP_AMQP
>  	bool "php-amqp"
>  	depends on BR2_PACKAGE_PHP
> +	depends on !BR2_STATIC_LIBS # rabbitmq-c: amqp_ssl_socket.h

Why is this needed? rabbitmq-c does not depend on !BR2_STATIC_LIBS.

>  	depends on BR2_TOOLCHAIN_HAS_THREADS # rabbitmq-c
> +	select BR2_PACKAGE_OPENSSL # rabbitmq-c: amqp_ssl_socket.h
>  	select BR2_PACKAGE_RABBITMQ_C
>  	help
>  	  Communicate with any AMQP compliant server.
>  
>  	  http://pecl.php.net/package/amqp
>  
> -comment "php-amqp needs a toolchain w/ threads"
> -	depends on !BR2_TOOLCHAIN_HAS_THREADS
> +comment "php-amqp needs a toolchain w/ dynamic library, threads"
> +	depends on BR2_STATIC_LIBS || !BR2_TOOLCHAIN_HAS_THREADS

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

[Buildroot] [PATCH 1/1] php-amqp: selects openssl

[Thomas Petazzoni]

Hello,

On Sun,  3 Jun 2018 21:31:26 +0200, Fabrice Fontaine wrote:
> php-amqp needs a rabbitmq-c with openssl support:
> https://github.com/pdezwart/php-amqp/issues/310

We've had php-amqp since October 2016 and the last version bump is from
May 2017, i.e a year ago. What has changed that makes php-amqp now
require OpenSSL support in rabbitmq-c ?

Is this an issue that was always occurring, but we never fixed ? Is it
a new issue ? If so, why does it suddenly started to happen ?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH 1/1] php-amqp: selects openssl

[Fabrice Fontaine]

Dear Thomas,

2018-06-04 6:59 GMT+02:00 Thomas Petazzoni <thomas.petazzoni@bootlin.com>:

> Hello,
>
> On Sun,  3 Jun 2018 21:31:26 +0200, Fabrice Fontaine wrote:
> > php-amqp needs a rabbitmq-c with openssl support:
> > https://github.com/pdezwart/php-amqp/issues/310
>
> We've had php-amqp since October 2016 and the last version bump is from
> May 2017, i.e a year ago. What has changed that makes php-amqp now
> require OpenSSL support in rabbitmq-c ?
>
SSL connection supports in php-amqp was added in 1.8.0beta2:
https://github.com/pdezwart/php-amqp/commit/83defa18d958503a395e928d4669a23041014b2e
.
So it was introduced in buildroot by the bump to version 1.9.0 in May 2017.
In autobuilders, we have three errors with php-amqp:
http://autobuild.buildroot.net/?reason=php-amqp-1.9.0.
The three errors are all related to SSL and the older one is from February
2018 but I suppose that autobuilder results are deleted after some time?

>
> Is this an issue that was always occurring, but we never fixed ? Is it
> a new issue ? If so, why does it suddenly started to happen ?


> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
> Embedded Linux and Kernel engineering
> https://bootlin.com
>
Best Regards,

Fabrice
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180604/c0364cc1/attachment.html>

[Buildroot] [PATCH 1/1] php-amqp: selects openssl

[Fabrice Fontaine]

Dear Baruch,

2018-06-04 4:32 GMT+02:00 Baruch Siach <baruch@tkos.co.il>:

> Hi Fabrice,
>
> On Sun, Jun 03, 2018 at 09:31:26PM +0200, Fabrice Fontaine wrote:
> > php-amqp needs a rabbitmq-c with openssl support:
> > https://github.com/pdezwart/php-amqp/issues/310
> >
> > Fixes:
> >  - http://autobuild.buildroot.net/results/b7c89bbbd0ca1df08dd7cbfc90c7b4
> 5dcf1fad05
> >
> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> > ---
> >  package/php-amqp/Config.in | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/package/php-amqp/Config.in b/package/php-amqp/Config.in
> > index 0aa2021f5a..cf32ec10b2 100644
> > --- a/package/php-amqp/Config.in
> > +++ b/package/php-amqp/Config.in
> > @@ -1,12 +1,14 @@
> >  config BR2_PACKAGE_PHP_AMQP
> >       bool "php-amqp"
> >       depends on BR2_PACKAGE_PHP
> > +     depends on !BR2_STATIC_LIBS # rabbitmq-c: amqp_ssl_socket.h
>
> Why is this needed? rabbitmq-c does not depend on !BR2_STATIC_LIBS.
>
This is needed because openssl supports in rabbitmq-c has been disabled in
static mode since May 2017: http://patchwork.ozlabs.org/patch/762183.
But perhaps it would be better to make all rabbitmq-c depends on
!BR2_STATIC_LIBS as suggested by Peter back in May 2017.

>
> >       depends on BR2_TOOLCHAIN_HAS_THREADS # rabbitmq-c
> > +     select BR2_PACKAGE_OPENSSL # rabbitmq-c: amqp_ssl_socket.h
> >       select BR2_PACKAGE_RABBITMQ_C
> >       help
> >         Communicate with any AMQP compliant server.
> >
> >         http://pecl.php.net/package/amqp
> >
> > -comment "php-amqp needs a toolchain w/ threads"
> > -     depends on !BR2_TOOLCHAIN_HAS_THREADS
> > +comment "php-amqp needs a toolchain w/ dynamic library, threads"
> > +     depends on BR2_STATIC_LIBS || !BR2_TOOLCHAIN_HAS_THREADS
>
> baruch
>
> --
>      http://baruch.siach.name/blog/                  ~. .~   Tk Open
> Systems
> =}------------------------------------------------ooO--U--
> Ooo------------{=
>    - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
>
Best Regards,

Fabrice
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180604/29baad23/attachment.html>

[Buildroot] [PATCH 1/1] php-amqp: selects openssl

[Baruch Siach]

Hi Fabrice,

On Mon, Jun 04, 2018 at 07:30:37AM +0200, Fabrice Fontaine wrote:
> 2018-06-04 4:32 GMT+02:00 Baruch Siach <baruch@tkos.co.il>:
> > On Sun, Jun 03, 2018 at 09:31:26PM +0200, Fabrice Fontaine wrote:
> > > php-amqp needs a rabbitmq-c with openssl support:
> > > https://github.com/pdezwart/php-amqp/issues/310
> > >
> > > Fixes:
> > >  - http://autobuild.buildroot.net/results/b7c89bbbd0ca1df08dd7cbfc90c7b4
> > 5dcf1fad05
> > >
> > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> > > ---
> > >  package/php-amqp/Config.in | 6 ++++--
> > >  1 file changed, 4 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/package/php-amqp/Config.in b/package/php-amqp/Config.in
> > > index 0aa2021f5a..cf32ec10b2 100644
> > > --- a/package/php-amqp/Config.in
> > > +++ b/package/php-amqp/Config.in
> > > @@ -1,12 +1,14 @@
> > >  config BR2_PACKAGE_PHP_AMQP
> > >       bool "php-amqp"
> > >       depends on BR2_PACKAGE_PHP
> > > +     depends on !BR2_STATIC_LIBS # rabbitmq-c: amqp_ssl_socket.h
> >
> > Why is this needed? rabbitmq-c does not depend on !BR2_STATIC_LIBS.
> >
> This is needed because openssl supports in rabbitmq-c has been disabled in
> static mode since May 2017: http://patchwork.ozlabs.org/patch/762183.
> But perhaps it would be better to make all rabbitmq-c depends on
> !BR2_STATIC_LIBS as suggested by Peter back in May 2017.

Thanks for the explanation. Please add it to the commit log.

In addition, it might be good time to check whether openssl detection in cmake 
has improved since May 2017.

baruch

> > >       depends on BR2_TOOLCHAIN_HAS_THREADS # rabbitmq-c
> > > +     select BR2_PACKAGE_OPENSSL # rabbitmq-c: amqp_ssl_socket.h
> > >       select BR2_PACKAGE_RABBITMQ_C
> > >       help
> > >         Communicate with any AMQP compliant server.
> > >
> > >         http://pecl.php.net/package/amqp
> > >
> > > -comment "php-amqp needs a toolchain w/ threads"
> > > -     depends on !BR2_TOOLCHAIN_HAS_THREADS
> > > +comment "php-amqp needs a toolchain w/ dynamic library, threads"
> > > +     depends on BR2_STATIC_LIBS || !BR2_TOOLCHAIN_HAS_THREADS

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

[Buildroot] [PATCH 1/1] php-amqp: selects openssl

[Thomas Petazzoni]

Hello,

On Mon, 4 Jun 2018 07:25:05 +0200, Fabrice Fontaine wrote:

> > We've had php-amqp since October 2016 and the last version bump is from
> > May 2017, i.e a year ago. What has changed that makes php-amqp now
> > require OpenSSL support in rabbitmq-c ?
> >  
> SSL connection supports in php-amqp was added in 1.8.0beta2:
> https://github.com/pdezwart/php-amqp/commit/83defa18d958503a395e928d4669a23041014b2e
> .
> So it was introduced in buildroot by the bump to version 1.9.0 in May 2017.
> In autobuilders, we have three errors with php-amqp:
> http://autobuild.buildroot.net/?reason=php-amqp-1.9.0.
> The three errors are all related to SSL and the older one is from February
> 2018 but I suppose that autobuilder results are deleted after some time?

No, autobuilder results are never deleted.

Except in October 2017, when I had a hard disk crash, and we lost all
the autobuilder results that we had back then. But since October 2017,
all autobuilder results are there.

Strange that this problem did not occur more often. Only 3 times since
October 2017. But OK, it happened once in February 2018, once in May
2018 and more recently in June.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH 1/1] php-amqp: selects openssl

[Fabrice Fontaine]

Dear Baruch,

2018-06-04 7:43 GMT+02:00 Baruch Siach <baruch@tkos.co.il>:

> Hi Fabrice,
>
> On Mon, Jun 04, 2018 at 07:30:37AM +0200, Fabrice Fontaine wrote:
> > 2018-06-04 4:32 GMT+02:00 Baruch Siach <baruch@tkos.co.il>:
> > > On Sun, Jun 03, 2018 at 09:31:26PM +0200, Fabrice Fontaine wrote:
> > > > php-amqp needs a rabbitmq-c with openssl support:
> > > > https://github.com/pdezwart/php-amqp/issues/310
> > > >
> > > > Fixes:
> > > >  - http://autobuild.buildroot.net/results/b7c89bbbd0ca1df08dd7c
> bfc90c7b4
> > > 5dcf1fad05
> > > >
> > > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> > > > ---
> > > >  package/php-amqp/Config.in | 6 ++++--
> > > >  1 file changed, 4 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/package/php-amqp/Config.in b/package/php-amqp/Config.in
> > > > index 0aa2021f5a..cf32ec10b2 100644
> > > > --- a/package/php-amqp/Config.in
> > > > +++ b/package/php-amqp/Config.in
> > > > @@ -1,12 +1,14 @@
> > > >  config BR2_PACKAGE_PHP_AMQP
> > > >       bool "php-amqp"
> > > >       depends on BR2_PACKAGE_PHP
> > > > +     depends on !BR2_STATIC_LIBS # rabbitmq-c: amqp_ssl_socket.h
> > >
> > > Why is this needed? rabbitmq-c does not depend on !BR2_STATIC_LIBS.
> > >
> > This is needed because openssl supports in rabbitmq-c has been disabled
> in
> > static mode since May 2017: http://patchwork.ozlabs.org/patch/762183.
> > But perhaps it would be better to make all rabbitmq-c depends on
> > !BR2_STATIC_LIBS as suggested by Peter back in May 2017.
>
> Thanks for the explanation. Please add it to the commit log.
>
In addition, it might be good time to check whether openssl detection in
> cmake
> has improved since May 2017.
>
Static linking with openssl works with my old cmake (version 3.5.1 released
in May 2016).
Thomas, the autobuilders results from May 2017 are not available anymore,
which version of cmake had an issue?

Nevertheless, I also found out that all PHP external extensions already
depend on !BR2_STATIC_LIBS (as specified in package/Config.in).
So, I will remove this dependency in v2 to keep only the select.

>
> baruch
>
> > > >       depends on BR2_TOOLCHAIN_HAS_THREADS # rabbitmq-c
> > > > +     select BR2_PACKAGE_OPENSSL # rabbitmq-c: amqp_ssl_socket.h
> > > >       select BR2_PACKAGE_RABBITMQ_C
> > > >       help
> > > >         Communicate with any AMQP compliant server.
> > > >
> > > >         http://pecl.php.net/package/amqp
> > > >
> > > > -comment "php-amqp needs a toolchain w/ threads"
> > > > -     depends on !BR2_TOOLCHAIN_HAS_THREADS
> > > > +comment "php-amqp needs a toolchain w/ dynamic library, threads"
> > > > +     depends on BR2_STATIC_LIBS || !BR2_TOOLCHAIN_HAS_THREADS
>
> --
>      http://baruch.siach.name/blog/                  ~. .~   Tk Open
> Systems
> =}------------------------------------------------ooO--U--Oo
> o------------{=
>    - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
>
Best Regards,

Fabrice
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180604/e84e015b/attachment.html>

[Buildroot] [PATCH 1/1] php-amqp: selects openssl

[Thomas Petazzoni]

Hello,

On Mon, 4 Jun 2018 18:50:53 +0200, Fabrice Fontaine wrote:

> Static linking with openssl works with my old cmake (version 3.5.1 released
> in May 2016).
> Thomas, the autobuilders results from May 2017 are not available anymore,
> which version of cmake had an issue?

Is this a question for me ? If so, I have absolutely no idea :-)

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH 1/1] php-amqp: selects openssl

[Arnout Vandecappelle]

On 04-06-18 12:12, Thomas Petazzoni wrote:
> Hello,
> 
> On Mon, 4 Jun 2018 07:25:05 +0200, Fabrice Fontaine wrote:
> 
>>> We've had php-amqp since October 2016 and the last version bump is from
>>> May 2017, i.e a year ago. What has changed that makes php-amqp now
>>> require OpenSSL support in rabbitmq-c ?
>>>  
>> SSL connection supports in php-amqp was added in 1.8.0beta2:
>> https://github.com/pdezwart/php-amqp/commit/83defa18d958503a395e928d4669a23041014b2e
>> .
>> So it was introduced in buildroot by the bump to version 1.9.0 in May 2017.
>> In autobuilders, we have three errors with php-amqp:
>> http://autobuild.buildroot.net/?reason=php-amqp-1.9.0.
>> The three errors are all related to SSL and the older one is from February
>> 2018 but I suppose that autobuilder results are deleted after some time?
> 
> No, autobuilder results are never deleted.
> 
> Except in October 2017, when I had a hard disk crash, and we lost all
> the autobuilder results that we had back then. But since October 2017,
> all autobuilder results are there.
> 
> Strange that this problem did not occur more often. Only 3 times since
> October 2017. But OK, it happened once in February 2018, once in May
> 2018 and more recently in June.

 I think that that's because it's very likely that openssl gets selected
somehow. And conversely, it's much less likely that php-amqp gets selected (it
is only selected if php is already selected, so with the average probably of
15%, that would be only 1 out of 45 builds).

 Regards,
 Arnout

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF