* [PATCH net-next] net/mlx5e: Make function mlx5e_change_rep_mtu() static
@ 2018-06-05 2:42 ` Wei Yongjun
0 siblings, 0 replies; 14+ messages in thread
From: Wei Yongjun @ 2018-06-05 2:42 UTC (permalink / raw)
To: Saeed Mahameed, Leon Romanovsky, Adi Nissim
Cc: Wei Yongjun, netdev, linux-rdma, kernel-janitors
Fixes the following sparse warning:
drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:903:5: warning:
symbol 'mlx5e_change_rep_mtu' was not declared. Should it be static?
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
index 3857f22..57987f6 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
@@ -900,7 +900,7 @@ int mlx5e_get_offload_stats(int attr_id, const struct net_device *dev,
.switchdev_port_attr_get = mlx5e_attr_get,
};
-int mlx5e_change_rep_mtu(struct net_device *netdev, int new_mtu)
+static int mlx5e_change_rep_mtu(struct net_device *netdev, int new_mtu)
{
return mlx5e_change_mtu(netdev, new_mtu, NULL);
}
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH net-next] net/mlx5e: Make function mlx5e_change_rep_mtu() static
@ 2018-06-05 2:42 ` Wei Yongjun
0 siblings, 0 replies; 14+ messages in thread
From: Wei Yongjun @ 2018-06-05 2:42 UTC (permalink / raw)
To: Saeed Mahameed, Leon Romanovsky, Adi Nissim
Cc: Wei Yongjun, netdev, linux-rdma, kernel-janitors
Fixes the following sparse warning:
drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:903:5: warning:
symbol 'mlx5e_change_rep_mtu' was not declared. Should it be static?
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
index 3857f22..57987f6 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
@@ -900,7 +900,7 @@ int mlx5e_get_offload_stats(int attr_id, const struct net_device *dev,
.switchdev_port_attr_get = mlx5e_attr_get,
};
-int mlx5e_change_rep_mtu(struct net_device *netdev, int new_mtu)
+static int mlx5e_change_rep_mtu(struct net_device *netdev, int new_mtu)
{
return mlx5e_change_mtu(netdev, new_mtu, NULL);
}
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH net-next] net/mlx5e: Make function mlx5e_change_rep_mtu() static
@ 2018-06-05 2:42 ` Wei Yongjun
0 siblings, 0 replies; 14+ messages in thread
From: Wei Yongjun @ 2018-06-05 2:42 UTC (permalink / raw)
To: Saeed Mahameed, Leon Romanovsky, Adi Nissim
Cc: Wei Yongjun, netdev, linux-rdma, kernel-janitors
Fixes the following sparse warning:
drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:903:5: warning:
symbol 'mlx5e_change_rep_mtu' was not declared. Should it be static?
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
index 3857f22..57987f6 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
@@ -900,7 +900,7 @@ int mlx5e_get_offload_stats(int attr_id, const struct net_device *dev,
.switchdev_port_attr_get = mlx5e_attr_get,
};
-int mlx5e_change_rep_mtu(struct net_device *netdev, int new_mtu)
+static int mlx5e_change_rep_mtu(struct net_device *netdev, int new_mtu)
{
return mlx5e_change_mtu(netdev, new_mtu, NULL);
}
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH net-next] net/mlx5e: Make function mlx5e_change_rep_mtu() static
2018-06-05 2:42 ` Wei Yongjun
@ 2018-06-05 4:20 ` Leon Romanovsky
-1 siblings, 0 replies; 14+ messages in thread
From: Leon Romanovsky @ 2018-06-05 4:20 UTC (permalink / raw)
To: Wei Yongjun
Cc: Saeed Mahameed, Adi Nissim, netdev, linux-rdma, kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 472 bytes --]
On Tue, Jun 05, 2018 at 02:42:45AM +0000, Wei Yongjun wrote:
> Fixes the following sparse warning:
>
> drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:903:5: warning:
> symbol 'mlx5e_change_rep_mtu' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH net-next] net/mlx5e: Make function mlx5e_change_rep_mtu() static
@ 2018-06-05 4:20 ` Leon Romanovsky
0 siblings, 0 replies; 14+ messages in thread
From: Leon Romanovsky @ 2018-06-05 4:20 UTC (permalink / raw)
To: Wei Yongjun
Cc: Saeed Mahameed, Adi Nissim, netdev, linux-rdma, kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 472 bytes --]
On Tue, Jun 05, 2018 at 02:42:45AM +0000, Wei Yongjun wrote:
> Fixes the following sparse warning:
>
> drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:903:5: warning:
> symbol 'mlx5e_change_rep_mtu' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH net-next] net/mlx5e: Make function mlx5e_change_rep_mtu() static
2018-06-05 2:42 ` Wei Yongjun
@ 2018-06-05 14:20 ` David Miller
-1 siblings, 0 replies; 14+ messages in thread
From: David Miller @ 2018-06-05 14:20 UTC (permalink / raw)
To: weiyongjun1; +Cc: saeedm, leon, adin, netdev, linux-rdma, kernel-janitors
From: Wei Yongjun <weiyongjun1@huawei.com>
Date: Tue, 5 Jun 2018 02:42:45 +0000
> Fixes the following sparse warning:
>
> drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:903:5: warning:
> symbol 'mlx5e_change_rep_mtu' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH net-next] net/mlx5e: Make function mlx5e_change_rep_mtu() static
@ 2018-06-05 14:20 ` David Miller
0 siblings, 0 replies; 14+ messages in thread
From: David Miller @ 2018-06-05 14:20 UTC (permalink / raw)
To: weiyongjun1; +Cc: saeedm, leon, adin, netdev, linux-rdma, kernel-janitors
From: Wei Yongjun <weiyongjun1@huawei.com>
Date: Tue, 5 Jun 2018 02:42:45 +0000
> Fixes the following sparse warning:
>
> drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:903:5: warning:
> symbol 'mlx5e_change_rep_mtu' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH net-next] net/mlx5e: Make function mlx5i_grp_sw_update_stats() static
@ 2018-09-05 11:16 ` Wei Yongjun
0 siblings, 0 replies; 14+ messages in thread
From: Wei Yongjun @ 2018-09-05 11:16 UTC (permalink / raw)
To: Saeed Mahameed, Leon Romanovsky, Jason Gunthorpe, Or Gerlitz,
Tariq Toukan, Feras Daoud, Alex Vesker, Erez Shitrit
Cc: Wei Yongjun, netdev, linux-rdma, kernel-janitors
Fixes the following sparse warning:
drivers/net/ethernet/mellanox/mlx5/core/ipoib/ipoib.c:119:6: warning:
symbol 'mlx5i_grp_sw_update_stats' was not declared. Should it be static?
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/net/ethernet/mellanox/mlx5/core/ipoib/ipoib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/ipoib/ipoib.c b/drivers/net/ethernet/mellanox/mlx5/core/ipoib/ipoib.c
index 48886b3..3dd9f88 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/ipoib/ipoib.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/ipoib/ipoib.c
@@ -116,7 +116,7 @@ static void mlx5i_cleanup(struct mlx5e_priv *priv)
/* Do nothing .. */
}
-void mlx5i_grp_sw_update_stats(struct mlx5e_priv *priv)
+static void mlx5i_grp_sw_update_stats(struct mlx5e_priv *priv)
{
struct mlx5e_sw_stats s = { 0 };
int i, j;
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH net-next] net/mlx5e: Make function mlx5i_grp_sw_update_stats() static
@ 2018-09-05 11:16 ` Wei Yongjun
0 siblings, 0 replies; 14+ messages in thread
From: Wei Yongjun @ 2018-09-05 11:16 UTC (permalink / raw)
To: Saeed Mahameed, Leon Romanovsky, Jason Gunthorpe, Or Gerlitz,
Tariq Toukan, Feras Daoud, Alex Vesker, Erez Shitrit
Cc: Wei Yongjun, netdev, linux-rdma, kernel-janitors
Fixes the following sparse warning:
drivers/net/ethernet/mellanox/mlx5/core/ipoib/ipoib.c:119:6: warning:
symbol 'mlx5i_grp_sw_update_stats' was not declared. Should it be static?
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/net/ethernet/mellanox/mlx5/core/ipoib/ipoib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/ipoib/ipoib.c b/drivers/net/ethernet/mellanox/mlx5/core/ipoib/ipoib.c
index 48886b3..3dd9f88 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/ipoib/ipoib.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/ipoib/ipoib.c
@@ -116,7 +116,7 @@ static void mlx5i_cleanup(struct mlx5e_priv *priv)
/* Do nothing .. */
}
-void mlx5i_grp_sw_update_stats(struct mlx5e_priv *priv)
+static void mlx5i_grp_sw_update_stats(struct mlx5e_priv *priv)
{
struct mlx5e_sw_stats s = { 0 };
int i, j;
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH net-next] net/mlx5e: Make function mlx5i_grp_sw_update_stats() static
@ 2018-09-05 11:16 ` Wei Yongjun
0 siblings, 0 replies; 14+ messages in thread
From: Wei Yongjun @ 2018-09-05 11:16 UTC (permalink / raw)
To: Saeed Mahameed, Leon Romanovsky, Jason Gunthorpe, Or Gerlitz,
Tariq Toukan, Feras Daoud, Alex Vesker, Erez Shitrit
Cc: Wei Yongjun, netdev, linux-rdma, kernel-janitors
Fixes the following sparse warning:
drivers/net/ethernet/mellanox/mlx5/core/ipoib/ipoib.c:119:6: warning:
symbol 'mlx5i_grp_sw_update_stats' was not declared. Should it be static?
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/net/ethernet/mellanox/mlx5/core/ipoib/ipoib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/ipoib/ipoib.c b/drivers/net/ethernet/mellanox/mlx5/core/ipoib/ipoib.c
index 48886b3..3dd9f88 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/ipoib/ipoib.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/ipoib/ipoib.c
@@ -116,7 +116,7 @@ static void mlx5i_cleanup(struct mlx5e_priv *priv)
/* Do nothing .. */
}
-void mlx5i_grp_sw_update_stats(struct mlx5e_priv *priv)
+static void mlx5i_grp_sw_update_stats(struct mlx5e_priv *priv)
{
struct mlx5e_sw_stats s = { 0 };
int i, j;
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH net-next] net/mlx5e: Make function mlx5i_grp_sw_update_stats() static
2018-09-05 11:16 ` Wei Yongjun
@ 2018-09-05 11:25 ` Leon Romanovsky
-1 siblings, 0 replies; 14+ messages in thread
From: Leon Romanovsky @ 2018-09-05 11:25 UTC (permalink / raw)
To: Wei Yongjun
Cc: Saeed Mahameed, Jason Gunthorpe, Or Gerlitz, Tariq Toukan,
Feras Daoud, Alex Vesker, Erez Shitrit, netdev, linux-rdma,
kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 487 bytes --]
On Wed, Sep 05, 2018 at 11:16:02AM +0000, Wei Yongjun wrote:
> Fixes the following sparse warning:
>
> drivers/net/ethernet/mellanox/mlx5/core/ipoib/ipoib.c:119:6: warning:
> symbol 'mlx5i_grp_sw_update_stats' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/ipoib/ipoib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH net-next] net/mlx5e: Make function mlx5i_grp_sw_update_stats() static
@ 2018-09-05 11:25 ` Leon Romanovsky
0 siblings, 0 replies; 14+ messages in thread
From: Leon Romanovsky @ 2018-09-05 11:25 UTC (permalink / raw)
To: Wei Yongjun
Cc: Saeed Mahameed, Jason Gunthorpe, Or Gerlitz, Tariq Toukan,
Feras Daoud, Alex Vesker, Erez Shitrit, netdev, linux-rdma,
kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 487 bytes --]
On Wed, Sep 05, 2018 at 11:16:02AM +0000, Wei Yongjun wrote:
> Fixes the following sparse warning:
>
> drivers/net/ethernet/mellanox/mlx5/core/ipoib/ipoib.c:119:6: warning:
> symbol 'mlx5i_grp_sw_update_stats' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/ipoib/ipoib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH net-next] net/mlx5e: Make function mlx5i_grp_sw_update_stats() static
2018-09-05 11:16 ` Wei Yongjun
@ 2018-09-05 15:06 ` David Miller
-1 siblings, 0 replies; 14+ messages in thread
From: David Miller @ 2018-09-05 15:06 UTC (permalink / raw)
To: weiyongjun1
Cc: saeedm, leon, jgg, ogerlitz, tariqt, ferasda, valex, erezsh,
netdev, linux-rdma, kernel-janitors
From: Wei Yongjun <weiyongjun1@huawei.com>
Date: Wed, 5 Sep 2018 11:16:02 +0000
> Fixes the following sparse warning:
>
> drivers/net/ethernet/mellanox/mlx5/core/ipoib/ipoib.c:119:6: warning:
> symbol 'mlx5i_grp_sw_update_stats' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH net-next] net/mlx5e: Make function mlx5i_grp_sw_update_stats() static
@ 2018-09-05 15:06 ` David Miller
0 siblings, 0 replies; 14+ messages in thread
From: David Miller @ 2018-09-05 15:06 UTC (permalink / raw)
To: weiyongjun1
Cc: saeedm, leon, jgg, ogerlitz, tariqt, ferasda, valex, erezsh,
netdev, linux-rdma, kernel-janitors
From: Wei Yongjun <weiyongjun1@huawei.com>
Date: Wed, 5 Sep 2018 11:16:02 +0000
> Fixes the following sparse warning:
>
> drivers/net/ethernet/mellanox/mlx5/core/ipoib/ipoib.c:119:6: warning:
> symbol 'mlx5i_grp_sw_update_stats' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2018-09-05 15:35 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-05 2:42 [PATCH net-next] net/mlx5e: Make function mlx5e_change_rep_mtu() static Wei Yongjun
2018-06-05 2:42 ` Wei Yongjun
2018-06-05 2:42 ` Wei Yongjun
2018-06-05 4:20 ` Leon Romanovsky
2018-06-05 4:20 ` Leon Romanovsky
2018-06-05 14:20 ` David Miller
2018-06-05 14:20 ` David Miller
2018-09-05 11:16 [PATCH net-next] net/mlx5e: Make function mlx5i_grp_sw_update_stats() static Wei Yongjun
2018-09-05 11:16 ` Wei Yongjun
2018-09-05 11:16 ` Wei Yongjun
2018-09-05 11:25 ` Leon Romanovsky
2018-09-05 11:25 ` Leon Romanovsky
2018-09-05 15:06 ` David Miller
2018-09-05 15:06 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.