From: Peter Zijlstra <peterz@infradead.org>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: rjw@rjwysocki.net, linux-kernel@vger.kernel.org,
Viresh Kumar <viresh.kumar@linaro.org>,
Eduardo Valentin <edubezval@gmail.com>,
Javi Merino <javi.merino@kernel.org>,
Leo Yan <leo.yan@linaro.org>,
Kevin Wangtao <kevin.wangtao@linaro.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
Rui Zhang <rui.zhang@intel.com>,
Daniel Thompson <daniel.thompson@linaro.org>,
"open list:POWER MANAGEMENT CORE" <linux-pm@vger.kernel.org>
Subject: Re: [PATCH V5] powercap/drivers/idle_injection: Add an idle injection framework
Date: Wed, 6 Jun 2018 14:23:57 +0200 [thread overview]
Message-ID: <20180606122357.GN12258@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <1528190208-22915-1-git-send-email-daniel.lezcano@linaro.org>
On Tue, Jun 05, 2018 at 11:16:40AM +0200, Daniel Lezcano wrote:
> + atomic_t idle_duration_ms;
> + atomic_t run_duration_ms;
> + idle_duration_ms = atomic_read(&ii_dev->idle_duration_ms);
> + run_duration_ms = atomic_read(&ii_dev->run_duration_ms);
> + atomic_set(&ii_dev->run_duration_ms, run_duration_ms);
> + atomic_set(&ii_dev->idle_duration_ms, idle_duration_ms);
> + *run_duration_ms = atomic_read(&ii_dev->run_duration_ms);
> + *idle_duration_ms = atomic_read(&ii_dev->idle_duration_ms);
> + if (!atomic_read(&ii_dev->idle_duration_ms))
> + if (!atomic_read(&ii_dev->run_duration_ms))
What is the point of atomic_t here ?!
next prev parent reply other threads:[~2018-06-06 12:24 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-05 9:16 [PATCH V5] powercap/drivers/idle_injection: Add an idle injection framework Daniel Lezcano
2018-06-05 9:16 ` Daniel Lezcano
2018-06-05 10:39 ` Viresh Kumar
2018-06-05 14:54 ` Daniel Lezcano
2018-06-06 4:27 ` Viresh Kumar
2018-06-06 10:22 ` Daniel Lezcano
2018-06-06 10:45 ` Viresh Kumar
2018-06-06 12:05 ` Andrea Parri
2018-06-06 12:29 ` Peter Zijlstra
2018-06-07 14:11 ` Daniel Lezcano
2018-06-08 4:48 ` Viresh Kumar
2018-06-08 8:31 ` Daniel Lezcano
2018-06-06 12:23 ` Peter Zijlstra [this message]
2018-06-06 13:42 ` Daniel Lezcano
2018-06-06 15:02 ` Peter Zijlstra
2018-06-07 8:18 ` Daniel Lezcano
2018-06-07 8:32 ` Peter Zijlstra
2018-06-07 8:42 ` Viresh Kumar
2018-06-07 8:46 ` Daniel Lezcano
2018-06-07 8:49 ` Viresh Kumar
2018-06-07 9:09 ` Daniel Lezcano
2018-06-07 9:32 ` Peter Zijlstra
2018-06-07 9:39 ` Peter Zijlstra
2018-06-07 12:31 ` Daniel Lezcano
2018-06-07 9:09 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180606122357.GN12258@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=daniel.lezcano@linaro.org \
--cc=daniel.thompson@linaro.org \
--cc=edubezval@gmail.com \
--cc=javi.merino@kernel.org \
--cc=kevin.wangtao@linaro.org \
--cc=leo.yan@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.