All of lore.kernel.org
 help / color / mirror / Atom feed
* master - lvmlockd: fix missing lock_type null check
@ 2018-06-06 18:58 David Teigland
  0 siblings, 0 replies; 2+ messages in thread
From: David Teigland @ 2018-06-06 18:58 UTC (permalink / raw)
  To: lvm-devel

Gitweb:        https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=3c657adc0a2c9026fef3186147f0d9a11b071c3b
Commit:        3c657adc0a2c9026fef3186147f0d9a11b071c3b
Parent:        c67bd8b47b755a33104e942abc49e516d2a6dace
Author:        David Teigland <teigland@redhat.com>
AuthorDate:    Wed Jun 6 13:56:02 2018 -0500
Committer:     David Teigland <teigland@redhat.com>
CommitterDate: Wed Jun 6 13:58:03 2018 -0500

lvmlockd: fix missing lock_type null check

Missed checking if vg->lock_type is NULL in commit db8d3bdfa:
  lvmlockd: enable mirror split and merge with dlm lock_type
---
 lib/metadata/raid_manip.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/metadata/raid_manip.c b/lib/metadata/raid_manip.c
index 4d58d74..53aa4f1 100644
--- a/lib/metadata/raid_manip.c
+++ b/lib/metadata/raid_manip.c
@@ -3395,7 +3395,7 @@ int lv_raid_split(struct logical_volume *lv, int yes, const char *split_name,
 
 	lvl->lv->name = split_name;
 
-	if (!strcmp(lv->vg->lock_type, "dlm"))
+	if (lv->vg->lock_type && !strcmp(lv->vg->lock_type, "dlm"))
 		lvl->lv->lock_args = lv->lock_args;
 
 	if (!vg_write(lv->vg)) {



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* master - lvmlockd: fix missing lock_type null check
@ 2018-06-07 15:21 Joe Thornber
  0 siblings, 0 replies; 2+ messages in thread
From: Joe Thornber @ 2018-06-07 15:21 UTC (permalink / raw)
  To: lvm-devel

Gitweb:        https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=d154dd66382d1bab4c227f6b3aaa12b6ccbb491f
Commit:        d154dd66382d1bab4c227f6b3aaa12b6ccbb491f
Parent:        1539e51721418768eae894c0179a82cf5ab8e040
Author:        David Teigland <teigland@redhat.com>
AuthorDate:    Wed Jun 6 13:56:02 2018 -0500
Committer:     Joe Thornber <ejt@redhat.com>
CommitterDate: Thu Jun 7 16:17:04 2018 +0100

lvmlockd: fix missing lock_type null check

Missed checking if vg->lock_type is NULL in commit db8d3bdfa:
  lvmlockd: enable mirror split and merge with dlm lock_type
---
 lib/metadata/raid_manip.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/metadata/raid_manip.c b/lib/metadata/raid_manip.c
index 4d58d74..53aa4f1 100644
--- a/lib/metadata/raid_manip.c
+++ b/lib/metadata/raid_manip.c
@@ -3395,7 +3395,7 @@ int lv_raid_split(struct logical_volume *lv, int yes, const char *split_name,
 
 	lvl->lv->name = split_name;
 
-	if (!strcmp(lv->vg->lock_type, "dlm"))
+	if (lv->vg->lock_type && !strcmp(lv->vg->lock_type, "dlm"))
 		lvl->lv->lock_args = lv->lock_args;
 
 	if (!vg_write(lv->vg)) {



^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-06-07 15:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-06 18:58 master - lvmlockd: fix missing lock_type null check David Teigland
2018-06-07 15:21 Joe Thornber

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.