Re: [PATCH] drm/i915/gtt: Invalidate GGTT caches after writing the gen6 page directories

From: kbuild test robot <lkp@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org, kbuild-all@01.org
Subject: Re: [PATCH] drm/i915/gtt: Invalidate GGTT caches after writing the gen6 page directories
Date: Thu, 7 Jun 2018 02:07:22 +0800	[thread overview]
Message-ID: <201806070005.pyQcBnvg%fengguang.wu@intel.com> (raw)
In-Reply-To: <20180605201624.15604-1-chris@chris-wilson.co.uk>

[-- Attachment #1: Type: text/plain, Size: 1946 bytes --]

Hi Chris,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on v4.17 next-20180605]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Chris-Wilson/drm-i915-gtt-Invalidate-GGTT-caches-after-writing-the-gen6-page-directories/20180607-003348
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-randconfig-x007-201822 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/gpu/drm/i915/i915_gem_gtt.c: In function 'gen6_write_page_range':
>> drivers/gpu/drm/i915/i915_gem_gtt.c:1747:28: error: 'struct i915_hw_ppgtt' has no member named 'vm'
     gen6_ggtt_invalidate(ppgtt->vm.i915);
                               ^~
   drivers/gpu/drm/i915/i915_gem_gtt.c: In function 'gen6_alloc_va_range':
   drivers/gpu/drm/i915/i915_gem_gtt.c:1963:29: error: 'struct i915_hw_ppgtt' has no member named 'vm'
      gen6_ggtt_invalidate(ppgtt->vm.i915);
                                ^~

vim +1747 drivers/gpu/drm/i915/i915_gem_gtt.c

  1734	
  1735	/* Write all the page tables found in the ppgtt structure to incrementing page
  1736	 * directories. */
  1737	static void gen6_write_page_range(struct i915_hw_ppgtt *ppgtt,
  1738					  u32 start, u32 length)
  1739	{
  1740		struct i915_page_table *pt;
  1741		unsigned int pde;
  1742	
  1743		gen6_for_each_pde(pt, &ppgtt->pd, start, length, pde)
  1744			gen6_write_pde(ppgtt, pde, pt);
  1745	
  1746		mark_tlbs_dirty(ppgtt);
> 1747		gen6_ggtt_invalidate(ppgtt->vm.i915);
  1748	}
  1749	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 33107 bytes --]

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx