* [PATCH] blktrace: display failfast and driver-specific flags
@ 2018-06-07 8:30 ` Hannes Reinecke
0 siblings, 0 replies; 6+ messages in thread
From: Hannes Reinecke @ 2018-06-07 8:30 UTC (permalink / raw)
To: Jens Axboe
Cc: Christoph Hellwig, Sagi Grimberg, Keith Busch, linux-nvme,
linux-block, Hannes Reinecke, Hannes Reinecke
Signed-off-by: Hannes Reinecke <hare@suse.com>
---
kernel/trace/blktrace.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c
index 987d9a9ae283..238e16211a5c 100644
--- a/kernel/trace/blktrace.c
+++ b/kernel/trace/blktrace.c
@@ -1922,6 +1922,14 @@ void blk_fill_rwbs(char *rwbs, unsigned int op, int bytes)
rwbs[i++] = 'S';
if (op & REQ_META)
rwbs[i++] = 'M';
+ if (op & REQ_FAILFAST_DEV)
+ rwbs[i++] = 'd';
+ if (op & REQ_FAILFAST_TRANSPORT)
+ rwbs[i++] = 't';
+ if (op & REQ_FAILFAST_DRIVER)
+ rwbs[i++] = 'v';
+ if (op & REQ_DRV)
+ rwbs[i++] = 'V';
rwbs[i] = '\0';
}
--
2.12.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] blktrace: display failfast and driver-specific flags
@ 2018-06-07 8:30 ` Hannes Reinecke
0 siblings, 0 replies; 6+ messages in thread
From: Hannes Reinecke @ 2018-06-07 8:30 UTC (permalink / raw)
Signed-off-by: Hannes Reinecke <hare at suse.com>
---
kernel/trace/blktrace.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c
index 987d9a9ae283..238e16211a5c 100644
--- a/kernel/trace/blktrace.c
+++ b/kernel/trace/blktrace.c
@@ -1922,6 +1922,14 @@ void blk_fill_rwbs(char *rwbs, unsigned int op, int bytes)
rwbs[i++] = 'S';
if (op & REQ_META)
rwbs[i++] = 'M';
+ if (op & REQ_FAILFAST_DEV)
+ rwbs[i++] = 'd';
+ if (op & REQ_FAILFAST_TRANSPORT)
+ rwbs[i++] = 't';
+ if (op & REQ_FAILFAST_DRIVER)
+ rwbs[i++] = 'v';
+ if (op & REQ_DRV)
+ rwbs[i++] = 'V';
rwbs[i] = '\0';
}
--
2.12.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] blktrace: display failfast and driver-specific flags
2018-06-07 8:30 ` Hannes Reinecke
@ 2018-06-07 11:24 ` Christoph Hellwig
-1 siblings, 0 replies; 6+ messages in thread
From: Christoph Hellwig @ 2018-06-07 11:24 UTC (permalink / raw)
To: Hannes Reinecke
Cc: Jens Axboe, Christoph Hellwig, Sagi Grimberg, Keith Busch,
linux-nvme, linux-block, Hannes Reinecke
Good idea to display the flags, but the characters aren't really
very self-describing. Should we prefix each with an f maybe?
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] blktrace: display failfast and driver-specific flags
@ 2018-06-07 11:24 ` Christoph Hellwig
0 siblings, 0 replies; 6+ messages in thread
From: Christoph Hellwig @ 2018-06-07 11:24 UTC (permalink / raw)
Good idea to display the flags, but the characters aren't really
very self-describing. Should we prefix each with an f maybe?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] blktrace: display failfast and driver-specific flags
2018-06-07 11:24 ` Christoph Hellwig
@ 2018-06-08 5:53 ` Hannes Reinecke
-1 siblings, 0 replies; 6+ messages in thread
From: Hannes Reinecke @ 2018-06-08 5:53 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Jens Axboe, Sagi Grimberg, Keith Busch, linux-nvme, linux-block,
Hannes Reinecke
On Thu, 7 Jun 2018 13:24:23 +0200
Christoph Hellwig <hch@lst.de> wrote:
> Good idea to display the flags, but the characters aren't really
> very self-describing. Should we prefix each with an f maybe?
Honestly, I don't care.
Just wanted to stick with the one-letter acronym like all the others
did.
But in the end having the failfast ones prefixed with an 'f' sounds
reasonable.
Cheers,
Hannes
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] blktrace: display failfast and driver-specific flags
@ 2018-06-08 5:53 ` Hannes Reinecke
0 siblings, 0 replies; 6+ messages in thread
From: Hannes Reinecke @ 2018-06-08 5:53 UTC (permalink / raw)
On Thu, 7 Jun 2018 13:24:23 +0200
Christoph Hellwig <hch@lst.de> wrote:
> Good idea to display the flags, but the characters aren't really
> very self-describing. Should we prefix each with an f maybe?
Honestly, I don't care.
Just wanted to stick with the one-letter acronym like all the others
did.
But in the end having the failfast ones prefixed with an 'f' sounds
reasonable.
Cheers,
Hannes
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-06-08 5:53 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-07 8:30 [PATCH] blktrace: display failfast and driver-specific flags Hannes Reinecke
2018-06-07 8:30 ` Hannes Reinecke
2018-06-07 11:24 ` Christoph Hellwig
2018-06-07 11:24 ` Christoph Hellwig
2018-06-08 5:53 ` Hannes Reinecke
2018-06-08 5:53 ` Hannes Reinecke
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.