All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Subject: [PATCH 16/17] drm/i915/gtt: Skip clearing the GGTT under gen6+ full-ppgtt
Date: Sun, 10 Jun 2018 20:43:24 +0100	[thread overview]
Message-ID: <20180610194325.13467-17-chris@chris-wilson.co.uk> (raw)
In-Reply-To: <20180610194325.13467-1-chris@chris-wilson.co.uk>

If we know that the user cannot access the GGTT, by virtue of having a
segregated memory area, we can skip clearing the unused entries as they
cannot be accessed.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: Matthew Auld <matthew.william.auld@gmail.com>
---
 drivers/gpu/drm/i915/i915_gem_gtt.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
index e5381d6dfbc8..5795934918ab 100644
--- a/drivers/gpu/drm/i915/i915_gem_gtt.c
+++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
@@ -3383,7 +3383,9 @@ static int gen6_gmch_probe(struct i915_ggtt *ggtt)
 	size = gen6_get_total_gtt_size(snb_gmch_ctl);
 	ggtt->vm.total = (size / sizeof(gen6_pte_t)) << PAGE_SHIFT;
 
-	ggtt->vm.clear_range = gen6_ggtt_clear_range;
+	ggtt->vm.clear_range = nop_clear_range;
+	if (!USES_FULL_PPGTT(dev_priv) || intel_scanout_needs_vtd_wa(dev_priv))
+		ggtt->vm.clear_range = gen6_ggtt_clear_range;
 	ggtt->vm.insert_page = gen6_ggtt_insert_page;
 	ggtt->vm.insert_entries = gen6_ggtt_insert_entries;
 	ggtt->vm.cleanup = gen6_gmch_remove;
-- 
2.17.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2018-06-10 19:44 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-10 19:43 Haswell full-ppgtt Chris Wilson
2018-06-10 19:43 ` [PATCH 01/17] drm/i915: Apply batch location restrictions before pinning Chris Wilson
2018-06-11  9:57   ` Joonas Lahtinen
2018-06-11 10:08     ` Chris Wilson
2018-06-10 19:43 ` [PATCH 02/17] drm/i915/ringbuffer: Brute force context restore Chris Wilson
2018-06-11 10:00   ` Tvrtko Ursulin
2018-06-11 10:04     ` Chris Wilson
2018-06-11 10:23       ` Tvrtko Ursulin
2018-06-11 10:33         ` Chris Wilson
2018-06-11 10:07   ` Mika Kuoppala
2018-06-11 10:11   ` Joonas Lahtinen
2018-06-10 19:43 ` [PATCH 03/17] drm/i915/ringbuffer: Fix context restore upon reset Chris Wilson
2018-06-11 10:28   ` Joonas Lahtinen
2018-06-10 19:43 ` [PATCH 04/17] drm/i915: Wrap around the tail offset before setting ring->tail Chris Wilson
2018-06-11 10:16   ` Mika Kuoppala
2018-06-11 10:26     ` Chris Wilson
2018-06-11 10:40       ` Mika Kuoppala
2018-06-11 10:30   ` Joonas Lahtinen
2018-06-10 19:43 ` [PATCH 05/17] drm/i915/gtt: Invalidate GGTT caches after writing the gen6 page directories Chris Wilson
2018-06-11 10:37   ` Joonas Lahtinen
2018-06-10 19:43 ` [PATCH 06/17] drm/i915/ringbuffer: Serialize load of PD_DIR Chris Wilson
2018-06-11 10:12   ` Chris Wilson
2018-06-11 10:43   ` Joonas Lahtinen
2018-06-11 10:47     ` Chris Wilson
2018-06-10 19:43 ` [PATCH 07/17] drm/i915/gtt: Subclass gen6_hw_ppgtt Chris Wilson
2018-06-10 19:43 ` [PATCH 08/17] drm/i915/gtt: Onionify error handling for gen6_ppgtt_create Chris Wilson
2018-06-11 10:48   ` Joonas Lahtinen
2018-06-10 19:43 ` [PATCH 09/17] drm/i915/gtt: Make gen6 page directories evictable Chris Wilson
2018-06-11 10:56   ` Joonas Lahtinen
2018-06-10 19:43 ` [PATCH 10/17] drm/i915/gtt: Only keep gen6 page directories pinned while active Chris Wilson
2018-06-10 19:43 ` [PATCH 11/17] drm/i915/gtt: Lazily allocate page directories for gen7 Chris Wilson
2018-06-11 11:03   ` Joonas Lahtinen
2018-06-10 19:43 ` [PATCH 12/17] drm/i915/gtt: Free unused page tables on unbind the context Chris Wilson
2018-06-11 11:09   ` Joonas Lahtinen
2018-06-10 19:43 ` [PATCH 13/17] drm/i915/gtt: Skip initializing PT with scratch if full Chris Wilson
2018-06-10 19:43 ` [PATCH 14/17] drm/i915/gtt: Cache the PTE encoding of the scratch page Chris Wilson
2018-06-10 19:43 ` [PATCH 15/17] drm/i915/gtt: Reduce a pair of runtime asserts Chris Wilson
2018-06-10 19:43 ` Chris Wilson [this message]
2018-06-11  9:28   ` [PATCH 16/17] drm/i915/gtt: Skip clearing the GGTT under gen6+ full-ppgtt Matthew Auld
2018-06-10 19:43 ` [PATCH 17/17] drm/i915/gtt: Enable full-ppgtt by default everywhere Chris Wilson
2018-06-10 20:00 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/17] drm/i915: Apply batch location restrictions before pinning Patchwork
2018-06-10 20:05 ` ✗ Fi.CI.SPARSE: " Patchwork
2018-06-10 20:18 ` ✓ Fi.CI.BAT: success " Patchwork
2018-06-10 21:10 ` ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180610194325.13467-17-chris@chris-wilson.co.uk \
    --to=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.