From: Heikki Krogerus <heikki.krogerus@linux.intel.com> To: Li Jun <jun.li@nxp.com> Cc: robh+dt@kernel.org, gregkh@linuxfoundation.org, linux@roeck-us.net, cw00.choi@samsung.com, a.hajda@samsung.com, shufan_lee@richtek.com, peter.chen@nxp.com, garsilva@embeddedor.com, gsomlo@gmail.com, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-imx@nxp.com Subject: Re: [PATCH v6 06/15] usb: typec: tcpm: support get typec and pd config from device properties Date: Mon, 11 Jun 2018 15:05:16 +0300 [thread overview] Message-ID: <20180611120516.GI17155@kuha.fi.intel.com> (raw) In-Reply-To: <1527475967-15201-7-git-send-email-jun.li@nxp.com> On Mon, May 28, 2018 at 10:52:38AM +0800, Li Jun wrote: > This patch adds support of get typec and power delivery config from > firmware description. > > Signed-off-by: Li Jun <jun.li@nxp.com> This looks good to me, assuming that everybody agrees with the names used in the bindings. As usual, I would like Guenter to check tcpm.c changes. I'm putting a few nitpicks below, but in any case: Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > --- > drivers/usb/typec/tcpm.c | 132 +++++++++++++++++++++++++++++++++++++++-------- > 1 file changed, 110 insertions(+), 22 deletions(-) > > diff --git a/drivers/usb/typec/tcpm.c b/drivers/usb/typec/tcpm.c > index fcd22e8..aa17cd5 100644 > --- a/drivers/usb/typec/tcpm.c > +++ b/drivers/usb/typec/tcpm.c > @@ -4241,6 +4241,81 @@ static int tcpm_copy_vdos(u32 *dest_vdo, const u32 *src_vdo, > return nr_vdo; > } > > +static int tcpm_fw_get_caps(struct tcpm_port *port, > + struct fwnode_handle *fwnode) > +{ > + const char *cap_str; > + int ret; > + u32 mw; > + > + if (!port || !fwnode) if (!fwnode) is enough. > + return -EINVAL; > + > + /* USB data support is optional */ > + ret = fwnode_property_read_string(fwnode, "data-role", &cap_str); > + if (ret == 0) { > + port->typec_caps.data = typec_find_port_data_role(cap_str); > + if (port->typec_caps.data < 0) > + return -EINVAL; > + } > + > + ret = fwnode_property_read_string(fwnode, "power-role", &cap_str); > + if (ret < 0) > + return ret; > + > + port->typec_caps.type = typec_find_port_power_role(cap_str); > + if (port->typec_caps.type < 0) > + return -EINVAL; > + port->port_type = port->typec_caps.type; > + > + if (port->port_type == TYPEC_PORT_SNK) > + goto sink; > + > + /* Get soruce pdos */ s/soruce/source/ > + ret = fwnode_property_read_u32_array(fwnode, "source-pdos", > + NULL, 0); > + if (ret <= 0) > + return -EINVAL; > + > + port->nr_src_pdo = min(ret, PDO_MAX_OBJECTS); > + ret = fwnode_property_read_u32_array(fwnode, "source-pdos", > + port->src_pdo, port->nr_src_pdo); > + if ((ret < 0) || tcpm_validate_caps(port, port->src_pdo, > + port->nr_src_pdo)) > + return -EINVAL; > + > + if (port->port_type == TYPEC_PORT_SRC) > + return 0; > + > + /* Get the preferred power role for DRP */ > + ret = fwnode_property_read_string(fwnode, "try-power-role", &cap_str); > + if (ret < 0) > + return ret; > + > + port->typec_caps.prefer_role = typec_find_power_role(cap_str); > + if (port->typec_caps.prefer_role < 0) > + return -EINVAL; > +sink: > + /* Get sink pdos */ > + ret = fwnode_property_read_u32_array(fwnode, "sink-pdos", > + NULL, 0); > + if (ret <= 0) > + return -EINVAL; > + > + port->nr_snk_pdo = min(ret, PDO_MAX_OBJECTS); > + ret = fwnode_property_read_u32_array(fwnode, "sink-pdos", > + port->snk_pdo, port->nr_snk_pdo); > + if ((ret < 0) || tcpm_validate_caps(port, port->snk_pdo, > + port->nr_snk_pdo)) > + return -EINVAL; > + > + if (fwnode_property_read_u32(fwnode, "op-sink-microwatt", &mw) < 0) > + return -EINVAL; > + port->operating_snk_mw = mw / 1000; > + > + return 0; > +} Thanks, -- heikki
WARNING: multiple messages have this Message-ID (diff)
From: Heikki Krogerus <heikki.krogerus@linux.intel.com> To: Li Jun <jun.li@nxp.com> Cc: robh+dt@kernel.org, gregkh@linuxfoundation.org, linux@roeck-us.net, cw00.choi@samsung.com, a.hajda@samsung.com, shufan_lee@richtek.com, peter.chen@nxp.com, garsilva@embeddedor.com, gsomlo@gmail.com, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-imx@nxp.com Subject: [v6,06/15] usb: typec: tcpm: support get typec and pd config from device properties Date: Mon, 11 Jun 2018 15:05:16 +0300 [thread overview] Message-ID: <20180611120516.GI17155@kuha.fi.intel.com> (raw) On Mon, May 28, 2018 at 10:52:38AM +0800, Li Jun wrote: > This patch adds support of get typec and power delivery config from > firmware description. > > Signed-off-by: Li Jun <jun.li@nxp.com> This looks good to me, assuming that everybody agrees with the names used in the bindings. As usual, I would like Guenter to check tcpm.c changes. I'm putting a few nitpicks below, but in any case: Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > --- > drivers/usb/typec/tcpm.c | 132 +++++++++++++++++++++++++++++++++++++++-------- > 1 file changed, 110 insertions(+), 22 deletions(-) > > diff --git a/drivers/usb/typec/tcpm.c b/drivers/usb/typec/tcpm.c > index fcd22e8..aa17cd5 100644 > --- a/drivers/usb/typec/tcpm.c > +++ b/drivers/usb/typec/tcpm.c > @@ -4241,6 +4241,81 @@ static int tcpm_copy_vdos(u32 *dest_vdo, const u32 *src_vdo, > return nr_vdo; > } > > +static int tcpm_fw_get_caps(struct tcpm_port *port, > + struct fwnode_handle *fwnode) > +{ > + const char *cap_str; > + int ret; > + u32 mw; > + > + if (!port || !fwnode) if (!fwnode) is enough. > + return -EINVAL; > + > + /* USB data support is optional */ > + ret = fwnode_property_read_string(fwnode, "data-role", &cap_str); > + if (ret == 0) { > + port->typec_caps.data = typec_find_port_data_role(cap_str); > + if (port->typec_caps.data < 0) > + return -EINVAL; > + } > + > + ret = fwnode_property_read_string(fwnode, "power-role", &cap_str); > + if (ret < 0) > + return ret; > + > + port->typec_caps.type = typec_find_port_power_role(cap_str); > + if (port->typec_caps.type < 0) > + return -EINVAL; > + port->port_type = port->typec_caps.type; > + > + if (port->port_type == TYPEC_PORT_SNK) > + goto sink; > + > + /* Get soruce pdos */ s/soruce/source/ > + ret = fwnode_property_read_u32_array(fwnode, "source-pdos", > + NULL, 0); > + if (ret <= 0) > + return -EINVAL; > + > + port->nr_src_pdo = min(ret, PDO_MAX_OBJECTS); > + ret = fwnode_property_read_u32_array(fwnode, "source-pdos", > + port->src_pdo, port->nr_src_pdo); > + if ((ret < 0) || tcpm_validate_caps(port, port->src_pdo, > + port->nr_src_pdo)) > + return -EINVAL; > + > + if (port->port_type == TYPEC_PORT_SRC) > + return 0; > + > + /* Get the preferred power role for DRP */ > + ret = fwnode_property_read_string(fwnode, "try-power-role", &cap_str); > + if (ret < 0) > + return ret; > + > + port->typec_caps.prefer_role = typec_find_power_role(cap_str); > + if (port->typec_caps.prefer_role < 0) > + return -EINVAL; > +sink: > + /* Get sink pdos */ > + ret = fwnode_property_read_u32_array(fwnode, "sink-pdos", > + NULL, 0); > + if (ret <= 0) > + return -EINVAL; > + > + port->nr_snk_pdo = min(ret, PDO_MAX_OBJECTS); > + ret = fwnode_property_read_u32_array(fwnode, "sink-pdos", > + port->snk_pdo, port->nr_snk_pdo); > + if ((ret < 0) || tcpm_validate_caps(port, port->snk_pdo, > + port->nr_snk_pdo)) > + return -EINVAL; > + > + if (fwnode_property_read_u32(fwnode, "op-sink-microwatt", &mw) < 0) > + return -EINVAL; > + port->operating_snk_mw = mw / 1000; > + > + return 0; > +} Thanks,
next prev parent reply other threads:[~2018-06-11 12:05 UTC|newest] Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-28 2:52 [PATCH v6 00/15] staging: typec: tcpci: move out of staging Li Jun 2018-05-28 2:52 ` [PATCH v6 01/15] dt-bindings: connector: add properties for typec Li Jun 2018-05-28 2:52 ` [v6,01/15] " Jun Li 2018-05-31 0:13 ` [PATCH v6 01/15] " Rob Herring 2018-05-31 0:13 ` [v6,01/15] " Rob Herring 2018-05-28 2:52 ` [PATCH v6 02/15] dt-bindings: usb: add documentation for typec port controller(TCPCI) Li Jun 2018-05-28 2:52 ` [v6,02/15] " Jun Li 2018-05-28 2:52 ` [PATCH v6 03/15] staging: typec: tcpci: add compatible string for nxp ptn5110 Li Jun 2018-05-28 2:52 ` [v6,03/15] " Jun Li 2018-06-11 12:32 ` [PATCH v6 03/15] " Heikki Krogerus 2018-06-11 12:32 ` [v6,03/15] " Heikki Krogerus 2018-05-28 2:52 ` [PATCH v6 04/15] usb: typec: add fwnode to tcpc Li Jun 2018-05-28 2:52 ` [v6,04/15] " Jun Li 2018-06-11 11:44 ` [PATCH v6 04/15] " Heikki Krogerus 2018-06-11 11:44 ` [v6,04/15] " Heikki Krogerus 2018-05-28 2:52 ` [PATCH v6 05/15] usb: typec: add API to get typec basic port power and data config Li Jun 2018-05-28 2:52 ` [v6,05/15] " Jun Li 2018-05-30 4:25 ` [PATCH v6 05/15] " kbuild test robot 2018-05-30 4:25 ` [v6,05/15] " kbuild test robot 2018-05-30 5:56 ` [PATCH v6 05/15] " Jun Li 2018-05-30 5:56 ` [v6,05/15] " Jun Li 2018-05-30 6:43 ` [PATCH v6 05/15] " kbuild test robot 2018-05-30 6:43 ` [v6,05/15] " kbuild test robot 2018-06-11 11:08 ` [PATCH v6 05/15] " Heikki Krogerus 2018-06-11 11:08 ` [v6,05/15] " Heikki Krogerus 2018-06-13 9:47 ` [PATCH v6 05/15] " Jun Li 2018-06-13 9:47 ` [v6,05/15] " Jun Li 2018-05-28 2:52 ` [PATCH v6 06/15] usb: typec: tcpm: support get typec and pd config from device properties Li Jun 2018-05-28 2:52 ` [v6,06/15] " Jun Li 2018-06-11 12:05 ` Heikki Krogerus [this message] 2018-06-11 12:05 ` Heikki Krogerus 2018-06-11 13:27 ` [PATCH v6 06/15] " Guenter Roeck 2018-06-11 13:27 ` [v6,06/15] " Guenter Roeck 2018-05-28 2:52 ` [PATCH v6 07/15] staging: typec: tcpci: remove unused tcpci_tcpc_config Li Jun 2018-05-28 2:52 ` [v6,07/15] " Jun Li 2018-06-11 12:33 ` [PATCH v6 07/15] " Heikki Krogerus 2018-06-11 12:33 ` [v6,07/15] " Heikki Krogerus 2018-05-28 2:52 ` [PATCH v6 08/15] staging: typec: tcpci: use IS_ERR() instead of PTR_ERR_OR_ZERO() Li Jun 2018-05-28 2:52 ` [v6,08/15] " Jun Li 2018-06-11 12:34 ` [PATCH v6 08/15] " Heikki Krogerus 2018-06-11 12:34 ` [v6,08/15] " Heikki Krogerus 2018-05-28 2:52 ` [PATCH v6 09/15] staging: typec: tcpci: register port before request irq Li Jun 2018-05-28 2:52 ` [v6,09/15] " Jun Li 2018-06-11 12:35 ` [PATCH v6 09/15] " Heikki Krogerus 2018-06-11 12:35 ` [v6,09/15] " Heikki Krogerus 2018-05-28 2:52 ` [PATCH v6 10/15] staging: typec: tcpci: enable vbus detection Li Jun 2018-05-28 2:52 ` [v6,10/15] " Jun Li 2018-06-11 12:36 ` [PATCH v6 10/15] " Heikki Krogerus 2018-06-11 12:36 ` [v6,10/15] " Heikki Krogerus 2018-05-28 2:52 ` [PATCH v6 11/15] typec: tcpm: add starting value for drp toggling Li Jun 2018-05-28 2:52 ` [v6,11/15] " Jun Li 2018-06-11 12:28 ` [PATCH v6 11/15] " Heikki Krogerus 2018-06-11 12:28 ` [v6,11/15] " Heikki Krogerus 2018-05-28 2:52 ` [PATCH v6 12/15] usb: typec: tcpm: set cc for drp toggling attach Li Jun 2018-05-28 2:52 ` [v6,12/15] " Jun Li 2018-06-11 12:29 ` [PATCH v6 12/15] " Heikki Krogerus 2018-06-11 12:29 ` [v6,12/15] " Heikki Krogerus 2018-06-11 13:35 ` [PATCH v6 12/15] " Guenter Roeck 2018-06-11 13:35 ` [v6,12/15] " Guenter Roeck 2018-06-13 11:06 ` [PATCH v6 12/15] " Jun Li 2018-06-13 11:06 ` [v6,12/15] " Jun Li 2018-06-13 11:14 ` [PATCH v6 12/15] " Jun Li 2018-06-13 11:14 ` [v6,12/15] " Jun Li 2018-05-28 2:52 ` [PATCH v6 13/15] staging: typec: tcpci: keep the disconnected cc line open Li Jun 2018-05-28 2:52 ` [v6,13/15] " Jun Li 2018-06-11 13:14 ` [PATCH v6 13/15] " Heikki Krogerus 2018-06-11 13:14 ` [v6,13/15] " Heikki Krogerus 2018-05-28 2:52 ` [PATCH v6 14/15] staging: typec: tcpci: Only touch target bit when enable vconn Li Jun 2018-05-28 2:52 ` [v6,14/15] " Jun Li 2018-06-11 13:15 ` [PATCH v6 14/15] " Heikki Krogerus 2018-06-11 13:15 ` [v6,14/15] " Heikki Krogerus 2018-05-28 2:52 ` [PATCH v6 15/15] staging: typec: tcpci: move tcpci drivers out of staging Li Jun 2018-05-28 2:52 ` [v6,15/15] " Jun Li 2018-06-06 21:44 ` [PATCH v6 00/15] staging: typec: tcpci: move " Mats Karrman 2018-06-07 0:47 ` Jun Li
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180611120516.GI17155@kuha.fi.intel.com \ --to=heikki.krogerus@linux.intel.com \ --cc=a.hajda@samsung.com \ --cc=cw00.choi@samsung.com \ --cc=devicetree@vger.kernel.org \ --cc=garsilva@embeddedor.com \ --cc=gregkh@linuxfoundation.org \ --cc=gsomlo@gmail.com \ --cc=jun.li@nxp.com \ --cc=linux-imx@nxp.com \ --cc=linux-usb@vger.kernel.org \ --cc=linux@roeck-us.net \ --cc=peter.chen@nxp.com \ --cc=robh+dt@kernel.org \ --cc=shufan_lee@richtek.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.