[PATCH v1] net/mlx5: fix pmd crash in device probe

[PATCH v1] net/mlx5: fix pmd crash in device probe

[Xueming Li]

This patch initializes counter descriptor struct before invoking Verbs
api to avoid segment fault.

Fixes: 9a761de8ea14 ("net/mlx5: flow counter support")
Cc: orika@mellanox.com
Cc: stable@dpdk.org

Signed-off-by: Xueming Li <xuemingl@mellanox.com>
---
 drivers/net/mlx5/mlx5.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
index c933e274f..9ab965968 100644
--- a/drivers/net/mlx5/mlx5.c
+++ b/drivers/net/mlx5/mlx5.c
@@ -706,7 +706,7 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
 	int i;
 	struct mlx5dv_context attrs_out = {0};
 #ifdef HAVE_IBV_DEVICE_COUNTERS_SET_SUPPORT
-	struct ibv_counter_set_description cs_desc;
+	struct ibv_counter_set_description cs_desc = { .counter_type = 0 };
 #endif
 
 	/* Prepare shared data between primary and secondary process. */
-- 
2.13.3

Re: [PATCH v1] net/mlx5: fix pmd crash in device probe

[Adrien Mazarguil]

On Tue, Jun 12, 2018 at 07:38:11PM +0800, Xueming Li wrote:
> This patch initializes counter descriptor struct before invoking Verbs
> api to avoid segment fault.
> 
> Fixes: 9a761de8ea14 ("net/mlx5: flow counter support")
> Cc: orika@mellanox.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Xueming Li <xuemingl@mellanox.com>

Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>

-- 
Adrien Mazarguil
6WIND

Re: [PATCH v1] net/mlx5: fix pmd crash in device probe

[Shahaf Shuler]

Wednesday, June 13, 2018 5:18 PM, Adrien Mazarguil:
> Subject: Re: [PATCH v1] net/mlx5: fix pmd crash in device probe
> 
> On Tue, Jun 12, 2018 at 07:38:11PM +0800, Xueming Li wrote:
> > This patch initializes counter descriptor struct before invoking Verbs
> > api to avoid segment fault.
> >
> > Fixes: 9a761de8ea14 ("net/mlx5: flow counter support")
> > Cc: orika@mellanox.com
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Xueming Li <xuemingl@mellanox.com>
> 
> Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>

Applied to next-net-mlx, thanks. 

> 
> --
> Adrien Mazarguil
> 6WIND