All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux1394-devel@lists.sourceforge.net, linux-usb@vger.kernel.org,
	kvm@vger.kernel.org, virtualization@lists.linux-foundation.org,
	netdev@vger.kernel.org, Juergen Gross <jgross@suse.com>,
	qla2xxx-upstream@qlogic.com,
	Kent Overstreet <kent.overstreet@gmail.com>,
	Jens Axboe <axboe@kernel.dk>
Cc: Matthew Wilcox <willy@infradead.org>
Subject: [PATCH 0/3] Use sbitmap instead of percpu_ida
Date: Tue, 12 Jun 2018 12:05:42 -0700	[thread overview]
Message-ID: <20180612190545.10781-1-willy@infradead.org> (raw)

Removing the percpu_ida code nets over 400 lines of removal.  It's not
as spectacular as deleting an entire architecture, but it's still a
worthy reduction in lines of code.

Untested due to lack of hardware and not understanding how to set up a
target platform.

Changes from v1:
 - Fixed bugs pointed out by Jens in iscsit_wait_for_tag()
 - Abstracted out tag freeing as requested by Bart
 - Made iscsit_wait_for_tag static as pointed out by 0day

Matthew Wilcox (3):
  target: Abstract tag freeing
  Convert target drivers to use sbitmap
  Remove percpu_ida

 drivers/scsi/qla2xxx/qla_target.c        |  14 +-
 drivers/target/iscsi/iscsi_target_util.c |  35 ++-
 drivers/target/sbp/sbp_target.c          |   7 +-
 drivers/target/target_core_transport.c   |   5 +-
 drivers/target/tcm_fc/tfc_cmd.c          |  10 +-
 drivers/usb/gadget/function/f_tcm.c      |   7 +-
 drivers/vhost/scsi.c                     |   8 +-
 drivers/xen/xen-scsiback.c               |   9 +-
 include/linux/percpu_ida.h               |  83 -----
 include/target/iscsi/iscsi_target_core.h |   1 +
 include/target/target_core_base.h        |  10 +-
 lib/Makefile                             |   2 +-
 lib/percpu_ida.c                         | 370 -----------------------
 13 files changed, 73 insertions(+), 488 deletions(-)
 delete mode 100644 include/linux/percpu_ida.h
 delete mode 100644 lib/percpu_ida.c

-- 
2.17.1


WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox <willy@infradead.org>
To: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org,
	linux1394-devel@lists.sourceforge.net, linux-usb@vger.kernel.org,
	kvm@vger.kernel.org, virtualization@lists.linux-foundation.org,
	netdev@vger.kernel.org, Juergen Gross <jgross@suse.com>,
	qla2xxx-upstream@qlogic.com,
	Kent Overstreet <kent.overstreet@gmail.com>,
	Jens Axboe <axboe@kernel.dk>
Cc: Matthew Wilcox <willy@infradead.org>
Subject: [PATCH 0/3] Use sbitmap instead of percpu_ida
Date: Tue, 12 Jun 2018 19:05:42 +0000	[thread overview]
Message-ID: <20180612190545.10781-1-willy@infradead.org> (raw)

Removing the percpu_ida code nets over 400 lines of removal.  It's not
as spectacular as deleting an entire architecture, but it's still a
worthy reduction in lines of code.

Untested due to lack of hardware and not understanding how to set up a
target platform.

Changes from v1:
 - Fixed bugs pointed out by Jens in iscsit_wait_for_tag()
 - Abstracted out tag freeing as requested by Bart
 - Made iscsit_wait_for_tag static as pointed out by 0day

Matthew Wilcox (3):
  target: Abstract tag freeing
  Convert target drivers to use sbitmap
  Remove percpu_ida

 drivers/scsi/qla2xxx/qla_target.c        |  14 +-
 drivers/target/iscsi/iscsi_target_util.c |  35 ++-
 drivers/target/sbp/sbp_target.c          |   7 +-
 drivers/target/target_core_transport.c   |   5 +-
 drivers/target/tcm_fc/tfc_cmd.c          |  10 +-
 drivers/usb/gadget/function/f_tcm.c      |   7 +-
 drivers/vhost/scsi.c                     |   8 +-
 drivers/xen/xen-scsiback.c               |   9 +-
 include/linux/percpu_ida.h               |  83 -----
 include/target/iscsi/iscsi_target_core.h |   1 +
 include/target/target_core_base.h        |  10 +-
 lib/Makefile                             |   2 +-
 lib/percpu_ida.c                         | 370 -----------------------
 13 files changed, 73 insertions(+), 488 deletions(-)
 delete mode 100644 include/linux/percpu_ida.h
 delete mode 100644 lib/percpu_ida.c

-- 
2.17.1


             reply	other threads:[~2018-06-12 19:05 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-12 19:05 Matthew Wilcox [this message]
2018-06-12 19:05 ` [PATCH 0/3] Use sbitmap instead of percpu_ida Matthew Wilcox
2018-06-12 19:05 ` [PATCH 1/3] target: Abstract tag freeing Matthew Wilcox
2018-06-12 19:05 ` Matthew Wilcox
2018-06-12 19:05   ` [1/3] " Matthew Wilcox
2018-06-12 19:05   ` [PATCH 1/3] " Matthew Wilcox
2018-06-12 19:05   ` Matthew Wilcox
2018-06-12 19:05 ` [PATCH 2/3] Convert target drivers to use sbitmap Matthew Wilcox
2018-06-12 19:05 ` Matthew Wilcox
2018-06-12 19:05   ` [2/3] " Matthew Wilcox
2018-06-12 19:05   ` [PATCH 2/3] " Matthew Wilcox
2018-06-12 19:05   ` Matthew Wilcox
2018-06-12 19:05 ` [PATCH 3/3] Remove percpu_ida Matthew Wilcox
2018-06-12 19:05   ` [3/3] " Matthew Wilcox
2018-06-12 19:05   ` [PATCH 3/3] " Matthew Wilcox
2018-06-12 19:05   ` Matthew Wilcox
2018-06-12 19:05 ` Matthew Wilcox
2018-06-12 20:06 ` [PATCH 0/3] Use sbitmap instead of percpu_ida Bart Van Assche
2018-06-12 20:06   ` Bart Van Assche
2018-06-12 20:06   ` Bart Van Assche
2018-06-12 20:40 ` Jens Axboe
2018-06-12 20:40   ` Jens Axboe
2018-06-15  2:06 ` Martin K. Petersen
2018-06-15  2:06   ` Martin K. Petersen
2018-06-15  2:06   ` Martin K. Petersen
2018-06-15  2:37   ` Matthew Wilcox
2018-06-15  2:37     ` Matthew Wilcox
2018-06-15  2:37     ` Matthew Wilcox
2018-06-19  2:26     ` Martin K. Petersen
2018-06-19  2:26       ` Martin K. Petersen
2018-06-19  2:26       ` Martin K. Petersen
2018-06-15  7:37 ` Christoph Hellwig
2018-06-15  7:37   ` Christoph Hellwig
2018-06-15  7:37   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180612190545.10781-1-willy@infradead.org \
    --to=willy@infradead.org \
    --cc=axboe@kernel.dk \
    --cc=jgross@suse.com \
    --cc=kent.overstreet@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux1394-devel@lists.sourceforge.net \
    --cc=netdev@vger.kernel.org \
    --cc=qla2xxx-upstream@qlogic.com \
    --cc=target-devel@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.