From: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org> To: Maxime Ripard <maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org>, Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org> Cc: Icenowy Zheng <icenowy-h8G6r0blFSE@public.gmane.org>, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org> Subject: [PATCH v3 1/4] soc: sunxi: export a regmap for EMAC clock reg on A64 Date: Thu, 14 Jun 2018 23:35:45 +0800 [thread overview] Message-ID: <20180614153548.9644-2-wens@csie.org> (raw) In-Reply-To: <20180614153548.9644-1-wens-jdAy2FN1RRM@public.gmane.org> From: Icenowy Zheng <icenowy-h8G6r0blFSE@public.gmane.org> The A64 SRAM controller memory zone has a EMAC clock register, which is needed by the Ethernet MAC driver (dwmac-sun8i). Export a regmap for this register on A64. Signed-off-by: Icenowy Zheng <icenowy-h8G6r0blFSE@public.gmane.org> [wens-jdAy2FN1RRM@public.gmane.org: export whole address range with only EMAC register accessible and drop regmap name] Signed-off-by: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org> Acked-by: Maxime Ripard <maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org> --- drivers/soc/sunxi/sunxi_sram.c | 57 ++++++++++++++++++++++++++++++++-- 1 file changed, 55 insertions(+), 2 deletions(-) diff --git a/drivers/soc/sunxi/sunxi_sram.c b/drivers/soc/sunxi/sunxi_sram.c index 882be5ed7e84..eec7fc6e9f66 100644 --- a/drivers/soc/sunxi/sunxi_sram.c +++ b/drivers/soc/sunxi/sunxi_sram.c @@ -17,6 +17,7 @@ #include <linux/of_address.h> #include <linux/of_device.h> #include <linux/platform_device.h> +#include <linux/regmap.h> #include <linux/soc/sunxi/sunxi_sram.h> @@ -281,13 +282,51 @@ int sunxi_sram_release(struct device *dev) } EXPORT_SYMBOL(sunxi_sram_release); +struct sunxi_sramc_variant { + bool has_emac_clock; +}; + +static const struct sunxi_sramc_variant sun4i_a10_sramc_variant = { + /* Nothing special */ +}; + +static const struct sunxi_sramc_variant sun50i_a64_sramc_variant = { + .has_emac_clock = true, +}; + +#define SUNXI_SRAM_EMAC_CLOCK_REG 0x30 +static bool sunxi_sram_regmap_accessible_reg(struct device *dev, + unsigned int reg) +{ + if (reg == SUNXI_SRAM_EMAC_CLOCK_REG) + return true; + return false; +} + +static struct regmap_config sunxi_sram_emac_clock_regmap = { + .reg_bits = 32, + .val_bits = 32, + .reg_stride = 4, + /* last defined register */ + .max_register = SUNXI_SRAM_EMAC_CLOCK_REG, + /* other devices have no business accessing other registers */ + .readable_reg = sunxi_sram_regmap_accessible_reg, + .writeable_reg = sunxi_sram_regmap_accessible_reg, +}; + static int sunxi_sram_probe(struct platform_device *pdev) { struct resource *res; struct dentry *d; + struct regmap *emac_clock; + const struct sunxi_sramc_variant *variant; sram_dev = &pdev->dev; + variant = of_device_get_match_data(&pdev->dev); + if (!variant) + return -EINVAL; + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); base = devm_ioremap_resource(&pdev->dev, res); if (IS_ERR(base)) @@ -300,12 +339,26 @@ static int sunxi_sram_probe(struct platform_device *pdev) if (!d) return -ENOMEM; + if (variant->has_emac_clock) { + emac_clock = devm_regmap_init_mmio(&pdev->dev, base, + &sunxi_sram_emac_clock_regmap); + + if (IS_ERR(emac_clock)) + return PTR_ERR(emac_clock); + } + return 0; } static const struct of_device_id sunxi_sram_dt_match[] = { - { .compatible = "allwinner,sun4i-a10-sram-controller" }, - { .compatible = "allwinner,sun50i-a64-sram-controller" }, + { + .compatible = "allwinner,sun4i-a10-sram-controller", + .data = &sun4i_a10_sramc_variant, + }, + { + .compatible = "allwinner,sun50i-a64-sram-controller", + .data = &sun50i_a64_sramc_variant, + }, { }, }; MODULE_DEVICE_TABLE(of, sunxi_sram_dt_match); -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: wens@csie.org (Chen-Yu Tsai) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 1/4] soc: sunxi: export a regmap for EMAC clock reg on A64 Date: Thu, 14 Jun 2018 23:35:45 +0800 [thread overview] Message-ID: <20180614153548.9644-2-wens@csie.org> (raw) In-Reply-To: <20180614153548.9644-1-wens@csie.org> From: Icenowy Zheng <icenowy@aosc.io> The A64 SRAM controller memory zone has a EMAC clock register, which is needed by the Ethernet MAC driver (dwmac-sun8i). Export a regmap for this register on A64. Signed-off-by: Icenowy Zheng <icenowy@aosc.io> [wens at csie.org: export whole address range with only EMAC register accessible and drop regmap name] Signed-off-by: Chen-Yu Tsai <wens@csie.org> Acked-by: Maxime Ripard <maxime.ripard@bootlin.com> --- drivers/soc/sunxi/sunxi_sram.c | 57 ++++++++++++++++++++++++++++++++-- 1 file changed, 55 insertions(+), 2 deletions(-) diff --git a/drivers/soc/sunxi/sunxi_sram.c b/drivers/soc/sunxi/sunxi_sram.c index 882be5ed7e84..eec7fc6e9f66 100644 --- a/drivers/soc/sunxi/sunxi_sram.c +++ b/drivers/soc/sunxi/sunxi_sram.c @@ -17,6 +17,7 @@ #include <linux/of_address.h> #include <linux/of_device.h> #include <linux/platform_device.h> +#include <linux/regmap.h> #include <linux/soc/sunxi/sunxi_sram.h> @@ -281,13 +282,51 @@ int sunxi_sram_release(struct device *dev) } EXPORT_SYMBOL(sunxi_sram_release); +struct sunxi_sramc_variant { + bool has_emac_clock; +}; + +static const struct sunxi_sramc_variant sun4i_a10_sramc_variant = { + /* Nothing special */ +}; + +static const struct sunxi_sramc_variant sun50i_a64_sramc_variant = { + .has_emac_clock = true, +}; + +#define SUNXI_SRAM_EMAC_CLOCK_REG 0x30 +static bool sunxi_sram_regmap_accessible_reg(struct device *dev, + unsigned int reg) +{ + if (reg == SUNXI_SRAM_EMAC_CLOCK_REG) + return true; + return false; +} + +static struct regmap_config sunxi_sram_emac_clock_regmap = { + .reg_bits = 32, + .val_bits = 32, + .reg_stride = 4, + /* last defined register */ + .max_register = SUNXI_SRAM_EMAC_CLOCK_REG, + /* other devices have no business accessing other registers */ + .readable_reg = sunxi_sram_regmap_accessible_reg, + .writeable_reg = sunxi_sram_regmap_accessible_reg, +}; + static int sunxi_sram_probe(struct platform_device *pdev) { struct resource *res; struct dentry *d; + struct regmap *emac_clock; + const struct sunxi_sramc_variant *variant; sram_dev = &pdev->dev; + variant = of_device_get_match_data(&pdev->dev); + if (!variant) + return -EINVAL; + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); base = devm_ioremap_resource(&pdev->dev, res); if (IS_ERR(base)) @@ -300,12 +339,26 @@ static int sunxi_sram_probe(struct platform_device *pdev) if (!d) return -ENOMEM; + if (variant->has_emac_clock) { + emac_clock = devm_regmap_init_mmio(&pdev->dev, base, + &sunxi_sram_emac_clock_regmap); + + if (IS_ERR(emac_clock)) + return PTR_ERR(emac_clock); + } + return 0; } static const struct of_device_id sunxi_sram_dt_match[] = { - { .compatible = "allwinner,sun4i-a10-sram-controller" }, - { .compatible = "allwinner,sun50i-a64-sram-controller" }, + { + .compatible = "allwinner,sun4i-a10-sram-controller", + .data = &sun4i_a10_sramc_variant, + }, + { + .compatible = "allwinner,sun50i-a64-sram-controller", + .data = &sun50i_a64_sramc_variant, + }, { }, }; MODULE_DEVICE_TABLE(of, sunxi_sram_dt_match); -- 2.17.1
next prev parent reply other threads:[~2018-06-14 15:35 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-06-14 15:35 [PATCH v3 0/4] allwinner: a64: add SRAM controller / system control Chen-Yu Tsai 2018-06-14 15:35 ` Chen-Yu Tsai [not found] ` <20180614153548.9644-1-wens-jdAy2FN1RRM@public.gmane.org> 2018-06-14 15:35 ` Chen-Yu Tsai [this message] 2018-06-14 15:35 ` [PATCH v3 1/4] soc: sunxi: export a regmap for EMAC clock reg on A64 Chen-Yu Tsai 2018-06-14 15:35 ` [PATCH v3 2/4] dt-bindings: sram: Rename A64 SRAM controller compatible Chen-Yu Tsai 2018-06-14 15:35 ` Chen-Yu Tsai [not found] ` <20180614153548.9644-3-wens-jdAy2FN1RRM@public.gmane.org> 2018-06-20 18:04 ` Rob Herring 2018-06-20 18:04 ` Rob Herring 2018-06-14 15:35 ` [PATCH v3 3/4] soc: sunxi: sram: Add updated compatible string for A64 system control Chen-Yu Tsai 2018-06-14 15:35 ` Chen-Yu Tsai 2018-06-14 15:35 ` [PATCH v3 4/4] arm64: dts: allwinner: a64: add SRAM controller device tree node Chen-Yu Tsai 2018-06-14 15:35 ` Chen-Yu Tsai [not found] ` <20180614153548.9644-5-wens-jdAy2FN1RRM@public.gmane.org> 2018-06-14 17:09 ` Jagan Teki 2018-06-14 17:09 ` [linux-sunxi] " Jagan Teki [not found] ` <CAMty3ZARNpBOQKvS7knH8kWE2+bvjuJoAA4cFGZK8+GzTUQ5zA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2018-06-14 17:27 ` Jernej Škrabec 2018-06-14 17:27 ` [linux-sunxi] " Jernej Škrabec 2018-06-14 23:09 ` Icenowy Zheng 2018-06-14 23:09 ` [linux-sunxi] " Icenowy Zheng [not found] ` <5C14D945-0795-4100-86E2-6FBF04350715-h8G6r0blFSE@public.gmane.org> 2018-06-19 7:36 ` Jagan Teki 2018-06-19 7:36 ` [linux-sunxi] " Jagan Teki [not found] ` <CAMty3ZCsPXh7Fhmhtd7UjTmJ9id+NeaZDVqkix1iQz7-fDqoUw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2018-06-19 14:27 ` Icenowy Zheng 2018-06-19 14:27 ` [linux-sunxi] " Icenowy Zheng 2018-06-15 9:14 ` [PATCH v3 0/4] allwinner: a64: add SRAM controller / system control Maxime Ripard 2018-06-15 9:14 ` Maxime Ripard 2018-06-18 2:11 ` Chen-Yu Tsai 2018-06-18 2:11 ` Chen-Yu Tsai [not found] ` <CAGb2v64Ar+rOgiXbjtRrQojHUZteLa9N7OwM3XY7ZcpS87Qpmw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2018-06-18 7:34 ` Maxime Ripard 2018-06-18 7:34 ` Maxime Ripard 2018-06-19 15:20 ` Chen-Yu Tsai 2018-06-19 15:20 ` Chen-Yu Tsai 2018-08-20 7:42 ` Emmanuel Vadot 2018-08-20 7:42 ` Emmanuel Vadot [not found] ` <20180820094210.6d856029d51dad480782a783-xXdDKFdH5B3kFDPD4ZthVA@public.gmane.org> 2018-08-20 8:41 ` Chen-Yu Tsai 2018-08-20 8:41 ` Chen-Yu Tsai 2018-08-20 14:01 ` Emmanuel Vadot 2018-08-20 14:01 ` Emmanuel Vadot [not found] ` <20180820160149.65771a35c5b46f5ddb483428-xXdDKFdH5B3kFDPD4ZthVA@public.gmane.org> 2018-08-20 14:25 ` Chen-Yu Tsai 2018-08-20 14:25 ` Chen-Yu Tsai 2018-08-20 14:29 ` Emmanuel Vadot 2018-08-20 14:29 ` Emmanuel Vadot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180614153548.9644-2-wens@csie.org \ --to=wens-jday2fn1rrm@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=icenowy-h8G6r0blFSE@public.gmane.org \ --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \ --cc=linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \ --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \ --cc=maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org \ --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.