All of lore.kernel.org
 help / color / mirror / Atom feed
* master - vgchange: trace faling activation
@ 2018-06-14 20:03 Zdenek Kabelac
  0 siblings, 0 replies; only message in thread
From: Zdenek Kabelac @ 2018-06-14 20:03 UTC (permalink / raw)
  To: lvm-devel

Gitweb:        https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=33703995ae264c7abdc6d566283d94d8587a85f1
Commit:        33703995ae264c7abdc6d566283d94d8587a85f1
Parent:        f38a54227d71b6fd661d83609f46459306bc373a
Author:        Zdenek Kabelac <zkabelac@redhat.com>
AuthorDate:    Thu Jun 14 21:04:53 2018 +0200
Committer:     Zdenek Kabelac <zkabelac@redhat.com>
CommitterDate: Thu Jun 14 22:02:01 2018 +0200

vgchange: trace faling activation

Trace failed activation and directly assign 0 returning failure.
---
 tools/vgchange.c |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/tools/vgchange.c b/tools/vgchange.c
index 71a6c54..55bc476 100644
--- a/tools/vgchange.c
+++ b/tools/vgchange.c
@@ -116,8 +116,11 @@ static int _activate_lvs_in_vg(struct cmd_context *cmd, struct volume_group *vg,
 
 		expected_count++;
 
-		if (!lv_change_activate(cmd, lv, activate))
+		if (!lv_change_activate(cmd, lv, activate)) {
+			stack;
+			r = 0;
 			continue;
+		}
 
 		count++;
 	}
@@ -135,7 +138,7 @@ static int _activate_lvs_in_vg(struct cmd_context *cmd, struct volume_group *vg,
 			    is_change_activating(activate) ?
 			    "Activated" : "Deactivated", count, vg->name);
 
-	return (expected_count != count) ? 0 : r;
+	return r;
 }
 
 static int _vgchange_monitoring(struct cmd_context *cmd, struct volume_group *vg)



^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2018-06-14 20:03 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-14 20:03 master - vgchange: trace faling activation Zdenek Kabelac

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.