All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] drm/i915/gtt: Enable full-ppgtt by default everywhere
@ 2018-06-14 20:14 Chris Wilson
  2018-06-14 20:14 ` [PATCH 2/2] drm/i915/gtt: Full ppgtt everywhere, no excuses Chris Wilson
                   ` (4 more replies)
  0 siblings, 5 replies; 12+ messages in thread
From: Chris Wilson @ 2018-06-14 20:14 UTC (permalink / raw)
  To: intel-gfx

We should we have all the kinks worked out and full-ppgtt now works
reliably on gen7 (Ivybridge, Valleyview/Baytrail and Haswell). If we can
let userspace have full control over their own ppgtt, it makes softpinning
far more effective, in turn making GPU dispatch far more efficient and
more secure (due to better mm segregation). On the other hand, switching
over to a different GTT for every client does incur noticeable overhead.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: Matthew Auld <matthew.william.auld@gmail.com>
---
 drivers/gpu/drm/i915/i915_gem_gtt.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
index c6aa761ca085..5ef5176e10fe 100644
--- a/drivers/gpu/drm/i915/i915_gem_gtt.c
+++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
@@ -179,13 +179,11 @@ int intel_sanitize_enable_ppgtt(struct drm_i915_private *dev_priv,
 		return 0;
 	}
 
-	if (HAS_LOGICAL_RING_CONTEXTS(dev_priv)) {
-		if (has_full_48bit_ppgtt)
-			return 3;
+	if (has_full_48bit_ppgtt)
+		return 3;
 
-		if (has_full_ppgtt)
-			return 2;
-	}
+	if (has_full_ppgtt)
+		return 2;
 
 	return 1;
 }
-- 
2.17.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [PATCH 2/2] drm/i915/gtt: Full ppgtt everywhere, no excuses
  2018-06-14 20:14 [PATCH 1/2] drm/i915/gtt: Enable full-ppgtt by default everywhere Chris Wilson
@ 2018-06-14 20:14 ` Chris Wilson
  2018-06-15 11:29   ` Joonas Lahtinen
  2018-06-14 20:24 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/gtt: Enable full-ppgtt by default everywhere Patchwork
                   ` (3 subsequent siblings)
  4 siblings, 1 reply; 12+ messages in thread
From: Chris Wilson @ 2018-06-14 20:14 UTC (permalink / raw)
  To: intel-gfx

We believe we have all the kinks worked out, even for the early
Valleyview devices, for whom we currently disable all ppgtt.

References: 62942ed7279d ("drm/i915/vlv: disable PPGTT on early revs v3")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
---
 drivers/gpu/drm/i915/i915_gem_gtt.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
index 5ef5176e10fe..dbc55ae234ac 100644
--- a/drivers/gpu/drm/i915/i915_gem_gtt.c
+++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
@@ -173,12 +173,6 @@ int intel_sanitize_enable_ppgtt(struct drm_i915_private *dev_priv,
 		return 0;
 	}
 
-	/* Early VLV doesn't have this */
-	if (IS_VALLEYVIEW(dev_priv) && dev_priv->drm.pdev->revision < 0xb) {
-		DRM_DEBUG_DRIVER("disabling PPGTT on pre-B3 step VLV\n");
-		return 0;
-	}
-
 	if (has_full_48bit_ppgtt)
 		return 3;
 
-- 
2.17.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 12+ messages in thread

* ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/gtt: Enable full-ppgtt by default everywhere
  2018-06-14 20:14 [PATCH 1/2] drm/i915/gtt: Enable full-ppgtt by default everywhere Chris Wilson
  2018-06-14 20:14 ` [PATCH 2/2] drm/i915/gtt: Full ppgtt everywhere, no excuses Chris Wilson
@ 2018-06-14 20:24 ` Patchwork
  2018-06-14 20:39 ` ✓ Fi.CI.BAT: success " Patchwork
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2018-06-14 20:24 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx

== Series Details ==

Series: series starting with [1/2] drm/i915/gtt: Enable full-ppgtt by default everywhere
URL   : https://patchwork.freedesktop.org/series/44778/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
e6d49115297f drm/i915/gtt: Enable full-ppgtt by default everywhere
1be6943fa79d drm/i915/gtt: Full ppgtt everywhere, no excuses
-:12: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 62942ed7279d ("drm/i915/vlv: disable PPGTT on early revs v3")'
#12: 
References: 62942ed7279d ("drm/i915/vlv: disable PPGTT on early revs v3")

total: 1 errors, 0 warnings, 0 checks, 12 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 12+ messages in thread

* ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/gtt: Enable full-ppgtt by default everywhere
  2018-06-14 20:14 [PATCH 1/2] drm/i915/gtt: Enable full-ppgtt by default everywhere Chris Wilson
  2018-06-14 20:14 ` [PATCH 2/2] drm/i915/gtt: Full ppgtt everywhere, no excuses Chris Wilson
  2018-06-14 20:24 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/gtt: Enable full-ppgtt by default everywhere Patchwork
@ 2018-06-14 20:39 ` Patchwork
  2018-06-15  5:01 ` ✓ Fi.CI.IGT: " Patchwork
  2018-06-15 11:28 ` [PATCH 1/2] " Joonas Lahtinen
  4 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2018-06-14 20:39 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx

== Series Details ==

Series: series starting with [1/2] drm/i915/gtt: Enable full-ppgtt by default everywhere
URL   : https://patchwork.freedesktop.org/series/44778/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4321 -> Patchwork_9310 =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/44778/revisions/1/mbox/

== Known issues ==

  Here are the changes found in Patchwork_9310 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@gem_exec_suspend@basic-s3:
      fi-glk-j4005:       PASS -> DMESG-WARN (fdo#106097)

    igt@kms_flip@basic-flip-vs-modeset:
      fi-glk-j4005:       PASS -> DMESG-WARN (fdo#106000, fdo#106097) +1

    igt@kms_pipe_crc_basic@read-crc-pipe-b:
      fi-glk-j4005:       PASS -> DMESG-WARN (fdo#105719)

    
    ==== Possible fixes ====

    igt@drv_module_reload@basic-reload-inject:
      fi-glk-j4005:       DMESG-WARN (fdo#106725, fdo#106248) -> PASS

    igt@kms_flip@basic-flip-vs-wf_vblank:
      fi-glk-j4005:       FAIL (fdo#100368) -> PASS

    igt@kms_pipe_crc_basic@hang-read-crc-pipe-b:
      fi-skl-6700k2:      FAIL (fdo#103191, fdo#104724) -> PASS

    
  fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
  fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
  fdo#104724 https://bugs.freedesktop.org/show_bug.cgi?id=104724
  fdo#105719 https://bugs.freedesktop.org/show_bug.cgi?id=105719
  fdo#106000 https://bugs.freedesktop.org/show_bug.cgi?id=106000
  fdo#106097 https://bugs.freedesktop.org/show_bug.cgi?id=106097
  fdo#106248 https://bugs.freedesktop.org/show_bug.cgi?id=106248
  fdo#106725 https://bugs.freedesktop.org/show_bug.cgi?id=106725


== Participating hosts (41 -> 38) ==

  Additional (1): fi-byt-j1900 
  Missing    (4): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-hsw-4200u 


== Build changes ==

    * Linux: CI_DRM_4321 -> Patchwork_9310

  CI_DRM_4321: 505d7dfc3c02d3efdb74aca0dbffd86d8b761a49 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4519: 3381a56be31defb3b5c23a4fbc19ac26a000c35b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_9310: 1be6943fa79dc1335f7028d851cb0cd5a57167c1 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

1be6943fa79d drm/i915/gtt: Full ppgtt everywhere, no excuses
e6d49115297f drm/i915/gtt: Enable full-ppgtt by default everywhere

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9310/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 12+ messages in thread

* ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915/gtt: Enable full-ppgtt by default everywhere
  2018-06-14 20:14 [PATCH 1/2] drm/i915/gtt: Enable full-ppgtt by default everywhere Chris Wilson
                   ` (2 preceding siblings ...)
  2018-06-14 20:39 ` ✓ Fi.CI.BAT: success " Patchwork
@ 2018-06-15  5:01 ` Patchwork
  2018-06-15 11:28 ` [PATCH 1/2] " Joonas Lahtinen
  4 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2018-06-15  5:01 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx

== Series Details ==

Series: series starting with [1/2] drm/i915/gtt: Enable full-ppgtt by default everywhere
URL   : https://patchwork.freedesktop.org/series/44778/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4321_full -> Patchwork_9310_full =

== Summary - WARNING ==

  Minor unknown changes coming with Patchwork_9310_full need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_9310_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  

== Possible new issues ==

  Here are the unknown changes that may have been introduced in Patchwork_9310_full:

  === IGT changes ===

    ==== Warnings ====

    igt@gem_exec_schedule@deep-blt:
      shard-kbl:          SKIP -> PASS +1

    igt@gem_mocs_settings@mocs-rc6-vebox:
      shard-kbl:          PASS -> SKIP +2

    igt@gem_ppgtt@flink-and-close-vma-leak:
      shard-hsw:          SKIP -> PASS +2

    
== Known issues ==

  Here are the changes found in Patchwork_9310_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@drv_selftest@live_gtt:
      shard-glk:          PASS -> FAIL (fdo#105347)

    igt@drv_suspend@shrink:
      shard-apl:          PASS -> INCOMPLETE (fdo#103927)

    igt@gem_ctx_switch@basic-all-light:
      shard-hsw:          PASS -> INCOMPLETE (fdo#103540)

    igt@gem_exec_suspend@basic-s3:
      shard-snb:          PASS -> INCOMPLETE (fdo#105411)

    igt@kms_flip@2x-plain-flip-fb-recreate:
      shard-glk:          PASS -> FAIL (fdo#100368)

    igt@kms_flip@2x-plain-flip-ts-check:
      shard-hsw:          PASS -> FAIL (fdo#100368) +1

    igt@kms_flip@flip-vs-expired-vblank-interruptible:
      shard-glk:          PASS -> FAIL (fdo#105363)

    igt@kms_flip_tiling@flip-to-y-tiled:
      shard-glk:          PASS -> FAIL (fdo#104724) +1

    
    ==== Possible fixes ====

    igt@drv_selftest@live_gtt:
      shard-kbl:          INCOMPLETE (fdo#103665) -> PASS +1

    igt@drv_selftest@live_hangcheck:
      shard-glk:          DMESG-FAIL (fdo#106560) -> PASS

    igt@kms_atomic_transition@1x-modeset-transitions-nonblocking-fencing:
      shard-glk:          FAIL (fdo#105703) -> PASS

    igt@kms_flip@2x-plain-flip-ts-check-interruptible:
      shard-hsw:          FAIL (fdo#100368) -> PASS +1

    igt@kms_flip@wf_vblank-ts-check:
      shard-hsw:          FAIL (fdo#103928) -> PASS

    igt@kms_setmode@basic:
      shard-apl:          FAIL (fdo#99912) -> PASS

    
  fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
  fdo#103540 https://bugs.freedesktop.org/show_bug.cgi?id=103540
  fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
  fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
  fdo#103928 https://bugs.freedesktop.org/show_bug.cgi?id=103928
  fdo#104724 https://bugs.freedesktop.org/show_bug.cgi?id=104724
  fdo#105347 https://bugs.freedesktop.org/show_bug.cgi?id=105347
  fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
  fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
  fdo#105703 https://bugs.freedesktop.org/show_bug.cgi?id=105703
  fdo#106560 https://bugs.freedesktop.org/show_bug.cgi?id=106560
  fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912


== Participating hosts (5 -> 5) ==

  No changes in participating hosts


== Build changes ==

    * Linux: CI_DRM_4321 -> Patchwork_9310

  CI_DRM_4321: 505d7dfc3c02d3efdb74aca0dbffd86d8b761a49 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4519: 3381a56be31defb3b5c23a4fbc19ac26a000c35b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_9310: 1be6943fa79dc1335f7028d851cb0cd5a57167c1 @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9310/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 1/2] drm/i915/gtt: Enable full-ppgtt by default everywhere
  2018-06-14 20:14 [PATCH 1/2] drm/i915/gtt: Enable full-ppgtt by default everywhere Chris Wilson
                   ` (3 preceding siblings ...)
  2018-06-15  5:01 ` ✓ Fi.CI.IGT: " Patchwork
@ 2018-06-15 11:28 ` Joonas Lahtinen
  4 siblings, 0 replies; 12+ messages in thread
From: Joonas Lahtinen @ 2018-06-15 11:28 UTC (permalink / raw)
  To: Chris Wilson, intel-gfx

Quoting Chris Wilson (2018-06-14 23:14:18)
> We should we have all the kinks worked out and full-ppgtt now works
> reliably on gen7 (Ivybridge, Valleyview/Baytrail and Haswell). If we can
> let userspace have full control over their own ppgtt, it makes softpinning
> far more effective, in turn making GPU dispatch far more efficient and
> more secure (due to better mm segregation). On the other hand, switching
> over to a different GTT for every client does incur noticeable overhead.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> Cc: Matthew Auld <matthew.william.auld@gmail.com>

I'd love to get Acks here from Mesa folks for documentation. But for the kernel
portions and by my understanding for userspace too this is ready to go, so from
me it is:

Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

Regards, Joonas
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 2/2] drm/i915/gtt: Full ppgtt everywhere, no excuses
  2018-06-14 20:14 ` [PATCH 2/2] drm/i915/gtt: Full ppgtt everywhere, no excuses Chris Wilson
@ 2018-06-15 11:29   ` Joonas Lahtinen
  2018-06-15 13:54     ` Ville Syrjälä
  0 siblings, 1 reply; 12+ messages in thread
From: Joonas Lahtinen @ 2018-06-15 11:29 UTC (permalink / raw)
  To: Chris Wilson, intel-gfx

Quoting Chris Wilson (2018-06-14 23:14:19)
> We believe we have all the kinks worked out, even for the early
> Valleyview devices, for whom we currently disable all ppgtt.
> 
> References: 62942ed7279d ("drm/i915/vlv: disable PPGTT on early revs v3")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

For the rather limited scope of the patch, can you Ville give a Tested-by?

Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

Regards, Joonas
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 2/2] drm/i915/gtt: Full ppgtt everywhere, no excuses
  2018-06-15 11:29   ` Joonas Lahtinen
@ 2018-06-15 13:54     ` Ville Syrjälä
  2018-06-15 13:57       ` Chris Wilson
  0 siblings, 1 reply; 12+ messages in thread
From: Ville Syrjälä @ 2018-06-15 13:54 UTC (permalink / raw)
  To: Joonas Lahtinen; +Cc: intel-gfx

On Fri, Jun 15, 2018 at 02:29:08PM +0300, Joonas Lahtinen wrote:
> Quoting Chris Wilson (2018-06-14 23:14:19)
> > We believe we have all the kinks worked out, even for the early
> > Valleyview devices, for whom we currently disable all ppgtt.
> > 
> > References: 62942ed7279d ("drm/i915/vlv: disable PPGTT on early revs v3")
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> 
> For the rather limited scope of the patch, can you Ville give a Tested-by?

Not sure I want to trust the B0 results quite that far.

> 
> Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> 
> Regards, Joonas

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 2/2] drm/i915/gtt: Full ppgtt everywhere, no excuses
  2018-06-15 13:54     ` Ville Syrjälä
@ 2018-06-15 13:57       ` Chris Wilson
  2018-06-15 14:10         ` Ville Syrjälä
  0 siblings, 1 reply; 12+ messages in thread
From: Chris Wilson @ 2018-06-15 13:57 UTC (permalink / raw)
  To: Ville Syrjälä, Joonas Lahtinen; +Cc: intel-gfx

Quoting Ville Syrjälä (2018-06-15 14:54:39)
> On Fri, Jun 15, 2018 at 02:29:08PM +0300, Joonas Lahtinen wrote:
> > Quoting Chris Wilson (2018-06-14 23:14:19)
> > > We believe we have all the kinks worked out, even for the early
> > > Valleyview devices, for whom we currently disable all ppgtt.
> > > 
> > > References: 62942ed7279d ("drm/i915/vlv: disable PPGTT on early revs v3")
> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> > 
> > For the rather limited scope of the patch, can you Ville give a Tested-by?
> 
> Not sure I want to trust the B0 results quite that far.

But perhaps an ack? :)
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 2/2] drm/i915/gtt: Full ppgtt everywhere, no excuses
  2018-06-15 13:57       ` Chris Wilson
@ 2018-06-15 14:10         ` Ville Syrjälä
  0 siblings, 0 replies; 12+ messages in thread
From: Ville Syrjälä @ 2018-06-15 14:10 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx

On Fri, Jun 15, 2018 at 02:57:32PM +0100, Chris Wilson wrote:
> Quoting Ville Syrjälä (2018-06-15 14:54:39)
> > On Fri, Jun 15, 2018 at 02:29:08PM +0300, Joonas Lahtinen wrote:
> > > Quoting Chris Wilson (2018-06-14 23:14:19)
> > > > We believe we have all the kinks worked out, even for the early
> > > > Valleyview devices, for whom we currently disable all ppgtt.
> > > > 
> > > > References: 62942ed7279d ("drm/i915/vlv: disable PPGTT on early revs v3")
> > > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> > > 
> > > For the rather limited scope of the patch, can you Ville give a Tested-by?
> > 
> > Not sure I want to trust the B0 results quite that far.
> 
> But perhaps an ack? :)

Sure
Acked-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Hopefully we'll get the B2 soon to verify the results.

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 12+ messages in thread

* ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/gtt: Enable full-ppgtt by default everywhere
  2018-07-17  9:57 [PATCH 1/2] " Chris Wilson
@ 2018-07-17 12:50 ` Patchwork
  0 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2018-07-17 12:50 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx

== Series Details ==

Series: series starting with [1/2] drm/i915/gtt: Enable full-ppgtt by default everywhere
URL   : https://patchwork.freedesktop.org/series/46685/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4501 -> Patchwork_9687 =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/46685/revisions/1/mbox/

== Known issues ==

  Here are the changes found in Patchwork_9687 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@drv_selftest@live_hangcheck:
      fi-kbl-7567u:       PASS -> DMESG-FAIL (fdo#106560, fdo#106947)

    igt@kms_flip@basic-flip-vs-modeset:
      fi-skl-6700hq:      PASS -> DMESG-WARN (fdo#105998) +1

    
    ==== Possible fixes ====

    igt@gem_exec_suspend@basic-s4-devices:
      fi-kbl-7500u:       DMESG-WARN (fdo#105128, fdo#107139) -> PASS

    igt@kms_busy@basic-flip-b:
      fi-skl-6700hq:      DMESG-WARN (fdo#105998) -> PASS +1

    
  fdo#105128 https://bugs.freedesktop.org/show_bug.cgi?id=105128
  fdo#105998 https://bugs.freedesktop.org/show_bug.cgi?id=105998
  fdo#106560 https://bugs.freedesktop.org/show_bug.cgi?id=106560
  fdo#106947 https://bugs.freedesktop.org/show_bug.cgi?id=106947
  fdo#107139 https://bugs.freedesktop.org/show_bug.cgi?id=107139


== Participating hosts (46 -> 42) ==

  Additional (1): fi-cfl-8109u 
  Missing    (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u 


== Build changes ==

    * Linux: CI_DRM_4501 -> Patchwork_9687

  CI_DRM_4501: 692d13f7b75baf0bb8c58b9784569c52d68f01e2 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4559: 6d341aac2124836443ce74e8e97a4508ac8d5095 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_9687: 0f8a1fa2eccd64f7e804829d1ce34f0c547ac418 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

0f8a1fa2eccd drm/i915/gtt: Full ppgtt everywhere, no excuses
b8b34765e511 drm/i915/gtt: Enable full-ppgtt by default everywhere

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9687/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 12+ messages in thread

* ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/gtt: Enable full-ppgtt by default everywhere
  2018-06-18 10:10 Chris Wilson
@ 2018-06-18 11:34 ` Patchwork
  0 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2018-06-18 11:34 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx

== Series Details ==

Series: series starting with [1/2] drm/i915/gtt: Enable full-ppgtt by default everywhere
URL   : https://patchwork.freedesktop.org/series/44925/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4333 -> Patchwork_9348 =

== Summary - WARNING ==

  Minor unknown changes coming with Patchwork_9348 need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_9348, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/44925/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in Patchwork_9348:

  === IGT changes ===

    ==== Warnings ====

    igt@kms_pipe_crc_basic@hang-read-crc-pipe-b:
      fi-glk-j4005:       SKIP -> PASS

    
== Known issues ==

  Here are the changes found in Patchwork_9348 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@kms_flip@basic-flip-vs-wf_vblank:
      fi-glk-j4005:       PASS -> FAIL (fdo#100368)

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
      fi-cnl-psr:         PASS -> DMESG-WARN (fdo#104951)

    
    ==== Possible fixes ====

    igt@debugfs_test@read_all_entries:
      fi-snb-2520m:       INCOMPLETE (fdo#103713) -> PASS

    igt@gem_ctx_create@basic-files:
      fi-kbl-guc:         DMESG-WARN -> PASS

    igt@kms_flip@basic-flip-vs-dpms:
      fi-glk-j4005:       DMESG-WARN (fdo#106000) -> PASS
      fi-skl-6700hq:      DMESG-WARN (fdo#105998) -> PASS

    
  fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
  fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
  fdo#104951 https://bugs.freedesktop.org/show_bug.cgi?id=104951
  fdo#105998 https://bugs.freedesktop.org/show_bug.cgi?id=105998
  fdo#106000 https://bugs.freedesktop.org/show_bug.cgi?id=106000


== Participating hosts (40 -> 36) ==

  Additional (1): fi-bxt-dsi 
  Missing    (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u 


== Build changes ==

    * Linux: CI_DRM_4333 -> Patchwork_9348

  CI_DRM_4333: 5fad115a81a20aa6b4ffd3f7f6663d43c88fa395 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4523: 778497e7965dc8662c770a89ebbd741778feb71e @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_9348: 5423c7e1efb6b188874236db402a5848bb3ab7cf @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

5423c7e1efb6 drm/i915/gtt: Full ppgtt everywhere, no excuses
f212fc4e9611 drm/i915/gtt: Enable full-ppgtt by default everywhere

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9348/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2018-07-17 12:50 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-14 20:14 [PATCH 1/2] drm/i915/gtt: Enable full-ppgtt by default everywhere Chris Wilson
2018-06-14 20:14 ` [PATCH 2/2] drm/i915/gtt: Full ppgtt everywhere, no excuses Chris Wilson
2018-06-15 11:29   ` Joonas Lahtinen
2018-06-15 13:54     ` Ville Syrjälä
2018-06-15 13:57       ` Chris Wilson
2018-06-15 14:10         ` Ville Syrjälä
2018-06-14 20:24 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/gtt: Enable full-ppgtt by default everywhere Patchwork
2018-06-14 20:39 ` ✓ Fi.CI.BAT: success " Patchwork
2018-06-15  5:01 ` ✓ Fi.CI.IGT: " Patchwork
2018-06-15 11:28 ` [PATCH 1/2] " Joonas Lahtinen
2018-06-18 10:10 Chris Wilson
2018-06-18 11:34 ` ✓ Fi.CI.BAT: success for series starting with [1/2] " Patchwork
2018-07-17  9:57 [PATCH 1/2] " Chris Wilson
2018-07-17 12:50 ` ✓ Fi.CI.BAT: success for series starting with [1/2] " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.