* TCP receive windows broken in 4.14.48
@ 2018-06-14 21:09 Benjamin Gilbert
2018-06-14 21:20 ` Guenter Roeck
0 siblings, 1 reply; 5+ messages in thread
From: Benjamin Gilbert @ 2018-06-14 21:09 UTC (permalink / raw)
To: stable; +Cc: Greg Kroah-Hartman, Guenter Roeck
Hi,
4.14.48 can cause abnormally small TCP receive windows when the sender is
faster than the receiver; see https://github.com/coreos/bugs/issues/2457 for
details. Reverting "tcp: avoid integer overflows in tcp_rcv_space_adjust()"
fixes it. Backporting 02db55718d53 ("tcp: do not overshoot window_clamp in
tcp_rcv_space_adjust()"), which is its parent commit upstream, also fixes
it.
--Benjamin Gilbert
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: TCP receive windows broken in 4.14.48
2018-06-14 21:09 TCP receive windows broken in 4.14.48 Benjamin Gilbert
@ 2018-06-14 21:20 ` Guenter Roeck
2018-06-18 4:47 ` Greg Kroah-Hartman
2018-06-18 5:20 ` Greg Kroah-Hartman
0 siblings, 2 replies; 5+ messages in thread
From: Guenter Roeck @ 2018-06-14 21:20 UTC (permalink / raw)
To: Benjamin Gilbert; +Cc: stable, Greg Kroah-Hartman
On Thu, Jun 14, 2018 at 05:09:21PM -0400, Benjamin Gilbert wrote:
> Hi,
>
> 4.14.48 can cause abnormally small TCP receive windows when the sender is
> faster than the receiver; see https://github.com/coreos/bugs/issues/2457 for
> details. Reverting "tcp: avoid integer overflows in tcp_rcv_space_adjust()"
> fixes it. Backporting 02db55718d53 ("tcp: do not overshoot window_clamp in
> tcp_rcv_space_adjust()"), which is its parent commit upstream, also fixes
> it.
>
02db55718d53 applies cleanly, so I would suggest we go along that route
instead of a revert.
Greg - given that the problematic commit is in all stable releases, it would
probably make sense to apply 02db55718d53 to pre-4.14 kernels as well. It
does apply clean to all kernels all the way back to 3.18.y.
Thanks,
Guenter
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: TCP receive windows broken in 4.14.48
2018-06-14 21:20 ` Guenter Roeck
@ 2018-06-18 4:47 ` Greg Kroah-Hartman
2018-06-18 5:20 ` Greg Kroah-Hartman
1 sibling, 0 replies; 5+ messages in thread
From: Greg Kroah-Hartman @ 2018-06-18 4:47 UTC (permalink / raw)
To: Guenter Roeck; +Cc: Benjamin Gilbert, stable
On Thu, Jun 14, 2018 at 02:20:29PM -0700, Guenter Roeck wrote:
> On Thu, Jun 14, 2018 at 05:09:21PM -0400, Benjamin Gilbert wrote:
> > Hi,
> >
> > 4.14.48 can cause abnormally small TCP receive windows when the sender is
> > faster than the receiver; see https://github.com/coreos/bugs/issues/2457 for
> > details. Reverting "tcp: avoid integer overflows in tcp_rcv_space_adjust()"
> > fixes it. Backporting 02db55718d53 ("tcp: do not overshoot window_clamp in
> > tcp_rcv_space_adjust()"), which is its parent commit upstream, also fixes
> > it.
> >
> 02db55718d53 applies cleanly, so I would suggest we go along that route
> instead of a revert.
>
> Greg - given that the problematic commit is in all stable releases, it would
> probably make sense to apply 02db55718d53 to pre-4.14 kernels as well. It
> does apply clean to all kernels all the way back to 3.18.y.
Now done, thanks.
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: TCP receive windows broken in 4.14.48
2018-06-14 21:20 ` Guenter Roeck
2018-06-18 4:47 ` Greg Kroah-Hartman
@ 2018-06-18 5:20 ` Greg Kroah-Hartman
2018-06-18 5:39 ` Guenter Roeck
1 sibling, 1 reply; 5+ messages in thread
From: Greg Kroah-Hartman @ 2018-06-18 5:20 UTC (permalink / raw)
To: Guenter Roeck; +Cc: Benjamin Gilbert, stable
On Thu, Jun 14, 2018 at 02:20:29PM -0700, Guenter Roeck wrote:
> On Thu, Jun 14, 2018 at 05:09:21PM -0400, Benjamin Gilbert wrote:
> > Hi,
> >
> > 4.14.48 can cause abnormally small TCP receive windows when the sender is
> > faster than the receiver; see https://github.com/coreos/bugs/issues/2457 for
> > details. Reverting "tcp: avoid integer overflows in tcp_rcv_space_adjust()"
> > fixes it. Backporting 02db55718d53 ("tcp: do not overshoot window_clamp in
> > tcp_rcv_space_adjust()"), which is its parent commit upstream, also fixes
> > it.
> >
> 02db55718d53 applies cleanly, so I would suggest we go along that route
> instead of a revert.
>
> Greg - given that the problematic commit is in all stable releases, it would
> probably make sense to apply 02db55718d53 to pre-4.14 kernels as well. It
> does apply clean to all kernels all the way back to 3.18.y.
Ah, but it breaks the build everywhere, so I've dropped it :(
Can someone please backport it? I'll be glad to queue it up then.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: TCP receive windows broken in 4.14.48
2018-06-18 5:20 ` Greg Kroah-Hartman
@ 2018-06-18 5:39 ` Guenter Roeck
0 siblings, 0 replies; 5+ messages in thread
From: Guenter Roeck @ 2018-06-18 5:39 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Benjamin Gilbert, stable
On 06/17/2018 10:20 PM, Greg Kroah-Hartman wrote:
> On Thu, Jun 14, 2018 at 02:20:29PM -0700, Guenter Roeck wrote:
>> On Thu, Jun 14, 2018 at 05:09:21PM -0400, Benjamin Gilbert wrote:
>>> Hi,
>>>
>>> 4.14.48 can cause abnormally small TCP receive windows when the sender is
>>> faster than the receiver; see https://github.com/coreos/bugs/issues/2457 for
>>> details. Reverting "tcp: avoid integer overflows in tcp_rcv_space_adjust()"
>>> fixes it. Backporting 02db55718d53 ("tcp: do not overshoot window_clamp in
>>> tcp_rcv_space_adjust()"), which is its parent commit upstream, also fixes
>>> it.
>>>
>> 02db55718d53 applies cleanly, so I would suggest we go along that route
>> instead of a revert.
>>
>> Greg - given that the problematic commit is in all stable releases, it would
>> probably make sense to apply 02db55718d53 to pre-4.14 kernels as well. It
>> does apply clean to all kernels all the way back to 3.18.y.
>
> Ah, but it breaks the build everywhere, so I've dropped it :(
>
Sigh. Maybe I'll learn to compile test at some point.
> Can someone please backport it? I'll be glad to queue it up then.
>
Just sent a backport, though with a bit confused subject. I did compile
test it this time with 4.14.y and 4.9.y.
Guenter
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-06-18 5:39 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-14 21:09 TCP receive windows broken in 4.14.48 Benjamin Gilbert
2018-06-14 21:20 ` Guenter Roeck
2018-06-18 4:47 ` Greg Kroah-Hartman
2018-06-18 5:20 ` Greg Kroah-Hartman
2018-06-18 5:39 ` Guenter Roeck
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.