All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Andreas Gruenbacher <agruenba@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>,
	linux-xfs@vger.kernel.org,
	Dan Williams <dan.j.williams@intel.com>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	cluster-devel <cluster-devel@redhat.com>,
	linux-ext4 <linux-ext4@vger.kernel.org>
Subject: Re: iomap preparations for GFS2 v2
Date: Fri, 15 Jun 2018 10:03:27 +0200	[thread overview]
Message-ID: <20180615080326.GB19525@lst.de> (raw)
In-Reply-To: <CAHc6FU4nQ562SxepV1=dqcuuuPBWOTXr4sAiY_5H-Z7uOaTNng@mail.gmail.com>

On Thu, Jun 14, 2018 at 03:04:38PM +0200, Andreas Gruenbacher wrote:
> I saw that you've pushed this onto the gfs2-iomap branch in your xfs
> repository. I've rebased the gfs2 iomap-write branch onto that;
> there's a trivial patch for adding a private pointer to struct iomap
> at the head of that branch that would sense to move to the shared
> branch as well now.

Please send that patch out ASAP.

> The next step would probably be to start using iomap_readpage /
> iomap_readpages in gfs2 for block size == page size. This requires
> adding inline data support to iomap_readpage which is trivial, but
> because of gfs2's reliance on buffer heads, that alone isn't enough.

Is it?  At least for block size == page size we will only call
readpage on a pristine, newly allocated page.  So buffer heads won't
be in the game at that point, and the iomap buffered write code will
just allocate them for you once we start a write operation, or take
a page fault that makes the page writable.

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Andreas Gruenbacher <agruenba@redhat.com>
Cc: cluster-devel <cluster-devel@redhat.com>,
	linux-xfs@vger.kernel.org,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Dan Williams <dan.j.williams@intel.com>,
	linux-ext4 <linux-ext4@vger.kernel.org>,
	Christoph Hellwig <hch@lst.de>
Subject: Re: iomap preparations for GFS2 v2
Date: Fri, 15 Jun 2018 10:03:27 +0200	[thread overview]
Message-ID: <20180615080326.GB19525@lst.de> (raw)
In-Reply-To: <CAHc6FU4nQ562SxepV1=dqcuuuPBWOTXr4sAiY_5H-Z7uOaTNng@mail.gmail.com>

On Thu, Jun 14, 2018 at 03:04:38PM +0200, Andreas Gruenbacher wrote:
> I saw that you've pushed this onto the gfs2-iomap branch in your xfs
> repository. I've rebased the gfs2 iomap-write branch onto that;
> there's a trivial patch for adding a private pointer to struct iomap
> at the head of that branch that would sense to move to the shared
> branch as well now.

Please send that patch out ASAP.

> The next step would probably be to start using iomap_readpage /
> iomap_readpages in gfs2 for block size == page size. This requires
> adding inline data support to iomap_readpage which is trivial, but
> because of gfs2's reliance on buffer heads, that alone isn't enough.

Is it?  At least for block size == page size we will only call
readpage on a pristine, newly allocated page.  So buffer heads won't
be in the game at that point, and the iomap buffered write code will
just allocate them for you once we start a write operation, or take
a page fault that makes the page writable.

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] iomap preparations for GFS2 v2
Date: Fri, 15 Jun 2018 10:03:27 +0200	[thread overview]
Message-ID: <20180615080326.GB19525@lst.de> (raw)
In-Reply-To: <CAHc6FU4nQ562SxepV1=dqcuuuPBWOTXr4sAiY_5H-Z7uOaTNng@mail.gmail.com>

On Thu, Jun 14, 2018 at 03:04:38PM +0200, Andreas Gruenbacher wrote:
> I saw that you've pushed this onto the gfs2-iomap branch in your xfs
> repository. I've rebased the gfs2 iomap-write branch onto that;
> there's a trivial patch for adding a private pointer to struct iomap
> at the head of that branch that would sense to move to the shared
> branch as well now.

Please send that patch out ASAP.

> The next step would probably be to start using iomap_readpage /
> iomap_readpages in gfs2 for block size == page size. This requires
> adding inline data support to iomap_readpage which is trivial, but
> because of gfs2's reliance on buffer heads, that alone isn't enough.

Is it?  At least for block size == page size we will only call
readpage on a pristine, newly allocated page.  So buffer heads won't
be in the game at that point, and the iomap buffered write code will
just allocate them for you once we start a write operation, or take
a page fault that makes the page writable.



  reply	other threads:[~2018-06-15  7:55 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-14 12:04 iomap preparations for GFS2 v2 Christoph Hellwig
2018-06-14 12:04 ` [Cluster-devel] " Christoph Hellwig
2018-06-14 12:04 ` Christoph Hellwig
2018-06-14 12:04 ` [PATCH 1/6] fs: factor out a __generic_write_end helper Christoph Hellwig
2018-06-14 12:04   ` [Cluster-devel] " Christoph Hellwig
2018-06-14 12:04   ` Christoph Hellwig
2018-06-14 12:04 ` [PATCH 2/6] iomap: move bdev and dax_dev in a union Christoph Hellwig
2018-06-14 12:04   ` [Cluster-devel] " Christoph Hellwig
2018-06-14 12:04   ` Christoph Hellwig
2018-06-19  6:25   ` Darrick J. Wong
2018-06-19  6:25     ` [Cluster-devel] " Darrick J. Wong
2018-06-19  6:25     ` Darrick J. Wong
2018-06-19  6:44     ` Christoph Hellwig
2018-06-19  6:44       ` [Cluster-devel] " Christoph Hellwig
2018-06-19  6:44       ` Christoph Hellwig
2018-06-19  6:50       ` Darrick J. Wong
2018-06-19  6:50         ` [Cluster-devel] " Darrick J. Wong
2018-06-19  6:50         ` Darrick J. Wong
2018-06-14 12:04 ` [PATCH 3/6] iomap: mark newly allocated buffer heads as new Christoph Hellwig
2018-06-14 12:04   ` [Cluster-devel] " Christoph Hellwig
2018-06-14 12:04   ` Christoph Hellwig
2018-06-14 12:04 ` [PATCH 4/6] iomap: complete partial direct I/O writes synchronously Christoph Hellwig
2018-06-14 12:04   ` [Cluster-devel] " Christoph Hellwig
2018-06-14 12:04   ` Christoph Hellwig
2018-06-14 12:04 ` [PATCH 5/6] iomap: generic inline data handling Christoph Hellwig
2018-06-14 12:04   ` [Cluster-devel] " Christoph Hellwig
2018-06-14 12:04   ` Christoph Hellwig
2018-06-14 12:04 ` [PATCH 6/6] iomap: add a page_done callback Christoph Hellwig
2018-06-14 12:04   ` [Cluster-devel] " Christoph Hellwig
2018-06-14 12:04   ` Christoph Hellwig
2018-06-14 13:04 ` iomap preparations for GFS2 v2 Andreas Gruenbacher
2018-06-14 13:04   ` [Cluster-devel] " Andreas Gruenbacher
2018-06-14 13:04   ` Andreas Gruenbacher
2018-06-15  8:03   ` Christoph Hellwig [this message]
2018-06-15  8:03     ` [Cluster-devel] " Christoph Hellwig
2018-06-15  8:03     ` Christoph Hellwig
2018-06-15  8:31     ` [Cluster-devel] " Steven Whitehouse
2018-06-15  8:31       ` Steven Whitehouse
2018-06-15  8:31       ` Steven Whitehouse
2018-06-19 11:08       ` [Cluster-devel] " Andreas Gruenbacher
2018-06-19 11:08         ` Andreas Gruenbacher
2018-06-19 11:08         ` Andreas Gruenbacher
2018-06-19 14:35         ` [Cluster-devel] " Christoph Hellwig
2018-06-19 14:35           ` Christoph Hellwig
2018-06-19 14:35           ` Christoph Hellwig
2018-06-19 15:14           ` [Cluster-devel] " Andreas Gruenbacher
2018-06-19 15:14             ` Andreas Gruenbacher
2018-06-19 15:14             ` Andreas Gruenbacher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180615080326.GB19525@lst.de \
    --to=hch@lst.de \
    --cc=agruenba@redhat.com \
    --cc=cluster-devel@redhat.com \
    --cc=dan.j.williams@intel.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.