* [PATCH v2 2/2] dt-bindings: iio: dac: Add docs for AD5758 DAC @ 2018-06-07 13:11 ` Stefan Popa 0 siblings, 0 replies; 9+ messages in thread From: Stefan Popa @ 2018-06-07 13:11 UTC (permalink / raw) To: jic23, Michael.Hennerich, lars Cc: knaack.h, pmeerw, robh+dt, mark.rutland, mchehab, davem, gregkh, akpm, linus.walleij, rdunlap, devicetree, linux-iio, linux-kernel, stefan.popa Signed-off-by: Stefan Popa <stefan.popa@analog.com> --- Changes in v2: - Nothing changed, just to follow the patch set version. .../devicetree/bindings/iio/dac/ad5758.txt | 84 ++++++++++++++++++++++ MAINTAINERS | 1 + 2 files changed, 85 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/dac/ad5758.txt diff --git a/Documentation/devicetree/bindings/iio/dac/ad5758.txt b/Documentation/devicetree/bindings/iio/dac/ad5758.txt new file mode 100644 index 0000000..75fff6c --- /dev/null +++ b/Documentation/devicetree/bindings/iio/dac/ad5758.txt @@ -0,0 +1,84 @@ +Analog Devices AD5758 DAC device driver + +Required properties for the AD5758: + - compatible: Must be "adi,ad5758" + - reg: SPI chip select number for the device + - spi-max-frequency: Max SPI frequency to use (< 50000000) + - spi-cpha: is the only mode that is supported + +Optional properties: + + - adi,dc-dc-mode: Mode of operation of the dc-to-dc converter + The following values are currently supported: + * 0: DC-to-DC converter powered off + * 1: DPC current mode + * 2: DPC voltage mode + * 3: PPC current mode + + - adi,dc-dc-ilim: The dc-to-dc converter current limit + The following values are currently supported [mA]: + * 150 + * 200 + * 250 + * 300 + * 350 + * 400 + + - adi,slew: Array of slewrate settings should contain 3 fields: + 1: Should be either 0 or 1 in order to enable or disable slewrate. + 2: Slew rate clock: + Valid values for the slew rate update frequency [Hz]: + * 240000 + * 200000 + * 150000 + * 128000 + * 64000 + * 32000 + * 16000 + * 8000 + * 4000 + * 2000 + * 1000 + * 512 + * 256 + * 128 + * 64 + * 16 + 3: Slew rate step: + Defines by how much the output value changes at each update. + Valid values for the step size LSBs: + * 4 + * 12 + * 64 + * 120 + * 256 + * 500 + * 1820 + * 2048 + + - adi,range: The output range + The following values are currently supported: + * 0: 0 V to 5 V voltage range + * 1: 0 V to 10 V voltage range + * 2: ±5 V voltage range + * 3: ±10 V voltage range + * 8: 0 mA to 20 mA current range + * 9: 0 mA to 24 mA current range + * 10: 4 mA to 20 mA current range + * 11: ±20 mA current range + * 12: ±24 mA current range + * 13: −1 mA to +22 mA current range + +AD5758 Example: + + ad5758@0 { + compatible = "adi,ad5758"; + reg = <0>; + spi-max-frequency = <1000000>; + spi-cpha; + + adi,dc-dc-mode = <2>; + adi,dc-dc-ilim = <200>; + adi,slew = <1 200000 12>; + adi,range = <1>; + }; diff --git a/MAINTAINERS b/MAINTAINERS index 1993779..f640146 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -808,6 +808,7 @@ L: linux-iio@vger.kernel.org W: http://ez.analog.com/community/linux-device-drivers S: Supported F: drivers/iio/dac/ad5758.c +F: Documentation/devicetree/bindings/iio/dac/ad5758.txt ANALOG DEVICES INC AD9389B DRIVER M: Hans Verkuil <hans.verkuil@cisco.com> -- 2.7.4 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v2 2/2] dt-bindings: iio: dac: Add docs for AD5758 DAC @ 2018-06-07 13:11 ` Stefan Popa 0 siblings, 0 replies; 9+ messages in thread From: Stefan Popa @ 2018-06-07 13:11 UTC (permalink / raw) To: jic23, Michael.Hennerich, lars Cc: knaack.h, pmeerw, robh+dt, mark.rutland, mchehab, davem, gregkh, akpm, linus.walleij, rdunlap, devicetree, linux-iio, linux-kernel, stefan.popa Signed-off-by: Stefan Popa <stefan.popa@analog.com> --- Changes in v2: - Nothing changed, just to follow the patch set version. .../devicetree/bindings/iio/dac/ad5758.txt | 84 ++++++++++++++++++++++ MAINTAINERS | 1 + 2 files changed, 85 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/dac/ad5758.txt diff --git a/Documentation/devicetree/bindings/iio/dac/ad5758.txt b/Documentation/devicetree/bindings/iio/dac/ad5758.txt new file mode 100644 index 0000000..75fff6c --- /dev/null +++ b/Documentation/devicetree/bindings/iio/dac/ad5758.txt @@ -0,0 +1,84 @@ +Analog Devices AD5758 DAC device driver + +Required properties for the AD5758: + - compatible: Must be "adi,ad5758" + - reg: SPI chip select number for the device + - spi-max-frequency: Max SPI frequency to use (< 50000000) + - spi-cpha: is the only mode that is supported + +Optional properties: + + - adi,dc-dc-mode: Mode of operation of the dc-to-dc converter + The following values are currently supported: + * 0: DC-to-DC converter powered off + * 1: DPC current mode + * 2: DPC voltage mode + * 3: PPC current mode + + - adi,dc-dc-ilim: The dc-to-dc converter current limit + The following values are currently supported [mA]: + * 150 + * 200 + * 250 + * 300 + * 350 + * 400 + + - adi,slew: Array of slewrate settings should contain 3 fields: + 1: Should be either 0 or 1 in order to enable or disable slewrate. + 2: Slew rate clock: + Valid values for the slew rate update frequency [Hz]: + * 240000 + * 200000 + * 150000 + * 128000 + * 64000 + * 32000 + * 16000 + * 8000 + * 4000 + * 2000 + * 1000 + * 512 + * 256 + * 128 + * 64 + * 16 + 3: Slew rate step: + Defines by how much the output value changes at each update. + Valid values for the step size LSBs: + * 4 + * 12 + * 64 + * 120 + * 256 + * 500 + * 1820 + * 2048 + + - adi,range: The output range + The following values are currently supported: + * 0: 0 V to 5 V voltage range + * 1: 0 V to 10 V voltage range + * 2: ±5 V voltage range + * 3: ±10 V voltage range + * 8: 0 mA to 20 mA current range + * 9: 0 mA to 24 mA current range + * 10: 4 mA to 20 mA current range + * 11: ±20 mA current range + * 12: ±24 mA current range + * 13: −1 mA to +22 mA current range + +AD5758 Example: + + ad5758@0 { + compatible = "adi,ad5758"; + reg = <0>; + spi-max-frequency = <1000000>; + spi-cpha; + + adi,dc-dc-mode = <2>; + adi,dc-dc-ilim = <200>; + adi,slew = <1 200000 12>; + adi,range = <1>; + }; diff --git a/MAINTAINERS b/MAINTAINERS index 1993779..f640146 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -808,6 +808,7 @@ L: linux-iio@vger.kernel.org W: http://ez.analog.com/community/linux-device-drivers S: Supported F: drivers/iio/dac/ad5758.c +F: Documentation/devicetree/bindings/iio/dac/ad5758.txt ANALOG DEVICES INC AD9389B DRIVER M: Hans Verkuil <hans.verkuil@cisco.com> -- 2.7.4 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2 2/2] dt-bindings: iio: dac: Add docs for AD5758 DAC 2018-06-07 13:11 ` Stefan Popa (?) @ 2018-06-10 13:59 ` Jonathan Cameron -1 siblings, 0 replies; 9+ messages in thread From: Jonathan Cameron @ 2018-06-10 13:59 UTC (permalink / raw) To: Stefan Popa Cc: Michael.Hennerich, lars, knaack.h, pmeerw, robh+dt, mark.rutland, mchehab, davem, gregkh, akpm, linus.walleij, rdunlap, devicetree, linux-iio, linux-kernel On Thu, 7 Jun 2018 16:11:05 +0300 Stefan Popa <stefan.popa@analog.com> wrote: > Signed-off-by: Stefan Popa <stefan.popa@analog.com> Hmm. The first part number I've ever googled where the top hit has been a flight number. Rio de Janeiro to Campinas is apparently on time today. > --- > Changes in v2: > - Nothing changed, just to follow the patch set version. > > .../devicetree/bindings/iio/dac/ad5758.txt | 84 ++++++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 85 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/dac/ad5758.txt > > diff --git a/Documentation/devicetree/bindings/iio/dac/ad5758.txt b/Documentation/devicetree/bindings/iio/dac/ad5758.txt > new file mode 100644 > index 0000000..75fff6c > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/dac/ad5758.txt > @@ -0,0 +1,84 @@ > +Analog Devices AD5758 DAC device driver > + > +Required properties for the AD5758: > + - compatible: Must be "adi,ad5758" > + - reg: SPI chip select number for the device > + - spi-max-frequency: Max SPI frequency to use (< 50000000) > + - spi-cpha: is the only mode that is supported > + > +Optional properties: > + > + - adi,dc-dc-mode: Mode of operation of the dc-to-dc converter > + The following values are currently supported: > + * 0: DC-to-DC converter powered off > + * 1: DPC current mode Perhaps expand those acronyms? Dynamic Power Control and perhaps a bit of explanation so people who are ready DT files don't have to go find the data sheet to have some idea of what these are? Otherwise, binding is fine. > + * 2: DPC voltage mode > + * 3: PPC current mode > + > + - adi,dc-dc-ilim: The dc-to-dc converter current limit > + The following values are currently supported [mA]: Unit should be in the name. adi,dc-dc-ilim_ma > + * 150 > + * 200 > + * 250 > + * 300 > + * 350 > + * 400 > + > + - adi,slew: Array of slewrate settings should contain 3 fields: > + 1: Should be either 0 or 1 in order to enable or disable slewrate. If it is disabled, why not just detect that as the 'not here' version and then you can drop this element? > + 2: Slew rate clock: > + Valid values for the slew rate update frequency [Hz]: > + * 240000 > + * 200000 > + * 150000 > + * 128000 > + * 64000 > + * 32000 > + * 16000 > + * 8000 > + * 4000 > + * 2000 > + * 1000 > + * 512 > + * 256 > + * 128 > + * 64 > + * 16 > + 3: Slew rate step: > + Defines by how much the output value changes at each update. > + Valid values for the step size LSBs: > + * 4 > + * 12 > + * 64 > + * 120 > + * 256 > + * 500 > + * 1820 > + * 2048 I think these last two are kind of separate parameters, would be interested to hear if Rob thinks this should be separate or not. They are both related to slew rate, but different elements that add up to it. > + > + - adi,range: The output range > + The following values are currently supported: > + * 0: 0 V to 5 V voltage range > + * 1: 0 V to 10 V voltage range > + * 2: ±5 V voltage range > + * 3: ±10 V voltage range > + * 8: 0 mA to 20 mA current range > + * 9: 0 mA to 24 mA current range > + * 10: 4 mA to 20 mA current range > + * 11: ±20 mA current range > + * 12: ±24 mA current range > + * 13: −1 mA to +22 mA current range Not sure if we can't represent this better. It's either a current or voltage output device. adi,voltage_output or something like that or use adi,voltage_range_v = <0 5> adi,current_range_ma = <-1 22> etc with it only being valid to specify one or the other. I much prefer DT elements that don't require looking at the docs where possible. Again, Rob's input on this would be good. > + > +AD5758 Example: > + > + ad5758@0 { > + compatible = "adi,ad5758"; > + reg = <0>; > + spi-max-frequency = <1000000>; > + spi-cpha; > + > + adi,dc-dc-mode = <2>; > + adi,dc-dc-ilim = <200>; > + adi,slew = <1 200000 12>; > + adi,range = <1>; > + }; > diff --git a/MAINTAINERS b/MAINTAINERS > index 1993779..f640146 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -808,6 +808,7 @@ L: linux-iio@vger.kernel.org > W: http://ez.analog.com/community/linux-device-drivers > S: Supported > F: drivers/iio/dac/ad5758.c > +F: Documentation/devicetree/bindings/iio/dac/ad5758.txt > > ANALOG DEVICES INC AD9389B DRIVER > M: Hans Verkuil <hans.verkuil@cisco.com> ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 2/2] dt-bindings: iio: dac: Add docs for AD5758 DAC @ 2018-06-10 13:59 ` Jonathan Cameron 0 siblings, 0 replies; 9+ messages in thread From: Jonathan Cameron @ 2018-06-10 13:59 UTC (permalink / raw) To: Stefan Popa Cc: Michael.Hennerich, lars, knaack.h, pmeerw, robh+dt, mark.rutland, mchehab, davem, gregkh, akpm, linus.walleij, rdunlap, devicetree, linux-iio, linux-kernel On Thu, 7 Jun 2018 16:11:05 +0300 Stefan Popa <stefan.popa@analog.com> wrote: > Signed-off-by: Stefan Popa <stefan.popa@analog.com> Hmm. The first part number I've ever googled where the top hit has been a flight number.=20 Rio de Janeiro to Campinas is apparently on time today. > --- > Changes in v2: > - Nothing changed, just to follow the patch set version. >=20 > .../devicetree/bindings/iio/dac/ad5758.txt | 84 ++++++++++++++++= ++++++ > MAINTAINERS | 1 + > 2 files changed, 85 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/dac/ad5758.txt >=20 > diff --git a/Documentation/devicetree/bindings/iio/dac/ad5758.txt b/Docum= entation/devicetree/bindings/iio/dac/ad5758.txt > new file mode 100644 > index 0000000..75fff6c > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/dac/ad5758.txt > @@ -0,0 +1,84 @@ > +Analog Devices AD5758 DAC device driver > + > +Required properties for the AD5758: > + - compatible: Must be "adi,ad5758" > + - reg: SPI chip select number for the device > + - spi-max-frequency: Max SPI frequency to use (< 50000000) > + - spi-cpha: is the only mode that is supported > + > +Optional properties: > + > + - adi,dc-dc-mode: Mode of operation of the dc-to-dc converter > + The following values are currently supported: > + * 0: DC-to-DC converter powered off > + * 1: DPC current mode Perhaps expand those acronyms? Dynamic Power Control and perhaps a bit of explanation so people who are ready DT files don't have to go find the data sheet to have some idea of what these are? Otherwise, binding is fine. > + * 2: DPC voltage mode > + * 3: PPC current mode > + > + - adi,dc-dc-ilim: The dc-to-dc converter current limit > + The following values are currently supported [mA]: Unit should be in the name. adi,dc-dc-ilim_ma > + * 150 > + * 200 > + * 250 > + * 300 > + * 350 > + * 400 > + > + - adi,slew: Array of slewrate settings should contain 3 fields: > + 1: Should be either 0 or 1 in order to enable or disable slewrate. If it is disabled, why not just detect that as the 'not here' version and then you can drop this element? > + 2: Slew rate clock: > + Valid values for the slew rate update frequency [Hz]: > + * 240000 > + * 200000 > + * 150000 > + * 128000 > + * 64000 > + * 32000 > + * 16000 > + * 8000 > + * 4000 > + * 2000 > + * 1000 > + * 512 > + * 256 > + * 128 > + * 64 > + * 16 > + 3: Slew rate step: > + Defines by how much the output value changes at each update. > + Valid values for the step size LSBs: > + * 4 > + * 12 > + * 64 > + * 120 > + * 256 > + * 500 > + * 1820 > + * 2048 I think these last two are kind of separate parameters, would be interested to hear if Rob thinks this should be separate or not. They are both related to slew rate, but different elements that add up to it. > + > + - adi,range: The output range > + The following values are currently supported: > + * 0: 0 V to 5 V voltage range > + * 1: 0 V to 10 V voltage range > + * 2: =C2=B15 V voltage range > + * 3: =C2=B110 V voltage range > + * 8: 0 mA to 20 mA current range > + * 9: 0 mA to 24 mA current range > + * 10: 4 mA to 20 mA current range > + * 11: =C2=B120 mA current range > + * 12: =C2=B124 mA current range > + * 13: =E2=88=921 mA to +22 mA current range Not sure if we can't represent this better. It's either a current or voltage output device. adi,voltage_output or something like that or use adi,voltage_range_v =3D <0 5> adi,current_range_ma =3D <-1 22> etc with it only being valid to specify one or the other. I much prefer DT elements that don't require looking at the docs where possible. Again, Rob's input on this would be good. > + > +AD5758 Example: > + > + ad5758@0 { > + compatible =3D "adi,ad5758"; > + reg =3D <0>; > + spi-max-frequency =3D <1000000>; > + spi-cpha; > + > + adi,dc-dc-mode =3D <2>; > + adi,dc-dc-ilim =3D <200>; > + adi,slew =3D <1 200000 12>; > + adi,range =3D <1>; > + }; > diff --git a/MAINTAINERS b/MAINTAINERS > index 1993779..f640146 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -808,6 +808,7 @@ L: linux-iio@vger.kernel.org > W: http://ez.analog.com/community/linux-device-drivers > S: Supported > F: drivers/iio/dac/ad5758.c > +F: Documentation/devicetree/bindings/iio/dac/ad5758.txt > =20 > ANALOG DEVICES INC AD9389B DRIVER > M: Hans Verkuil <hans.verkuil@cisco.com> ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 2/2] dt-bindings: iio: dac: Add docs for AD5758 DAC @ 2018-06-10 13:59 ` Jonathan Cameron 0 siblings, 0 replies; 9+ messages in thread From: Jonathan Cameron @ 2018-06-10 13:59 UTC (permalink / raw) To: Stefan Popa Cc: Michael.Hennerich, lars, knaack.h, pmeerw, robh+dt, mark.rutland, mchehab, davem, gregkh, akpm, linus.walleij, rdunlap, devicetree, linux-iio, linux-kernel On Thu, 7 Jun 2018 16:11:05 +0300 Stefan Popa <stefan.popa@analog.com> wrote: > Signed-off-by: Stefan Popa <stefan.popa@analog.com> Hmm. The first part number I've ever googled where the top hit has been a flight number. Rio de Janeiro to Campinas is apparently on time today. > --- > Changes in v2: > - Nothing changed, just to follow the patch set version. > > .../devicetree/bindings/iio/dac/ad5758.txt | 84 ++++++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 85 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/dac/ad5758.txt > > diff --git a/Documentation/devicetree/bindings/iio/dac/ad5758.txt b/Documentation/devicetree/bindings/iio/dac/ad5758.txt > new file mode 100644 > index 0000000..75fff6c > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/dac/ad5758.txt > @@ -0,0 +1,84 @@ > +Analog Devices AD5758 DAC device driver > + > +Required properties for the AD5758: > + - compatible: Must be "adi,ad5758" > + - reg: SPI chip select number for the device > + - spi-max-frequency: Max SPI frequency to use (< 50000000) > + - spi-cpha: is the only mode that is supported > + > +Optional properties: > + > + - adi,dc-dc-mode: Mode of operation of the dc-to-dc converter > + The following values are currently supported: > + * 0: DC-to-DC converter powered off > + * 1: DPC current mode Perhaps expand those acronyms? Dynamic Power Control and perhaps a bit of explanation so people who are ready DT files don't have to go find the data sheet to have some idea of what these are? Otherwise, binding is fine. > + * 2: DPC voltage mode > + * 3: PPC current mode > + > + - adi,dc-dc-ilim: The dc-to-dc converter current limit > + The following values are currently supported [mA]: Unit should be in the name. adi,dc-dc-ilim_ma > + * 150 > + * 200 > + * 250 > + * 300 > + * 350 > + * 400 > + > + - adi,slew: Array of slewrate settings should contain 3 fields: > + 1: Should be either 0 or 1 in order to enable or disable slewrate. If it is disabled, why not just detect that as the 'not here' version and then you can drop this element? > + 2: Slew rate clock: > + Valid values for the slew rate update frequency [Hz]: > + * 240000 > + * 200000 > + * 150000 > + * 128000 > + * 64000 > + * 32000 > + * 16000 > + * 8000 > + * 4000 > + * 2000 > + * 1000 > + * 512 > + * 256 > + * 128 > + * 64 > + * 16 > + 3: Slew rate step: > + Defines by how much the output value changes at each update. > + Valid values for the step size LSBs: > + * 4 > + * 12 > + * 64 > + * 120 > + * 256 > + * 500 > + * 1820 > + * 2048 I think these last two are kind of separate parameters, would be interested to hear if Rob thinks this should be separate or not. They are both related to slew rate, but different elements that add up to it. > + > + - adi,range: The output range > + The following values are currently supported: > + * 0: 0 V to 5 V voltage range > + * 1: 0 V to 10 V voltage range > + * 2: ±5 V voltage range > + * 3: ±10 V voltage range > + * 8: 0 mA to 20 mA current range > + * 9: 0 mA to 24 mA current range > + * 10: 4 mA to 20 mA current range > + * 11: ±20 mA current range > + * 12: ±24 mA current range > + * 13: −1 mA to +22 mA current range Not sure if we can't represent this better. It's either a current or voltage output device. adi,voltage_output or something like that or use adi,voltage_range_v = <0 5> adi,current_range_ma = <-1 22> etc with it only being valid to specify one or the other. I much prefer DT elements that don't require looking at the docs where possible. Again, Rob's input on this would be good. > + > +AD5758 Example: > + > + ad5758@0 { > + compatible = "adi,ad5758"; > + reg = <0>; > + spi-max-frequency = <1000000>; > + spi-cpha; > + > + adi,dc-dc-mode = <2>; > + adi,dc-dc-ilim = <200>; > + adi,slew = <1 200000 12>; > + adi,range = <1>; > + }; > diff --git a/MAINTAINERS b/MAINTAINERS > index 1993779..f640146 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -808,6 +808,7 @@ L: linux-iio@vger.kernel.org > W: http://ez.analog.com/community/linux-device-drivers > S: Supported > F: drivers/iio/dac/ad5758.c > +F: Documentation/devicetree/bindings/iio/dac/ad5758.txt > > ANALOG DEVICES INC AD9389B DRIVER > M: Hans Verkuil <hans.verkuil@cisco.com> ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 2/2] dt-bindings: iio: dac: Add docs for AD5758 DAC 2018-06-10 13:59 ` Jonathan Cameron (?) (?) @ 2018-06-12 18:21 ` Rob Herring -1 siblings, 0 replies; 9+ messages in thread From: Rob Herring @ 2018-06-12 18:21 UTC (permalink / raw) To: Jonathan Cameron Cc: Stefan Popa, Michael.Hennerich, lars, knaack.h, pmeerw, mark.rutland, mchehab, davem, gregkh, akpm, linus.walleij, rdunlap, devicetree, linux-iio, linux-kernel On Sun, Jun 10, 2018 at 02:59:23PM +0100, Jonathan Cameron wrote: > On Thu, 7 Jun 2018 16:11:05 +0300 > Stefan Popa <stefan.popa@analog.com> wrote: > > > Signed-off-by: Stefan Popa <stefan.popa@analog.com> > Hmm. The first part number I've ever googled where the top hit has > been a flight number. > Rio de Janeiro to Campinas is apparently on time today. > > > --- > > Changes in v2: > > - Nothing changed, just to follow the patch set version. > > > > .../devicetree/bindings/iio/dac/ad5758.txt | 84 ++++++++++++++++++++++ > > MAINTAINERS | 1 + > > 2 files changed, 85 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/iio/dac/ad5758.txt > > > > diff --git a/Documentation/devicetree/bindings/iio/dac/ad5758.txt b/Documentation/devicetree/bindings/iio/dac/ad5758.txt > > new file mode 100644 > > index 0000000..75fff6c > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/iio/dac/ad5758.txt > > @@ -0,0 +1,84 @@ > > +Analog Devices AD5758 DAC device driver > > + > > +Required properties for the AD5758: > > + - compatible: Must be "adi,ad5758" > > + - reg: SPI chip select number for the device > > + - spi-max-frequency: Max SPI frequency to use (< 50000000) > > + - spi-cpha: is the only mode that is supported > > + > > +Optional properties: > > + > > + - adi,dc-dc-mode: Mode of operation of the dc-to-dc converter > > + The following values are currently supported: > > + * 0: DC-to-DC converter powered off > > + * 1: DPC current mode > Perhaps expand those acronyms? > Dynamic Power Control and perhaps a bit of explanation so people > who are ready DT files don't have to go find the data sheet to have > some idea of what these are? > > Otherwise, binding is fine. > > > + * 2: DPC voltage mode > > + * 3: PPC current mode > > + > > + - adi,dc-dc-ilim: The dc-to-dc converter current limit > > + The following values are currently supported [mA]: > Unit should be in the name. > adi,dc-dc-ilim_ma Yes, but don't use '_' and follow what is in property-units.txt. ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 2/2] dt-bindings: iio: dac: Add docs for AD5758 DAC 2018-06-07 13:11 ` Stefan Popa (?) (?) @ 2018-06-11 8:42 ` Linus Walleij 2018-06-16 17:49 ` Jonathan Cameron -1 siblings, 1 reply; 9+ messages in thread From: Linus Walleij @ 2018-06-11 8:42 UTC (permalink / raw) To: Stefan Popa Cc: Jonathan Cameron, Michael Hennerich, Lars-Peter Clausen, Hartmut Knaack, Peter Meerwald, Rob Herring, Mark Rutland, Mauro Carvalho Chehab, David S. Miller, Greg KH, Andrew Morton, Randy Dunlap, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, linux-iio, linux-kernel On Thu, Jun 7, 2018 at 3:11 PM, Stefan Popa <stefan.popa@analog.com> wrote: > + - adi,slew: Array of slewrate settings should contain 3 fields: > + 1: Should be either 0 or 1 in order to enable or disable slewrate. We have a standard binding in pin control for "slew-rate". It doesn't have a unit today though. > + 2: Slew rate clock: > + Valid values for the slew rate update frequency [Hz]: > + * 240000 > + * 200000 > + * 150000 > + * 128000 > + * 64000 > + * 32000 > + * 16000 > + * 8000 > + * 4000 > + * 2000 > + * 1000 > + * 512 > + * 256 > + * 128 > + * 64 > + * 16 > + 3: Slew rate step: > + Defines by how much the output value changes at each update. > + Valid values for the step size LSBs: > + * 4 > + * 12 > + * 64 > + * 120 > + * 256 > + * 500 > + * 1820 > + * 2048 This is pretty idiomatic and just encodes the configuration fields from the hardware into the device tree. The normal slew rate unit is Volts per microsecond. I get the feeling that we could define that simply, and then calculate the slew rate clock and step using that to find the best match for a certain slew rate. Yours, Linus Walleij ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 2/2] dt-bindings: iio: dac: Add docs for AD5758 DAC 2018-06-11 8:42 ` Linus Walleij @ 2018-06-16 17:49 ` Jonathan Cameron 0 siblings, 0 replies; 9+ messages in thread From: Jonathan Cameron @ 2018-06-16 17:49 UTC (permalink / raw) To: Linus Walleij Cc: Stefan Popa, Michael Hennerich, Lars-Peter Clausen, Hartmut Knaack, Peter Meerwald, Rob Herring, Mark Rutland, Mauro Carvalho Chehab, David S. Miller, Greg KH, Andrew Morton, Randy Dunlap, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, linux-iio, linux-kernel On Mon, 11 Jun 2018 10:42:35 +0200 Linus Walleij <linus.walleij@linaro.org> wrote: > On Thu, Jun 7, 2018 at 3:11 PM, Stefan Popa <stefan.popa@analog.com> wrote: > > > + - adi,slew: Array of slewrate settings should contain 3 fields: > > + 1: Should be either 0 or 1 in order to enable or disable slewrate. > > We have a standard binding in pin control for "slew-rate". > > It doesn't have a unit today though. > > > + 2: Slew rate clock: > > + Valid values for the slew rate update frequency [Hz]: > > + * 240000 > > + * 200000 > > + * 150000 > > + * 128000 > > + * 64000 > > + * 32000 > > + * 16000 > > + * 8000 > > + * 4000 > > + * 2000 > > + * 1000 > > + * 512 > > + * 256 > > + * 128 > > + * 64 > > + * 16 > > + 3: Slew rate step: > > + Defines by how much the output value changes at each update. > > + Valid values for the step size LSBs: > > + * 4 > > + * 12 > > + * 64 > > + * 120 > > + * 256 > > + * 500 > > + * 1820 > > + * 2048 > > This is pretty idiomatic and just encodes the configuration fields from the > hardware into the device tree. > > The normal slew rate unit is Volts per microsecond. > > I get the feeling that we could define that simply, and then calculate > the slew rate clock and step using that to find the best match for > a certain slew rate. > > Yours, > Linus Walleij Agreed. A single value would be nice if possible. J ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 2/2] dt-bindings: iio: dac: Add docs for AD5758 DAC @ 2018-06-16 17:49 ` Jonathan Cameron 0 siblings, 0 replies; 9+ messages in thread From: Jonathan Cameron @ 2018-06-16 17:49 UTC (permalink / raw) To: Linus Walleij Cc: Stefan Popa, Michael Hennerich, Lars-Peter Clausen, Hartmut Knaack, Peter Meerwald, Rob Herring, Mark Rutland, Mauro Carvalho Chehab, David S. Miller, Greg KH, Andrew Morton, Randy Dunlap, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, linux-iio, linux-kernel On Mon, 11 Jun 2018 10:42:35 +0200 Linus Walleij <linus.walleij@linaro.org> wrote: > On Thu, Jun 7, 2018 at 3:11 PM, Stefan Popa <stefan.popa@analog.com> wrote: > > > + - adi,slew: Array of slewrate settings should contain 3 fields: > > + 1: Should be either 0 or 1 in order to enable or disable slewrate. > > We have a standard binding in pin control for "slew-rate". > > It doesn't have a unit today though. > > > + 2: Slew rate clock: > > + Valid values for the slew rate update frequency [Hz]: > > + * 240000 > > + * 200000 > > + * 150000 > > + * 128000 > > + * 64000 > > + * 32000 > > + * 16000 > > + * 8000 > > + * 4000 > > + * 2000 > > + * 1000 > > + * 512 > > + * 256 > > + * 128 > > + * 64 > > + * 16 > > + 3: Slew rate step: > > + Defines by how much the output value changes at each update. > > + Valid values for the step size LSBs: > > + * 4 > > + * 12 > > + * 64 > > + * 120 > > + * 256 > > + * 500 > > + * 1820 > > + * 2048 > > This is pretty idiomatic and just encodes the configuration fields from the > hardware into the device tree. > > The normal slew rate unit is Volts per microsecond. > > I get the feeling that we could define that simply, and then calculate > the slew rate clock and step using that to find the best match for > a certain slew rate. > > Yours, > Linus Walleij Agreed. A single value would be nice if possible. J ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2018-06-16 17:49 UTC | newest] Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-06-07 13:11 [PATCH v2 2/2] dt-bindings: iio: dac: Add docs for AD5758 DAC Stefan Popa 2018-06-07 13:11 ` Stefan Popa 2018-06-10 13:59 ` Jonathan Cameron 2018-06-10 13:59 ` Jonathan Cameron 2018-06-10 13:59 ` Jonathan Cameron 2018-06-12 18:21 ` Rob Herring 2018-06-11 8:42 ` Linus Walleij 2018-06-16 17:49 ` Jonathan Cameron 2018-06-16 17:49 ` Jonathan Cameron
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.