All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Karim Eshapa <karim.eshapa@gmail.com>
Cc: lars@metafoo.de, Michael.Hennerich@analog.com, knaack.h@gmx.de,
	pmeerw@pmeerw.net, gregkh@linuxfoundation.org,
	linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging:iio:accel:adis16240: sign extend function avoiding code duplication
Date: Sat, 16 Jun 2018 19:02:26 +0100	[thread overview]
Message-ID: <20180616190226.4a6a5980@archlinux> (raw)
In-Reply-To: <20180612162153.21789-1-karim.eshapa@gmail.com>

On Tue, 12 Jun 2018 18:21:53 +0200
Karim Eshapa <karim.eshapa@gmail.com> wrote:

> Use sign_extend32 kernel function instead of code duplication,
> Safe also for 16 bit. and remove declaration of bits variable not needed.
> 
> Signed-off-by: Karim Eshapa <karim.eshapa@gmail.com>

Please consider how a patch is applied and resend as a v3 which can actually 
be applied.  Test it (by applying it yourself) to make sure you have everything correct...

Jonathan

> 
> >On Tue, 2018-06-12 at 01:38 +0200, Karim Eshapa wrote:  
> >> Use sign_extend32 kernel function instead of code duplication.
> >> Safe also for 16 bit.  
> >
> >Perhaps remove the bits declaration and assignments
> >and just use 9 directly.
> >  
> >> diff --git a/drivers/staging/iio/accel/adis16240.c b/drivers/staging/iio/accel/adis16240.c  
> >  
> >> @@ -292,9 +292,7 @@ static int adis16240_read_raw(struct iio_dev *indio_dev,
> >>               ret = adis_read_reg_16(st, addr, &val16);
> >>               if (ret)
> >>                       return ret;
> >> -             val16 &= (1 << bits) - 1;
> >> -             val16 = (s16)(val16 << (16 - bits)) >> (16 - bits);
> >> -             *val = val16;
> >> +             *val = sign_extend32(val16, bits - 1);
> >>               return IIO_VAL_INT;
> >>       case IIO_CHAN_INFO_PEAK:
> >>               bits = 10;
> >> @@ -302,9 +300,7 @@ static int adis16240_read_raw(struct iio_dev *indio_dev,
> >>               ret = adis_read_reg_16(st, addr, &val16);
> >>               if (ret)
> >>                       return ret;
> >> -             val16 &= (1 << bits) - 1;
> >> -             val16 = (s16)(val16 << (16 - bits)) >> (16 - bits);
> >> -             *val = val16;
> >> +             *val = sign_extend32(val16, bits - 1);
> >>               return IIO_VAL_INT;
> >>       }
> >>       return -EINVAL;  
> ---
>  drivers/staging/iio/accel/adis16240.c | 11 ++---------
>  1 file changed, 2 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/staging/iio/accel/adis16240.c b/drivers/staging/iio/accel/adis16240.c
> index fff6d99089cc..24e525f1ef25 100644
> --- a/drivers/staging/iio/accel/adis16240.c
> +++ b/drivers/staging/iio/accel/adis16240.c
> @@ -250,7 +250,6 @@ static int adis16240_read_raw(struct iio_dev *indio_dev,
>  {
>  	struct adis *st = iio_priv(indio_dev);
>  	int ret;
> -	int bits;
>  	u8 addr;
>  	s16 val16;
>  
> @@ -287,24 +286,18 @@ static int adis16240_read_raw(struct iio_dev *indio_dev,
>  		*val = 25000 / 244 - 0x133; /* 25 C = 0x133 */
>  		return IIO_VAL_INT;
>  	case IIO_CHAN_INFO_CALIBBIAS:
> -		bits = 10;
>  		addr = adis16240_addresses[chan->scan_index][0];
>  		ret = adis_read_reg_16(st, addr, &val16);
>  		if (ret)
>  			return ret;
> -		val16 &= (1 << bits) - 1;
> -		val16 = (s16)(val16 << (16 - bits)) >> (16 - bits);
> -		*val = val16;
> +		*val = sign_extend32(val16, 9);
>  		return IIO_VAL_INT;
>  	case IIO_CHAN_INFO_PEAK:
> -		bits = 10;
>  		addr = adis16240_addresses[chan->scan_index][1];
>  		ret = adis_read_reg_16(st, addr, &val16);
>  		if (ret)
>  			return ret;
> -		val16 &= (1 << bits) - 1;
> -		val16 = (s16)(val16 << (16 - bits)) >> (16 - bits);
> -		*val = val16;
> +		*val = sign_extend32(val16, 9);
>  		return IIO_VAL_INT;
>  	}
>  	return -EINVAL;


  reply	other threads:[~2018-06-16 18:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-12 16:21 [PATCH v2] staging:iio:accel:adis16240: sign extend function avoiding code duplication Karim Eshapa
2018-06-16 18:02 ` Jonathan Cameron [this message]
2018-06-17  0:25   ` karim eshapa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180616190226.4a6a5980@archlinux \
    --to=jic23@kernel.org \
    --cc=Michael.Hennerich@analog.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=karim.eshapa@gmail.com \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.