* [PATCH v2] staging:iio:accel:adis16240: sign extend function avoiding code duplication
@ 2018-06-12 16:21 Karim Eshapa
2018-06-16 18:02 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Karim Eshapa @ 2018-06-12 16:21 UTC (permalink / raw)
To: lars
Cc: Michael.Hennerich, jic23, knaack.h, pmeerw, gregkh, linux-iio,
devel, linux-kernel, Karim Eshapa
Use sign_extend32 kernel function instead of code duplication,
Safe also for 16 bit. and remove declaration of bits variable not needed.
Signed-off-by: Karim Eshapa <karim.eshapa@gmail.com>
>On Tue, 2018-06-12 at 01:38 +0200, Karim Eshapa wrote:
>> Use sign_extend32 kernel function instead of code duplication.
>> Safe also for 16 bit.
>
>Perhaps remove the bits declaration and assignments
>and just use 9 directly.
>
>> diff --git a/drivers/staging/iio/accel/adis16240.c b/drivers/staging/iio/accel/adis16240.c
>
>> @@ -292,9 +292,7 @@ static int adis16240_read_raw(struct iio_dev *indio_dev,
>> ret = adis_read_reg_16(st, addr, &val16);
>> if (ret)
>> return ret;
>> - val16 &= (1 << bits) - 1;
>> - val16 = (s16)(val16 << (16 - bits)) >> (16 - bits);
>> - *val = val16;
>> + *val = sign_extend32(val16, bits - 1);
>> return IIO_VAL_INT;
>> case IIO_CHAN_INFO_PEAK:
>> bits = 10;
>> @@ -302,9 +300,7 @@ static int adis16240_read_raw(struct iio_dev *indio_dev,
>> ret = adis_read_reg_16(st, addr, &val16);
>> if (ret)
>> return ret;
>> - val16 &= (1 << bits) - 1;
>> - val16 = (s16)(val16 << (16 - bits)) >> (16 - bits);
>> - *val = val16;
>> + *val = sign_extend32(val16, bits - 1);
>> return IIO_VAL_INT;
>> }
>> return -EINVAL;
---
drivers/staging/iio/accel/adis16240.c | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/iio/accel/adis16240.c b/drivers/staging/iio/accel/adis16240.c
index fff6d99089cc..24e525f1ef25 100644
--- a/drivers/staging/iio/accel/adis16240.c
+++ b/drivers/staging/iio/accel/adis16240.c
@@ -250,7 +250,6 @@ static int adis16240_read_raw(struct iio_dev *indio_dev,
{
struct adis *st = iio_priv(indio_dev);
int ret;
- int bits;
u8 addr;
s16 val16;
@@ -287,24 +286,18 @@ static int adis16240_read_raw(struct iio_dev *indio_dev,
*val = 25000 / 244 - 0x133; /* 25 C = 0x133 */
return IIO_VAL_INT;
case IIO_CHAN_INFO_CALIBBIAS:
- bits = 10;
addr = adis16240_addresses[chan->scan_index][0];
ret = adis_read_reg_16(st, addr, &val16);
if (ret)
return ret;
- val16 &= (1 << bits) - 1;
- val16 = (s16)(val16 << (16 - bits)) >> (16 - bits);
- *val = val16;
+ *val = sign_extend32(val16, 9);
return IIO_VAL_INT;
case IIO_CHAN_INFO_PEAK:
- bits = 10;
addr = adis16240_addresses[chan->scan_index][1];
ret = adis_read_reg_16(st, addr, &val16);
if (ret)
return ret;
- val16 &= (1 << bits) - 1;
- val16 = (s16)(val16 << (16 - bits)) >> (16 - bits);
- *val = val16;
+ *val = sign_extend32(val16, 9);
return IIO_VAL_INT;
}
return -EINVAL;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] staging:iio:accel:adis16240: sign extend function avoiding code duplication
2018-06-12 16:21 [PATCH v2] staging:iio:accel:adis16240: sign extend function avoiding code duplication Karim Eshapa
@ 2018-06-16 18:02 ` Jonathan Cameron
2018-06-17 0:25 ` karim eshapa
0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Cameron @ 2018-06-16 18:02 UTC (permalink / raw)
To: Karim Eshapa
Cc: lars, Michael.Hennerich, knaack.h, pmeerw, gregkh, linux-iio,
devel, linux-kernel
On Tue, 12 Jun 2018 18:21:53 +0200
Karim Eshapa <karim.eshapa@gmail.com> wrote:
> Use sign_extend32 kernel function instead of code duplication,
> Safe also for 16 bit. and remove declaration of bits variable not needed.
>
> Signed-off-by: Karim Eshapa <karim.eshapa@gmail.com>
Please consider how a patch is applied and resend as a v3 which can actually
be applied. Test it (by applying it yourself) to make sure you have everything correct...
Jonathan
>
> >On Tue, 2018-06-12 at 01:38 +0200, Karim Eshapa wrote:
> >> Use sign_extend32 kernel function instead of code duplication.
> >> Safe also for 16 bit.
> >
> >Perhaps remove the bits declaration and assignments
> >and just use 9 directly.
> >
> >> diff --git a/drivers/staging/iio/accel/adis16240.c b/drivers/staging/iio/accel/adis16240.c
> >
> >> @@ -292,9 +292,7 @@ static int adis16240_read_raw(struct iio_dev *indio_dev,
> >> ret = adis_read_reg_16(st, addr, &val16);
> >> if (ret)
> >> return ret;
> >> - val16 &= (1 << bits) - 1;
> >> - val16 = (s16)(val16 << (16 - bits)) >> (16 - bits);
> >> - *val = val16;
> >> + *val = sign_extend32(val16, bits - 1);
> >> return IIO_VAL_INT;
> >> case IIO_CHAN_INFO_PEAK:
> >> bits = 10;
> >> @@ -302,9 +300,7 @@ static int adis16240_read_raw(struct iio_dev *indio_dev,
> >> ret = adis_read_reg_16(st, addr, &val16);
> >> if (ret)
> >> return ret;
> >> - val16 &= (1 << bits) - 1;
> >> - val16 = (s16)(val16 << (16 - bits)) >> (16 - bits);
> >> - *val = val16;
> >> + *val = sign_extend32(val16, bits - 1);
> >> return IIO_VAL_INT;
> >> }
> >> return -EINVAL;
> ---
> drivers/staging/iio/accel/adis16240.c | 11 ++---------
> 1 file changed, 2 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/staging/iio/accel/adis16240.c b/drivers/staging/iio/accel/adis16240.c
> index fff6d99089cc..24e525f1ef25 100644
> --- a/drivers/staging/iio/accel/adis16240.c
> +++ b/drivers/staging/iio/accel/adis16240.c
> @@ -250,7 +250,6 @@ static int adis16240_read_raw(struct iio_dev *indio_dev,
> {
> struct adis *st = iio_priv(indio_dev);
> int ret;
> - int bits;
> u8 addr;
> s16 val16;
>
> @@ -287,24 +286,18 @@ static int adis16240_read_raw(struct iio_dev *indio_dev,
> *val = 25000 / 244 - 0x133; /* 25 C = 0x133 */
> return IIO_VAL_INT;
> case IIO_CHAN_INFO_CALIBBIAS:
> - bits = 10;
> addr = adis16240_addresses[chan->scan_index][0];
> ret = adis_read_reg_16(st, addr, &val16);
> if (ret)
> return ret;
> - val16 &= (1 << bits) - 1;
> - val16 = (s16)(val16 << (16 - bits)) >> (16 - bits);
> - *val = val16;
> + *val = sign_extend32(val16, 9);
> return IIO_VAL_INT;
> case IIO_CHAN_INFO_PEAK:
> - bits = 10;
> addr = adis16240_addresses[chan->scan_index][1];
> ret = adis_read_reg_16(st, addr, &val16);
> if (ret)
> return ret;
> - val16 &= (1 << bits) - 1;
> - val16 = (s16)(val16 << (16 - bits)) >> (16 - bits);
> - *val = val16;
> + *val = sign_extend32(val16, 9);
> return IIO_VAL_INT;
> }
> return -EINVAL;
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] staging:iio:accel:adis16240: sign extend function avoiding code duplication
2018-06-16 18:02 ` Jonathan Cameron
@ 2018-06-17 0:25 ` karim eshapa
0 siblings, 0 replies; 3+ messages in thread
From: karim eshapa @ 2018-06-17 0:25 UTC (permalink / raw)
To: Jonathan Cameron
Cc: lars, Michael.Hennerich, knaack.h, Peter Meerwald-Stadler,
gregkh, linux-iio, devel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 4356 bytes --]
>> Use sign_extend32 kernel function instead of code duplication,
>> Safe also for 16 bit. and remove declaration of bits variable not needed.
>>
>> Signed-off-by: Karim Eshapa <karim.eshapa@gmail.com>
>
>Please consider how a patch is applied and resend as a v3 which can
actually
>be applied. Test it (by applying it yourself) to make sure you have
everything correct...
OK I did with the previous patches, but i didn't know what you meant in the
previous
mail with resend patch V2 included the change log so, I did what you have
seen :)
sorry for that.
Thanks,
On 16 June 2018 at 20:02, Jonathan Cameron <jic23@kernel.org> wrote:
> On Tue, 12 Jun 2018 18:21:53 +0200
> Karim Eshapa <karim.eshapa@gmail.com> wrote:
>
> > Use sign_extend32 kernel function instead of code duplication,
> > Safe also for 16 bit. and remove declaration of bits variable not needed.
> >
> > Signed-off-by: Karim Eshapa <karim.eshapa@gmail.com>
>
> Please consider how a patch is applied and resend as a v3 which can
> actually
> be applied. Test it (by applying it yourself) to make sure you have
> everything correct...
>
> Jonathan
>
> >
> > >On Tue, 2018-06-12 at 01:38 +0200, Karim Eshapa wrote:
> > >> Use sign_extend32 kernel function instead of code duplication.
> > >> Safe also for 16 bit.
> > >
> > >Perhaps remove the bits declaration and assignments
> > >and just use 9 directly.
> > >
> > >> diff --git a/drivers/staging/iio/accel/adis16240.c
> b/drivers/staging/iio/accel/adis16240.c
> > >
> > >> @@ -292,9 +292,7 @@ static int adis16240_read_raw(struct iio_dev
> *indio_dev,
> > >> ret = adis_read_reg_16(st, addr, &val16);
> > >> if (ret)
> > >> return ret;
> > >> - val16 &= (1 << bits) - 1;
> > >> - val16 = (s16)(val16 << (16 - bits)) >> (16 - bits);
> > >> - *val = val16;
> > >> + *val = sign_extend32(val16, bits - 1);
> > >> return IIO_VAL_INT;
> > >> case IIO_CHAN_INFO_PEAK:
> > >> bits = 10;
> > >> @@ -302,9 +300,7 @@ static int adis16240_read_raw(struct iio_dev
> *indio_dev,
> > >> ret = adis_read_reg_16(st, addr, &val16);
> > >> if (ret)
> > >> return ret;
> > >> - val16 &= (1 << bits) - 1;
> > >> - val16 = (s16)(val16 << (16 - bits)) >> (16 - bits);
> > >> - *val = val16;
> > >> + *val = sign_extend32(val16, bits - 1);
> > >> return IIO_VAL_INT;
> > >> }
> > >> return -EINVAL;
> > ---
> > drivers/staging/iio/accel/adis16240.c | 11 ++---------
> > 1 file changed, 2 insertions(+), 9 deletions(-)
> >
> > diff --git a/drivers/staging/iio/accel/adis16240.c
> b/drivers/staging/iio/accel/adis16240.c
> > index fff6d99089cc..24e525f1ef25 100644
> > --- a/drivers/staging/iio/accel/adis16240.c
> > +++ b/drivers/staging/iio/accel/adis16240.c
> > @@ -250,7 +250,6 @@ static int adis16240_read_raw(struct iio_dev
> *indio_dev,
> > {
> > struct adis *st = iio_priv(indio_dev);
> > int ret;
> > - int bits;
> > u8 addr;
> > s16 val16;
> >
> > @@ -287,24 +286,18 @@ static int adis16240_read_raw(struct iio_dev
> *indio_dev,
> > *val = 25000 / 244 - 0x133; /* 25 C = 0x133 */
> > return IIO_VAL_INT;
> > case IIO_CHAN_INFO_CALIBBIAS:
> > - bits = 10;
> > addr = adis16240_addresses[chan->scan_index][0];
> > ret = adis_read_reg_16(st, addr, &val16);
> > if (ret)
> > return ret;
> > - val16 &= (1 << bits) - 1;
> > - val16 = (s16)(val16 << (16 - bits)) >> (16 - bits);
> > - *val = val16;
> > + *val = sign_extend32(val16, 9);
> > return IIO_VAL_INT;
> > case IIO_CHAN_INFO_PEAK:
> > - bits = 10;
> > addr = adis16240_addresses[chan->scan_index][1];
> > ret = adis_read_reg_16(st, addr, &val16);
> > if (ret)
> > return ret;
> > - val16 &= (1 << bits) - 1;
> > - val16 = (s16)(val16 << (16 - bits)) >> (16 - bits);
> > - *val = val16;
> > + *val = sign_extend32(val16, 9);
> > return IIO_VAL_INT;
> > }
> > return -EINVAL;
>
>
[-- Attachment #2: Type: text/html, Size: 7001 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-06-17 0:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-12 16:21 [PATCH v2] staging:iio:accel:adis16240: sign extend function avoiding code duplication Karim Eshapa
2018-06-16 18:02 ` Jonathan Cameron
2018-06-17 0:25 ` karim eshapa
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.