* [PATCH v2 1/2] drm/i915/guc: Print CTL params passed to Guc
@ 2018-06-18 11:18 Michal Wajdeczko
2018-06-18 11:18 ` [PATCH v2 2/2] HAX enable GuC for CI Michal Wajdeczko
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Michal Wajdeczko @ 2018-06-18 11:18 UTC (permalink / raw)
To: intel-gfx
While debugging we may want to examine params passed to GuC.
v2: drop #ifdef DEBUG_GUC - Michal
Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Michel Thierry <michel.thierry@intel.com>
Reviewed-by: Michel Thierry <michel.thierry@intel.com> #1
Cc: Michal Winiarski <michal.winiarski@intel.com>
---
drivers/gpu/drm/i915/intel_guc.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_guc.c b/drivers/gpu/drm/i915/intel_guc.c
index 1aff30b..feecf6e5 100644
--- a/drivers/gpu/drm/i915/intel_guc.c
+++ b/drivers/gpu/drm/i915/intel_guc.c
@@ -327,6 +327,9 @@ void intel_guc_init_params(struct intel_guc *guc)
params[GUC_CTL_DEBUG] = guc_ctl_debug_flags(guc);
params[GUC_CTL_CTXINFO] = guc_ctl_ctxinfo_flags(guc);
+ for (i = 0; i < GUC_CTL_MAX_DWORDS; i++)
+ DRM_DEBUG_DRIVER("param[%2d] = %#x\n", i, params[i]);
+
/*
* All SOFT_SCRATCH registers are in FORCEWAKE_BLITTER domain and
* they are power context saved so it's ok to release forcewake
--
1.9.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v2 2/2] HAX enable GuC for CI
2018-06-18 11:18 [PATCH v2 1/2] drm/i915/guc: Print CTL params passed to Guc Michal Wajdeczko
@ 2018-06-18 11:18 ` Michal Wajdeczko
2018-06-18 12:32 ` [PATCH v2 1/2] drm/i915/guc: Print CTL params passed to Guc Michał Winiarski
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Michal Wajdeczko @ 2018-06-18 11:18 UTC (permalink / raw)
To: intel-gfx
Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
---
drivers/gpu/drm/i915/i915_params.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h
index aebe046..3e4e128 100644
--- a/drivers/gpu/drm/i915/i915_params.h
+++ b/drivers/gpu/drm/i915/i915_params.h
@@ -47,7 +47,7 @@
param(int, disable_power_well, -1) \
param(int, enable_ips, 1) \
param(int, invert_brightness, 0) \
- param(int, enable_guc, 0) \
+ param(int, enable_guc, -1) \
param(int, guc_log_level, -1) \
param(char *, guc_firmware_path, NULL) \
param(char *, huc_firmware_path, NULL) \
--
1.9.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/2] drm/i915/guc: Print CTL params passed to Guc
2018-06-18 11:18 [PATCH v2 1/2] drm/i915/guc: Print CTL params passed to Guc Michal Wajdeczko
2018-06-18 11:18 ` [PATCH v2 2/2] HAX enable GuC for CI Michal Wajdeczko
@ 2018-06-18 12:32 ` Michał Winiarski
2018-06-29 22:37 ` Chris Wilson
2018-06-18 12:42 ` ✓ Fi.CI.BAT: success for series starting with [v2,1/2] " Patchwork
2018-06-18 16:25 ` ✗ Fi.CI.IGT: failure " Patchwork
3 siblings, 1 reply; 7+ messages in thread
From: Michał Winiarski @ 2018-06-18 12:32 UTC (permalink / raw)
To: Michal Wajdeczko; +Cc: intel-gfx
On Mon, Jun 18, 2018 at 11:18:20AM +0000, Michal Wajdeczko wrote:
> While debugging we may want to examine params passed to GuC.
>
> v2: drop #ifdef DEBUG_GUC - Michal
>
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Cc: Michel Thierry <michel.thierry@intel.com>
> Reviewed-by: Michel Thierry <michel.thierry@intel.com> #1
> Cc: Michal Winiarski <michal.winiarski@intel.com>
> ---
> drivers/gpu/drm/i915/intel_guc.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_guc.c b/drivers/gpu/drm/i915/intel_guc.c
> index 1aff30b..feecf6e5 100644
> --- a/drivers/gpu/drm/i915/intel_guc.c
> +++ b/drivers/gpu/drm/i915/intel_guc.c
> @@ -327,6 +327,9 @@ void intel_guc_init_params(struct intel_guc *guc)
> params[GUC_CTL_DEBUG] = guc_ctl_debug_flags(guc);
> params[GUC_CTL_CTXINFO] = guc_ctl_ctxinfo_flags(guc);
>
> + for (i = 0; i < GUC_CTL_MAX_DWORDS; i++)
> + DRM_DEBUG_DRIVER("param[%2d] = %#x\n", i, params[i]);
> +
Reviewed-by: Michał Winiarski <michal.winiarski@intel.com>
-Michał
> /*
> * All SOFT_SCRATCH registers are in FORCEWAKE_BLITTER domain and
> * they are power context saved so it's ok to release forcewake
> --
> 1.9.1
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* ✓ Fi.CI.BAT: success for series starting with [v2,1/2] drm/i915/guc: Print CTL params passed to Guc
2018-06-18 11:18 [PATCH v2 1/2] drm/i915/guc: Print CTL params passed to Guc Michal Wajdeczko
2018-06-18 11:18 ` [PATCH v2 2/2] HAX enable GuC for CI Michal Wajdeczko
2018-06-18 12:32 ` [PATCH v2 1/2] drm/i915/guc: Print CTL params passed to Guc Michał Winiarski
@ 2018-06-18 12:42 ` Patchwork
2018-06-18 16:25 ` ✗ Fi.CI.IGT: failure " Patchwork
3 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2018-06-18 12:42 UTC (permalink / raw)
To: Michal Wajdeczko; +Cc: intel-gfx
== Series Details ==
Series: series starting with [v2,1/2] drm/i915/guc: Print CTL params passed to Guc
URL : https://patchwork.freedesktop.org/series/44934/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4334 -> Patchwork_9351 =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_9351 need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_9351, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/44934/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_9351:
=== IGT changes ===
==== Warnings ====
igt@gem_exec_gttfill@basic:
fi-pnv-d510: SKIP -> PASS
== Known issues ==
Here are the changes found in Patchwork_9351 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_exec_gttfill@basic:
fi-byt-n2820: PASS -> FAIL (fdo#106744)
igt@kms_pipe_crc_basic@read-crc-pipe-b:
fi-glk-j4005: PASS -> DMESG-WARN (fdo#106000) +1
igt@pm_rpm@basic-rte:
fi-glk-j4005: PASS -> DMESG-WARN (fdo#106097)
==== Possible fixes ====
igt@gem_ctx_create@basic-files:
fi-kbl-guc: DMESG-WARN -> PASS
igt@gem_ctx_switch@basic-default-heavy:
fi-glk-j4005: DMESG-WARN (fdo#106745, fdo#105719) -> PASS
igt@kms_flip@basic-plain-flip:
fi-glk-j4005: DMESG-WARN (fdo#106097) -> PASS
igt@kms_pipe_crc_basic@read-crc-pipe-c-frame-sequence:
fi-glk-j4005: DMESG-WARN (fdo#106238) -> PASS
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
fi-snb-2520m: INCOMPLETE (fdo#103713) -> PASS
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#105719 https://bugs.freedesktop.org/show_bug.cgi?id=105719
fdo#106000 https://bugs.freedesktop.org/show_bug.cgi?id=106000
fdo#106097 https://bugs.freedesktop.org/show_bug.cgi?id=106097
fdo#106238 https://bugs.freedesktop.org/show_bug.cgi?id=106238
fdo#106744 https://bugs.freedesktop.org/show_bug.cgi?id=106744
fdo#106745 https://bugs.freedesktop.org/show_bug.cgi?id=106745
== Participating hosts (42 -> 36) ==
Missing (6): fi-ilk-m540 fi-bxt-dsi fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600
== Build changes ==
* Linux: CI_DRM_4334 -> Patchwork_9351
CI_DRM_4334: e2635b9253c80ae63fcea5b3382351aa34e5f056 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4523: 778497e7965dc8662c770a89ebbd741778feb71e @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9351: 35d1fdad52ec99775e0816dfefa8ac3456322672 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
35d1fdad52ec HAX enable GuC for CI
820365971843 drm/i915/guc: Print CTL params passed to Guc
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9351/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* ✗ Fi.CI.IGT: failure for series starting with [v2,1/2] drm/i915/guc: Print CTL params passed to Guc
2018-06-18 11:18 [PATCH v2 1/2] drm/i915/guc: Print CTL params passed to Guc Michal Wajdeczko
` (2 preceding siblings ...)
2018-06-18 12:42 ` ✓ Fi.CI.BAT: success for series starting with [v2,1/2] " Patchwork
@ 2018-06-18 16:25 ` Patchwork
2018-06-29 13:55 ` Michal Wajdeczko
3 siblings, 1 reply; 7+ messages in thread
From: Patchwork @ 2018-06-18 16:25 UTC (permalink / raw)
To: Michal Wajdeczko; +Cc: intel-gfx
== Series Details ==
Series: series starting with [v2,1/2] drm/i915/guc: Print CTL params passed to Guc
URL : https://patchwork.freedesktop.org/series/44934/
State : failure
== Summary ==
= CI Bug Log - changes from CI_DRM_4334_full -> Patchwork_9351_full =
== Summary - FAILURE ==
Serious unknown changes coming with Patchwork_9351_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_9351_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_9351_full:
=== IGT changes ===
==== Possible regressions ====
igt@drv_selftest@mock_contexts:
shard-apl: PASS -> DMESG-FAIL +1
shard-kbl: PASS -> DMESG-FAIL
shard-snb: PASS -> DMESG-FAIL
shard-hsw: PASS -> DMESG-FAIL
shard-glk: PASS -> DMESG-FAIL
igt@gem_exec_capture@capture-render:
shard-kbl: PASS -> DMESG-WARN +3
igt@pm_rpm@debugfs-read:
shard-apl: PASS -> DMESG-WARN
==== Warnings ====
igt@drv_selftest@live_evict:
shard-snb: PASS -> SKIP +13
igt@drv_selftest@live_execlists:
shard-hsw: PASS -> SKIP +13
igt@drv_selftest@live_objects:
shard-glk: PASS -> SKIP +11
igt@drv_selftest@live_requests:
shard-kbl: PASS -> SKIP +19
igt@drv_selftest@live_workarounds:
shard-apl: PASS -> SKIP +14
igt@gem_mocs_settings@mocs-rc6-blt:
shard-kbl: SKIP -> PASS
== Known issues ==
Here are the changes found in Patchwork_9351_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_eio@execbuf:
shard-apl: PASS -> INCOMPLETE (fdo#103927) +1
igt@gem_exec_suspend@basic-s4-devices:
shard-kbl: PASS -> DMESG-WARN (fdo#103558, fdo#105602, fdo#103313)
igt@gem_wait@await-default:
shard-snb: PASS -> INCOMPLETE (fdo#105411)
igt@kms_flip@dpms-vs-vblank-race:
shard-glk: PASS -> FAIL (fdo#103060)
igt@kms_flip@flip-vs-panning-vs-hang:
shard-snb: PASS -> DMESG-WARN (fdo#103821)
igt@kms_flip_tiling@flip-to-y-tiled:
shard-glk: PASS -> FAIL (fdo#104724, fdo#103822)
igt@kms_vblank@pipe-c-wait-forked-hang:
shard-kbl: PASS -> DMESG-WARN (fdo#103558, fdo#105602) +2
igt@prime_busy@wait-hang-vebox:
shard-kbl: PASS -> INCOMPLETE (fdo#103665) +3
==== Possible fixes ====
igt@drv_selftest@live_gtt:
shard-glk: FAIL (fdo#105347) -> SKIP
igt@drv_selftest@live_hangcheck:
shard-glk: DMESG-FAIL (fdo#106947) -> SKIP
igt@kms_flip@2x-plain-flip-ts-check-interruptible:
shard-glk: FAIL (fdo#100368) -> PASS +1
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#103313 https://bugs.freedesktop.org/show_bug.cgi?id=103313
fdo#103558 https://bugs.freedesktop.org/show_bug.cgi?id=103558
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#103821 https://bugs.freedesktop.org/show_bug.cgi?id=103821
fdo#103822 https://bugs.freedesktop.org/show_bug.cgi?id=103822
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#104724 https://bugs.freedesktop.org/show_bug.cgi?id=104724
fdo#105347 https://bugs.freedesktop.org/show_bug.cgi?id=105347
fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
fdo#106947 https://bugs.freedesktop.org/show_bug.cgi?id=106947
== Participating hosts (5 -> 5) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_4334 -> Patchwork_9351
CI_DRM_4334: e2635b9253c80ae63fcea5b3382351aa34e5f056 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4523: 778497e7965dc8662c770a89ebbd741778feb71e @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9351: 35d1fdad52ec99775e0816dfefa8ac3456322672 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9351/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: ✗ Fi.CI.IGT: failure for series starting with [v2,1/2] drm/i915/guc: Print CTL params passed to Guc
2018-06-18 16:25 ` ✗ Fi.CI.IGT: failure " Patchwork
@ 2018-06-29 13:55 ` Michal Wajdeczko
0 siblings, 0 replies; 7+ messages in thread
From: Michal Wajdeczko @ 2018-06-29 13:55 UTC (permalink / raw)
To: Patchwork, intel-gfx
On Mon, 18 Jun 2018 18:25:21 +0200, Patchwork
<patchwork@emeril.freedesktop.org> wrote:
> == Series Details ==
>
> Series: series starting with [v2,1/2] drm/i915/guc: Print CTL params
> passed to Guc
> URL : https://patchwork.freedesktop.org/series/44934/
> State : failure
>
> == Summary ==
>
> = CI Bug Log - changes from CI_DRM_4334_full -> Patchwork_9351_full =
>
> == Summary - FAILURE ==
>
> Serious unknown changes coming with Patchwork_9351_full absolutely
> need to be
> verified manually.
> If you think the reported changes have nothing to do with the changes
> introduced in Patchwork_9351_full, please notify your bug team to
> allow them
> to document this new failure mode, which will reduce false positives
> in CI.
>
>
> == Possible new issues ==
>
> Here are the unknown changes that may have been introduced in
> Patchwork_9351_full:
>
> === IGT changes ===
>
> ==== Possible regressions ====
>
> igt@drv_selftest@mock_contexts:
> shard-apl: PASS -> DMESG-FAIL +1
> shard-kbl: PASS -> DMESG-FAIL
> shard-snb: PASS -> DMESG-FAIL
> shard-hsw: PASS -> DMESG-FAIL
> shard-glk: PASS -> DMESG-FAIL
>
> igt@gem_exec_capture@capture-render:
> shard-kbl: PASS -> DMESG-WARN +3
>
> igt@pm_rpm@debugfs-read:
> shard-apl: PASS -> DMESG-WARN
>
again, all these issues are the same as with HAX alone - see [1]
[1] https://patchwork.freedesktop.org/series/40112/
Michal
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/2] drm/i915/guc: Print CTL params passed to Guc
2018-06-18 12:32 ` [PATCH v2 1/2] drm/i915/guc: Print CTL params passed to Guc Michał Winiarski
@ 2018-06-29 22:37 ` Chris Wilson
0 siblings, 0 replies; 7+ messages in thread
From: Chris Wilson @ 2018-06-29 22:37 UTC (permalink / raw)
To: Michał Winiarski, Michal Wajdeczko; +Cc: intel-gfx
Quoting Michał Winiarski (2018-06-18 13:32:47)
> On Mon, Jun 18, 2018 at 11:18:20AM +0000, Michal Wajdeczko wrote:
> > While debugging we may want to examine params passed to GuC.
> >
> > v2: drop #ifdef DEBUG_GUC - Michal
> >
> > Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> > Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> > Cc: Michel Thierry <michel.thierry@intel.com>
> > Reviewed-by: Michel Thierry <michel.thierry@intel.com> #1
> > Cc: Michal Winiarski <michal.winiarski@intel.com>
>
> > ---
> > drivers/gpu/drm/i915/intel_guc.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_guc.c b/drivers/gpu/drm/i915/intel_guc.c
> > index 1aff30b..feecf6e5 100644
> > --- a/drivers/gpu/drm/i915/intel_guc.c
> > +++ b/drivers/gpu/drm/i915/intel_guc.c
> > @@ -327,6 +327,9 @@ void intel_guc_init_params(struct intel_guc *guc)
> > params[GUC_CTL_DEBUG] = guc_ctl_debug_flags(guc);
> > params[GUC_CTL_CTXINFO] = guc_ctl_ctxinfo_flags(guc);
> >
> > + for (i = 0; i < GUC_CTL_MAX_DWORDS; i++)
> > + DRM_DEBUG_DRIVER("param[%2d] = %#x\n", i, params[i]);
> > +
>
> Reviewed-by: Michał Winiarski <michal.winiarski@intel.com>
And pushed. Thanks for the patch and review,
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-06-29 22:37 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-18 11:18 [PATCH v2 1/2] drm/i915/guc: Print CTL params passed to Guc Michal Wajdeczko
2018-06-18 11:18 ` [PATCH v2 2/2] HAX enable GuC for CI Michal Wajdeczko
2018-06-18 12:32 ` [PATCH v2 1/2] drm/i915/guc: Print CTL params passed to Guc Michał Winiarski
2018-06-29 22:37 ` Chris Wilson
2018-06-18 12:42 ` ✓ Fi.CI.BAT: success for series starting with [v2,1/2] " Patchwork
2018-06-18 16:25 ` ✗ Fi.CI.IGT: failure " Patchwork
2018-06-29 13:55 ` Michal Wajdeczko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.