* [PATCH] ACPI / processor: Finish making acpi_processor_ppc_has_changed() void
@ 2018-06-19 17:02 ` Brian Norris
0 siblings, 0 replies; 4+ messages in thread
From: Brian Norris @ 2018-06-19 17:02 UTC (permalink / raw)
To: Rafael J. Wysocki, Len Brown
Cc: linux-kernel, linux-acpi, devel, Matthias Kaehlcke, Brian Norris
Commit bca5f557dcea ("ACPI / processor: Make
acpi_processor_ppc_has_changed() void") changed one of the declarations
of acpi_processor_ppc_has_changed() to return void, but the !CPU_FREQ
version still return int. Let's return void to be consistent.
Signed-off-by: Brian Norris <briannorris@chromium.org>
---
include/acpi/processor.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/include/acpi/processor.h b/include/acpi/processor.h
index 40a916efd7c0..1194a4c78d55 100644
--- a/include/acpi/processor.h
+++ b/include/acpi/processor.h
@@ -309,7 +309,7 @@ static inline void acpi_processor_ppc_exit(void)
{
return;
}
-static inline int acpi_processor_ppc_has_changed(struct acpi_processor *pr,
+static inline void acpi_processor_ppc_has_changed(struct acpi_processor *pr,
int event_flag)
{
static unsigned int printout = 1;
@@ -320,7 +320,6 @@ static inline int acpi_processor_ppc_has_changed(struct acpi_processor *pr,
"Consider compiling CPUfreq support into your kernel.\n");
printout = 0;
}
- return 0;
}
static inline int acpi_processor_get_bios_limit(int cpu, unsigned int *limit)
{
--
2.18.0.rc1.244.gcf134e6275-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] ACPI / processor: Finish making acpi_processor_ppc_has_changed() void
@ 2018-06-19 17:02 ` Brian Norris
0 siblings, 0 replies; 4+ messages in thread
From: Brian Norris @ 2018-06-19 17:02 UTC (permalink / raw)
To: Rafael J. Wysocki, Len Brown
Cc: linux-kernel, linux-acpi, devel, Matthias Kaehlcke, Brian Norris
Commit bca5f557dcea ("ACPI / processor: Make
acpi_processor_ppc_has_changed() void") changed one of the declarations
of acpi_processor_ppc_has_changed() to return void, but the !CPU_FREQ
version still return int. Let's return void to be consistent.
Signed-off-by: Brian Norris <briannorris@chromium.org>
---
include/acpi/processor.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/include/acpi/processor.h b/include/acpi/processor.h
index 40a916efd7c0..1194a4c78d55 100644
--- a/include/acpi/processor.h
+++ b/include/acpi/processor.h
@@ -309,7 +309,7 @@ static inline void acpi_processor_ppc_exit(void)
{
return;
}
-static inline int acpi_processor_ppc_has_changed(struct acpi_processor *pr,
+static inline void acpi_processor_ppc_has_changed(struct acpi_processor *pr,
int event_flag)
{
static unsigned int printout = 1;
@@ -320,7 +320,6 @@ static inline int acpi_processor_ppc_has_changed(struct acpi_processor *pr,
"Consider compiling CPUfreq support into your kernel.\n");
printout = 0;
}
- return 0;
}
static inline int acpi_processor_get_bios_limit(int cpu, unsigned int *limit)
{
--
2.18.0.rc1.244.gcf134e6275-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ACPI / processor: Finish making acpi_processor_ppc_has_changed() void
@ 2018-06-21 13:15 ` Rafael J. Wysocki
0 siblings, 0 replies; 4+ messages in thread
From: Rafael J. Wysocki @ 2018-06-21 13:15 UTC (permalink / raw)
To: Brian Norris
Cc: Len Brown, linux-kernel, linux-acpi, devel, Matthias Kaehlcke
On Tuesday, June 19, 2018 7:02:01 PM CEST Brian Norris wrote:
> Commit bca5f557dcea ("ACPI / processor: Make
> acpi_processor_ppc_has_changed() void") changed one of the declarations
> of acpi_processor_ppc_has_changed() to return void, but the !CPU_FREQ
> version still return int. Let's return void to be consistent.
>
> Signed-off-by: Brian Norris <briannorris@chromium.org>
> ---
> include/acpi/processor.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/include/acpi/processor.h b/include/acpi/processor.h
> index 40a916efd7c0..1194a4c78d55 100644
> --- a/include/acpi/processor.h
> +++ b/include/acpi/processor.h
> @@ -309,7 +309,7 @@ static inline void acpi_processor_ppc_exit(void)
> {
> return;
> }
> -static inline int acpi_processor_ppc_has_changed(struct acpi_processor *pr,
> +static inline void acpi_processor_ppc_has_changed(struct acpi_processor *pr,
> int event_flag)
> {
> static unsigned int printout = 1;
> @@ -320,7 +320,6 @@ static inline int acpi_processor_ppc_has_changed(struct acpi_processor *pr,
> "Consider compiling CPUfreq support into your kernel.\n");
> printout = 0;
> }
> - return 0;
> }
> static inline int acpi_processor_get_bios_limit(int cpu, unsigned int *limit)
> {
>
Applied, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Devel] [PATCH] ACPI / processor: Finish making acpi_processor_ppc_has_changed() void
@ 2018-06-21 13:15 ` Rafael J. Wysocki
0 siblings, 0 replies; 4+ messages in thread
From: Rafael J. Wysocki @ 2018-06-21 13:15 UTC (permalink / raw)
To: devel
[-- Attachment #1: Type: text/plain, Size: 1332 bytes --]
On Tuesday, June 19, 2018 7:02:01 PM CEST Brian Norris wrote:
> Commit bca5f557dcea ("ACPI / processor: Make
> acpi_processor_ppc_has_changed() void") changed one of the declarations
> of acpi_processor_ppc_has_changed() to return void, but the !CPU_FREQ
> version still return int. Let's return void to be consistent.
>
> Signed-off-by: Brian Norris <briannorris(a)chromium.org>
> ---
> include/acpi/processor.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/include/acpi/processor.h b/include/acpi/processor.h
> index 40a916efd7c0..1194a4c78d55 100644
> --- a/include/acpi/processor.h
> +++ b/include/acpi/processor.h
> @@ -309,7 +309,7 @@ static inline void acpi_processor_ppc_exit(void)
> {
> return;
> }
> -static inline int acpi_processor_ppc_has_changed(struct acpi_processor *pr,
> +static inline void acpi_processor_ppc_has_changed(struct acpi_processor *pr,
> int event_flag)
> {
> static unsigned int printout = 1;
> @@ -320,7 +320,6 @@ static inline int acpi_processor_ppc_has_changed(struct acpi_processor *pr,
> "Consider compiling CPUfreq support into your kernel.\n");
> printout = 0;
> }
> - return 0;
> }
> static inline int acpi_processor_get_bios_limit(int cpu, unsigned int *limit)
> {
>
Applied, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-06-21 13:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-19 17:02 [PATCH] ACPI / processor: Finish making acpi_processor_ppc_has_changed() void Brian Norris
2018-06-19 17:02 ` Brian Norris
2018-06-21 13:15 ` Rafael J. Wysocki
2018-06-21 13:15 ` [Devel] " Rafael J. Wysocki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.