From: David Miller <davem@davemloft.net>
To: joakim.tjernlund@infinera.com
Cc: leoyang.li@nxp.com, netdev@vger.kernel.org
Subject: Re: [PATCH] ucc_geth: Add BQL support
Date: Wed, 20 Jun 2018 14:39:45 +0900 (KST) [thread overview]
Message-ID: <20180620.143945.116462011875467035.davem@davemloft.net> (raw)
In-Reply-To: <20180619163036.20578-1-joakim.tjernlund@infinera.com>
From: Joakim Tjernlund <joakim.tjernlund@infinera.com>
Date: Tue, 19 Jun 2018 18:30:36 +0200
> @@ -3242,6 +3243,8 @@ static int ucc_geth_tx(struct net_device *dev, u8 txQ)
> struct ucc_geth_private *ugeth = netdev_priv(dev);
> u8 __iomem *bd; /* BD pointer */
> u32 bd_status;
> + int howmany = 0;
> + unsigned int bytes_sent = 0;
Please keep the function local variable declarations ordered from
longest to shortest line.
Thank you.
next prev parent reply other threads:[~2018-06-20 5:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-19 16:30 [PATCH] ucc_geth: Add BQL support Joakim Tjernlund
2018-06-19 18:24 ` Li Yang
2018-06-19 18:37 ` Dave Taht
2018-06-19 19:06 ` Joakim Tjernlund
2018-06-20 5:39 ` David Miller [this message]
2018-06-20 16:29 ` [PATCH v2] " Joakim Tjernlund
2018-06-22 4:56 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180620.143945.116462011875467035.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=joakim.tjernlund@infinera.com \
--cc=leoyang.li@nxp.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.