* [RFC PATCH] drm/i915/dp: try normal detection on connector force enable
@ 2018-06-20 8:11 Jani Nikula
2018-06-20 8:25 ` ✗ Fi.CI.BAT: failure for " Patchwork
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Jani Nikula @ 2018-06-20 8:11 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
Connector force enable on DP bypasses the detect hooks, skipping all the
DPCD parameter reading and negotiation. This does not really have a
chance to work, at all, and any modesets are bound to fail.
Try to do the normal detection in the force hook on force enable.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103347
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106291
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/intel_dp.c | 14 ++++++--------
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 6ac6c8787dcf..ec9c96b1d013 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -4962,14 +4962,12 @@ intel_dp_force(struct drm_connector *connector)
connector->base.id, connector->name);
intel_dp_unset_edid(intel_dp);
- if (connector->status != connector_status_connected)
- return;
-
- intel_display_power_get(dev_priv, intel_dp->aux_power_domain);
-
- intel_dp_set_edid(intel_dp);
-
- intel_display_power_put(dev_priv, intel_dp->aux_power_domain);
+ /*
+ * Force enable doesn't really work with DP. Try the normal detect path
+ * anyway to read the DPCD etc.
+ */
+ if (connector->status == connector_status_connected)
+ drm_helper_probe_detect(connector, NULL, false);
}
static int intel_dp_get_modes(struct drm_connector *connector)
--
2.11.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915/dp: try normal detection on connector force enable
2018-06-20 8:11 [RFC PATCH] drm/i915/dp: try normal detection on connector force enable Jani Nikula
@ 2018-06-20 8:25 ` Patchwork
2018-06-20 8:48 ` [RFC PATCH v2] " Jani Nikula
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2018-06-20 8:25 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/dp: try normal detection on connector force enable
URL : https://patchwork.freedesktop.org/series/45056/
State : failure
== Summary ==
CALL scripts/checksyscalls.sh
DESCEND objtool
CHK include/generated/compile.h
CC [M] drivers/gpu/drm/i915/intel_dp.o
drivers/gpu/drm/i915/intel_dp.c: In function ‘intel_dp_force’:
drivers/gpu/drm/i915/intel_dp.c:4959:27: error: unused variable ‘dev_priv’ [-Werror=unused-variable]
struct drm_i915_private *dev_priv = to_i915(intel_encoder->base.dev);
^~~~~~~~
cc1: all warnings being treated as errors
scripts/Makefile.build:317: recipe for target 'drivers/gpu/drm/i915/intel_dp.o' failed
make[4]: *** [drivers/gpu/drm/i915/intel_dp.o] Error 1
scripts/Makefile.build:558: recipe for target 'drivers/gpu/drm/i915' failed
make[3]: *** [drivers/gpu/drm/i915] Error 2
scripts/Makefile.build:558: recipe for target 'drivers/gpu/drm' failed
make[2]: *** [drivers/gpu/drm] Error 2
scripts/Makefile.build:558: recipe for target 'drivers/gpu' failed
make[1]: *** [drivers/gpu] Error 2
Makefile:1034: recipe for target 'drivers' failed
make: *** [drivers] Error 2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* [RFC PATCH v2] drm/i915/dp: try normal detection on connector force enable
2018-06-20 8:11 [RFC PATCH] drm/i915/dp: try normal detection on connector force enable Jani Nikula
2018-06-20 8:25 ` ✗ Fi.CI.BAT: failure for " Patchwork
@ 2018-06-20 8:48 ` Jani Nikula
2018-06-20 9:15 ` ✓ Fi.CI.BAT: success for drm/i915/dp: try normal detection on connector force enable (rev2) Patchwork
2018-06-20 10:05 ` ✓ Fi.CI.IGT: " Patchwork
3 siblings, 0 replies; 5+ messages in thread
From: Jani Nikula @ 2018-06-20 8:48 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
Connector force enable on DP bypasses the detect hooks, skipping all the
DPCD parameter reading and negotiation. This does not really have a
chance to work, at all, and any modesets are bound to fail.
Try to do the normal detection in the force hook on force enable.
v2: fix unused variable warnings
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103347
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106291
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/intel_dp.c | 16 ++++++----------
1 file changed, 6 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 6ac6c8787dcf..93db47ecda06 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -4955,21 +4955,17 @@ static void
intel_dp_force(struct drm_connector *connector)
{
struct intel_dp *intel_dp = intel_attached_dp(connector);
- struct intel_encoder *intel_encoder = &dp_to_dig_port(intel_dp)->base;
- struct drm_i915_private *dev_priv = to_i915(intel_encoder->base.dev);
DRM_DEBUG_KMS("[CONNECTOR:%d:%s]\n",
connector->base.id, connector->name);
intel_dp_unset_edid(intel_dp);
- if (connector->status != connector_status_connected)
- return;
-
- intel_display_power_get(dev_priv, intel_dp->aux_power_domain);
-
- intel_dp_set_edid(intel_dp);
-
- intel_display_power_put(dev_priv, intel_dp->aux_power_domain);
+ /*
+ * Force enable doesn't really work with DP. Try the normal detect path
+ * anyway to read the DPCD etc.
+ */
+ if (connector->status == connector_status_connected)
+ drm_helper_probe_detect(connector, NULL, false);
}
static int intel_dp_get_modes(struct drm_connector *connector)
--
2.11.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915/dp: try normal detection on connector force enable (rev2)
2018-06-20 8:11 [RFC PATCH] drm/i915/dp: try normal detection on connector force enable Jani Nikula
2018-06-20 8:25 ` ✗ Fi.CI.BAT: failure for " Patchwork
2018-06-20 8:48 ` [RFC PATCH v2] " Jani Nikula
@ 2018-06-20 9:15 ` Patchwork
2018-06-20 10:05 ` ✓ Fi.CI.IGT: " Patchwork
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2018-06-20 9:15 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/dp: try normal detection on connector force enable (rev2)
URL : https://patchwork.freedesktop.org/series/45056/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4346 -> Patchwork_9366 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/45056/revisions/2/mbox/
== Known issues ==
Here are the changes found in Patchwork_9366 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
fi-bxt-dsi: PASS -> INCOMPLETE (fdo#103927)
==== Possible fixes ====
igt@debugfs_test@read_all_entries:
fi-snb-2520m: INCOMPLETE (fdo#103713) -> PASS
igt@gem_exec_gttfill@basic:
fi-byt-n2820: FAIL (fdo#106744) -> PASS
igt@kms_flip@basic-flip-vs-wf_vblank:
fi-glk-j4005: FAIL (fdo#100368) -> PASS
igt@kms_flip@basic-plain-flip:
fi-glk-j4005: DMESG-WARN (fdo#106097) -> PASS
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#106097 https://bugs.freedesktop.org/show_bug.cgi?id=106097
fdo#106744 https://bugs.freedesktop.org/show_bug.cgi?id=106744
== Participating hosts (42 -> 37) ==
Missing (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u
== Build changes ==
* Linux: CI_DRM_4346 -> Patchwork_9366
CI_DRM_4346: 92d7e0feac3acdf911aacfcc8a5df92756e2d11a @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4525: 578c645406d59138029fa6ef343fcc87c2d95d4c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9366: 2703dcc12d6c2781ad55288fd7fac0cc3debee65 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
2703dcc12d6c drm/i915/dp: try normal detection on connector force enable
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9366/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915/dp: try normal detection on connector force enable (rev2)
2018-06-20 8:11 [RFC PATCH] drm/i915/dp: try normal detection on connector force enable Jani Nikula
` (2 preceding siblings ...)
2018-06-20 9:15 ` ✓ Fi.CI.BAT: success for drm/i915/dp: try normal detection on connector force enable (rev2) Patchwork
@ 2018-06-20 10:05 ` Patchwork
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2018-06-20 10:05 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/dp: try normal detection on connector force enable (rev2)
URL : https://patchwork.freedesktop.org/series/45056/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4346_full -> Patchwork_9366_full =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_9366_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_9366_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_9366_full:
=== IGT changes ===
==== Warnings ====
igt@gem_mmap_wc@set-cache-level:
shard-snb: PASS -> SKIP
igt@gem_mocs_settings@mocs-rc6-blt:
shard-kbl: SKIP -> PASS
== Known issues ==
Here are the changes found in Patchwork_9366_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_selftest@live_gtt:
shard-kbl: PASS -> FAIL (fdo#105347)
shard-glk: PASS -> INCOMPLETE (k.org#198133, fdo#103359)
igt@gem_partial_pwrite_pread@reads:
shard-snb: PASS -> INCOMPLETE (fdo#105411)
igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy:
shard-glk: PASS -> FAIL (fdo#104873)
igt@kms_draw_crc@draw-method-rgb565-blt-xtiled:
shard-glk: PASS -> WARN (fdo#106974)
igt@kms_flip_tiling@flip-y-tiled:
shard-glk: PASS -> FAIL (fdo#104724, fdo#103822)
igt@kms_plane_scaling@pipe-b-scaler-with-clipping-clamping:
shard-glk: PASS -> DMESG-WARN (fdo#105763) +1
igt@kms_setmode@basic:
shard-apl: PASS -> FAIL (fdo#99912)
==== Possible fixes ====
igt@drv_selftest@live_gtt:
shard-apl: INCOMPLETE (fdo#103927) -> PASS
igt@gem_ppgtt@blt-vs-render-ctxn:
shard-kbl: INCOMPLETE (fdo#106023, fdo#103665) -> PASS
igt@gem_workarounds@suspend-resume-context:
shard-glk: FAIL (fdo#103375) -> PASS
igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic:
shard-glk: FAIL (fdo#105454, fdo#106509) -> PASS
igt@kms_cursor_legacy@cursorb-vs-flipb-toggle:
shard-glk: DMESG-WARN (fdo#106538, fdo#105763) -> PASS
igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
shard-glk: FAIL (fdo#105189) -> PASS
fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#103822 https://bugs.freedesktop.org/show_bug.cgi?id=103822
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#104724 https://bugs.freedesktop.org/show_bug.cgi?id=104724
fdo#104873 https://bugs.freedesktop.org/show_bug.cgi?id=104873
fdo#105189 https://bugs.freedesktop.org/show_bug.cgi?id=105189
fdo#105347 https://bugs.freedesktop.org/show_bug.cgi?id=105347
fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
fdo#105454 https://bugs.freedesktop.org/show_bug.cgi?id=105454
fdo#105763 https://bugs.freedesktop.org/show_bug.cgi?id=105763
fdo#106023 https://bugs.freedesktop.org/show_bug.cgi?id=106023
fdo#106509 https://bugs.freedesktop.org/show_bug.cgi?id=106509
fdo#106538 https://bugs.freedesktop.org/show_bug.cgi?id=106538
fdo#106974 https://bugs.freedesktop.org/show_bug.cgi?id=106974
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133
== Participating hosts (5 -> 5) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_4346 -> Patchwork_9366
CI_DRM_4346: 92d7e0feac3acdf911aacfcc8a5df92756e2d11a @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4525: 578c645406d59138029fa6ef343fcc87c2d95d4c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9366: 2703dcc12d6c2781ad55288fd7fac0cc3debee65 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9366/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-06-20 10:05 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-20 8:11 [RFC PATCH] drm/i915/dp: try normal detection on connector force enable Jani Nikula
2018-06-20 8:25 ` ✗ Fi.CI.BAT: failure for " Patchwork
2018-06-20 8:48 ` [RFC PATCH v2] " Jani Nikula
2018-06-20 9:15 ` ✓ Fi.CI.BAT: success for drm/i915/dp: try normal detection on connector force enable (rev2) Patchwork
2018-06-20 10:05 ` ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.