All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Marcel Holtmann <marcel@holtmann.org>,
	Alan Stern <stern@rowland.harvard.edu>
Cc: Greg Kroah-Hartman <greg@kroah.com>,
	"open list:BLUETOOTH DRIVERS" <linux-bluetooth@vger.kernel.org>,
	linux-usb@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
	Johan Hedberg <johan.hedberg@gmail.com>
Subject: Re: [PATCH] Bluetooth: btusb: use irqsave() in URB's complete callback
Date: Thu, 21 Jun 2018 14:52:07 +0200	[thread overview]
Message-ID: <20180621125207.7xtz2jpnp2vdvaau@linutronix.de> (raw)
In-Reply-To: <66D1D85C-A671-45CF-BBB4-974E3063B9F3@holtmann.org>

On 2018-06-21 14:43:41 [+0200], Marcel Holtmann wrote:
> Hi Sebastian,
Hi Marcel,

> > The USB completion callback does not disable interrupts while acquiring
> > the ->lock. We want to remove the local_irq_disable() invocation from
> > __usb_hcd_giveback_urb() and therefore it is required for the callback
> > handler to disable the interrupts while acquiring the lock.
> > The callback may be invoked either in IRQ or BH context depending on the
> > USB host controller.
> > Use the _irqsave variant of the locking primitives.
> > 
> > Cc: Marcel Holtmann <marcel@holtmann.org>
> > Cc: Johan Hedberg <johan.hedberg@gmail.com>
> > Cc: linux-bluetooth@vger.kernel.org
> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> > ---
> > drivers/bluetooth/btusb.c | 20 ++++++++++++--------
> > 1 file changed, 12 insertions(+), 8 deletions(-)
> 
> can I get an ACK from someone ensuring that this is the direction we are going with the USB host controllers?
+Alan.

EHCI completes in BH since v3.12-rc1. In order to get rid of that
local_irq_save() in USB core code I need to make sure that the USB
device driver(s) use irqsave primitives. See
  https://lkml.kernel.org/r/Pine.LNX.4.44L0.1806011629140.1404-100000@iolanthe.rowland.org

> Regards
> 
> Marcel

Sebastian

WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Marcel Holtmann <marcel@holtmann.org>,
	Alan Stern <stern@rowland.harvard.edu>
Cc: Greg Kroah-Hartman <greg@kroah.com>,
	"open list:BLUETOOTH DRIVERS" <linux-bluetooth@vger.kernel.org>,
	linux-usb@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
	Johan Hedberg <johan.hedberg@gmail.com>
Subject: Bluetooth: btusb: use irqsave() in URB's complete callback
Date: Thu, 21 Jun 2018 14:52:07 +0200	[thread overview]
Message-ID: <20180621125207.7xtz2jpnp2vdvaau@linutronix.de> (raw)

On 2018-06-21 14:43:41 [+0200], Marcel Holtmann wrote:
> Hi Sebastian,
Hi Marcel,

> > The USB completion callback does not disable interrupts while acquiring
> > the ->lock. We want to remove the local_irq_disable() invocation from
> > __usb_hcd_giveback_urb() and therefore it is required for the callback
> > handler to disable the interrupts while acquiring the lock.
> > The callback may be invoked either in IRQ or BH context depending on the
> > USB host controller.
> > Use the _irqsave variant of the locking primitives.
> > 
> > Cc: Marcel Holtmann <marcel@holtmann.org>
> > Cc: Johan Hedberg <johan.hedberg@gmail.com>
> > Cc: linux-bluetooth@vger.kernel.org
> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> > ---
> > drivers/bluetooth/btusb.c | 20 ++++++++++++--------
> > 1 file changed, 12 insertions(+), 8 deletions(-)
> 
> can I get an ACK from someone ensuring that this is the direction we are going with the USB host controllers?
+Alan.

EHCI completes in BH since v3.12-rc1. In order to get rid of that
local_irq_save() in USB core code I need to make sure that the USB
device driver(s) use irqsave primitives. See
  https://lkml.kernel.org/r/Pine.LNX.4.44L0.1806011629140.1404-100000@iolanthe.rowland.org

> Regards
> 
> Marcel

Sebastian
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2018-06-21 12:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-19 21:56 [PATCH] Bluetooth: btusb: use irqsave() in URB's complete callback Sebastian Andrzej Siewior
2018-06-19 21:56 ` Sebastian Andrzej Siewior
2018-06-21 12:43 ` [PATCH] " Marcel Holtmann
2018-06-21 12:43   ` Marcel Holtmann
2018-06-21 12:52   ` Sebastian Andrzej Siewior [this message]
2018-06-21 12:52     ` Sebastian Andrzej Siewior
2018-06-21 15:34     ` [PATCH] " Alan Stern
2018-06-21 15:34       ` Alan Stern
2018-07-01 15:19       ` [PATCH] " Sebastian Andrzej Siewior
2018-07-01 15:19         ` Sebastian Andrzej Siewior
2018-07-06 10:46 ` [PATCH] " Marcel Holtmann
2018-07-06 10:46   ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180621125207.7xtz2jpnp2vdvaau@linutronix.de \
    --to=bigeasy@linutronix.de \
    --cc=greg@kroah.com \
    --cc=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=stern@rowland.harvard.edu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.