[PATCH] glib: remove unnecessary dependency to DISTRO_FEATURES

[PATCH] glib: remove unnecessary dependency to DISTRO_FEATURES

[Samuli Piippo]

Since DISTRO_FEATURES was expanded in the comments, it created
task dependency to the full content of DISTRO_FEATURES, instead
of just the x11 used below. This prevented reuse of sstate-cache
when unrelated feature flags were changed.

Signed-off-by: Samuli Piippo <samuli.piippo@qt.io>
---
 meta/recipes-core/glib-2.0/glib.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-core/glib-2.0/glib.inc b/meta/recipes-core/glib-2.0/glib.inc
index 31b74362e3..d6d91335a6 100644
--- a/meta/recipes-core/glib-2.0/glib.inc
+++ b/meta/recipes-core/glib-2.0/glib.inc
@@ -117,7 +117,7 @@ do_install_append () {
 
 do_install_append_class-target () {
 	# Tests are only installed on targets, not native builds.  Separating this out
-	# keeps glib-2.0-native from depending on ${DISTRO_FEATURES}
+	# keeps glib-2.0-native from depending on DISTRO_FEATURES
 	if [ -f ${D}${datadir}/installed-tests/glib/gdbus-serialization.test ]; then
 		if ${@bb.utils.contains("DISTRO_FEATURES", "x11", "false", "true", d)}; then
 			rm ${D}${datadir}/installed-tests/glib/gdbus-serialization.test
-- 
2.17.1

Re: [PATCH] glib: remove unnecessary dependency to DISTRO_FEATURES

[Richard Purdie]

On Tue, 2018-06-26 at 10:59 +0300, Samuli Piippo wrote:
> Since DISTRO_FEATURES was expanded in the comments, it created
> task dependency to the full content of DISTRO_FEATURES, instead
> of just the x11 used below. This prevented reuse of sstate-cache
> when unrelated feature flags were changed.
> 
> Signed-off-by: Samuli Piippo <samuli.piippo@qt.io>
> ---
>  meta/recipes-core/glib-2.0/glib.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks, good catch!

Cheers,

Richard