Re: [Qemu-devel] [PULL 1/6] audio/hda: create millisecond timers that handle IO

From: Gerd Hoffmann <kraxel@redhat.com>
To: Max Reitz <mreitz@redhat.com>
Cc: Martin Schrodt <martin@schrodt.org>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PULL 1/6] audio/hda: create millisecond timers that handle IO
Date: Wed, 27 Jun 2018 13:13:19 +0200	[thread overview]
Message-ID: <20180627111319.4mlws52yq5ldoxwe@sirius.home.kraxel.org> (raw)
In-Reply-To: <20180627065126.mwzdxshr3njzok7n@sirius.home.kraxel.org>

  Hi,

> Given the code runs under big qemu lock anyway the atomics are not
> needed, so we could drop just them.  I left them in nevertheless because
> 
>   (a) we might want try run the code in a thread instead of using a timer, and
>   (b) I was too lazy to rewrite the code to drop the atomics.
> 
> I'd prefer to keep option (a) ...

Well, experimented with that a bit. 

As long as the core audio system runs using qemu timers too moving to a
thread doesn't buy us much as any latency spikes in qemu will hit us no
matter what.

So, that point is moot.  I'll go drop the atomics.

cheers,
  Gerd