All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: Tony Lindgren <tony@atomide.com>
Cc: Eyal Reizer <eyalr@ti.com>,
	Kishon Vijay Abraham I <kishon@ti.com>, Guy Mishol <guym@ti.com>,
	Luca Coelho <luciano.coelho@intel.com>,
	Maital Hahn <maitalm@ti.com>,
	Maxim Altshul <maxim.altshul@ti.com>,
	Shahar Patury <shaharp@ti.com>,
	linux-wireless@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [5/8] wclore: Fix timout errors after recovery
Date: Wed, 27 Jun 2018 15:41:52 +0000 (UTC)	[thread overview]
Message-ID: <20180627154152.7434960791@smtp.codeaurora.org> (raw)
In-Reply-To: <20180619094342.81831-6-tony@atomide.com>

Tony Lindgren <tony@atomide.com> wrote:

> After enabling runtime PM, if we force hardware reset multiple times with:
> 
> # echo 1 > /sys/kernel/debug/ieee80211/phy0/wlcore/start_recovery
> 
> We will after few tries get the following error:
> 
> wlcore: ERROR timeout waiting for the hardware to complete initialization
> 
> And then wlcore is unable to reconnect until after the wlcore related modules
> are reloaded.
> 
> Let's fix this by moving pm_runtime_put() earlier before we restart the hardware.
> And let's use the sync version to make sure we're done before we restart.
> 
> Note that we still will get -EBUSY warning from wl12xx_sdio_set_power() but let's
> fix that separately once we know exactly why we get the warning.
> 
> Reported-by: Eyal Reizer <eyalr@ti.com>
> Signed-off-by: Tony Lindgren <tony@atomide.com>

I'll do s/wclore/wlcore/ to the title.

-- 
https://patchwork.kernel.org/patch/10473897/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
To: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
Cc: Eyal Reizer <eyalr-l0cyMroinI0@public.gmane.org>,
	Kishon Vijay Abraham I <kishon-l0cyMroinI0@public.gmane.org>,
	Guy Mishol <guym-l0cyMroinI0@public.gmane.org>,
	Luca Coelho
	<luciano.coelho-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	Maital Hahn <maitalm-l0cyMroinI0@public.gmane.org>,
	Maxim Altshul <maxim.altshul-l0cyMroinI0@public.gmane.org>,
	Shahar Patury <shaharp-l0cyMroinI0@public.gmane.org>,
	linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [5/8] wclore: Fix timout errors after recovery
Date: Wed, 27 Jun 2018 15:41:52 +0000 (UTC)	[thread overview]
Message-ID: <20180627154152.7434960791@smtp.codeaurora.org> (raw)
In-Reply-To: <20180619094342.81831-6-tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>

Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> wrote:

> After enabling runtime PM, if we force hardware reset multiple times with:
> 
> # echo 1 > /sys/kernel/debug/ieee80211/phy0/wlcore/start_recovery
> 
> We will after few tries get the following error:
> 
> wlcore: ERROR timeout waiting for the hardware to complete initialization
> 
> And then wlcore is unable to reconnect until after the wlcore related modules
> are reloaded.
> 
> Let's fix this by moving pm_runtime_put() earlier before we restart the hardware.
> And let's use the sync version to make sure we're done before we restart.
> 
> Note that we still will get -EBUSY warning from wl12xx_sdio_set_power() but let's
> fix that separately once we know exactly why we get the warning.
> 
> Reported-by: Eyal Reizer <eyalr-l0cyMroinI0@public.gmane.org>
> Signed-off-by: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>

I'll do s/wclore/wlcore/ to the title.

-- 
https://patchwork.kernel.org/patch/10473897/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

  reply	other threads:[~2018-06-27 15:41 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-19  9:43 [PATCHv4 0/8] Runtime PM support for wlcore Tony Lindgren
2018-06-19  9:43 ` Tony Lindgren
2018-06-19  9:43 ` [PATCH 1/8] wlcore: Add missing PM call for wlcore_cmd_wait_for_event_or_timeout() Tony Lindgren
2018-06-19  9:43   ` Tony Lindgren
2018-06-27 15:46   ` [1/8] " Kalle Valo
2018-06-27 15:46     ` Kalle Valo
2018-06-19  9:43 ` [PATCH 2/8] wlcore: Make sure PM calls are paired Tony Lindgren
2018-06-19  9:43   ` Tony Lindgren
2018-06-19  9:43 ` [PATCH 3/8] wlcore: Add support for runtime PM Tony Lindgren
2018-06-19  9:43   ` Tony Lindgren
2018-06-19  9:43 ` [PATCH 4/8] wlcore: Fix misplaced PM call for scan_complete_work() Tony Lindgren
2018-06-19  9:43   ` Tony Lindgren
2018-06-19  9:43 ` [PATCH 5/8] wclore: Fix timout errors after recovery Tony Lindgren
2018-06-19  9:43   ` Tony Lindgren
2018-06-27 15:41   ` Kalle Valo [this message]
2018-06-27 15:41     ` [5/8] " Kalle Valo
     [not found]   ` <20180627154152.BCECB60714@smtp.codeaurora.org>
2018-06-28  9:07     ` Tony Lindgren
2018-06-28  9:07       ` Tony Lindgren
2018-06-28  9:19       ` Kalle Valo
2018-06-28  9:19         ` Kalle Valo
2018-06-19  9:43 ` [PATCH 6/8] wlcore: Use generic runtime pm calls for wowlan elp configuration Tony Lindgren
2018-06-19  9:43   ` Tony Lindgren
2018-06-19  9:43 ` [PATCH 7/8] wlcore: Make sure firmware is initialized in wl1271_op_add_interface() Tony Lindgren
2018-06-19  9:43   ` Tony Lindgren
2018-06-19  9:43 ` [PATCH 8/8] wlcore: Enable runtime PM autosuspend support Tony Lindgren
2018-06-19  9:43   ` Tony Lindgren
2018-06-26 15:53 ` [PATCHv4 0/8] Runtime PM support for wlcore Kalle Valo
2018-06-26 15:53   ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180627154152.7434960791@smtp.codeaurora.org \
    --to=kvalo@codeaurora.org \
    --cc=eyalr@ti.com \
    --cc=guym@ti.com \
    --cc=kishon@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=luciano.coelho@intel.com \
    --cc=maitalm@ti.com \
    --cc=maxim.altshul@ti.com \
    --cc=shaharp@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.