From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@01.org, Ramalingam C <ramalingam.c@intel.com>
Cc: intel-gfx@lists.freedesktop.org, alexander.usyskin@intel.com,
dri-devel@lists.freedesktop.org, uma.shankar@intel.com,
kbuild-all@01.org, daniel@ffwll.ch, tomas.winkler@intel.com
Subject: Re: [Intel-gfx] [PATCH v5 08/40] drm/i915: Initialize HDCP2.2 and its MEI interface
Date: Thu, 28 Jun 2018 14:41:59 +0300 [thread overview]
Message-ID: <20180628114159.hye3emcwbdibg6xl@mwanda> (raw)
In-Reply-To: <1530088829-11730-9-git-send-email-ramalingam.c@intel.com>
[ The bot has a bug where it doesn't copy the error messages so I just
guess what the issue is. - dan ]
Hi Ramalingam,
Thank you for the patch! Perhaps something to improve:
url: https://github.com/0day-ci/linux/commits/Ramalingam-C/drm-i915-Implement-HDCP2-2/20180627-174219
base: git://anongit.freedesktop.org/drm-intel for-linux-next
# https://github.com/0day-ci/linux/commit/86525c76cf90e793d6d915879e144924d1520d60
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 86525c76cf90e793d6d915879e144924d1520d60
vim +941 drivers/gpu/drm/i915/intel_hdcp.c
86525c76 Ramalingam C 2018-06-27 913
86525c76 Ramalingam C 2018-06-27 914 static int i915_hdcp_component_master_bind(struct device *dev)
86525c76 Ramalingam C 2018-06-27 915 {
86525c76 Ramalingam C 2018-06-27 916 struct drm_i915_private *dev_priv = kdev_to_i915(dev);
86525c76 Ramalingam C 2018-06-27 917 struct i915_hdcp_component *comp = dev_priv->hdcp_comp;
86525c76 Ramalingam C 2018-06-27 918 int ret;
86525c76 Ramalingam C 2018-06-27 919
86525c76 Ramalingam C 2018-06-27 920 mutex_lock(&comp->mutex);
86525c76 Ramalingam C 2018-06-27 921 ret = component_bind_all(dev, comp);
86525c76 Ramalingam C 2018-06-27 922 if (ret < 0)
86525c76 Ramalingam C 2018-06-27 923 return ret;
^^^^^^^^^^
We should unlock before returning. goto unlock. We probably don't want
to unbind if the bind failed?
86525c76 Ramalingam C 2018-06-27 924
86525c76 Ramalingam C 2018-06-27 925 /*
86525c76 Ramalingam C 2018-06-27 926 * Atm, we don't support dynamic unbinding initiated by the child
86525c76 Ramalingam C 2018-06-27 927 * component, so pin its containing module until we unbind.
86525c76 Ramalingam C 2018-06-27 928 */
86525c76 Ramalingam C 2018-06-27 929 if (!try_module_get(comp->ops->owner)) {
86525c76 Ramalingam C 2018-06-27 930 ret = -ENODEV;
86525c76 Ramalingam C 2018-06-27 931 goto out_unbind;
86525c76 Ramalingam C 2018-06-27 932 }
86525c76 Ramalingam C 2018-06-27 933
86525c76 Ramalingam C 2018-06-27 934 mutex_unlock(&comp->mutex);
86525c76 Ramalingam C 2018-06-27 935 return 0;
86525c76 Ramalingam C 2018-06-27 936
86525c76 Ramalingam C 2018-06-27 937 out_unbind:
86525c76 Ramalingam C 2018-06-27 938 component_unbind_all(dev, comp);
86525c76 Ramalingam C 2018-06-27 939 mutex_unlock(&comp->mutex);
86525c76 Ramalingam C 2018-06-27 940
86525c76 Ramalingam C 2018-06-27 @941 return ret;
86525c76 Ramalingam C 2018-06-27 942 }
86525c76 Ramalingam C 2018-06-27 943
next prev parent reply other threads:[~2018-06-28 11:41 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-27 8:39 [PATCH v5 00/40] drm/i915: Implement HDCP2.2 Ramalingam C
2018-06-27 8:39 ` [PATCH v5 01/40] drm: hdcp2.2 authentication msg definitions Ramalingam C
2018-07-09 20:21 ` Sean Paul
2018-07-11 17:57 ` C, Ramalingam
2018-07-11 19:08 ` Sean Paul
2018-07-12 3:52 ` [Intel-gfx] " C, Ramalingam
2018-06-27 8:39 ` [PATCH v5 02/40] drm: HDMI and DP specific HDCP2.2 defines Ramalingam C
2018-07-09 20:23 ` Sean Paul
2018-07-11 17:59 ` C, Ramalingam
2018-06-27 8:39 ` [PATCH v5 03/40] mei: bus: whitelist hdcp client Ramalingam C
2018-06-27 8:39 ` [PATCH v5 04/40] linux/mei: Header for mei_hdcp driver interface Ramalingam C
2018-06-27 8:39 ` [PATCH v5 05/40] drm/i915: wrapping all hdcp var into intel_hdcp Ramalingam C
2018-07-09 20:30 ` Sean Paul
2018-07-11 18:06 ` C, Ramalingam
2018-06-27 8:39 ` [PATCH v5 06/40] drm/i915: Define HDCP2.2 related variables Ramalingam C
2018-07-09 20:31 ` Sean Paul
2018-07-12 14:33 ` Ramalingam C
2018-06-27 8:39 ` [PATCH v5 07/40] drm/i915: Define Intel HDCP2.2 registers Ramalingam C
2018-07-09 20:31 ` Sean Paul
2018-06-27 8:39 ` [PATCH v5 08/40] drm/i915: Initialize HDCP2.2 and its MEI interface Ramalingam C
2018-06-28 11:41 ` Dan Carpenter [this message]
2018-06-27 8:39 ` [PATCH v5 09/40] drm/i915: Schedule hdcp_check_link in _intel_hdcp_enable Ramalingam C
2018-07-09 20:34 ` Sean Paul
2018-07-11 19:07 ` C, Ramalingam
2018-07-11 21:05 ` Sean Paul
2018-07-12 3:49 ` C, Ramalingam
2018-06-27 8:39 ` [PATCH v5 10/40] drm/i915: Pullout the bksv read and validation Ramalingam C
2018-07-09 20:35 ` [Intel-gfx] " Sean Paul
2018-06-27 8:40 ` [PATCH v5 11/40] drm/i915: Enable superior HDCP ver that is capable Ramalingam C
2018-07-09 20:44 ` Sean Paul
2018-07-12 14:30 ` Ramalingam C
2018-06-27 8:40 ` [PATCH v5 12/40] drm/i915: Enable HDCP1.4 incase of HDCP2.2 failure Ramalingam C
2018-07-09 20:44 ` Sean Paul
2018-07-12 14:31 ` [Intel-gfx] " Ramalingam C
2018-06-27 8:40 ` [PATCH v5 13/40] drm/i915: Implement HDCP2.2 Enable and Disable Ramalingam C
2018-07-09 20:48 ` [Intel-gfx] " Sean Paul
2018-07-12 14:41 ` Ramalingam C
2018-06-27 8:40 ` [PATCH v5 14/40] drm/i915: Enable and Disable HDCP2.2 port encryption Ramalingam C
2018-06-27 8:40 ` [PATCH v5 15/40] drm/i915: Implement HDCP2.2 receiver authentication Ramalingam C
2018-06-27 8:40 ` [PATCH v5 16/40] drm/i915: Implement HDCP2.2 repeater authentication Ramalingam C
2018-06-27 14:23 ` kbuild test robot
2018-06-27 8:40 ` [PATCH v5 17/40] drm/i915: Implement HDCP2.2 link integrity check Ramalingam C
2018-06-27 8:40 ` [PATCH v5 18/40] drm/i915: Handle HDCP2.2 downstream topology change Ramalingam C
2018-06-27 8:40 ` [PATCH v5 19/40] drm/i915: hdcp_check_link only on CP_IRQ Ramalingam C
2018-07-09 20:49 ` Sean Paul
2018-06-27 8:40 ` [PATCH v5 20/40] drm/i915: Check HDCP 1.4 and 2.2 link " Ramalingam C
2018-07-09 20:50 ` Sean Paul
2018-07-12 3:54 ` C, Ramalingam
2018-06-27 8:40 ` [PATCH v5 21/40] drm/i915/gmbus: Increase the Bytes per Rd/Wr Op Ramalingam C
2018-06-27 8:40 ` [PATCH v5 22/40] drm/i915/gmbus: Enable burst read Ramalingam C
2018-06-27 8:40 ` [PATCH v5 23/40] drm/i915: Implement the HDCP2.2 support for DP Ramalingam C
2018-06-27 8:40 ` [PATCH v5 24/40] drm/i915: Implement the HDCP2.2 support for HDMI Ramalingam C
2018-06-27 8:40 ` [PATCH v5 25/40] drm/i915: Add HDCP2.2 support for DP connectors Ramalingam C
2018-06-27 8:40 ` [PATCH v5 26/40] drm/i915: Add HDCP2.2 support for HDMI connectors Ramalingam C
2018-06-27 8:40 ` [PATCH v5 27/40] misc/mei/hdcp: Client driver for HDCP application Ramalingam C
2018-06-27 8:40 ` [PATCH v5 28/40] misc/mei/hdcp: Component framework for I915 Interface Ramalingam C
2018-06-27 14:46 ` kbuild test robot
2018-06-27 14:46 ` [RFC PATCH] misc/mei/hdcp: mei_hdcp_component_registered can be static kbuild test robot
2018-06-27 8:40 ` [PATCH v5 29/40] misc/mei/hdcp: Define ME FW interface for HDCP2.2 Ramalingam C
2018-06-27 8:40 ` [PATCH v5 30/40] misc/mei/hdcp: Initiate Wired HDCP2.2 Tx Session Ramalingam C
2018-06-27 8:40 ` [PATCH v5 31/40] misc/mei/hdcp: Verify Receiver Cert and prepare km Ramalingam C
2018-06-27 8:40 ` [PATCH v5 32/40] misc/mei/hdcp: Verify H_prime Ramalingam C
2018-06-27 8:40 ` [PATCH v5 33/40] misc/mei/hdcp: Store the HDCP Pairing info Ramalingam C
2018-06-27 8:40 ` [PATCH v5 34/40] misc/mei/hdcp: Initiate Locality check Ramalingam C
2018-06-27 8:40 ` [PATCH v5 35/40] misc/mei/hdcp: Verify L_prime Ramalingam C
2018-06-27 8:40 ` [PATCH v5 36/40] misc/mei/hdcp: Prepare Session Key Ramalingam C
2018-06-27 8:40 ` [PATCH v5 37/40] misc/mei/hdcp: Repeater topology verification and ack Ramalingam C
2018-06-27 8:40 ` [PATCH v5 38/40] misc/mei/hdcp: Verify M_prime Ramalingam C
2018-06-27 8:40 ` [PATCH v5 39/40] misc/mei/hdcp: Enabling the HDCP authentication Ramalingam C
2018-06-27 8:40 ` [PATCH v5 40/40] misc/mei/hdcp: Closing wired HDCP2.2 Tx Session Ramalingam C
2018-06-27 9:51 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Implement HDCP2.2 (rev6) Patchwork
2018-06-27 10:01 ` ✗ Fi.CI.SPARSE: " Patchwork
2018-06-27 10:02 ` ✗ Fi.CI.BAT: failure " Patchwork
2018-06-27 17:45 ` ✗ Fi.CI.BAT: failure for drm/i915: Implement HDCP2.2 (rev7) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180628114159.hye3emcwbdibg6xl@mwanda \
--to=dan.carpenter@oracle.com \
--cc=alexander.usyskin@intel.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kbuild-all@01.org \
--cc=kbuild@01.org \
--cc=ramalingam.c@intel.com \
--cc=tomas.winkler@intel.com \
--cc=uma.shankar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.