From: Sean Paul <seanpaul@chromium.org>
To: Ramalingam C <ramalingam.c@intel.com>
Cc: intel-gfx@lists.freedesktop.org, alexander.usyskin@intel.com,
dri-devel@lists.freedesktop.org, tomas.winkler@intel.com
Subject: Re: [PATCH v5 01/40] drm: hdcp2.2 authentication msg definitions
Date: Mon, 9 Jul 2018 16:21:26 -0400 [thread overview]
Message-ID: <20180709202126.GG20303@art_vandelay> (raw)
In-Reply-To: <1530088829-11730-2-git-send-email-ramalingam.c@intel.com>
On Wed, Jun 27, 2018 at 02:09:50PM +0530, Ramalingam C wrote:
> This patch defines the hdcp2.2 protocol messages for authentication.
>
> v2:
> bit_fields are removed. Instead bitmasking used. [Tomas and Jani]
> prefix HDCP_2_2_ is added to the macros. [Tomas]
> v3:
> No Changes.
> v4:
> Style and spellings are fixed [Uma]
> v5:
> Fix for macros.
>
> Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
> ---
> include/drm/drm_hdcp.h | 179 +++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 179 insertions(+)
>
> diff --git a/include/drm/drm_hdcp.h b/include/drm/drm_hdcp.h
> index 98e63d870139..3e963c5d04b2 100644
> --- a/include/drm/drm_hdcp.h
> +++ b/include/drm/drm_hdcp.h
> @@ -38,4 +38,183 @@
> #define DRM_HDCP_DDC_BSTATUS 0x41
> #define DRM_HDCP_DDC_KSV_FIFO 0x43
>
> +#define DRM_HDCP_1_4_SRM_ID 0x8
> +#define DRM_HDCP_1_4_VRL_LENGTH_SIZE 3
> +#define DRM_HDCP_1_4_DCP_SIG_SIZE 40
These don't seem to be related to the patch?
> +
> +/* Protocol message definition for HDCP2.2 specification */
> +#define HDCP_STREAM_TYPE0 0x00
> +#define HDCP_STREAM_TYPE1 0x01
Why not HDCP_2_2 prefix?
> +
> +/* HDCP2.2 Msg IDs */
> +#define HDCP_2_2_NULL_MSG 1
> +#define HDCP_2_2_AKE_INIT 2
> +#define HDCP_2_2_AKE_SEND_CERT 3
> +#define HDCP_2_2_AKE_NO_STORED_KM 4
> +#define HDCP_2_2_AKE_STORED_KM 5
> +#define HDCP_2_2_AKE_SEND_HPRIME 7
> +#define HDCP_2_2_AKE_SEND_PAIRING_INFO 8
> +#define HDCP_2_2_LC_INIT 9
> +#define HDCP_2_2_LC_SEND_LPRIME 10
> +#define HDCP_2_2_SKE_SEND_EKS 11
> +#define HDCP_2_2_REP_SEND_RECVID_LIST 12
> +#define HDCP_2_2_REP_SEND_ACK 15
> +#define HDCP_2_2_REP_STREAM_MANAGE 16
> +#define HDCP_2_2_REP_STREAM_READY 17
> +#define HDCP_2_2_ERRATA_DP_STREAM_TYPE 50
> +
> +#define HDCP_2_2_RTX_LEN 8
> +#define HDCP_2_2_RRX_LEN 8
> +
> +#define HDCP_2_2_K_PUB_RX_MOD_N_LEN 128
> +#define HDCP_2_2_K_PUB_RX_EXP_E_LEN 3
> +#define HDCP_2_2_K_PUB_RX_LEN (HDCP_2_2_K_PUB_RX_MOD_N_LEN + \
> + HDCP_2_2_K_PUB_RX_EXP_E_LEN)
> +
> +#define HDCP_2_2_DCP_LLC_SIG_LEN 384
> +
> +#define HDCP_2_2_E_KPUB_KM_LEN 128
> +#define HDCP_2_2_E_KH_KM_M_LEN (16 + 16)
> +#define HDCP_2_2_H_PRIME_LEN 32
> +#define HDCP_2_2_E_KH_KM_LEN 16
> +#define HDCP_2_2_RN_LEN 8
> +#define HDCP_2_2_L_PRIME_LEN 32
> +#define HDCP_2_2_E_DKEY_KS_LEN 16
> +#define HDCP_2_2_RIV_LEN 8
> +#define HDCP_2_2_SEQ_NUM_LEN 3
> +#define HDCP_2_2_LPRIME_HALF_LEN (HDCP_2_2_L_PRIME_LEN / 2)
> +#define HDCP_2_2_RECEIVER_ID_LEN DRM_HDCP_KSV_LEN
> +#define HDCP_2_2_MAX_DEVICE_COUNT 31
> +#define HDCP_2_2_RECEIVER_IDS_MAX_LEN (HDCP_2_2_RECEIVER_ID_LEN * \
> + HDCP_2_2_MAX_DEVICE_COUNT)
> +#define HDCP_2_2_MPRIME_LEN 32
> +
> +/* Following Macros take a byte at a time for bit(s) masking */
> +/*
> + * TODO: This has to be changed for DP MST, as multiple stream on
> + * same port is possible.
> + * For HDCP2.2 on HDMI and DP SST this value is always 1.
> + */
> +#define HDCP_2_2_MAX_CONTENT_STREAMS_CNT 1
> +#define HDCP_2_2_TXCAP_MASK_LEN 2
> +#define HDCP_2_2_RXCAPS_LEN 3
> +#define HDCP_2_2_RX_REPEATER(x) ((x) & BIT(0))
> +#define HDCP_2_2_DP_HDCP_CAPABLE(x) ((x) & BIT(1))
> +#define HDCP_2_2_RXINFO_LEN 2
> +
> +/* HDCP1.x compliant device in downstream */
> +#define HDCP_2_2_HDCP1_DEVICE_CONNECTED(x) ((x) & BIT(0))
> +
> +/* HDCP2.0 Compliant repeater in downstream */
> +#define HDCP_2_2_HDCP_2_0_REP_CONNECTED(x) ((x) & BIT(1))
> +#define HDCP_2_2_MAX_CASCADE_EXCEEDED(x) ((x) & BIT(2))
> +#define HDCP_2_2_MAX_DEVS_EXCEEDED(x) ((x) & BIT(3))
> +#define HDCP_2_2_DEV_COUNT_LO(x) (((x) & (0xF << 4)) >> 4)
> +#define HDCP_2_2_DEV_COUNT_HI(x) ((x) & BIT(0))
> +#define HDCP_2_2_DEPTH(x) (((x) & (0x7 << 1)) >> 1)
> +
> +struct hdcp2_cert_rx {
> + uint8_t receiver_id[HDCP_2_2_RECEIVER_ID_LEN];
> + uint8_t kpub_rx[HDCP_2_2_K_PUB_RX_LEN];
> + uint8_t reserved[2];
> + uint8_t dcp_signature[HDCP_2_2_DCP_LLC_SIG_LEN];
> +} __packed;
> +
> +struct hdcp2_streamid_type {
> + uint8_t stream_id;
> + uint8_t stream_type;
> +} __packed;
> +
> +/*
> + * The TxCaps field specified in the HDCP HDMI, DP specs
> + * This field is big endian as specified in the errata.
> + */
> +struct hdcp2_tx_caps {
> + /* Transmitter must set this to 0x2 */
> + uint8_t version;
> +
> + /* Reserved for HDCP and DP Spec. Read as Zero */
> + uint8_t tx_cap_mask[HDCP_2_2_TXCAP_MASK_LEN];
> +} __packed;
> +
> +/* Main structures for HDCP2.2 protocol communication */
> +struct hdcp2_ake_init {
> + uint8_t msg_id;
> + uint8_t r_tx[HDCP_2_2_RTX_LEN];
> + struct hdcp2_tx_caps tx_caps;
> +} __packed;
> +
> +struct hdcp2_ake_send_cert {
> + uint8_t msg_id;
> + struct hdcp2_cert_rx cert_rx;
> + uint8_t r_rx[HDCP_2_2_RRX_LEN];
> + uint8_t rx_caps[HDCP_2_2_RXCAPS_LEN];
> +} __packed;
> +
> +struct hdcp2_ake_no_stored_km {
> + uint8_t msg_id;
> + uint8_t e_kpub_km[HDCP_2_2_E_KPUB_KM_LEN];
> +} __packed;
> +
> +struct hdcp2_ake_stored_km {
> + uint8_t msg_id;
> + uint8_t e_kh_km_m[HDCP_2_2_E_KH_KM_M_LEN];
> +} __packed;
> +
> +struct hdcp2_ake_send_hprime {
> + uint8_t msg_id;
> + uint8_t h_prime[HDCP_2_2_H_PRIME_LEN];
> +} __packed;
> +
> +struct hdcp2_ake_send_pairing_info {
> + uint8_t msg_id;
> + uint8_t e_kh_km[HDCP_2_2_E_KH_KM_LEN];
> +} __packed;
> +
> +struct hdcp2_lc_init {
> + uint8_t msg_id;
> + uint8_t r_n[HDCP_2_2_RN_LEN];
> +} __packed;
> +
> +struct hdcp2_lc_send_lprime {
> + uint8_t msg_id;
> + uint8_t l_prime[HDCP_2_2_L_PRIME_LEN];
> +} __packed;
> +
> +struct hdcp2_ske_send_eks {
> + uint8_t msg_id;
> + uint8_t e_dkey_ks[HDCP_2_2_E_DKEY_KS_LEN];
> + uint8_t riv[HDCP_2_2_RIV_LEN];
> +} __packed;
> +
> +struct hdcp2_rep_send_receiverid_list {
> + uint8_t msg_id;
> + uint8_t rx_info[HDCP_2_2_RXINFO_LEN];
> + uint8_t seq_num_v[HDCP_2_2_SEQ_NUM_LEN];
> + uint8_t v_prime[HDCP_2_2_LPRIME_HALF_LEN];
> + uint8_t receiver_ids[HDCP_2_2_RECEIVER_IDS_MAX_LEN];
> +} __packed;
> +
> +struct hdcp2_rep_send_ack {
> + uint8_t msg_id;
> + uint8_t v[HDCP_2_2_LPRIME_HALF_LEN];
> +} __packed;
> +
> +struct hdcp2_rep_stream_manage {
> + uint8_t msg_id;
> + uint8_t seq_num_m[HDCP_2_2_SEQ_NUM_LEN];
> + __be16 k;
> + struct hdcp2_streamid_type streams[HDCP_2_2_MAX_CONTENT_STREAMS_CNT];
> +} __packed;
> +
> +struct hdcp2_rep_stream_ready {
> + uint8_t msg_id;
> + uint8_t m_prime[HDCP_2_2_MPRIME_LEN];
> +} __packed;
> +
> +struct hdcp2_dp_errata_stream_type {
> + uint8_t msg_id;
> + uint8_t stream_type;
> +} __packed;
Perhaps this has already been asked and answered, but do all of these need to be
__packed? This is kind of the problem with adding a bunch of unused structures
to a patch, it's hard to see what their usage is. In future, these should
probably be introduced when they're being used.
Sean
> +
> #endif
> --
> 2.7.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-07-09 20:21 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-27 8:39 [PATCH v5 00/40] drm/i915: Implement HDCP2.2 Ramalingam C
2018-06-27 8:39 ` [PATCH v5 01/40] drm: hdcp2.2 authentication msg definitions Ramalingam C
2018-07-09 20:21 ` Sean Paul [this message]
2018-07-11 17:57 ` C, Ramalingam
2018-07-11 19:08 ` Sean Paul
2018-07-12 3:52 ` [Intel-gfx] " C, Ramalingam
2018-06-27 8:39 ` [PATCH v5 02/40] drm: HDMI and DP specific HDCP2.2 defines Ramalingam C
2018-07-09 20:23 ` Sean Paul
2018-07-11 17:59 ` C, Ramalingam
2018-06-27 8:39 ` [PATCH v5 03/40] mei: bus: whitelist hdcp client Ramalingam C
2018-06-27 8:39 ` [PATCH v5 04/40] linux/mei: Header for mei_hdcp driver interface Ramalingam C
2018-06-27 8:39 ` [PATCH v5 05/40] drm/i915: wrapping all hdcp var into intel_hdcp Ramalingam C
2018-07-09 20:30 ` Sean Paul
2018-07-11 18:06 ` C, Ramalingam
2018-06-27 8:39 ` [PATCH v5 06/40] drm/i915: Define HDCP2.2 related variables Ramalingam C
2018-07-09 20:31 ` Sean Paul
2018-07-12 14:33 ` Ramalingam C
2018-06-27 8:39 ` [PATCH v5 07/40] drm/i915: Define Intel HDCP2.2 registers Ramalingam C
2018-07-09 20:31 ` Sean Paul
2018-06-27 8:39 ` [PATCH v5 08/40] drm/i915: Initialize HDCP2.2 and its MEI interface Ramalingam C
2018-06-28 11:41 ` [Intel-gfx] " Dan Carpenter
2018-06-27 8:39 ` [PATCH v5 09/40] drm/i915: Schedule hdcp_check_link in _intel_hdcp_enable Ramalingam C
2018-07-09 20:34 ` Sean Paul
2018-07-11 19:07 ` C, Ramalingam
2018-07-11 21:05 ` Sean Paul
2018-07-12 3:49 ` C, Ramalingam
2018-06-27 8:39 ` [PATCH v5 10/40] drm/i915: Pullout the bksv read and validation Ramalingam C
2018-07-09 20:35 ` [Intel-gfx] " Sean Paul
2018-06-27 8:40 ` [PATCH v5 11/40] drm/i915: Enable superior HDCP ver that is capable Ramalingam C
2018-07-09 20:44 ` Sean Paul
2018-07-12 14:30 ` Ramalingam C
2018-06-27 8:40 ` [PATCH v5 12/40] drm/i915: Enable HDCP1.4 incase of HDCP2.2 failure Ramalingam C
2018-07-09 20:44 ` Sean Paul
2018-07-12 14:31 ` [Intel-gfx] " Ramalingam C
2018-06-27 8:40 ` [PATCH v5 13/40] drm/i915: Implement HDCP2.2 Enable and Disable Ramalingam C
2018-07-09 20:48 ` [Intel-gfx] " Sean Paul
2018-07-12 14:41 ` Ramalingam C
2018-06-27 8:40 ` [PATCH v5 14/40] drm/i915: Enable and Disable HDCP2.2 port encryption Ramalingam C
2018-06-27 8:40 ` [PATCH v5 15/40] drm/i915: Implement HDCP2.2 receiver authentication Ramalingam C
2018-06-27 8:40 ` [PATCH v5 16/40] drm/i915: Implement HDCP2.2 repeater authentication Ramalingam C
2018-06-27 14:23 ` kbuild test robot
2018-06-27 8:40 ` [PATCH v5 17/40] drm/i915: Implement HDCP2.2 link integrity check Ramalingam C
2018-06-27 8:40 ` [PATCH v5 18/40] drm/i915: Handle HDCP2.2 downstream topology change Ramalingam C
2018-06-27 8:40 ` [PATCH v5 19/40] drm/i915: hdcp_check_link only on CP_IRQ Ramalingam C
2018-07-09 20:49 ` Sean Paul
2018-06-27 8:40 ` [PATCH v5 20/40] drm/i915: Check HDCP 1.4 and 2.2 link " Ramalingam C
2018-07-09 20:50 ` Sean Paul
2018-07-12 3:54 ` C, Ramalingam
2018-06-27 8:40 ` [PATCH v5 21/40] drm/i915/gmbus: Increase the Bytes per Rd/Wr Op Ramalingam C
2018-06-27 8:40 ` [PATCH v5 22/40] drm/i915/gmbus: Enable burst read Ramalingam C
2018-06-27 8:40 ` [PATCH v5 23/40] drm/i915: Implement the HDCP2.2 support for DP Ramalingam C
2018-06-27 8:40 ` [PATCH v5 24/40] drm/i915: Implement the HDCP2.2 support for HDMI Ramalingam C
2018-06-27 8:40 ` [PATCH v5 25/40] drm/i915: Add HDCP2.2 support for DP connectors Ramalingam C
2018-06-27 8:40 ` [PATCH v5 26/40] drm/i915: Add HDCP2.2 support for HDMI connectors Ramalingam C
2018-06-27 8:40 ` [PATCH v5 27/40] misc/mei/hdcp: Client driver for HDCP application Ramalingam C
2018-06-27 8:40 ` [PATCH v5 28/40] misc/mei/hdcp: Component framework for I915 Interface Ramalingam C
2018-06-27 14:46 ` kbuild test robot
2018-06-27 14:46 ` [RFC PATCH] misc/mei/hdcp: mei_hdcp_component_registered can be static kbuild test robot
2018-06-27 8:40 ` [PATCH v5 29/40] misc/mei/hdcp: Define ME FW interface for HDCP2.2 Ramalingam C
2018-06-27 8:40 ` [PATCH v5 30/40] misc/mei/hdcp: Initiate Wired HDCP2.2 Tx Session Ramalingam C
2018-06-27 8:40 ` [PATCH v5 31/40] misc/mei/hdcp: Verify Receiver Cert and prepare km Ramalingam C
2018-06-27 8:40 ` [PATCH v5 32/40] misc/mei/hdcp: Verify H_prime Ramalingam C
2018-06-27 8:40 ` [PATCH v5 33/40] misc/mei/hdcp: Store the HDCP Pairing info Ramalingam C
2018-06-27 8:40 ` [PATCH v5 34/40] misc/mei/hdcp: Initiate Locality check Ramalingam C
2018-06-27 8:40 ` [PATCH v5 35/40] misc/mei/hdcp: Verify L_prime Ramalingam C
2018-06-27 8:40 ` [PATCH v5 36/40] misc/mei/hdcp: Prepare Session Key Ramalingam C
2018-06-27 8:40 ` [PATCH v5 37/40] misc/mei/hdcp: Repeater topology verification and ack Ramalingam C
2018-06-27 8:40 ` [PATCH v5 38/40] misc/mei/hdcp: Verify M_prime Ramalingam C
2018-06-27 8:40 ` [PATCH v5 39/40] misc/mei/hdcp: Enabling the HDCP authentication Ramalingam C
2018-06-27 8:40 ` [PATCH v5 40/40] misc/mei/hdcp: Closing wired HDCP2.2 Tx Session Ramalingam C
2018-06-27 9:51 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Implement HDCP2.2 (rev6) Patchwork
2018-06-27 10:01 ` ✗ Fi.CI.SPARSE: " Patchwork
2018-06-27 10:02 ` ✗ Fi.CI.BAT: failure " Patchwork
2018-06-27 17:45 ` ✗ Fi.CI.BAT: failure for drm/i915: Implement HDCP2.2 (rev7) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180709202126.GG20303@art_vandelay \
--to=seanpaul@chromium.org \
--cc=alexander.usyskin@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ramalingam.c@intel.com \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.